Commits · 879a1c6a724636969d9977bcf649b9bd9e92b6c3 · Kirill Smelkov / go

11 Nov, 2011 1 commit

godefs: delete, replaced by cgo -godefs · 879a1c6a

Russ Cox authored Nov 10, 2011

Godefs was a C program that ran gcc and then parsed the
stabs debugging information in the resulting object file to
generate C or Go code for bootstrapping as part of
package runtime or package syscall.

Cgo does the same work, but using the dwarf debugging
information.  Add -godefs and -cdefs options to cgo that
mimic godefs's output, albeit with different input
(a Go program, not a C program).

This has been a "nice to have" for a while but was forced
by Apple removing stabs debugging output from their
latest compilers.

Fixes #835.
Fixes #2338.

R=golang-dev, bradfitz, r, dave, iant
CC=golang-dev
https://golang.org/cl/5367043

879a1c6a

10 Nov, 2011 8 commits

tutorial: describe unidirectional channels · a50ee009
Rob Pike authored Nov 10, 2011
```
R=golang-dev, adg, gri
CC=golang-dev
https://golang.org/cl/5370058
```
a50ee009

time: add ISOWeek method to Time · d9897096

Volker Dobler authored Nov 10, 2011

As the ISO 8601 week number is untrivial to compute a new method
on *Time provides year and number of week.

R=golang-dev, rsc, r, r
CC=golang-dev
https://golang.org/cl/5316074

d9897096

testing: add file:line stamps to messages. · 2c39ca08

Rob Pike authored Nov 10, 2011

A single-line error looks like this:
--- FAIL: foo_test.TestFoo (0.00 seconds)
        foo_test.go:123: Foo(8) = "10" want "100"

A multi-line error looks like this:
--- FAIL: foo_test.TestFoo (0.00 seconds)
        foo_test.go:456: Foo(88) = "100"
                want "1000"

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5376057

2c39ca08

runtime: fix semasleep() duration for openbsd · 85b74192

Joel Sing authored Nov 10, 2011

The timespec passed to thrsleep() needs to be an absolute/realtime
value, so add the current nanotime to ns.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5374048

85b74192

math/big: Correcting typo in SetBit() documentation · 120f3b7b
David G. Andersen authored Nov 10, 2011
```
z is set to x+bit change, not z+bit change

R=golang-dev
CC=golang-dev
https://golang.org/cl/5374056
```
120f3b7b

html: parse framesets · e9e874b7

Andrew Balholm authored Nov 10, 2011

Pass tests1.dat, test 106:
<frameset><frame><frameset><frame></frameset><noframes></noframes></frameset>

| <html>
|   <head>
|   <frameset>
|     <frame>
|     <frameset>
|       <frame>
|     <noframes>

Also pass test 107:
<h1><table><td><h3></table><h3></h1>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5373050

e9e874b7

runtime: fix freebsd build · be802560
Mikio Hara authored Nov 10, 2011
```
R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5370050
```
be802560
effective_go: a little more about comma ok and type assertion · bb661645
Rob Pike authored Nov 09, 2011
```
Fixes #2416.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5370049
```
bb661645

09 Nov, 2011 31 commits

misc/windows: Go for Windows installer in MSI format · e4eacf39

Joe Poirier authored Nov 09, 2011

Requesting suggestions for the comment and description strings in installer.wxs.
Fixes #2394.

R=rsc, alex.brainman, tjyang2001
CC=golang-dev
https://golang.org/cl/5339046

e4eacf39

effective_go: fix up the description of cipher blocks and streams · a9aef26a
Rob Pike authored Nov 09, 2011
```
R=golang-dev, r, agl, dsymonds
CC=golang-dev
https://golang.org/cl/5374046
```
a9aef26a
crypto: update incorrect references to Cipher interface; should be Block. · 217408ab
Rob Pike authored Nov 09, 2011
```
R=gri, rsc, r
CC=golang-dev
https://golang.org/cl/5372050
```
217408ab
os/exec: Fix documentation references to os.DevNull · 6c10aa19
Scott Lawrence authored Nov 09, 2011
```
R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/5372049
```
6c10aa19
FAQ: rearrange and expand the discussion of testing · f6615f1b
Rob Pike authored Nov 09, 2011
```
R=gri, r, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5369052
```
f6615f1b

html: don't emit text token for empty raw text elements. · ddc5ec64

Andrew Balholm authored Nov 10, 2011

Pass tests1.dat, test 99:
<script></script></div><title></title><p><p>

| <html>
|   <head>
|     <script>
|     <title>
|   <body>
|     <p>
|     <p>

Also pass tests through test 105:
<ul><li><ul></li><li>a</li></ul></li></ul>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5373043

ddc5ec64

cgo: print error instead of panic on undeclared enums/structs · 23ffbe61

Rémy Oudompheng authored Nov 09, 2011

Types are left as nil if no DWARF information is found and
checking in the rewriting pass so that appropriate errors
with line numbers can be printed.
Fixes #2408.

R=rsc
CC=golang-dev, remy
https://golang.org/cl/5336041

23ffbe61

6l: add MOVQ xmm_reg, xmm_reg · 17105870

Michał Derkacz authored Nov 09, 2011

Added handler for:
        MOVQ xmm_reg, xmm_reg/mem64
        MOVQ xmm_reg/mem64, xmm_reg
using native MOVQ (it take precedence above REX.W MOVD)
I don't understood 6l code enough to be sure that my small changes
didn't broke it. But now 6l works with MOVQ xmm_reg, xmm_reg and
all.bash reports "0 unexpected bugs".

There is test assembly source:
MOVQ    X0, X1
MOVQ    AX, X1
MOVQ    X1, AX
MOVQ    xxx+8(FP), X2
MOVQ    X2, xxx+8(FP)

and generated code (gdb disassemble /r):

0x000000000040f112 <+0>:   f3 0f 7e c8        movq  %xmm0,%xmm1
0x000000000040f116 <+4>:   66 48 0f 6e c8     movq  %rax,%xmm1
0x000000000040f11b <+9>:   66 48 0f 7e c8     movq  %xmm1,%rax
0x000000000040f120 <+14>:  f3 0f 7e 54 24 10  movq  0x10(%rsp),%xmm2
0x000000000040f126 <+20>:  66 0f d6 54 24 10  movq  %xmm2,0x10(%rsp)

Fixes #2418.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5316076

17105870

6l: Fixes opcode for PSLLQ imm8, xmm_reg · c8a2be8c
Michał Derkacz authored Nov 09, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5340056
```
c8a2be8c
A+C: Michał Derkacz (individual CLA) · 7be2a7d9
Russ Cox authored Nov 09, 2011
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/5375046
```
7be2a7d9
A+C: Rémy Oudompheng (individual CLA) · 5524b646
Russ Cox authored Nov 09, 2011
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/5376045
```
5524b646

math: faster Lgamma · 300b443a

Charles L. Dorian authored Nov 09, 2011

Converting from polynomial constants to counted array speeds up Lgamma from 51.3 to 37.7 ns/op. Variables renamed in Gamma to avoid overlap in Lgamma.

R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/5359045

300b443a

runtime: add timer support, use for package time · 3b860269

Russ Cox authored Nov 09, 2011

This looks like it is just moving some code from
time to runtime (and translating it to C), but the
runtime can do a better job managing the goroutines,
and it needs this functionality for its own maintenance
(for example, for the garbage collector to hand back
unused memory to the OS on a time delay).
Might as well have just one copy of the timer logic,
and runtime can't depend on time, so vice versa.

It also unifies Sleep, NewTicker, and NewTimer behind
one mechanism, so that there are no claims that one
is more efficient than another.  (For example, today
people recommend using time.After instead of time.Sleep
to avoid blocking an OS thread.)

Fixes #1644.
Fixes #1731.
Fixes #2190.

R=golang-dev, r, hectorchu, iant, iant, jsing, alex.brainman, dvyukov
CC=golang-dev
https://golang.org/cl/5334051

3b860269

cgo: fix g0 stack guard · fbfed491

Dmitriy Vyukov authored Nov 09, 2011

Fixes crash when cgo consumes more than 8K
of stack and makes a callback.

Fixes #1328.

R=golang-dev, rogpeppe, rsc
CC=golang-dev, mpimenov
https://golang.org/cl/5371042

fbfed491

doc: htmlescape weekly notes · 98321731
Russ Cox authored Nov 09, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5370046
```
98321731

builtin: document delete · e99f68f0

Rob Pike authored Nov 09, 2011

Fixes #2434.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5370045

e99f68f0

regexp: fix doc comment · 7a6a9755
Russ Cox authored Nov 09, 2011
```
Fixes #2432.

R=r, r
CC=golang-dev
https://golang.org/cl/5376041
```
7a6a9755

gopack: fixes for Plan 9 build · 74f61fc6

Lucio De Re authored Nov 09, 2011

. removed an unnexessary initialisation.
. replaced 0 with 0L to match print format that in turn matched
  the type of the original function return value.

R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/5306072

74f61fc6

undo CL 5375043 / ea8b178f9b73 · 1eadb89e

Russ Cox authored Nov 09, 2011

Never lasts long.

««« original CL description
gc: add GOEXPERIMENT=reorg

This won't last long but may ease conversions.

R=ken2
CC=golang-dev
https://golang.org/cl/5375043
»»»

R=ken2, ken
CC=golang-dev
https://golang.org/cl/5370043

1eadb89e

gc: add GOEXPERIMENT=reorg · ae7a003c

Russ Cox authored Nov 09, 2011

This won't last long but may ease conversions.

R=ken2
CC=golang-dev
https://golang.org/cl/5375043

ae7a003c

gc: better error for non-calling use of unsafe builtins. · 924ea515
Luuk van Dijk authored Nov 09, 2011
```
Fixes #1951

R=rsc
CC=golang-dev
https://golang.org/cl/5372041
```
924ea515
http: add a disabled failing test for Issue 2357 · 21f50576
Brad Fitzpatrick authored Nov 09, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5372044
```
21f50576
gc: Preserve original blank name for .anon substitution on out params. · d5a5855b
Luuk van Dijk authored Nov 09, 2011
```
Fixes #1802.

R=rsc
CC=golang-dev
https://golang.org/cl/5364043
```
d5a5855b
gc: Fail on implicit assigment to non-exported fields in copy and append. · 151b2f15
Luuk van Dijk authored Nov 09, 2011
```
Fixes #1387.

R=rsc
CC=golang-dev
https://golang.org/cl/5348046
```
151b2f15

gc: Better typechecks and errors in switches. · 13e92e4d

Luuk van Dijk authored Nov 09, 2011

Allow any type in switch on interface value.
Statically check typeswitch early.

Fixes #2423.
Fixes #2424.

R=rsc, dsymonds
CC=golang-dev
https://golang.org/cl/5339045

13e92e4d

html: correctly parse </html> in <head> element. · 820523d0

Andrew Balholm authored Nov 09, 2011

Pass tests1.dat, test 92:
<head></html><meta><p>

| <html>
|   <head>
|   <body>
|     <meta>
|     <p>

Also pass tests through test 98:
<p><b><div><marquee></p></b></div>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5359054

820523d0

net/http: use t.Errorf from alternate goroutine in test. · 929070ee
David Symonds authored Nov 09, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5348051
```
929070ee
net/http: fix sniffing when using ReadFrom. · 9c6a73e4
David Symonds authored Nov 09, 2011
```
R=golang-dev, rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5362046
```
9c6a73e4
doc: fix anchor ID in weekly.html. · e5373c01
David Symonds authored Nov 09, 2011
```
R=adg, rsc
CC=golang-dev
https://golang.org/cl/5359055
```
e5373c01

http: make httputil's chunked reader/writer code a direct copy · bad305c2

Andrew Gerrand authored Nov 09, 2011

Arrange the code so that it's easier to keep edits in sync.

R=golang-dev, mikioh.mikioh, bradfitz, andybalholm, rsc
CC=golang-dev
https://golang.org/cl/5345041

bad305c2

runtime: add comments for various functions in proc.c · 4ac425fc
Ian Lance Taylor authored Nov 08, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5357047
```
4ac425fc