Commits · 8a8b5cba67da4e16aef2ab7704bb079cc8771cf3 · Kirill Smelkov / go

25 Feb, 2014 15 commits

crypto/sha1: restore accidental removal of arm build tag · 8a8b5cba

Brad Fitzpatrick authored Feb 25, 2014

Regression from https://golang.org/cl/68490043/diff/60001/src/pkg/crypto/sha1/sha1block_decl.go

Fixes arm build.

TBR=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/68080046

8a8b5cba

spec: clarify default "true" condition/tag in for/switch statements · ab266231

Robert Griesemer authored Feb 25, 2014

An absent condition/tag in for and switch statements is equivalent
to the predeclared constant true; not simply the expression true
(which might lead to a locally defined true).

Not a language change.

Fixes #7404.

LGTM=iant, r
R=r, iant, rsc, ken
CC=golang-codereviews
https://golang.org/cl/68150046

ab266231

runtime: fix 386, arm build · 5b35dc0f

Russ Cox authored Feb 25, 2014

CL 68150047 lost runtime.panicdivide.

TBR=dfc
CC=golang-codereviews
https://golang.org/cl/68610043

5b35dc0f

cmd/go: fix bug in remote package discovery · 441c4bb9

Russ Cox authored Feb 25, 2014

The parser was assuming it would find <body> or </head>.
If the entire response is just <meta> tags, it finds EOF and
treats that as an error. It's not.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/68520044

441c4bb9

net/http: add Transport.TLSHandshakeTimeout; set it by default · fd4b4b56
Brad Fitzpatrick authored Feb 25, 2014
```
Update #3362

LGTM=agl
R=agl
CC=golang-codereviews
https://golang.org/cl/68150045
```
fd4b4b56

doc/go1.3: note a couple more crypto changes. · abe53f87

Adam Langley authored Feb 25, 2014

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/68600043

abe53f87

cmd/go: document new -exec flag on run/test · 280d46b0

Russ Cox authored Feb 25, 2014

The new flag was added by CL 68150047 (part of the NaCl replay),
but the change, like the original, omitted documentation of the
new behavior.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/68580043

280d46b0

all: merge NaCl branch (part 1) · 7c8280c9

Dave Cheney authored Feb 25, 2014

See golang.org/s/go13nacl for design overview.

This CL is the mostly mechanical changes from rsc's Go 1.2 based NaCl branch, specifically 39cb35750369 to 500771b477cf from https://code.google.com/r/rsc-go13nacl. This CL does not include working NaCl support, there are probably two or three more large merges to come.

CL 15750044 is not included as it involves more invasive changes to the linker which will need to be merged separately.

The exact change lists included are

15050047: syscall: support for Native Client
15360044: syscall: unzip implementation for Native Client
15370044: syscall: Native Client SRPC implementation
15400047: cmd/dist, cmd/go, go/build, test: support for Native Client
15410048: runtime: support for Native Client
15410049: syscall: file descriptor table for Native Client
15410050: syscall: in-memory file system for Native Client
15440048: all: update +build lines for Native Client port
15540045: cmd/6g, cmd/8g, cmd/gc: support for Native Client
15570045: os: support for Native Client
15680044: crypto/..., hash/crc32, reflect, sync/atomic: support for amd64p32
15690044: net: support for Native Client
15690048: runtime: support for fake time like on Go Playground
15690051: build: disable various tests on Native Client

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/68150047

7c8280c9

runtime: use monotonic clock for timers on linux/arm · 7206f50f

Mikio Hara authored Feb 25, 2014

Update #6007

LGTM=dvyukov
R=golang-codereviews, dvyukov
CC=golang-codereviews
https://golang.org/cl/67730048

7206f50f

syscall: add mmap test · b05f3de5

Mikio Hara authored Feb 25, 2014

This CL adds a test that calls Mmap and Munmap through Syscall9
as the canary that detects assembly fragment breakage. For now
there is no package test that uses Syscall9 in the standard
library across all Unix-like systems.

Note that the package runtime owns its assembly fragments, so
this canary never works for runtime breakage.

LGTM=iant, bradfitz
R=iant, minux.ma, bradfitz
CC=golang-codereviews
https://golang.org/cl/61520049

b05f3de5

sync: use RunParallel in benchmarks · ec0c9f27

Dmitriy Vyukov authored Feb 25, 2014

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/68050043

ec0c9f27

syscall: add support for GOOS=solaris · 1c986191

Aram Hăvărneanu authored Feb 25, 2014

These are only the new files, autogenerated files are in a
different CL to keep the size down.

LGTM=dave, minux.ma, jsing
R=golang-codereviews, dave, jsing, gobot, minux.ma, rsc, iant, mikioh.mikioh
CC=golang-codereviews
https://golang.org/cl/36000043

1c986191

syscall: generate zfiles for GOOS=solaris · e5b5f9b3

Aram Hăvărneanu authored Feb 25, 2014

LGTM=minux.ma, mikioh.mikioh
R=golang-codereviews, minux.ma, gobot, jsing, mikioh.mikioh, dave
CC=golang-codereviews
https://golang.org/cl/36010043

e5b5f9b3

runtime, net: add support for GOOS=solaris · 50df1364

Aram Hăvărneanu authored Feb 24, 2014

LGTM=dave, rsc
R=golang-codereviews, minux.ma, mikioh.mikioh, dave, iant, rsc
CC=golang-codereviews
https://golang.org/cl/36030043

50df1364

go/printer: fix alignment of comments in labeled statements · c738591e

Robert Griesemer authored Feb 24, 2014

Does not change src, misc formatting.

Fixes #5623.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/68400043

c738591e

24 Feb, 2014 25 commits

net/http: use TCP Keep-Alives on DefaultTransport's connections · 49beb23b

Brad Fitzpatrick authored Feb 24, 2014

Update #3362

Also set a 30 second timeout, instead of relying on the
operating system's timeout, which if often but not always 3
minutes.

LGTM=crawshaw
R=rsc, crawshaw
CC=golang-codereviews
https://golang.org/cl/68330046

49beb23b

crypto/tls: report TLS version in ConnectionState. · c7612f34

Adam Langley authored Feb 24, 2014

Fixes #7231.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/68250043

c7612f34

crypto/tls: pick ECDHE curves based on server preference. · db99a8fa

Adam Langley authored Feb 24, 2014

Currently an ECDHE handshake uses the client's curve preference. This
generally means that we use P-521. However, P-521's strength is
mismatched with the rest of the cipher suite in most cases and we have
a fast, constant-time implementation of P-256.

With this change, Go servers will use P-256 where the client supports
it although that can be overridden in the Config.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/66060043

db99a8fa

build: comment possible ulimit failure in run.bash · e6e89450

Russ Cox authored Feb 24, 2014

Record what's going on in case someone is debugging a failure there.
It's not Go's fault.

Fixes #7381.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/68200043

e6e89450

net: add Dialer.KeepAlive option · fdfbb406
Brad Fitzpatrick authored Feb 24, 2014
```
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/68380043
```
fdfbb406

cmd/ld: fix build for ARMv5. · e2fe968d

Shenghou Ma authored Feb 25, 2014

Credit goes to Dave Cheney for debugging the issue.

LGTM=dave, rsc
R=dave, rsc
CC=golang-codereviews
https://golang.org/cl/67820043

e2fe968d

cmd/gc: fix walkcompare bugs. · 14b0af42

Rémy Oudompheng authored Feb 24, 2014

Revision c0e0467635ec (cmd/gc: return canonical Node* from temp)
exposed original nodes of temporaries, allowing callers to mutate
their types.

In walkcompare a temporary could be typed as ideal because of
this. Additionnally, assignment of a comparison result to
a custom boolean type was broken.

Fixes #7366.

LGTM=rsc
R=rsc, iant, khr
CC=golang-codereviews
https://golang.org/cl/66930044

14b0af42

cmd/go: Plan 9 compatible "env" output · ff15e5c0

Lucio De Re authored Feb 24, 2014

Fixes the output of go env so that variables can be set
more accurately when using Plan 9's rc shell. Specifically,
GOPATH may have multiple components and the current
representation is plain wrong. In practice, we probably
ought to change os. Getenv to produce the right result, but
that requires considerably more thought.

LGTM=rsc
R=golang-codereviews, gobot, rsc
CC=golang-codereviews
https://golang.org/cl/66600043

ff15e5c0

crypto/md5,sha1: add examples for Sum · c687be42

Rob Pike authored Feb 24, 2014

LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/66900044

c687be42

testing: fix bogus benchmark · cd13a57b

Dmitriy Vyukov authored Feb 24, 2014

Fatal must not be called from secondary goroutines.
Fixes #7401.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/67820047

cd13a57b

testing: improve diagnosis of a potential misuse of RunParallel · 5b6aaba1
Dmitriy Vyukov authored Feb 24, 2014
```
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/68230045
```
5b6aaba1

runtime: fix heap memory corruption · ea875017

Dmitriy Vyukov authored Feb 24, 2014

With concurrent sweeping finc if modified by runfinq and queuefinalizer concurrently.
Fixes crashes like this one:
http://build.golang.org/log/6ad7b59ef2e93e3c9347eabfb4c4bd66df58fd5a
Fixes #7324.
Update #7396

LGTM=rsc
R=golang-codereviews, minux.ma, rsc
CC=golang-codereviews, khr
https://golang.org/cl/67980043

ea875017

runtime: fix potential memory corruption · 6e612ae0

Dmitriy Vyukov authored Feb 24, 2014

Reinforce the guarantee that MSpan_EnsureSwept actually ensures that the span is swept.
I have not observed crashes related to this, but I do not see why it can't crash as well.

LGTM=rsc
R=golang-codereviews
CC=golang-codereviews, khr, rsc
https://golang.org/cl/67990043

6e612ae0

runtime: use RunParallel in more benchmarks · 69257d17

Dmitriy Vyukov authored Feb 24, 2014

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/68020043

69257d17

time: use RunParallel in benchmarks · bb9531e1

Dmitriy Vyukov authored Feb 24, 2014

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/68060043

bb9531e1

math/big: use RunParallel in benchmarks · 51b9879a

Dmitriy Vyukov authored Feb 24, 2014

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/67830044

51b9879a

fmt: use RunParallel in benchmarks · 44cc8e5c

Dmitriy Vyukov authored Feb 24, 2014

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/67910046

44cc8e5c

syscall: regenerate Flock_t to make it compliant with EABI · 2ff43118

Mikio Hara authored Feb 24, 2014

Note that current z-files for linux/amd64,386,arm are based on 3.2 kernel.

LGTM=iant
R=golang-codereviews, dave, bradfitz, gobot, iant
CC=golang-codereviews
https://golang.org/cl/59160044

2ff43118

testing: diagnose a potential misuse of RunParallel · 1163127d
Dmitriy Vyukov authored Feb 24, 2014
```
LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/68030043
```
1163127d

net/http: use RunParallel in benchmarks · 96d52298

Dmitriy Vyukov authored Feb 24, 2014

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/68070043

96d52298

net/rpc: use RunParallel in benchmarks · b5705ed9

Dmitriy Vyukov authored Feb 24, 2014

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/68040044

b5705ed9

runtime: fix double symbol definition · 0ef0d6cd

Dmitriy Vyukov authored Feb 24, 2014

runfinqv is already defined the same way on line 271.
There may also be something to fix in compiler/linker wrt diagnostics.
Fixes #7375.

LGTM=bradfitz
R=golang-codereviews, dave, bradfitz
CC=golang-codereviews
https://golang.org/cl/67850044

0ef0d6cd

runtime: stack allocate Panic structure during runtime.panic · dd740343

Dave Cheney authored Feb 24, 2014

Update #7347

When runtime.panic is called the *Panic is malloced from the heap. This can lead to a gc cycle while panicing which can make a bad situation worse.

It appears to be possible to stack allocate the Panic and avoid malloc'ing during a panic.

Ref: https://groups.google.com/d/topic/golang-dev/OfxqpklGkh0/discussion

LGTM=minux.ma, dvyukov, rsc
R=r, minux.ma, gobot, rsc, dvyukov
CC=golang-codereviews
https://golang.org/cl/66830043

dd740343

runtime: use monotonic clock for timers (linux/386, linux/amd64) · 86c976ff

Jay Weisskopf authored Feb 24, 2014

This lays the groundwork for making Go robust when the system's
calendar time jumps around. All input values to the runtimeTimer
struct now use the runtime clock as a common reference point.
This affects net.Conn.Set[Read|Write]Deadline(), time.Sleep(),
time.Timer, etc. Under normal conditions, behavior is unchanged.

Each platform and architecture's implementation of runtime·nanotime()
should be modified to use a monotonic system clock when possible.

Platforms/architectures modified and tested with monotonic clock:
  linux/x86     - clock_gettime(CLOCK_MONOTONIC)

Update #6007

LGTM=dvyukov, rsc
R=golang-codereviews, dvyukov, alex.brainman, stephen.gutekanst, dave, rsc, mikioh.mikioh
CC=golang-codereviews
https://golang.org/cl/53010043

86c976ff

time: explicitely mention Tickers have to be stopped · 7403071a
Patrick Mézard authored Feb 24, 2014
```
LGTM=rsc
R=golang-codereviews, gobot, rsc
CC=golang-codereviews
https://golang.org/cl/64770043
```
7403071a