- 24 May, 2016 3 commits
-
-
Russ Cox authored
The use of a prefix check was too liberal. Noted in review after submit. Change-Id: I4fe1df660997efd225609e818040b8392fab79f0 Reviewed-on: https://go-review.googlesource.com/23375 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
Andrew Gerrand <adg@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Russ Cox authored
CL 19725 changed the encoding of []typedByte to look for typedByte.MarshalJSON and typedByte.MarshalText. Previously it was handled like []byte, producing a base64 encoding of the underlying byte data. CL 19725 forgot to look for (*typedByte).MarshalJSON and (*typedByte).MarshalText, as the marshaling of other slices would. Add test and fix for those. This CL also adds tests that the decoder can handle both the old and new encodings. (This was true even in Go 1.6, which is the only reason we can consider this not an incompatible change.) For #13783. Change-Id: I7cab8b6c0154a7f2d09335b7fa23173bcf856c37 Reviewed-on: https://go-review.googlesource.com/23294Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Russ Cox authored
The compiler has caught up. In fact the compiler is ahead; it knows about a magic multiply-by-5 instruction: // compute '0' + byte(r - t*10) in AX MOVQ t, AX LEAQ (AX)(AX*4), AX SHLQ $1, AX MOVQ r, CX SUBQ AX, CX LEAL 48(CX), AX For comparison, the shifty version compiles to: // compute '0' + byte(r - t*10) in AX MOVQ t, AX MOVQ AX, CX SHLQ $3, AX MOVQ r, DX SUBQ AX, DX SUBQ CX, DX SUBQ CX, DX LEAL 48(DX), AX Fixes #2671. Change-Id: Ifbf23dbfeb19c0bb020fa44eb2f025943969fb6b Reviewed-on: https://go-review.googlesource.com/23372 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
-
- 23 May, 2016 3 commits
-
-
Keith Randall authored
Now that CSE uses dom tree to order partitions, we need the dom tree computed before benchmarking CSE. Fixes #15801 Change-Id: Ifa4702c7b75250f34de185e69a880b3f3cc46a12 Reviewed-on: https://go-review.googlesource.com/23361Reviewed-by:
David Chase <drchase@google.com>
-
Robert Griesemer authored
In n:1 variable declarations (multiple lhs variables with single multi-valued initialization expression) where also a variable type is provided, make sure that that type is assigned to all variables on the lhs before the init expression assignment is checked. Otherwise, (some) variables are assumed to take the type of the corresponding value of the multi-valued init expression. Fixes #15755. Change-Id: I969cb5a95c85e28dbb38abd7fa7df16ff5554c03 Reviewed-on: https://go-review.googlesource.com/23313Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Kenny Grant authored
The source xml data has changed, so running genzabbrs.go regenerates a new time zone file in zoneinfo_abbrs_windows.go which adds some zones and adjusts others. Now set export ZONEINFO=$GOROOT/lib/time/zoneinfo.zip to use zoneinfo.zip in go tip. Change-Id: I19f72359cc808094e5dcb420e480a00c6b2205d7 Reviewed-on: https://go-review.googlesource.com/23321Reviewed-by:
Alex Brainman <alex.brainman@gmail.com> Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 22 May, 2016 1 commit
-
-
djherbis authored
Change-Id: I91608b15e00c8eaf732db3a99a890d4ceeb41955 Reviewed-on: https://go-review.googlesource.com/23317Reviewed-by:
-
- 21 May, 2016 3 commits
-
-
Brad Fitzpatrick authored
Add Abe Haskins (individual CLA) Add Ahmy Yulrizka (individual CLA) Add Akihiro Suda (individual CLA) Add Alex Vaghin (corporate CLA for Google Inc.) Add Arlo Breault (individual CLA) Add Audrey Lim (individual CLA) Add Benjamin Wester (corporate CLA for Square, Inc.) Add Bryan Chan (corporate CLA for IBM) Add Christy Perez (corporate CLA for IBM) Add Colin Edwards (individual CLA) Add David Brophy (individual CLA) Add David Sansome (individual CLA) Add Diwaker Gupta (individual CLA) Add Doug Anderson (corporate CLA for Google Inc.) Add Dustin Carlino (corporate CLA for Google Inc.) Add Ernest Chiang (individual CLA) Add Ethan Burns (corporate CLA for Google Inc.) Add Gary Elliott (corporate CLA for Google Inc.) Add Hallgrimur Gunnarsson (corporate CLA for Google Inc.) Add Hironao OTSUBO (individual CLA) Add Holden Huang (individual CLA) Add Idora Shinatose (individual CLA) Add Irieda Noboru (individual CLA) Add Jeff Craig (corporate CLA for Google Inc.) Add Joe Henke (individual CLA) Add John Schnake (individual CLA) Add Jonathan Amsterdam (corporate CLA for Google Inc.) Add Kenji Kaneda (individual CLA) Add Kenneth Shaw (individual CLA) Add Mark Severson (individual CLA) Add Martin Garton (individual CLA) Add Mathias Leppich (individual CLA) Add Maxwell Krohn (individual CLA) Add Niall Sheridan (individual CLA) Add Nick Patavalis (individual CLA) Add Nick Petroni (individual CLA) Add Omar Jarjur (corporate CLA for Google Inc.) Add Özgür Kesim (individual CLA) Add Peter Gonda (corporate CLA for Google Inc.) Add Pierre Durand (individual CLA) Add Quentin Smith (corporate CLA for Google Inc.) Add Ricardo Padilha (individual CLA) Add Riku Voipio (corporate CLA for Linaro Limited) Add Roland Shoemaker (individual CLA) Add Sam Hug (individual CLA) Add Sam Whited (individual CLA) Add Sami Commerot (corporate CLA for Google Inc.) Add Scott Mansfield (corporate CLA for Netflix, Inc.) Add Sean Harger (corporate CLA for Google Inc.) Add Simon Jefford (individual CLA) Add Sridhar Venkatakrishnan (individual CLA) Add Tim Swast (corporate CLA for Google Inc.) Add Timothy Studd (individual CLA) Add Tipp Moseley (corporate CLA for Google Inc.) Add Toby Burress (corporate CLA for Google Inc.) Add Tzu-Jung Lee (corporate CLA for Currant) Add Vadim Grek (individual CLA) Add Xudong Zhang (individual CLA) Updates #12042 Change-Id: I4119a8829119a2b8a9abbea9f52ceebb04878764 Reviewed-on: https://go-review.googlesource.com/23306Reviewed-by:
-
Brad Fitzpatrick authored
Updates x/net/http2 to git rev 0c607074 for https://golang.org/cl/23311, "http2: prevent Server from sending status 100 header after anything else" New test is in the x/net/http2 package (not bundled to std). Fixes #14030 Change-Id: Ifc6afa4a5fe35977135428f6d0e9f7c164767720 Reviewed-on: https://go-review.googlesource.com/23312Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Mikio Hara authored
Also renames the test function to TestDNSFlood. Updates #15659. Change-Id: Ia562004c43bcc19c2fee9440321c27b591f85da5 Reviewed-on: https://go-review.googlesource.com/23077Reviewed-by:
-
- 20 May, 2016 13 commits
-
-
Brad Fitzpatrick authored
Add Aiden Scandella (individual CLA) Add Alessandro Arzilli (individual CLA) Add Augusto Roman (individual CLA) Add Brady Catherman (individual CLA) Add Brady Sullivan (individual CLA) Add Caio Marcelo de Oliveira Filho (corporate CLA for Intel Corporation) Add Catalin Nicutar (corporate CLA for Google Inc.) Add Cherry Zhang (corporate CLA for Google Inc.) Add Chris Zou (corporate CLA for IBM) Add Christopher Nelson (individual CLA) Add Conrad Irwin (individual CLA) Add Cuihtlauac ALVARADO (corporate CLA for Orange) Add Daniel Speichert (individual CLA) Add Datong Sun (individual CLA) Add Denys Honsiorovskyi (individual CLA) Add Derek Shockey (individual CLA) Add Dmitriy Dudkin (individual CLA) Add Dustin Herbis (individual CLA) Add Frits van Bommel (individual CLA) Add Harshavardhana (individual CLA) Add Hitoshi Mitake (individual CLA) Add James Bardin (individual CLA) Add James Chacon (corporate CLA for Google Inc.) Add Jamil Djadala (individual CLA) Add Jess Frazelle (individual CLA) Add Joe Sylve (individual CLA) Add Johan Sageryd (individual CLA) Add John Jeffery (individual CLA) Add Julia Hansbrough (corporate CLA for Google Inc.) Add Jure Ham (corporate CLA for Zemanta d.o.o.) Add Kamal Aboul-Hosn (corporate CLA for Google Inc.) Add Kevin Burke (individual CLA) Add Kevin Kirsche (individual CLA) Add Kevin Vu (individual CLA) Add Lee Hinman (individual CLA) Add Luan Santos (individual CLA) Add Marc-Antoine Ruel (corporate CLA for Google Inc.) Add Matt Robenolt (individual CLA) Add Michael McConville (individual CLA) Add Michael Munday (corporate CLA for IBM) Add Michael Pratt (corporate CLA for Google Inc.) Add Michel Lespinasse (corporate CLA for Google Inc.) Add Mike Danese (corporate CLA for Google Inc.) Add Mikhail Gusarov (individual CLA) Add Monty Taylor (individual CLA) Add Morten Siebuhr (individual CLA) Add Muhammed Uluyol (individual CLA) Add Niels Widger (individual CLA) Add Niko Dziemba (individual CLA) Add Olivier Poitrey (individual CLA) Add Paul Wankadia (corporate CLA for Google Inc.) Add Philip Hofer (individual CLA) Add Prashant Varanasi (individual CLA) Add Rhys Hiltner (corporate CLA for Amazon.com, Inc) Add Richard Miller (individual CLA) Add Scott Bell (individual CLA) Add Shahar Kohanim (individual CLA) Add Shinji Tanaka (individual CLA) Add Suharsh Sivakumar (corporate CLA for Google Inc.) Add Tal Shprecher (individual CLA) Add Tilman Dilo (individual CLA) Add Tim Ebringer (individual CLA) Add Tom Bergan (corporate CLA for Google Inc.) Add Vishvananda Ishaya (individual CLA) Add Wedson Almeida Filho (corporate CLA for Google Inc.) Add Zhongwei Yao (corporate CLA for ARM Ltd.) Updates #12042 Change-Id: Ia118adc2eb38e5ffc8448de2d9dd3ca792ee7227 Reviewed-on: https://go-review.googlesource.com/23303Reviewed-by:
-
Brad Fitzpatrick authored
Fixes #15698 Change-Id: I616fc06dcf04092bafdaf56fb1afba2a998a6d83 Reviewed-on: https://go-review.googlesource.com/23304Reviewed-by:
-
Robert Griesemer authored
Ignore respective bit in export data, but leave the info to minimize format changes for 1.7. Scheduled to remove by 1.8. For #15772. Change-Id: Ifb3beea655367308a4e2d5dc8cb625915f904287 Reviewed-on: https://go-review.googlesource.com/23285 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by:
Matthew Dempsky <mdempsky@google.com>
-
Brad Fitzpatrick authored
Fixes #15765 Change-Id: Id0a89d90ef9d3fffa9af0affca8c10a26fe6b7bc Reviewed-on: https://go-review.googlesource.com/23284 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Updates x/net/http2 to git rev 4d07e8a49 for CL 23287: http2: let handlers close Request.Body without killing streams https://golang.org/cl/23287 Fixes #15425 Change-Id: I20b6e37cd09aa1d5a040c122ca0daf14b8916559 Reviewed-on: https://go-review.googlesource.com/23301 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Fixes #15775 Change-Id: I0a6c2ca09d3850c3538494711f7a9801b9500411 Reviewed-on: https://go-review.googlesource.com/23300 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Updates #15771 Change-Id: I5dad96bdca19d680dd00cbd17b72a03e43eb557e Reviewed-on: https://go-review.googlesource.com/23283Reviewed-by:
Tom Bergan <tombergan@google.com> Reviewed-by:
-
David Crawshaw authored
Fixes #15673 Change-Id: Ib36d8db3299a93d92665dbde012d52c2c5332ac0 Reviewed-on: https://go-review.googlesource.com/23253Reviewed-by:
Russ Cox <rsc@golang.org> Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Brad Fitzpatrick authored
Updates x/net/http2 to git rev 8a52c78 for golang.org/cl/23258 (http2: fix Transport.CloseIdleConnections when http1+http2 are wired together) Fixes #14607 Change-Id: I038badc69e230715b8ce4e398eb5e6ede73af918 Reviewed-on: https://go-review.googlesource.com/23280Reviewed-by:
-
Jess Frazelle authored
Change-Id: Iedce3770a92112802f3a45c7b95ee145ab5b187e Reviewed-on: https://go-review.googlesource.com/23282Reviewed-by:
-
Brad Fitzpatrick authored
Updates x/net/http2 to git rev 202ff482 for https://golang.org/cl/23235 (Expect: 100-continue support for HTTP/2) Fixes a flaky test too, and changes the automatic HTTP/2 behavior to no longer special-case the DefaultTransport, because ExpectContinueTimeout is no longer unsupported by the HTTP/2 transport. Fixes #13851 Fixes #15744 Change-Id: I3522aace14179a1ca070fd7063368a831167a0f7 Reviewed-on: https://go-review.googlesource.com/23254Reviewed-by:
-
Mikio Hara authored
Fixes #15745. Change-Id: I6f9a1dcf0b1d97cb443900c7d8da09ead83d4b6a Reviewed-on: https://go-review.googlesource.com/23243 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> Reviewed-by:
-
Jess Frazelle authored
This patch adds Unshare flags to SysProcAttr for Linux systems. Fixes #1954 Change-Id: Id819c3f92b1474e5a06dd8d55f89d74a43eb770c Reviewed-on: https://go-review.googlesource.com/23233 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 19 May, 2016 16 commits
-
-
Robert Griesemer authored
Non-syntax errors are always counted to determine if to exit early, but then deduplication eliminates them. This can lead to situations which report "too many errors" and only one error is shown. De-duplicate non-syntax errors early, at least the ones that appear consecutively, and only count the ones actually being shown. This doesn't work perfectly as they may not appear in sequence, but it's cheap and good enough. Fixes #14136. Change-Id: I7b11ebb2e1e082f0d604b88e544fe5ba967af1d7 Reviewed-on: https://go-review.googlesource.com/23259Reviewed-by:
-
Brad Fitzpatrick authored
Fixes #14238 Change-Id: I1538bfb5cfa63e36a89df1f6eb9f5a0dcafb6ce5 Reviewed-on: https://go-review.googlesource.com/23256Reviewed-by:
Dave Cheney <dave@cheney.net> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Brad Fitzpatrick authored
In Go versions 1 up to and including Go 1.6, ResponseRecorder.HeaderMap was both the map that handlers got access to, and was the map tests checked their results against. That did not mimic the behavior of the real HTTP server (Issue #8857), so HeaderMap was changed to be a snapshot at the first write in https://golang.org/cl/20047. But that broke cases where the Handler never did a write (#15560), so revert the behavior. Instead, introduce the ResponseWriter.Result method, returning an *http.Response. It subsumes ResponseWriter.Trailers which was added for Go 1.7 in CL 20047. Result().Header now contains the correct answer, and HeaderMap is unchanged in behavior from previous Go releases, so we don't break people's tests. People wanting the correct behavior can use ResponseWriter.Result. Fixes #15560 Updates #8857 Change-Id: I7ea9b56a6b843103784553d67f67847b5315b3d2 Reviewed-on: https://go-review.googlesource.com/23257Reviewed-by:
Damien Neil <dneil@google.com> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Brad Fitzpatrick authored
Fixes #14340 Change-Id: I43e1624fafc972fb868708c3857fc8acf1bfbbd7 Reviewed-on: https://go-review.googlesource.com/23255 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Rob Pike <r@golang.org>
-
Austin Clements authored
Currently it's possible for user code to exploit the high scheduler priority of the GC worker in conjunction with the runnext optimization to elevate a user goroutine to high priority so it will always run even if there are other runnable goroutines. For example, if a goroutine is in a tight allocation loop, the following can happen: 1. Goroutine 1 allocates, triggering a GC. 2. G 1 attempts an assist, but fails and blocks. 3. The scheduler runs the GC worker, since it is high priority. Note that this also starts a new scheduler quantum. 4. The GC worker does enough work to satisfy the assist. 5. The GC worker readies G 1, putting it in runnext. 6. GC finishes and the scheduler runs G 1 from runnext, giving it the rest of the GC worker's quantum. 7. Go to 1. Even if there are other goroutines on the run queue, they never get a chance to run in the above sequence. This requires a confluence of circumstances that make it unlikely, though not impossible, that it would happen in "real" code. In the test added by this commit, we force this confluence by setting GOMAXPROCS to 1 and GOGC to 1 so it's easy for the test to repeated trigger GC and wake from a blocked assist. We fix this by making GC always put user goroutines at the end of the run queue, instead of in runnext. This makes it so user code can't piggy-back on the GC's high priority to make a user goroutine act like it has high priority. The only other situation where GC wakes user goroutines is waking all blocked assists at the end, but this uses the global run queue and hence doesn't have this problem. Fixes #15706. Change-Id: I1589dee4b7b7d0c9c8575ed3472226084dfce8bc Reviewed-on: https://go-review.googlesource.com/23172Reviewed-by:
Rick Hudson <rlh@golang.org>
-
Austin Clements authored
Currently ready always puts the readied goroutine in runnext. We're going to have to change this for some uses, so add a flag for whether or not to use runnext. For now we always pass true so this is a no-op change. For #15706. Change-Id: Iaa66d8355ccfe4bbe347570cc1b1878c70fa25df Reviewed-on: https://go-review.googlesource.com/23171 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Ian Lance Taylor authored
When the generated stub functions write back the results to the stack, they can in some cases be writing to the same memory on the g0 stack. There is no race here (assuming there is no race in the Go code), but the thread sanitizer does not know that. Turn off the thread sanitizer for the stub functions to prevent false positive warnings. Current clang suggests the no_sanitize("thread") attribute, but that does not work with clang 3.6 or GCC. clang 3.6, GCC, and current clang all support the no_sanitize_thread attribute, so use that unconditionally. The test case and first version of the patch are from Dmitriy Vyukov. Change-Id: I80ce92824c6c8cf88ea0fe44f21cf50cf62474c9 Reviewed-on: https://go-review.googlesource.com/23252 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:Dmitry Vyukov <dvyukov@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Joel Sing authored
OpenBSD 6.0 (due out November 2016) will support PT_TLS, which will allow for the OpenBSD cgo pthread_create() workaround to be removed. However, in order for Go to continue working on supported OpenBSD releases (the current release and the previous release - 5.9 and 6.0, once 6.0 is released), we cannot enable PT_TLS immediately. Instead, adjust the existing code so that it works with the previous TCB allocation and the new TIB allocation. This allows the same Go runtime to work on 5.8, 5.9 and later 6.0. Once OpenBSD 5.9 is no longer supported (May 2017, when 6.1 is released), PT_TLS can be enabled and the additional cgo runtime code removed. Change-Id: I3eed5ec593d80eea78c6656cb12557004b2c0c9a Reviewed-on: https://go-review.googlesource.com/23197Reviewed-by:
-
Keith Randall authored
They get rewritten to NEWs, and they must be marked as escaping so walk doesn't try to allocate them back onto the stack. Fixes #15733 Change-Id: I433033e737c3de51a9e83a5a273168dbc9110b74 Reviewed-on: https://go-review.googlesource.com/23223 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Mikio Hara authored
Fixes #15316. Fixes #15574. Change-Id: I3ec8bffd35b9e5123de4be983a53fc0b8c2a0895 Reviewed-on: https://go-review.googlesource.com/23242 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Mikio Hara authored
Fixes #14717. Updates #15157. Change-Id: I7238b4fe39f3670c2dfe09b3a3df51a982f261ed Reviewed-on: https://go-review.googlesource.com/23244 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Ian Lance Taylor authored
The test case in #15639 somehow causes an invalid syscall frame. The failure is obscured because the throw occurs when throwsplit == true, which causes a "stack split at bad time" error when trying to print the throw message. This CL fixes the "stack split at bad time" by using systemstack. No test because there shouldn't be any way to trigger this error anyhow. Update #15639. Change-Id: I4240f3fd01bdc3c112f3ffd1316b68504222d9e1 Reviewed-on: https://go-review.googlesource.com/23153 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
Austin Clements <austin@google.com>
-
Scott Bell authored
Fixes #15088. Change-Id: I7727829a4062e15c0e5e3beff4d0bfc1fa327b0f Reviewed-on: https://go-review.googlesource.com/23232Reviewed-by:
-
Brad Fitzpatrick authored
Updates x/net/http2 to git rev 5916dcb1 for: * http2, lex/httplex: make Transport reject bogus headers before sending https://golang.org/cl/23229 * http2: reject more trailer values https://golang.org/cl/23230 Fixes #14048 Fixes #14188 Change-Id: Iaa8beca6e005267a3e849a10013eb424a882f2bb Reviewed-on: https://go-review.googlesource.com/23234Reviewed-by:
-
Mikio Hara authored
Updates #15735. Fixes #15741. Change-Id: Ic4ad7e948e8c3ab5feffef89d7a37417f82722a1 Reviewed-on: https://go-review.googlesource.com/23199 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Updates #15735 Change-Id: I42ab2345443bbaeaf935d683460fc2c941b7679c Reviewed-on: https://go-review.googlesource.com/23227Reviewed-by:
-
- 18 May, 2016 1 commit
-
-
Ian Lance Taylor authored
Change-Id: I54ed7a26a753afb2d6a72080e1f50ce9fba7c183 Reviewed-on: https://go-review.googlesource.com/23228 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
-
