1. 19 Nov, 2012 2 commits
  2. 18 Nov, 2012 2 commits
    • Dave Cheney's avatar
      net: fix data race on fd.sysfd · c9856e7d
      Dave Cheney authored
      Fixes #4369.
      
      Remove the check for fd.sysfd < 0, the first line of fd.accept() tests if the fd is open correctly and will handle the fd being closed during accept.
      
      R=dvyukov, bradfitz
      CC=golang-dev
      https://golang.org/cl/6843076
      c9856e7d
    • Dave Cheney's avatar
      net: remove unused nil check · 0bfece06
      Dave Cheney authored
      This is part 1 of a series of proposals to fix issue 4369.
      
      In resolving issue 3507 it was decided not to nil out the inner conn.fd field to avoid a race. This implies the checks for fd == nil inside incref/decref are never true.
      
      Removing this logic removes one source of errClosing error values, which affects issue 4373 and moves towards bradfitz's request that fd.accept() return io.EOF when closed concurrently.
      
      Update #4369.
      Update #4373.
      
      R=mikioh.mikioh, bradfitz, dvyukov, rsc
      CC=golang-dev
      https://golang.org/cl/6852057
      0bfece06
  3. 17 Nov, 2012 9 commits
  4. 16 Nov, 2012 7 commits
  5. 15 Nov, 2012 8 commits
  6. 14 Nov, 2012 11 commits
  7. 13 Nov, 2012 1 commit
    • Robert Griesemer's avatar
      reflect: fix FieldByNameFunc · aa388017
      Robert Griesemer authored
      The existing algorithm did not properly propagate the type
      count from one level to the next, and as a consequence it
      missed collisions.
      
      Properly propagate multiplicity (count) information to the
      next level.
      
      benchmark                old ns/op    new ns/op    delta
      BenchmarkFieldByName1          182          180   -1.10%
      BenchmarkFieldByName2         6273         6183   -1.43%
      BenchmarkFieldByName3        49267        46784   -5.04%
      
      Fixes #4355.
      
      R=rsc
      CC=golang-dev
      https://golang.org/cl/6821094
      aa388017