1. 14 Apr, 2014 8 commits
    • Dmitriy Vyukov's avatar
      sync: less agressive local caching in Pool · 8fc6ed4c
      Dmitriy Vyukov authored
      Currently Pool can cache up to 15 elements per P, and these elements are not accesible to other Ps.
      If a Pool caches large objects, say 2MB, and GOMAXPROCS is set to a large value, say 32,
      then the Pool can waste up to 960MB.
      The new caching policy caches at most 1 per-P element, the rest is shared between Ps.
      
      Get/Put performance is unchanged. Nested Get/Put performance is 57% worse.
      However, overall scalability of nested Get/Put is significantly improved,
      so the new policy starts winning under contention.
      
      benchmark                     old ns/op     new ns/op     delta
      BenchmarkPool                 27.4          26.7          -2.55%
      BenchmarkPool-4               6.63          6.59          -0.60%
      BenchmarkPool-16              1.98          1.87          -5.56%
      BenchmarkPool-64              1.93          1.86          -3.63%
      BenchmarkPoolOverlflow        3970          6235          +57.05%
      BenchmarkPoolOverlflow-4      10935         1668          -84.75%
      BenchmarkPoolOverlflow-16     13419         520           -96.12%
      BenchmarkPoolOverlflow-64     10295         380           -96.31%
      
      LGTM=rsc
      R=rsc
      CC=golang-codereviews, khr
      https://golang.org/cl/86020043
      8fc6ed4c
    • Ian Lance Taylor's avatar
      libbio: add casts to eliminate -Wconversion warning · 1e1506a2
      Ian Lance Taylor authored
      LGTM=bradfitz
      R=golang-codereviews, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/87140044
      1e1506a2
    • Russ Cox's avatar
      cmd/dist: mark cmd/link and debug/goobj as unreleased · 41ff456f
      Russ Cox authored
      These are not ready and will not be in Go 1.3.
      
      Fixes #6932.
      
      LGTM=bradfitz
      R=golang-codereviews, bradfitz, minux.ma
      CC=golang-codereviews, iant, r
      https://golang.org/cl/87630043
      41ff456f
    • Russ Cox's avatar
      cmd/prof, libmach: delete · 1d718164
      Russ Cox authored
      We have never released cmd/prof and don't plan to.
      Now that nm, addr2line, and objdump have been rewritten in Go,
      cmd/prof is the only thing keeping us from deleting libmach.
      
      Delete cmd/prof, and then since nothing is using libmach, delete libmach.
      
      13,000 lines of C deleted.
      
      LGTM=minux.ma
      R=golang-codereviews, minux.ma
      CC=golang-codereviews, iant, r
      https://golang.org/cl/87020044
      1d718164
    • Brad Fitzpatrick's avatar
      net/http: close Body in client code always, even on errors, and document · a8d90ec3
      Brad Fitzpatrick authored
      Fixes #6981
      
      LGTM=rsc
      R=golang-codereviews, nightlyone
      CC=adg, dsymonds, golang-codereviews, rsc
      https://golang.org/cl/85560045
      a8d90ec3
    • Russ Cox's avatar
      cmd/objdump: rewrite in Go · 0d441a08
      Russ Cox authored
      Update cmd/dist not to build the C version.
      Update cmd/go to install the Go version to the tool directory.
      
      Update #7452
      
      This is the basic logic needed for objdump, and it works well enough
      to support the pprof list and weblist commands. A real disassembler
      needs to be added in order to support the pprof disasm command
      and the per-line assembly displays in weblist. That's still to come.
      
      Probably objdump will move to go.tools when the disassembler
      is added, but it can stay here for now.
      
      LGTM=minux.ma
      R=golang-codereviews, minux.ma
      CC=golang-codereviews, iant, r
      https://golang.org/cl/87580043
      0d441a08
    • Russ Cox's avatar
      undo CL 66510044 / 6c0339d94123 · c48db9a4
      Russ Cox authored
      Broke other things - see issue 7522.
      
      Fixes #7522.
      Reopens issue 7363.
      
      ««« original CL description
      cmd/gc: make embedded, unexported fields read-only.
      
      Fixes #7363.
      
      LGTM=gri
      R=gri, rsc, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/66510044
      »»»
      
      LGTM=r, mpvl
      R=golang-codereviews, r
      CC=golang-codereviews, iant, mpvl
      https://golang.org/cl/85580046
      c48db9a4
    • Russ Cox's avatar
      runtime: increase timeout in TestStackGrowth · 72185093
      Russ Cox authored
      It looks like maybe on slower builders 4 seconds is not enough.
      Trying to get rid of the flaky failures.
      
      TBR=iant
      CC=golang-codereviews
      https://golang.org/cl/86870044
      72185093
  2. 12 Apr, 2014 1 commit
  3. 11 Apr, 2014 16 commits
  4. 10 Apr, 2014 15 commits