Skip to content

G
go
Switch branch/tag
  1. 06 Nov, 2014 4 commits
    • Andrew Gerrand's avatar
      bufio: remove unused 'panicked' variable from test · 908dcab6
      Andrew Gerrand authored 
      LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/166230044
      908dcab6
    • Russ Cox's avatar
      runtime: avoid gentraceback of self on user goroutine stack · 39bcbb35
      Russ Cox authored 
      Gentraceback may grow the stack.
One of the gentraceback wrappers may grow the stack.
One of the gentraceback callback calls may grow the stack.
Various stack pointers are stored in various stack locations
as type uintptr during the execution of these calls.
If the stack does grow, these stack pointers will not be
updated and will start trying to decode stack memory that
is no longer valid.

It may be possible to change the type of the stack pointer
variables to be unsafe.Pointer, but that's pretty subtle and
may still have problems, even if we catch every last one.
An easier, more obviously correct fix is to require that
gentraceback of the currently running goroutine must run
on the g0 stack, not on the goroutine's own stack.

Not doing this causes faults when you set
        StackFromSystem = 1
        StackFaultOnFree = 1

The new check in gentraceback will catch future lapses.

The more general problem is calling getcallersp but then
calling a function that might relocate the stack, which would
invalidate the result of getcallersp. Add note to stubs.go
declaration of getcallersp explaining the problem, and
check all existing calls to getcallersp. Most needed fixes.

This affects Callers, Stack, and nearly all the runtime
profiling routines. It does not affect stack copying directly
nor garbage collection.

LGTM=khr
R=khr, bradfitz
CC=golang-codereviews, r
https://golang.org/cl/167060043
      39bcbb35
    • Russ Cox's avatar
      bufio: fix reading of many blank lines in a row · 2d0db8e5
      Russ Cox authored 
      Fixes #9020.

LGTM=bradfitz, r
R=r, bradfitz
CC=golang-codereviews
https://golang.org/cl/170030043
      2d0db8e5
    • Russ Cox's avatar
      doc/go1.4.html: document new subrepo import paths · 67742ef5
      Russ Cox authored 
      LGTM=r, adg
R=adg, r, 0xjnml, dr.volker.dobler
CC=golang-codereviews
https://golang.org/cl/166980044
      67742ef5
  3. 05 Nov, 2014 2 commits
  5. 04 Nov, 2014 2 commits
    • Ian Lance Taylor's avatar
      test: comment out failing cases from sinit.go · c6e53fea
      Ian Lance Taylor authored 
      One failing case this removes is:

var bytes = []byte("hello, world")
var copy_bytes = bytes

We could handle this in the compiler, but it requires special
case for a variable that is initialized to the value of a
variable that is initialized to a string literal converted to
[]byte.  This seems an unlikely case--it never occurs in the
standrd library--and it seems unnecessary to write the code to
handle it.

If we do want to support this case, one approach is
https://golang.org/cl/171840043.

The other failing cases are of the form

var bx bool
var copy_bx = bx

The compiler used to initialize copy_bx to false.  However,
that led to issue 7665, since bx may be initialized in non-Go
code.  The compiler no longer assumes that bx must be false,
so copy_bx can not be statically initialized.

We can fix these with https://golang.org/cl/169040043
if we also pass -complete to the compiler as part of this
test.  This is OK but it's too late in the release cycle.

Fixes #8746.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/165400043
      c6e53fea
    • Austin Clements's avatar
      gc: abort if given an unknown debug (-d) flag · 516d9ef5
      Austin Clements authored 
      The check for unknown command line debug flags in gc was
incorrect: the loop over debugtab terminates when it reaches a
nil entry, but it was only reporting an error if the parser
had passed the last entry of debugtab (which it never did).
Fix this by reporting the usage error if the loop reaches a
nil entry.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/166110043
      516d9ef5
  7. 03 Nov, 2014 3 commits
  9. 01 Nov, 2014 2 commits
  11. 31 Oct, 2014 5 commits
  13. 30 Oct, 2014 10 commits
  15. 29 Oct, 2014 12 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7