1. 02 May, 2015 5 commits
  2. 01 May, 2015 21 commits
    • Dave Cheney's avatar
      cmd/internal/obj: remove Biobuf unget · 8d16253c
      Dave Cheney authored
      This change applies CL 9365 to the copy of Biobuf in cmd/internal/obj.
      
      In the process I discovered that some of the methods that should have been
      checking the unget buffer before reading were not and it was probably just
      dumb luck that we handn't hit these issues before; Bungetc is only used in
      one place in cmd/internal/gc and only an unlikely code path.
      
      Change-Id: Ifa0c5c08442e9fe951a5078c6e9ec77a8a4dc2ff
      Reviewed-on: https://go-review.googlesource.com/9529Reviewed-by: default avatarDaniel Morsing <daniel.morsing@gmail.com>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      Reviewed-by: default avatarDave Cheney <dave@cheney.net>
      Run-TryBot: Dave Cheney <dave@cheney.net>
      8d16253c
    • Brad Fitzpatrick's avatar
      net/http: fix scheduling race resulting in flaky test · c723230e
      Brad Fitzpatrick authored
      The test was measuring something, assuming other goroutines had
      already scheduled.
      
      Fixes #10427
      
      Change-Id: I2a4d3906f9d4b5ea44b57d972e303bbe2b0b1cde
      Reviewed-on: https://go-review.googlesource.com/9561Reviewed-by: default avatarDavid Crawshaw <crawshaw@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      c723230e
    • Didier Spezia's avatar
      text/template: detect unmatched else at parsing time · 80cedf3e
      Didier Spezia authored
      An unmatched {{else}} should trigger a parsing error.
      
      The top level parser is able to issue an error in case
      of unmatched {{end}}. It does it a posteriori (i.e. after having
      parsed the action).
      
      Extend this behavior to also check for unmatched {{else}}
      
      Fixes #10611
      
      Change-Id: I1d4f433cc64e11bea5f4d61419ccc707ac01bb1d
      Reviewed-on: https://go-review.googlesource.com/9620Reviewed-by: default avatarRob Pike <r@golang.org>
      80cedf3e
    • Didier Spezia's avatar
      cmd/internal/gc,ld: use new flag argument syntax · 8a072ada
      Didier Spezia authored
      The usage messages for the flags in gc and ld are using the old
      flag argument syntax:
         "arg: description using arg"
      
      Update them to the Go 1.5 flag package's syntax:
         "description using arg"
      
      Fixes #10505
      
      Change-Id: Ifa54ff91e1fd644cfc9a3b41e10176eac3654137
      Reviewed-on: https://go-review.googlesource.com/9505Reviewed-by: default avatarRob Pike <r@golang.org>
      8a072ada
    • Austin Clements's avatar
      runtime: detailed debug output of controller state · dc870d5f
      Austin Clements authored
      This adds a detailed debug dump of the state of the GC controller and
      a GODEBUG flag to enable it.
      
      Change-Id: I562fed7981691a84ddf0f9e6fcd9f089f497ac13
      Reviewed-on: https://go-review.googlesource.com/9640Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      dc870d5f
    • Russ Cox's avatar
      runtime: correct accounting of scan work and bytes marked · 4fffc50c
      Russ Cox authored
      (1) Count pointer-free objects found during scanning roots
      as marked bytes, by not zeroing the mark total after scanning roots.
      
      (2) Don't count the bytes for the roots themselves, by not adding
      them to the mark total in scanblock (the zeroing removed by (1)
      was aimed at that add but hitting more).
      
      Combined, (1) and (2) fix the calculation of the marked heap size.
      This makes the GC trigger much less often in the Go 1 benchmarks,
      which have a global []byte pointing at 256 MB of data.
      That 256 MB allocation was not being included in the heap size
      in the current code, but was included in Go 1.4.
      This is the source of much of the relative slowdown in that directory.
      
      (3) Count the bytes for the roots as scanned work, by not zeroing
      the scan total after scanning roots. There is no strict justification
      for this, and it probably doesn't matter much either way,
      but it was always combined with another buggy zeroing
      (removed in (1)), so guilty by association.
      
      Austin noticed this.
      
      name                                    old mean                new mean        delta
      BenchmarkBinaryTree17              13.1s × (0.97,1.03)      5.9s × (0.97,1.05)  -55.19% (p=0.000)
      BenchmarkFannkuch11                4.35s × (0.99,1.01)     4.37s × (1.00,1.01)  +0.47% (p=0.032)
      BenchmarkFmtFprintfEmpty          84.6ns × (0.95,1.14)    85.7ns × (0.94,1.05)  ~ (p=0.521)
      BenchmarkFmtFprintfString          320ns × (0.95,1.06)     283ns × (0.99,1.02)  -11.48% (p=0.000)
      BenchmarkFmtFprintfInt             311ns × (0.98,1.03)     288ns × (0.99,1.02)  -7.26% (p=0.000)
      BenchmarkFmtFprintfIntInt          554ns × (0.96,1.05)     478ns × (0.99,1.02)  -13.70% (p=0.000)
      BenchmarkFmtFprintfPrefixedInt     434ns × (0.96,1.06)     393ns × (0.98,1.04)  -9.60% (p=0.000)
      BenchmarkFmtFprintfFloat           620ns × (0.99,1.03)     584ns × (0.99,1.01)  -5.73% (p=0.000)
      BenchmarkFmtManyArgs              2.19µs × (0.98,1.03)    1.94µs × (0.99,1.01)  -11.62% (p=0.000)
      BenchmarkGobDecode                21.2ms × (0.97,1.06)    15.2ms × (0.99,1.01)  -28.17% (p=0.000)
      BenchmarkGobEncode                18.1ms × (0.94,1.06)    11.8ms × (0.99,1.01)  -35.00% (p=0.000)
      BenchmarkGzip                      650ms × (0.98,1.01)     649ms × (0.99,1.02)  ~ (p=0.802)
      BenchmarkGunzip                    143ms × (1.00,1.01)     143ms × (1.00,1.01)  ~ (p=0.438)
      BenchmarkHTTPClientServer          110µs × (0.98,1.04)     101µs × (0.98,1.02)  -8.79% (p=0.000)
      BenchmarkJSONEncode               40.3ms × (0.97,1.03)    31.8ms × (0.98,1.03)  -20.92% (p=0.000)
      BenchmarkJSONDecode                119ms × (0.97,1.02)     108ms × (0.99,1.02)  -9.15% (p=0.000)
      BenchmarkMandelbrot200            6.03ms × (1.00,1.01)    6.03ms × (0.99,1.01)  ~ (p=0.750)
      BenchmarkGoParse                  8.58ms × (0.89,1.10)    6.80ms × (1.00,1.00)  -20.71% (p=0.000)
      BenchmarkRegexpMatchEasy0_32       162ns × (1.00,1.01)     162ns × (0.99,1.02)  ~ (p=0.131)
      BenchmarkRegexpMatchEasy0_1K       540ns × (0.99,1.02)     559ns × (0.99,1.02)  +3.58% (p=0.000)
      BenchmarkRegexpMatchEasy1_32       139ns × (0.98,1.04)     139ns × (1.00,1.00)  ~ (p=0.466)
      BenchmarkRegexpMatchEasy1_1K       889ns × (0.99,1.01)     885ns × (0.99,1.01)  -0.50% (p=0.022)
      BenchmarkRegexpMatchMedium_32      252ns × (0.99,1.02)     252ns × (0.99,1.01)  ~ (p=0.469)
      BenchmarkRegexpMatchMedium_1K     72.9µs × (0.99,1.01)    73.6µs × (0.99,1.03)  ~ (p=0.168)
      BenchmarkRegexpMatchHard_32       3.87µs × (1.00,1.01)    3.86µs × (1.00,1.00)  ~ (p=0.055)
      BenchmarkRegexpMatchHard_1K        118µs × (0.99,1.01)     117µs × (0.99,1.00)  ~ (p=0.133)
      BenchmarkRevcomp                   995ms × (0.94,1.10)     949ms × (0.99,1.01)  -4.64% (p=0.000)
      BenchmarkTemplate                  141ms × (0.97,1.02)     127ms × (0.99,1.01)  -10.00% (p=0.000)
      BenchmarkTimeParse                 641ns × (0.99,1.01)     623ns × (0.99,1.01)  -2.79% (p=0.000)
      BenchmarkTimeFormat                729ns × (0.98,1.03)     679ns × (0.99,1.00)  -6.93% (p=0.000)
      
      Change-Id: I839bd7356630d18377989a0748763414e15ed057
      Reviewed-on: https://go-review.googlesource.com/9602Reviewed-by: default avatarAustin Clements <austin@google.com>
      4fffc50c
    • Russ Cox's avatar
      cmd/internal/gc, runtime: use 1-bit bitmap for stack frames, data, bss · 4d0f3a1c
      Russ Cox authored
      The bitmaps were 2 bits per pointer because we needed to distinguish
      scalar, pointer, multiword, and we used the leftover value to distinguish
      uninitialized from scalar, even though the garbage collector (GC) didn't care.
      
      Now that there are no multiword structures from the GC's point of view,
      cut the bitmaps down to 1 bit per pointer, recording just live pointer vs not.
      
      The GC assumes the same layout for stack frames and for the maps
      describing the global data and bss sections, so change them all in one CL.
      
      The code still refers to 4-bit heap bitmaps and 2-bit "type bitmaps", since
      the 2-bit representation lives (at least for now) in some of the reflect data.
      
      Because these stack frame bitmaps are stored directly in the rodata in
      the binary, this CL reduces the size of the 6g binary by about 1.1%.
      
      Performance change is basically a wash, but using less memory,
      and smaller binaries, and enables other bitmap reductions.
      
      name                                      old mean                new mean        delta
      BenchmarkBinaryTree17                13.2s × (0.97,1.03)     13.0s × (0.99,1.01)  -0.93% (p=0.005)
      BenchmarkBinaryTree17-2              9.69s × (0.96,1.05)     9.51s × (0.96,1.03)  -1.86% (p=0.001)
      BenchmarkBinaryTree17-4              10.1s × (0.97,1.05)     10.0s × (0.96,1.05)  ~ (p=0.141)
      BenchmarkFannkuch11                  4.35s × (0.99,1.01)     4.43s × (0.98,1.04)  +1.75% (p=0.001)
      BenchmarkFannkuch11-2                4.31s × (0.99,1.03)     4.32s × (1.00,1.00)  ~ (p=0.095)
      BenchmarkFannkuch11-4                4.32s × (0.99,1.02)     4.38s × (0.98,1.04)  +1.38% (p=0.008)
      BenchmarkFmtFprintfEmpty            83.5ns × (0.97,1.10)    87.3ns × (0.92,1.11)  +4.55% (p=0.014)
      BenchmarkFmtFprintfEmpty-2          81.8ns × (0.98,1.04)    82.5ns × (0.97,1.08)  ~ (p=0.364)
      BenchmarkFmtFprintfEmpty-4          80.9ns × (0.99,1.01)    82.6ns × (0.97,1.08)  +2.12% (p=0.010)
      BenchmarkFmtFprintfString            320ns × (0.95,1.04)     322ns × (0.97,1.05)  ~ (p=0.368)
      BenchmarkFmtFprintfString-2          303ns × (0.97,1.04)     304ns × (0.97,1.04)  ~ (p=0.484)
      BenchmarkFmtFprintfString-4          305ns × (0.97,1.05)     306ns × (0.98,1.05)  ~ (p=0.543)
      BenchmarkFmtFprintfInt               311ns × (0.98,1.03)     319ns × (0.97,1.03)  +2.63% (p=0.000)
      BenchmarkFmtFprintfInt-2             297ns × (0.98,1.04)     301ns × (0.97,1.04)  +1.19% (p=0.023)
      BenchmarkFmtFprintfInt-4             302ns × (0.98,1.02)     304ns × (0.97,1.03)  ~ (p=0.126)
      BenchmarkFmtFprintfIntInt            554ns × (0.96,1.05)     554ns × (0.97,1.03)  ~ (p=0.975)
      BenchmarkFmtFprintfIntInt-2          520ns × (0.98,1.03)     517ns × (0.98,1.02)  ~ (p=0.153)
      BenchmarkFmtFprintfIntInt-4          524ns × (0.98,1.02)     525ns × (0.98,1.03)  ~ (p=0.597)
      BenchmarkFmtFprintfPrefixedInt       433ns × (0.97,1.06)     434ns × (0.97,1.06)  ~ (p=0.804)
      BenchmarkFmtFprintfPrefixedInt-2     413ns × (0.98,1.04)     413ns × (0.98,1.03)  ~ (p=0.881)
      BenchmarkFmtFprintfPrefixedInt-4     420ns × (0.97,1.03)     421ns × (0.97,1.03)  ~ (p=0.561)
      BenchmarkFmtFprintfFloat             620ns × (0.99,1.03)     636ns × (0.97,1.03)  +2.57% (p=0.000)
      BenchmarkFmtFprintfFloat-2           601ns × (0.98,1.02)     617ns × (0.98,1.03)  +2.58% (p=0.000)
      BenchmarkFmtFprintfFloat-4           613ns × (0.98,1.03)     626ns × (0.98,1.02)  +2.15% (p=0.000)
      BenchmarkFmtManyArgs                2.19µs × (0.96,1.04)    2.23µs × (0.97,1.02)  +1.65% (p=0.000)
      BenchmarkFmtManyArgs-2              2.08µs × (0.98,1.03)    2.10µs × (0.99,1.02)  +0.79% (p=0.019)
      BenchmarkFmtManyArgs-4              2.10µs × (0.98,1.02)    2.13µs × (0.98,1.02)  +1.72% (p=0.000)
      BenchmarkGobDecode                  21.3ms × (0.97,1.05)    21.1ms × (0.97,1.04)  -1.36% (p=0.025)
      BenchmarkGobDecode-2                20.0ms × (0.97,1.03)    19.2ms × (0.97,1.03)  -4.00% (p=0.000)
      BenchmarkGobDecode-4                19.5ms × (0.99,1.02)    19.0ms × (0.99,1.01)  -2.39% (p=0.000)
      BenchmarkGobEncode                  18.3ms × (0.95,1.07)    18.1ms × (0.96,1.08)  ~ (p=0.305)
      BenchmarkGobEncode-2                16.8ms × (0.97,1.02)    16.4ms × (0.98,1.02)  -2.79% (p=0.000)
      BenchmarkGobEncode-4                15.4ms × (0.98,1.02)    15.4ms × (0.98,1.02)  ~ (p=0.465)
      BenchmarkGzip                        650ms × (0.98,1.03)     655ms × (0.97,1.04)  ~ (p=0.075)
      BenchmarkGzip-2                      652ms × (0.98,1.03)     655ms × (0.98,1.02)  ~ (p=0.337)
      BenchmarkGzip-4                      656ms × (0.98,1.04)     653ms × (0.98,1.03)  ~ (p=0.291)
      BenchmarkGunzip                      143ms × (1.00,1.01)     143ms × (1.00,1.01)  ~ (p=0.507)
      BenchmarkGunzip-2                    143ms × (1.00,1.01)     143ms × (1.00,1.01)  ~ (p=0.313)
      BenchmarkGunzip-4                    143ms × (1.00,1.01)     143ms × (1.00,1.01)  ~ (p=0.312)
      BenchmarkHTTPClientServer            110µs × (0.98,1.03)     109µs × (0.99,1.02)  -1.40% (p=0.000)
      BenchmarkHTTPClientServer-2          154µs × (0.90,1.08)     149µs × (0.90,1.08)  -3.43% (p=0.007)
      BenchmarkHTTPClientServer-4          138µs × (0.97,1.04)     138µs × (0.96,1.04)  ~ (p=0.670)
      BenchmarkJSONEncode                 40.2ms × (0.98,1.02)    40.2ms × (0.98,1.05)  ~ (p=0.828)
      BenchmarkJSONEncode-2               35.1ms × (0.99,1.02)    35.2ms × (0.98,1.03)  ~ (p=0.392)
      BenchmarkJSONEncode-4               35.3ms × (0.98,1.03)    35.3ms × (0.98,1.02)  ~ (p=0.813)
      BenchmarkJSONDecode                  119ms × (0.97,1.02)     117ms × (0.98,1.02)  -1.80% (p=0.000)
      BenchmarkJSONDecode-2                115ms × (0.99,1.02)     114ms × (0.98,1.02)  -1.18% (p=0.000)
      BenchmarkJSONDecode-4                116ms × (0.98,1.02)     114ms × (0.98,1.02)  -1.43% (p=0.000)
      BenchmarkMandelbrot200              6.03ms × (1.00,1.01)    6.03ms × (1.00,1.01)  ~ (p=0.985)
      BenchmarkMandelbrot200-2            6.03ms × (1.00,1.01)    6.02ms × (1.00,1.01)  ~ (p=0.320)
      BenchmarkMandelbrot200-4            6.03ms × (1.00,1.01)    6.03ms × (1.00,1.01)  ~ (p=0.799)
      BenchmarkGoParse                    8.63ms × (0.89,1.10)    8.58ms × (0.93,1.09)  ~ (p=0.667)
      BenchmarkGoParse-2                  8.20ms × (0.97,1.04)    8.37ms × (0.97,1.04)  +1.96% (p=0.001)
      BenchmarkGoParse-4                  8.00ms × (0.98,1.02)    8.14ms × (0.99,1.02)  +1.75% (p=0.000)
      BenchmarkRegexpMatchEasy0_32         162ns × (1.00,1.01)     164ns × (0.98,1.04)  +1.35% (p=0.011)
      BenchmarkRegexpMatchEasy0_32-2       161ns × (1.00,1.01)     161ns × (1.00,1.00)  ~ (p=0.185)
      BenchmarkRegexpMatchEasy0_32-4       161ns × (1.00,1.00)     161ns × (1.00,1.00)  -0.19% (p=0.001)
      BenchmarkRegexpMatchEasy0_1K         540ns × (0.99,1.02)     566ns × (0.98,1.04)  +4.98% (p=0.000)
      BenchmarkRegexpMatchEasy0_1K-2       540ns × (0.99,1.01)     557ns × (0.99,1.01)  +3.21% (p=0.000)
      BenchmarkRegexpMatchEasy0_1K-4       541ns × (0.99,1.01)     559ns × (0.99,1.01)  +3.26% (p=0.000)
      BenchmarkRegexpMatchEasy1_32         139ns × (0.98,1.04)     139ns × (0.99,1.03)  ~ (p=0.979)
      BenchmarkRegexpMatchEasy1_32-2       139ns × (0.99,1.04)     139ns × (0.99,1.02)  ~ (p=0.777)
      BenchmarkRegexpMatchEasy1_32-4       139ns × (0.98,1.04)     139ns × (0.99,1.04)  ~ (p=0.771)
      BenchmarkRegexpMatchEasy1_1K         890ns × (0.99,1.03)     885ns × (1.00,1.01)  -0.50% (p=0.004)
      BenchmarkRegexpMatchEasy1_1K-2       888ns × (0.99,1.01)     885ns × (0.99,1.01)  -0.37% (p=0.004)
      BenchmarkRegexpMatchEasy1_1K-4       890ns × (0.99,1.02)     884ns × (1.00,1.00)  -0.70% (p=0.000)
      BenchmarkRegexpMatchMedium_32        252ns × (0.99,1.01)     251ns × (0.99,1.01)  ~ (p=0.081)
      BenchmarkRegexpMatchMedium_32-2      254ns × (0.99,1.04)     252ns × (0.99,1.01)  -0.78% (p=0.027)
      BenchmarkRegexpMatchMedium_32-4      253ns × (0.99,1.04)     252ns × (0.99,1.01)  -0.70% (p=0.022)
      BenchmarkRegexpMatchMedium_1K       72.9µs × (0.99,1.01)    72.7µs × (1.00,1.00)  ~ (p=0.064)
      BenchmarkRegexpMatchMedium_1K-2     74.1µs × (0.98,1.05)    72.9µs × (1.00,1.01)  -1.61% (p=0.001)
      BenchmarkRegexpMatchMedium_1K-4     73.6µs × (0.99,1.05)    72.8µs × (1.00,1.00)  -1.13% (p=0.007)
      BenchmarkRegexpMatchHard_32         3.88µs × (0.99,1.03)    3.92µs × (0.98,1.05)  ~ (p=0.143)
      BenchmarkRegexpMatchHard_32-2       3.89µs × (0.99,1.03)    3.93µs × (0.98,1.09)  ~ (p=0.278)
      BenchmarkRegexpMatchHard_32-4       3.90µs × (0.99,1.05)    3.93µs × (0.98,1.05)  ~ (p=0.252)
      BenchmarkRegexpMatchHard_1K          118µs × (0.99,1.01)     117µs × (0.99,1.02)  -0.54% (p=0.003)
      BenchmarkRegexpMatchHard_1K-2        118µs × (0.99,1.01)     118µs × (0.99,1.03)  ~ (p=0.581)
      BenchmarkRegexpMatchHard_1K-4        118µs × (0.99,1.02)     117µs × (0.99,1.01)  -0.54% (p=0.002)
      BenchmarkRevcomp                     991ms × (0.95,1.10)     989ms × (0.94,1.08)  ~ (p=0.879)
      BenchmarkRevcomp-2                   978ms × (0.95,1.11)     962ms × (0.96,1.08)  ~ (p=0.257)
      BenchmarkRevcomp-4                   979ms × (0.96,1.07)     974ms × (0.96,1.11)  ~ (p=0.678)
      BenchmarkTemplate                    141ms × (0.99,1.02)     145ms × (0.99,1.02)  +2.75% (p=0.000)
      BenchmarkTemplate-2                  135ms × (0.98,1.02)     138ms × (0.99,1.02)  +2.34% (p=0.000)
      BenchmarkTemplate-4                  136ms × (0.98,1.02)     140ms × (0.99,1.02)  +2.71% (p=0.000)
      BenchmarkTimeParse                   640ns × (0.99,1.01)     622ns × (0.99,1.01)  -2.88% (p=0.000)
      BenchmarkTimeParse-2                 640ns × (0.99,1.01)     622ns × (1.00,1.00)  -2.81% (p=0.000)
      BenchmarkTimeParse-4                 640ns × (1.00,1.01)     622ns × (0.99,1.01)  -2.82% (p=0.000)
      BenchmarkTimeFormat                  730ns × (0.98,1.02)     731ns × (0.98,1.03)  ~ (p=0.767)
      BenchmarkTimeFormat-2                709ns × (0.99,1.02)     707ns × (0.99,1.02)  ~ (p=0.347)
      BenchmarkTimeFormat-4                717ns × (0.98,1.01)     718ns × (0.98,1.02)  ~ (p=0.793)
      
      Change-Id: Ie779c47e912bf80eb918bafa13638bd8dfd6c2d9
      Reviewed-on: https://go-review.googlesource.com/9406Reviewed-by: default avatarRick Hudson <rlh@golang.org>
      4d0f3a1c
    • Dave Cheney's avatar
      cmd/internal/obj: clean up Biobuf · e9ab343f
      Dave Cheney authored
      This is a follow up to rev 443a32e7 which reduces some of the
      duplication between methods and functions that operate on obj.Biobuf.
      
      obj.Biobuf has Flush and Write methods as well as helpers which duplicate
      those methods, consolidate on the former and remove the latter.
      
      Also, address a final comment from CL 9525.
      
      Change-Id: I67deaf3a163bb489a9bb21bb39524785d7a2f6c5
      Reviewed-on: https://go-review.googlesource.com/9527Reviewed-by: default avatarJosh Bleecher Snyder <josharian@gmail.com>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      e9ab343f
    • David Chase's avatar
      cmd/internal/gc: Toughen escape analysis against some bugs. · bc44b818
      David Chase authored
      Ensures that parameter flow bits are not set for tags EscScope, EscHeap, EscNever;
      crash the compiler earl to expose faulty logic, rather than flake out silently downstream.
      
      Change-Id: I1428129980ae047d02975f033d56cbbd04f49579
      Reviewed-on: https://go-review.googlesource.com/9601Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      bc44b818
    • Josh Bleecher Snyder's avatar
      Revert "runtime/pprof: write heap statistics to heap profile always" · 7bebccb9
      Josh Bleecher Snyder authored
      This reverts commit c26fc88d.
      
      This broke pprof. See the comments at 9491.
      
      Change-Id: Ic99ce026e86040c050a9bf0ea3024a1a42274ad1
      Reviewed-on: https://go-review.googlesource.com/9565Reviewed-by: default avatarDaniel Morsing <daniel.morsing@gmail.com>
      Reviewed-by: default avatarMatthew Dempsky <mdempsky@google.com>
      7bebccb9
    • Keith Randall's avatar
      cmd/dist, runtime: Make stack guard larger for non-optimized builds · a55b1313
      Keith Randall authored
      Kind of a hack, but makes the non-optimized builds pass.
      
      Fixes #10079
      
      Change-Id: I26f41c546867f8f3f16d953dc043e784768f2aff
      Reviewed-on: https://go-review.googlesource.com/9552Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      a55b1313
    • David Chase's avatar
      cmd/internal/gc: improve flow of input params to output params · 7fbb1b36
      David Chase authored
      This includes the following information in the per-function summary:
      
      outK = paramJ   encoded in outK bits for paramJ
      outK = *paramJ  encoded in outK bits for paramJ
      heap = paramJ   EscHeap
      heap = *paramJ  EscContentEscapes
      
      Note that (currently) if the address of a parameter is taken and
      returned, necessarily a heap allocation occurred to contain that
      reference, and the heap can never refer to stack, therefore the
      parameter and everything downstream from it escapes to the heap.
      
      The per-function summary information now has a tuneable number of bits
      (2 is probably noticeably better than 1, 3 is likely overkill, but it
      is now easy to check and the -m debugging output includes information
      that allows you to figure out if more would be better.)
      
      A new test was  added to check pointer flow through struct-typed and
      *struct-typed parameters and returns; some of these are sensitive to
      the number of summary bits, and ought to yield better results with a
      more competent escape analysis algorithm.  Another new test checks
      (some) correctness with array parameters, results, and operations.
      
      The old analysis inferred a piece of plan9 runtime was non-escaping by
      counteracting overconservative analysis with buggy analysis; with the
      bug fixed, the result was too conservative (and it's not easy to fix
      in this framework) so the source code was tweaked to get the desired
      result.  A test was added against the discovered bug.
      
      The escape analysis was further improved splitting the "level" into
      3 parts, one tracking the conventional "level" and the other two
      computing the highest-level-suffix-from-copy, which is used to
      generally model the cancelling effect of indirection applied to
      address-of.
      
      With the improved escape analysis enabled, it was necessary to
      modify one of the runtime tests because it now attempts to allocate
      too much on the (small, fixed-size) G0 (system) stack and this
      failed the test.
      
      Compiling src/std after touching src/runtime/*.go with -m logging
      turned on shows 420 fewer heap allocation sites (10538 vs 10968).
      
      Profiling allocations in src/html/template with
      for i in {1..5} ;
        do go tool 6g -memprofile=mastx.${i}.prof  -memprofilerate=1 *.go;
        go tool pprof -alloc_objects -text  mastx.${i}.prof ;
      done
      
      showed a 15% reduction in allocations performed by the compiler.
      
      Update #3753
      Update #4720
      Fixes #10466
      
      Change-Id: I0fd97d5f5ac527b45f49e2218d158a6e89951432
      Reviewed-on: https://go-review.googlesource.com/8202
      Run-TryBot: David Chase <drchase@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      7fbb1b36
    • David Crawshaw's avatar
      runtime/cgo, cmd/dist: turn off exc_bad_access handler by default · 4044aded
      David Crawshaw authored
      App Store policy requires programs do not reference the exc_server
      symbol. (Some public forum threads show that Unity ran into this
      several years ago and it is a hard policy rule.) While some research
      suggests that I could write my own version of exc_server, the
      expedient course is to disable the exception handler by default.
      
      Go programs only need it when running under lldb, which is primarily
      used by tests. So enable the exception handler in cmd/dist when we
      are running the tests.
      
      Fixes #10646
      
      Change-Id: I853905254894b5367edb8abd381d45585a78ee8b
      Reviewed-on: https://go-review.googlesource.com/9549Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      4044aded
    • Shenghou Ma's avatar
      runtime: adjust traceTickDiv for non-x86 architectures · 5f69e739
      Shenghou Ma authored
      Fixes #10554.
      Fixes #10623.
      
      Change-Id: I90fbaa34e3d55c8758178f8d2e7fa41ff1194a1b
      Signed-off-by: default avatarShenghou Ma <minux@golang.org>
      Reviewed-on: https://go-review.googlesource.com/9247Reviewed-by: default avatarDmitry Vyukov <dvyukov@google.com>
      Reviewed-by: default avatarDave Cheney <dave@cheney.net>
      5f69e739
    • Dave Cheney's avatar
      cmd/cover: fix build · ffd33449
      Dave Cheney authored
      Fix the various builds which don't have a real filesystem or don't support forking.
      
      Change-Id: I3075c662fe6191ecbe70ba359b73d9a88bb06f35
      Reviewed-on: https://go-review.googlesource.com/9528Reviewed-by: default avatarRob Pike <r@golang.org>
      Reviewed-by: default avatarDave Cheney <dave@cheney.net>
      ffd33449
    • Rob Pike's avatar
      cmd/cover: try once again to fix the build · bc1410a4
      Rob Pike authored
      Forgot to update the references to the old cover package. No excuse.
      
      Change-Id: If17b7521f0bf70bc0c8da9c5adf246d90f644637
      Reviewed-on: https://go-review.googlesource.com/9564Reviewed-by: default avatarRob Pike <r@golang.org>
      bc1410a4
    • Rob Pike's avatar
      cmd/cover: fix build · e0820ac8
      Rob Pike authored
      TBR=rsc
      
      Change-Id: I6ec69013027213c5e7adedd2edb89dea6af876d9
      Reviewed-on: https://go-review.googlesource.com/9563Reviewed-by: default avatarRob Pike <r@golang.org>
      e0820ac8
    • Dave Cheney's avatar
      cmd/8g: don't call gc.Fatal during initalisation · 443a32e7
      Dave Cheney authored
      Fixes #10592
      
      Calling gc.Fatal before gc.Main has been called ends up flushing gc.bstdout before
      it is properly set up. Ideally obj.Bflush would handle this case, but that type
      and its callers are rather convoluted, so take the simpler route and avoid calling
      gc.Fatal altogether.
      
      Change-Id: I338b469e86edba558b6bedff35bb904bfc3d6990
      Reviewed-on: https://go-review.googlesource.com/9525Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      Reviewed-by: default avatarDave Cheney <dave@cheney.net>
      Run-TryBot: Dave Cheney <dave@cheney.net>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      443a32e7
    • Rob Pike's avatar
      text/template: allow newlines in raw quotes · 04220014
      Rob Pike authored
      This was disallowed for error-checking reasons but people ask for
      it, it's easy, and it's clear what it all means.
      
      Fixes #7323.
      
      Change-Id: I26542f5ac6519e45b335ad789713a4d9e356279b
      Reviewed-on: https://go-review.googlesource.com/9537Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      04220014
    • Rob Pike's avatar
      doc/go1.5.txt: cover has moved · cf3ac26a
      Rob Pike authored
      Change-Id: Ie4b59d72e2b704559e075494e79fdc7b0bca6556
      Reviewed-on: https://go-review.googlesource.com/9562Reviewed-by: default avatarRob Pike <r@golang.org>
      cf3ac26a
    • Rob Pike's avatar
      cmd/cover: copy to standard repository from golang.org/x/tools/cmd/cover · 5eddc5ba
      Rob Pike authored
      This required dealing with the ill-advised split of the profile code
      into a separate package. I just copied it over unchanged. The package
      does not deserve to be in the standard repository. We can cope
      with the duplication.
      
      Also update the go command to know about the new location.
      
      Fixes #10528.
      
      Change-Id: I05170ef3663326d57b9c18888d01163acd9256b6
      Reviewed-on: https://go-review.googlesource.com/9560Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      5eddc5ba
  3. 30 Apr, 2015 14 commits
    • Matthew Dempsky's avatar
      doc/progs: remove flaky timing-sensitive test · 198dceda
      Matthew Dempsky authored
      Package time already has enough inherently flaky tests covering its
      behavior.  No need for more of them.
      
      Fixes #10632.
      
      Change-Id: I1229e9fcc2e28ba2c9b0b79f73638e35dbbe8bbf
      Reviewed-on: https://go-review.googlesource.com/9517Reviewed-by: default avatarJosh Bleecher Snyder <josharian@gmail.com>
      198dceda
    • Ian Lance Taylor's avatar
      cmd/go: support -buildmode=c-shared for gccgo · 6c0f9c9e
      Ian Lance Taylor authored
      Change-Id: I4cdfd5a59e0468e9e5400aa06334b21cc80913cd
      Reviewed-on: https://go-review.googlesource.com/9550Reviewed-by: default avatarDavid Crawshaw <crawshaw@golang.org>
      6c0f9c9e
    • Brad Fitzpatrick's avatar
      net/http: document ServeFile and FileServer index.html redirect behavior · 125ed11c
      Brad Fitzpatrick authored
      Fixes #9876
      
      Change-Id: I97a354fde827dfccc9e373fadea2e37d094439b0
      Reviewed-on: https://go-review.googlesource.com/9538Reviewed-by: default avatarRob Pike <r@golang.org>
      125ed11c
    • Alex A Skinner's avatar
      net: make go DNS use localhost if resolv.conf is missing or empty · f3901357
      Alex A Skinner authored
      Per resolv.conf man page, "If this file does not exist, only the name
      server on the local machine will be queried."
      
      This behavior also occurs if file is present but unreadable,
      or if no nameservers are listed.
      
      Fixes #10566
      
      Change-Id: Id5716da0eae534d5ebfafea111bbc657f302e307
      Reviewed-on: https://go-review.googlesource.com/9380
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      f3901357
    • Michael Hudson-Doyle's avatar
      cmd/internal/ld: put the list of packages built into a shared library into an ELF note · 7556948e
      Michael Hudson-Doyle authored
      Change-Id: I611f7dec2109dc7e2f090ced0a1dca3d4b577134
      Reviewed-on: https://go-review.googlesource.com/9520Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      7556948e
    • Dave Cheney's avatar
      misc/cgo/testcshared, misc/cgo/testshared: fix clang warnings and errors · ccaaf1f1
      Dave Cheney authored
      Fix several warnings generated on the linux-amd64-clang builder
      and make it clear to clang that -znow is a linker only flag.
      
      Tested with
      
          env CC=clang-3.5 ./all.bash
          env CC=gcc-4.8 ./all.bash
      
      Change-Id: I5ca7366ba8bf6221a36d25a2157dda4b4f3e16fa
      Reviewed-on: https://go-review.googlesource.com/9523Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      ccaaf1f1
    • Ian Lance Taylor's avatar
      cmd/go, cmd/cgo: support -buildmode=c-archive for gccgo · 42bb59a3
      Ian Lance Taylor authored
      This extends the cgo changes in http://golang.org/cl/8094 to gccgo.
      It also adds support for setting runtime_iscgo correctly for gccgo;
      the gc runtime bases the variable on the runtime/cgo package, but
      gccgo has no equivalent to that package.
      
      The go tool supports -buildmode=c-archive for gccgo by linking all the
      Go objects together using -r.  For convenience this object is then put
      into an archive file.
      
      The go tool now passes -fsplit-stack when building C code for gccgo on
      386 and amd64.  This is required for using -r and will also cut down
      on unnecessary stack splits.
      
      The go tool no longer applies standard package cgo LDFLAGS when using
      gccgo.  This is mainly to avoid getting confused by the LDFLAGS in the
      runtime/cgo package that gccgo does not use.
      
      Change-Id: I1d0865b2a362818a033ca9e9e901d0ce250784e7
      Reviewed-on: https://go-review.googlesource.com/9511Reviewed-by: default avatarDavid Crawshaw <crawshaw@golang.org>
      42bb59a3
    • Didier Spezia's avatar
      html/template: fix quadratic performance with special tags · f4e3e5ea
      Didier Spezia authored
      The current implementation of the tSpecialTagEnd function
      is inefficient since it generates plenty of memory allocations
      and converts the whole buffer to lowercase at each call.
      
      If the number of special tags increases linearly with the
      template size, the complexity becomes quadratic.
      
      This CL provides an alternative implementation.
      While the algorithm is probably still not optimal, it avoids
      the quadratic behavior and the memory allocations.
      
      benchmark                          old ns/op     new ns/op     delta
      BenchmarkTemplateSpecialTags-4     19326431      532190        -97.25%
      
      benchmark                          old allocs    new allocs    delta
      BenchmarkTemplateSpecialTags-4     2650          190           -92.83%
      
      benchmark                          old bytes     new bytes     delta
      BenchmarkTemplateSpecialTags-4     4106460       46568         -98.87%
      
      While we are there, make sure we respect the HTML tokenization algorithm.
      An end tag needs to be followed by a space, tab, CR, FF, /, or > as described
      in https://html.spec.whatwg.org/multipage/syntax.html#tokenization
      Explicitly add this check.
      
      Fixes #10605
      
      Change-Id: Ia33ddee164ab608a69ac4183e16ec506bbeaa54c
      Reviewed-on: https://go-review.googlesource.com/9502Reviewed-by: default avatarRob Pike <r@golang.org>
      f4e3e5ea
    • Russ Cox's avatar
      runtime: schedule GC work more aggressively · 79a990b8
      Russ Cox authored
      Schedule the work as early as possible, while still respecting the
      utilization percentage on average. The old code tried never to
      go above the utilization percentage. The new code is willing
      to go above the utilization percentage by one time slice
      (but of course after doing that it must wait until the percentage
      drops back down to the target before it gets another time slice).
      
      The effect is that for concurrent GCs that can run in a small number
      of time slices, the time during which write barriers are enabled is
      reduced by one mutator + GC time slice round (possibly 30 ms per GC).
      
      This only affects the fractional GC processor (the remainder of GOMAXPROCS/4),
      so it matters most in GOMAXPROCS=1, a bit in GOMAXPROCS=2, and not at
      all in GOMAXPROCS=4.
      
      GOMAXPROCS=1
      name                                      old mean                new mean        delta
      BenchmarkBinaryTree17                12.4s × (0.98,1.03)     13.5s × (0.97,1.04)  +8.84% (p=0.000)
      BenchmarkFannkuch11                  4.38s × (1.00,1.01)     4.38s × (1.00,1.01)  ~ (p=0.343)
      BenchmarkFmtFprintfEmpty            88.9ns × (0.97,1.10)    90.1ns × (0.93,1.14)  ~ (p=0.224)
      BenchmarkFmtFprintfString            356ns × (0.94,1.05)     321ns × (0.94,1.12)  -9.77% (p=0.000)
      BenchmarkFmtFprintfInt               344ns × (0.98,1.03)     325ns × (0.96,1.03)  -5.46% (p=0.000)
      BenchmarkFmtFprintfIntInt            622ns × (0.97,1.03)     571ns × (0.95,1.05)  -8.09% (p=0.000)
      BenchmarkFmtFprintfPrefixedInt       462ns × (0.96,1.04)     431ns × (0.95,1.05)  -6.81% (p=0.000)
      BenchmarkFmtFprintfFloat             653ns × (0.98,1.03)     621ns × (0.99,1.03)  -4.90% (p=0.000)
      BenchmarkFmtManyArgs                2.32µs × (0.97,1.03)    2.19µs × (0.98,1.02)  -5.43% (p=0.000)
      BenchmarkGobDecode                  27.0ms × (0.96,1.04)    20.0ms × (0.97,1.04)  -26.06% (p=0.000)
      BenchmarkGobEncode                  26.6ms × (0.99,1.01)    17.8ms × (0.95,1.05)  -33.19% (p=0.000)
      BenchmarkGzip                        659ms × (0.98,1.03)     650ms × (0.99,1.01)  -1.34% (p=0.000)
      BenchmarkGunzip                      145ms × (0.98,1.04)     143ms × (1.00,1.01)  -1.47% (p=0.000)
      BenchmarkHTTPClientServer            111µs × (0.97,1.04)     110µs × (0.96,1.03)  -1.30% (p=0.000)
      BenchmarkJSONEncode                 52.0ms × (0.97,1.03)    40.8ms × (0.97,1.03)  -21.47% (p=0.000)
      BenchmarkJSONDecode                  127ms × (0.98,1.04)     120ms × (0.98,1.02)  -5.55% (p=0.000)
      BenchmarkMandelbrot200              6.04ms × (0.99,1.04)    6.02ms × (1.00,1.01)  ~ (p=0.176)
      BenchmarkGoParse                    8.62ms × (0.96,1.08)    8.55ms × (0.93,1.09)  ~ (p=0.302)
      BenchmarkRegexpMatchEasy0_32         164ns × (0.98,1.05)     165ns × (0.98,1.07)  ~ (p=0.293)
      BenchmarkRegexpMatchEasy0_1K         546ns × (0.98,1.06)     547ns × (0.97,1.07)  ~ (p=0.741)
      BenchmarkRegexpMatchEasy1_32         142ns × (0.97,1.09)     141ns × (0.97,1.05)  ~ (p=0.231)
      BenchmarkRegexpMatchEasy1_1K         904ns × (0.97,1.07)     900ns × (0.98,1.04)  ~ (p=0.294)
      BenchmarkRegexpMatchMedium_32        256ns × (0.98,1.06)     256ns × (0.97,1.04)  ~ (p=0.530)
      BenchmarkRegexpMatchMedium_1K       74.2µs × (0.98,1.05)    73.8µs × (0.98,1.04)  ~ (p=0.334)
      BenchmarkRegexpMatchHard_32         3.94µs × (0.98,1.07)    3.92µs × (0.98,1.05)  ~ (p=0.356)
      BenchmarkRegexpMatchHard_1K          119µs × (0.98,1.07)     119µs × (0.98,1.06)  ~ (p=0.467)
      BenchmarkRevcomp                     978ms × (0.96,1.09)     984ms × (0.95,1.07)  ~ (p=0.448)
      BenchmarkTemplate                    151ms × (0.96,1.03)     142ms × (0.95,1.04)  -5.55% (p=0.000)
      BenchmarkTimeParse                   628ns × (0.99,1.01)     628ns × (0.99,1.01)  ~ (p=0.855)
      BenchmarkTimeFormat                  729ns × (0.98,1.06)     734ns × (0.97,1.05)  ~ (p=0.149)
      
      GOMAXPROCS=2
      name                                      old mean                new mean        delta
      BenchmarkBinaryTree17-2              9.80s × (0.97,1.03)     9.85s × (0.99,1.02)  ~ (p=0.444)
      BenchmarkFannkuch11-2                4.35s × (0.99,1.01)     4.40s × (0.98,1.05)  ~ (p=0.099)
      BenchmarkFmtFprintfEmpty-2          86.7ns × (0.97,1.05)    85.9ns × (0.98,1.04)  ~ (p=0.409)
      BenchmarkFmtFprintfString-2          297ns × (0.98,1.01)     297ns × (0.99,1.01)  ~ (p=0.743)
      BenchmarkFmtFprintfInt-2             309ns × (0.98,1.02)     310ns × (0.99,1.01)  ~ (p=0.464)
      BenchmarkFmtFprintfIntInt-2          525ns × (0.97,1.05)     518ns × (0.99,1.01)  ~ (p=0.151)
      BenchmarkFmtFprintfPrefixedInt-2     408ns × (0.98,1.02)     408ns × (0.98,1.03)  ~ (p=0.797)
      BenchmarkFmtFprintfFloat-2           603ns × (0.99,1.01)     604ns × (0.98,1.02)  ~ (p=0.588)
      BenchmarkFmtManyArgs-2              2.07µs × (0.98,1.02)    2.05µs × (0.99,1.01)  ~ (p=0.091)
      BenchmarkGobDecode-2                19.1ms × (0.97,1.01)    19.3ms × (0.97,1.04)  ~ (p=0.195)
      BenchmarkGobEncode-2                16.2ms × (0.97,1.03)    16.4ms × (0.99,1.01)  ~ (p=0.069)
      BenchmarkGzip-2                      652ms × (0.99,1.01)     651ms × (0.99,1.01)  ~ (p=0.705)
      BenchmarkGunzip-2                    143ms × (1.00,1.01)     143ms × (1.00,1.00)  ~ (p=0.665)
      BenchmarkHTTPClientServer-2          149µs × (0.92,1.11)     149µs × (0.91,1.08)  ~ (p=0.862)
      BenchmarkJSONEncode-2               34.6ms × (0.98,1.02)    37.2ms × (0.99,1.01)  +7.56% (p=0.000)
      BenchmarkJSONDecode-2                117ms × (0.99,1.01)     117ms × (0.99,1.01)  ~ (p=0.858)
      BenchmarkMandelbrot200-2            6.10ms × (0.99,1.03)    6.03ms × (1.00,1.00)  ~ (p=0.083)
      BenchmarkGoParse-2                  8.25ms × (0.98,1.01)    8.21ms × (0.99,1.02)  ~ (p=0.307)
      BenchmarkRegexpMatchEasy0_32-2       162ns × (0.99,1.02)     162ns × (0.99,1.01)  ~ (p=0.857)
      BenchmarkRegexpMatchEasy0_1K-2       541ns × (0.99,1.01)     540ns × (1.00,1.00)  ~ (p=0.530)
      BenchmarkRegexpMatchEasy1_32-2       138ns × (1.00,1.00)     141ns × (0.98,1.04)  +1.88% (p=0.038)
      BenchmarkRegexpMatchEasy1_1K-2       887ns × (0.99,1.01)     894ns × (0.99,1.01)  ~ (p=0.087)
      BenchmarkRegexpMatchMedium_32-2      252ns × (0.99,1.01)     252ns × (0.99,1.01)  ~ (p=0.954)
      BenchmarkRegexpMatchMedium_1K-2     73.4µs × (0.99,1.02)    72.8µs × (1.00,1.01)  -0.87% (p=0.029)
      BenchmarkRegexpMatchHard_32-2       3.95µs × (0.97,1.05)    3.87µs × (1.00,1.01)  -2.11% (p=0.035)
      BenchmarkRegexpMatchHard_1K-2        117µs × (0.99,1.01)     117µs × (0.99,1.01)  ~ (p=0.669)
      BenchmarkRevcomp-2                   980ms × (0.95,1.03)     993ms × (0.94,1.09)  ~ (p=0.527)
      BenchmarkTemplate-2                  136ms × (0.98,1.01)     135ms × (0.99,1.01)  ~ (p=0.200)
      BenchmarkTimeParse-2                 630ns × (1.00,1.01)     630ns × (1.00,1.00)  ~ (p=0.634)
      BenchmarkTimeFormat-2                705ns × (0.99,1.01)     710ns × (0.98,1.02)  ~ (p=0.174)
      
      GOMAXPROCS=4
      BenchmarkBinaryTree17-4              9.87s × (0.96,1.04)     9.75s × (0.96,1.03)  ~ (p=0.178)
      BenchmarkFannkuch11-4                4.35s × (1.00,1.01)     4.40s × (0.99,1.04)  ~ (p=0.071)
      BenchmarkFmtFprintfEmpty-4          85.8ns × (0.98,1.06)    85.6ns × (0.98,1.04)  ~ (p=0.858)
      BenchmarkFmtFprintfString-4          306ns × (0.99,1.03)     304ns × (0.97,1.02)  ~ (p=0.470)
      BenchmarkFmtFprintfInt-4             317ns × (0.98,1.01)     315ns × (0.98,1.02)  -0.92% (p=0.044)
      BenchmarkFmtFprintfIntInt-4          527ns × (0.99,1.01)     525ns × (0.98,1.01)  ~ (p=0.164)
      BenchmarkFmtFprintfPrefixedInt-4     421ns × (0.98,1.03)     417ns × (0.99,1.02)  ~ (p=0.092)
      BenchmarkFmtFprintfFloat-4           623ns × (0.98,1.02)     618ns × (0.98,1.03)  ~ (p=0.172)
      BenchmarkFmtManyArgs-4              2.09µs × (0.98,1.02)    2.09µs × (0.98,1.02)  ~ (p=0.679)
      BenchmarkGobDecode-4                18.6ms × (0.99,1.01)    18.6ms × (0.98,1.03)  ~ (p=0.595)
      BenchmarkGobEncode-4                15.0ms × (0.98,1.02)    15.1ms × (0.99,1.01)  ~ (p=0.301)
      BenchmarkGzip-4                      659ms × (0.98,1.04)     660ms × (0.97,1.02)  ~ (p=0.724)
      BenchmarkGunzip-4                    145ms × (0.98,1.04)     144ms × (0.99,1.04)  ~ (p=0.671)
      BenchmarkHTTPClientServer-4          139µs × (0.97,1.02)     138µs × (0.99,1.02)  ~ (p=0.392)
      BenchmarkJSONEncode-4               35.0ms × (0.99,1.02)    35.1ms × (0.98,1.02)  ~ (p=0.777)
      BenchmarkJSONDecode-4                119ms × (0.98,1.01)     118ms × (0.98,1.02)  ~ (p=0.710)
      BenchmarkMandelbrot200-4            6.02ms × (1.00,1.00)    6.02ms × (1.00,1.00)  ~ (p=0.289)
      BenchmarkGoParse-4                  7.96ms × (0.99,1.01)    7.96ms × (0.99,1.01)  ~ (p=0.884)
      BenchmarkRegexpMatchEasy0_32-4       164ns × (0.98,1.04)     166ns × (0.97,1.04)  ~ (p=0.221)
      BenchmarkRegexpMatchEasy0_1K-4       540ns × (0.99,1.01)     552ns × (0.97,1.04)  +2.10% (p=0.018)
      BenchmarkRegexpMatchEasy1_32-4       140ns × (0.99,1.04)     142ns × (0.97,1.04)  ~ (p=0.226)
      BenchmarkRegexpMatchEasy1_1K-4       896ns × (0.99,1.03)     907ns × (0.97,1.04)  ~ (p=0.155)
      BenchmarkRegexpMatchMedium_32-4      255ns × (0.99,1.04)     255ns × (0.98,1.04)  ~ (p=0.904)
      BenchmarkRegexpMatchMedium_1K-4     73.4µs × (0.99,1.04)    73.8µs × (0.98,1.04)  ~ (p=0.560)
      BenchmarkRegexpMatchHard_32-4       3.93µs × (0.98,1.04)    3.95µs × (0.98,1.04)  ~ (p=0.571)
      BenchmarkRegexpMatchHard_1K-4        117µs × (1.00,1.01)     119µs × (0.98,1.04)  +1.48% (p=0.048)
      BenchmarkRevcomp-4                   990ms × (0.94,1.08)     989ms × (0.94,1.10)  ~ (p=0.957)
      BenchmarkTemplate-4                  137ms × (0.98,1.02)     137ms × (0.99,1.01)  ~ (p=0.996)
      BenchmarkTimeParse-4                 629ns × (1.00,1.00)     629ns × (0.99,1.01)  ~ (p=0.924)
      BenchmarkTimeFormat-4                710ns × (0.99,1.01)     716ns × (0.98,1.02)  +0.84% (p=0.033)
      
      Change-Id: I43a04e0f6ad5e3ba9847dddf12e13222561f9cf4
      Reviewed-on: https://go-review.googlesource.com/9543Reviewed-by: default avatarAustin Clements <austin@google.com>
      79a990b8
    • Josh Bleecher Snyder's avatar
      doc/go1.5.txt: add Jacobi and Int.ModSqrt to math/big · a593a36b
      Josh Bleecher Snyder authored
      Change-Id: I187e97592cd0403d84ca25c4acb1a4b25495041b
      Reviewed-on: https://go-review.googlesource.com/9534Reviewed-by: default avatarJosh Bleecher Snyder <josharian@gmail.com>
      a593a36b
    • Austin Clements's avatar
      runtime: fix gcDumpObject on non-heap pointers · 3ca20218
      Austin Clements authored
      gcDumpObject is used to print the source and destination objects when
      checkmark find a missing mark. However, gcDumpObject currently assumes
      the given pointer will point to a heap object. This is not true of the
      source object during root marking and may not even be true of the
      destination object in the limited situations where the heap points
      back in to the stack.
      
      If the pointer isn't a heap object, gcDumpObject will attempt an
      out-of-bounds access to h_spans. This will cause a panicslice, which
      will attempt to construct a useful panic message. This will cause a
      string allocation, which will lead mallocgc to panic because the GC is
      in mark termination (checkmark only happens during mark termination).
      
      Fix this by checking that the pointer points into the heap arena
      before attempting to use it as an arena pointer.
      
      Change-Id: I09da600c380d4773f1f8f38e45b82cb229ea6382
      Reviewed-on: https://go-review.googlesource.com/9498Reviewed-by: default avatarRick Hudson <rlh@golang.org>
      3ca20218
    • Dmitry Vyukov's avatar
      strings: use LastIndexByte in LastIndex · cfb8b18e
      Dmitry Vyukov authored
      Change-Id: I1add1b92f5c2688a99133d90bf9789d770fd9f05
      Reviewed-on: https://go-review.googlesource.com/9503Reviewed-by: default avatarMatthew Dempsky <mdempsky@google.com>
      cfb8b18e
    • Dmitry Vyukov's avatar
      doc/go1.5.txt: bytes, strings: add LastIndexByte · 09edc5c6
      Dmitry Vyukov authored
      Change-Id: I05cfacd746e87011de8b659ab3b2fbe23146a7f3
      Reviewed-on: https://go-review.googlesource.com/9504Reviewed-by: default avatarDmitry Vyukov <dvyukov@google.com>
      09edc5c6
    • Dmitry Vyukov's avatar
      bytes, strings: add LastIndexByte · 0fb5475b
      Dmitry Vyukov authored
      Currently the packages have the following index functions:
      
      func Index(s, sep []byte) int
      func IndexAny(s []byte, chars string) int
      func IndexByte(s []byte, c byte) int
      func IndexFunc(s []byte, f func(r rune) bool) int
      func IndexRune(s []byte, r rune) int
      
      func LastIndex(s, sep []byte) int
      func LastIndexAny(s []byte, chars string) int
      func LastIndexFunc(s []byte, f func(r rune) bool) int
      
      Searching for the last occurrence of a byte is quite common
      for string parsing algorithms (e.g. find the last paren on a line).
      Also addition of LastIndexByte makes the set more orthogonal.
      
      Change-Id: Ida168849acacf8e78dd70c1354bef9eac5effafe
      Reviewed-on: https://go-review.googlesource.com/9500Reviewed-by: default avatarRob Pike <r@golang.org>
      0fb5475b