- 03 Dec, 2016 2 commits
-
-
Brad Fitzpatrick authored
Updates #18173 Change-Id: I4c667c89ba3bf16433a4cef7cb01054f1798667d Reviewed-on: https://go-review.googlesource.com/33892 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Josh Bleecher Snyder authored
Change-Id: I9277e869e171d9e051ff9a70ac578b8127fa74f8 Reviewed-on: https://go-review.googlesource.com/33897 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
- 02 Dec, 2016 8 commits
-
-
Ian Lance Taylor authored
Change-Id: I5e33db9e63f70706882b85ab124a48509797b05a Reviewed-on: https://go-review.googlesource.com/33790 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Filippo Valsorda authored
Change-Id: If8200e54b3650f789c5312f10cce32201a199b80 Reviewed-on: https://go-review.googlesource.com/33775Reviewed-by:
-
Ian Lance Taylor authored
Internal linking on an ELF system creates two reloc sections, which must be adjacent. The default is to base section alignment on the section size, but doing that for ELF reloc sections can introduce a gap. Set the reloc section alignment explicitly to avoid that. Fixes #18044. Change-Id: I8ccc131e60937d30c5f715a34c7803258833fc2f Reviewed-on: https://go-review.googlesource.com/33872 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
And link it. Change-Id: Ic0105468435299fb1638f86522f4f3ce417ec1c2 Reviewed-on: https://go-review.googlesource.com/33871Reviewed-by:
-
Robert Griesemer authored
Change-Id: I8a3ce0fa513ff943009c5669531132cd23ecf155 Reviewed-on: https://go-review.googlesource.com/33870Reviewed-by:
-
Shenghou Ma authored
Fixes #18154. Change-Id: I1836b63a380b7fc2f9965e909859b1a89a3ae5d5 Reviewed-on: https://go-review.googlesource.com/33856 Run-TryBot: Minux Ma <minux@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Kevin Burke authored
Previously the docs suggested downloading 1.7.2 (no good) or 1.7.3 (has security flaw). Change-Id: Ifabe85908df8d6591c0957ef4bb1b800fc145793 Reviewed-on: https://go-review.googlesource.com/33808Reviewed-by:
-
Ian Lance Taylor authored
Reversion CL was 33770. Change-Id: I119f26796bb2b66d302e132dd118847ac3bd6633 Reviewed-on: https://go-review.googlesource.com/33807Reviewed-by:
-
- 01 Dec, 2016 30 commits
-
-
Brad Fitzpatrick authored
The introduction of NoBody and related body-peeking bug fixes also added a "cleanup" of sorts to make NewRequest set the returned Requests's ContentLength to -1 when it didn't know it. Using -1 to mean unknown is what the documentation says, but then people apparently(?) depended on it being zero so they could do this: req, _ := http.NewRequest("POST", url, someNonNilReaderWithUnkownSize) req.Body = nil res, err := http.DefaultClient.Do(req) ... and expect it to work. After https://golang.org/cl/31445 the contrived(?) code above stopped working, since Body was nil and ContentLength was -1, which has been disallowed since Go 1.0. So this restores the old behavior of NewRequest, not setting it to -1. That part of the fix isn't required as of https://golang.org/cl/31726 (which added NoBody) I still don't know whether this bug is hypothetical or actually affected people in practice. Let's assume it's real for now. Fixes #18117 Change-Id: I42400856ee92a1a4999b5b4668bef97d885fbb53 Reviewed-on: https://go-review.googlesource.com/33801 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: -
Brad Fitzpatrick authored
Per recommendation from imgtec.com folk. Change-Id: I9b6f30572f257acce59842ac55362f52fe36c5ab Reviewed-on: https://go-review.googlesource.com/33804Reviewed-by:
-
Ian Lance Taylor authored
Also change a couple of `go get` tests to use MustHaveExternalNetwork rather than checking testing.Short. Change-Id: I98ccc05b8b0354f1b7486e28dac5f8341c342a07 Reviewed-on: https://go-review.googlesource.com/33802 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Matthew Dempsky authored
This file is entirely about the implementation of LineHist, and I can never remember which generic filename in cmd/internal/obj has it. Rename to line.go to match the already existing line_test.go. Change-Id: Id01f3339dc550c9759569d5610d808b17bca44d0 Reviewed-on: https://go-review.googlesource.com/33803Reviewed-by:
-
Daniel Theophanes authored
Ensure documented behavior of returning ErrTxDone if the Tx has already been committed or rolled back. Fixes #18147 Change-Id: I07dc75bef4dbd4dd88dd252c96dc8ab99f28c00e Reviewed-on: https://go-review.googlesource.com/33793 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Robert Griesemer authored
This was a regression from 1.7. See the issue for details. Fixes #18149. Change-Id: Ic8f5a35d14edf9254b1275400316cff7aff32a27 Reviewed-on: https://go-review.googlesource.com/33799 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by:
Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Chris Broadfoot authored
Change-Id: I853da2666ed2b5f8b80bd9438f8c352f233b9c89 Reviewed-on: https://go-review.googlesource.com/33800Reviewed-by:
-
Brad Fitzpatrick authored
NoBody is new in Go 1.8. Found while investigating #18117 Change-Id: I6bda030f358e2270f090d108cb3a89c8a2665fcb Reviewed-on: https://go-review.googlesource.com/33714 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Chris Broadfoot authored
Change-Id: I0728afe6a1d1e0aee4701e51a5548fa9fd637b66 Reviewed-on: https://go-review.googlesource.com/33795Reviewed-by:
Russ Cox <rsc@golang.org> Reviewed-by:
-
Chris Broadfoot authored
Change-Id: I3dd1513e927733ce5c63928da772cb81760ba869 Reviewed-on: https://go-review.googlesource.com/31442Reviewed-by:
Andrew Gerrand <adg@golang.org> Reviewed-by:
-
Elias Naur authored
Change-Id: Iacced25363f54ee2cc1e00a71605dba7fb447162 Reviewed-on: https://go-review.googlesource.com/33772Reviewed-by:
-
Keith Randall authored
func f() { g() } We mistakenly don't add a frame pointer for f. This means f isn't seen when walking the frame pointer linked list. That matters for kernel-gathered profiles, and is an impediment for issues like #16638. To fix, allocate a stack frame even for otherwise frameless functions like f. It is a bit tricky because we need to avoid some runtime internals that really, really don't want one. No test at the moment, as only kernel CPU profiles would catch it. Tests will come with the implementation of #16638. Fixes #18103 Change-Id: I411206cc9de4c8fdd265bee2e4fa61d161ad1847 Reviewed-on: https://go-review.googlesource.com/33754 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:Austin Clements <austin@google.com>
-
Quentin Smith authored
Darwin separately stores bits indicating whether a root certificate should be trusted; this changes Go to read and use those when initializing SystemCertPool. Unfortunately, the trust API is very slow. To avoid a delay of up to 0.5s in initializing the system cert pool, we assume that the trust settings found in kSecTrustSettingsDomainSystem will always indicate trust. (That is, all root certs Apple distributes are trusted.) This is not guaranteed by the API but is true in practice. In the non-cgo codepath, we do not have that benefit, so we must check the trust status of every certificate. This causes about 0.5s of delay in initializing the SystemCertPool. On OS X 10.11 and older, the "security" command requires a certificate to be provided in a file and not on stdin, so the non-cgo codepath creates temporary files for each certificate, further slowing initialization. Updates #18141. Change-Id: If681c514047afe5e1a68de6c9d40ceabbce54755 Reviewed-on: https://go-review.googlesource.com/33721 Run-TryBot: Quentin Smith <quentin@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David Lazar authored
Now the net tests pass with -gcflags '-l=4'. Fixes #18125. Change-Id: I4e3a46eb0cb3a93b203e74f5bc99c5822331f535 Reviewed-on: https://go-review.googlesource.com/33722Reviewed-by:
Keith Randall <khr@golang.org>
-
Keith Randall authored
... so we don't have to export gosym.PCValue. Change-Id: Ie8f196d5e5ab63e3e69d1d7b4bfbbf32b7b5e4f5 Reviewed-on: https://go-review.googlesource.com/33791 Run-TryBot: Keith Randall <khr@golang.org> Reviewed-by:
-
Mohit Agarwal authored
Fixes #18128 Change-Id: I5530c9d774a1e398cd759a05bbf308e6e42f0007 Reviewed-on: https://go-review.googlesource.com/33810Reviewed-by:
-
Brad Fitzpatrick authored
Reverts https://golang.org/cl/23672 and tweaks the text to clarify HTTP/2 request cancelations also cancel the context (not just closing the TCP conn). Fixes #18143 Change-Id: I9f838e09b906d455c98f676e5bc5559f8f7ecb17 Reviewed-on: https://go-review.googlesource.com/33769Reviewed-by:
Chris Broadfoot <cbro@golang.org>
-
Daniel Theophanes authored
Require parameter names to not begin with a symbol. Change-Id: I5dfe9d4e181f0daf71dad2f395aca41c68678cbe Reviewed-on: https://go-review.googlesource.com/33493Reviewed-by:
-
Austin Clements authored
Commit 303b69fe packed bitvectors more tightly, but missed a comment describing their old layout. Update that comment. Change-Id: I095ccb01f245197054252545f37b40605a550dec Reviewed-on: https://go-review.googlesource.com/33718Reviewed-by:
-
Brad Fitzpatrick authored
And reflow paragraph while I'm at it. Change-Id: Ia13bb364783790fbd9f8b69ef268f8a4b71679cb Reviewed-on: https://go-review.googlesource.com/33767Reviewed-by:
-
Brad Fitzpatrick authored
Updates #17929 Change-Id: I03b8847384c6cd8c43fe8bf2d75cd26db7063b8b Reviewed-on: https://go-review.googlesource.com/33762Reviewed-by:
Joe Tsai <thebrokentoaster@gmail.com>
-
Daniel Theophanes authored
Fixes #18135 Change-Id: I54ef9d6fc804d0fb77b729a04367a138e40f9ddf Reviewed-on: https://go-review.googlesource.com/33766Reviewed-by:
-
Elias Naur authored
This reverts commit d24b57a6. Reason for revert: Further complications arised (issue 18100). We'll try again in Go 1.9. Change-Id: I5ca93d2643a4be877dd9c2d8df3359718440f02f Reviewed-on: https://go-review.googlesource.com/33770 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Minux Ma <minux@golang.org> Run-TryBot: Minux Ma <minux@golang.org>
-
Shenghou Ma authored
Updates #17082. Change-Id: I0bf330d1a1ebb7e31e42d03287160b474522c332 Reviewed-on: https://go-review.googlesource.com/33455Reviewed-by:
-
Shenghou Ma authored
so that our release note can reference a simple command to check if the processor implements ARMv6K or not. Updates #17082. Change-Id: I9ca52051e5517394a7cd6b778fb822c3ee435f84 Reviewed-on: https://go-review.googlesource.com/33686 Run-TryBot: Minux Ma <minux@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Change-Id: I34ba4eaf1d232b639998ad3bbb0d075dd097722b Reviewed-on: https://go-review.googlesource.com/33763 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Dominik Honnef <dominik@honnef.co>
-
Chris Broadfoot authored
Change-Id: I37f2893ce14009efe095aac3bc811d650c66bf2a Reviewed-on: https://go-review.googlesource.com/33761Reviewed-by:
-
Chris Broadfoot authored
Updates #18099 Change-Id: I16b4b2dd881d63cbb406d14a4fd960f0a777a452 Reviewed-on: https://go-review.googlesource.com/33760Reviewed-by:
-
Ian Lance Taylor authored
Fixes #18126. Change-Id: I7ae090945ef203673b06eb94817cc5c894b5eadc Reviewed-on: https://go-review.googlesource.com/33752 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
TBR=See https://golang.org/cl/33244 Updates #17929 Change-Id: Ic6d449e7822daa70f3fe17e942e9d29233547019 Reviewed-on: https://go-review.googlesource.com/33759Reviewed-by:
-
