1. 29 May, 2012 12 commits
    • Brad Fitzpatrick's avatar
      database/sql: use driver.ColumnConverter everywhere consistently · 93fe8c0c
      Brad Fitzpatrick authored
      It was only being used for (*Stmt).Exec, not Query, and not for
      the same two methods on *DB.
      
      This unifies (*Stmt).Exec's old inline code into the old
      subsetArgs function, renaming it in the process (changing the
      old word "subset" to "driver", mostly converted earlier)
      
      Fixes #3640
      
      R=golang-dev, rsc
      CC=golang-dev
      https://golang.org/cl/6258045
      93fe8c0c
    • Russ Cox's avatar
      runtime: replace runtime·rnd function with ROUND macro · 6dbaa206
      Russ Cox authored
      It's sad to introduce a new macro, but rnd shows up consistently
      in profiles, and the function call overwhelms the two arithmetic
      instructions it performs.
      
      R=r
      CC=golang-dev
      https://golang.org/cl/6260051
      6dbaa206
    • Rob Pike's avatar
      test/bench/shootout/timing.log: update after recent compiler changes · 90d59c58
      Rob Pike authored
      Moving panic out of line speeds up fannkuch almost a factor of two.
      Changes to bitwhacking code affect mandelbrot badly.
      
      R=golang-dev, bradfitz, rsc, r
      CC=golang-dev
      https://golang.org/cl/6258056
      90d59c58
    • Russ Cox's avatar
      exp/types: disable test · 95ae5c18
      Russ Cox authored
      It's broken and seems to be exp/types's fault.
      
      Update #3682.
      
      R=golang-dev, r
      CC=golang-dev
      https://golang.org/cl/6243068
      95ae5c18
    • Mikio Hara's avatar
      net: fix comment on FileListener · 8c8ab055
      Mikio Hara authored
      R=rsc
      CC=golang-dev
      https://golang.org/cl/6242067
      8c8ab055
    • Russ Cox's avatar
      crypto: housekeeping · 992a11b8
      Russ Cox authored
      Rename _Block to block, don't bother making it compute count.
      Add benchmarks.
      
      R=agl, agl
      CC=golang-dev
      https://golang.org/cl/6243053
      992a11b8
    • Mikio Hara's avatar
      undo CL 6248054 / 0f418a63cdf9 · 14ad4114
      Mikio Hara authored
      breaks public API document style
      
      ««« original CL description
      net: fix comment on FileListener
      
      R=golang-dev, bradfitz
      CC=golang-dev
      https://golang.org/cl/6248054
      »»»
      
      R=golang-dev, rsc
      CC=golang-dev
      https://golang.org/cl/6242066
      14ad4114
    • Peter Kleiweg's avatar
      Emacs go-mode: fix Emacs freeze-up when copy/pasting from string or comment. · 28e9e158
      Peter Kleiweg authored
      Fixes #3509.
      Fixes #2767.
      
      R=golang-dev, sameer
      CC=golang-dev
      https://golang.org/cl/6139066
      28e9e158
    • Akshat Kumar's avatar
      cmd/6l: Fixes for 64-bit Plan 9 · 154c84cd
      Akshat Kumar authored
      Plan 9 versions for amd64 have 2 megabyte pages.
      This also fixes the logic for 32-bit vs 64-bit Plan 9,
      making 64-bit the default, and adds logic to generate
      a symbols table.
      
      R=golang-dev, rsc, rminnich, ality, 0intro
      CC=golang-dev, john
      https://golang.org/cl/6218046
      154c84cd
    • Russ Cox's avatar
      cmd/6g, cmd/8g: move panicindex calls out of line · fefae6ee
      Russ Cox authored
      The old code generated for a bounds check was
                      CMP
                      JLT ok
                      CALL panicindex
              ok:
                      ...
      
      The new code is (once the linker finishes with it):
                      CMP
                      JGE panic
                      ...
              panic:
                      CALL panicindex
      
      which moves the calls out of line, putting more useful
      code in each cache line.  This matters especially in tight
      loops, such as in Fannkuch.  The benefit is more modest
      elsewhere, but real.
      
      From test/bench/go1, amd64:
      
      benchmark                old ns/op    new ns/op    delta
      BenchmarkBinaryTree17   6096092000   6088808000   -0.12%
      BenchmarkFannkuch11     6151404000   4020463000  -34.64%
      BenchmarkGobDecode        28990050     28894630   -0.33%
      BenchmarkGobEncode        12406310     12136730   -2.17%
      BenchmarkGzip               179923       179903   -0.01%
      BenchmarkGunzip              11219        11130   -0.79%
      BenchmarkJSONEncode       86429350     86515900   +0.10%
      BenchmarkJSONDecode      334593800    315728400   -5.64%
      BenchmarkRevcomp25M     1219763000   1180767000   -3.20%
      BenchmarkTemplate        492947600    483646800   -1.89%
      
      And 386:
      
      benchmark                old ns/op    new ns/op    delta
      BenchmarkBinaryTree17   6354902000   6243000000   -1.76%
      BenchmarkFannkuch11     8043769000   7326965000   -8.91%
      BenchmarkGobDecode        19010800     18941230   -0.37%
      BenchmarkGobEncode        14077500     13792460   -2.02%
      BenchmarkGzip               194087       193619   -0.24%
      BenchmarkGunzip              12495        12457   -0.30%
      BenchmarkJSONEncode      125636400    125451400   -0.15%
      BenchmarkJSONDecode      696648600    685032800   -1.67%
      BenchmarkRevcomp25M     2058088000   2052545000   -0.27%
      BenchmarkTemplate        602140000    589876800   -2.04%
      
      To implement this, two new instruction forms:
      
              JLT target      // same as always
              JLT $0, target  // branch expected not taken
              JLT $1, target  // branch expected taken
      
      The linker could also emit the prediction prefixes, but it
      does not: expected taken branches are reversed so that the
      expected case is not taken (as in example above), and
      the default expectaton for such a jump is not taken
      already.
      
      R=golang-dev, gri, r, dave
      CC=golang-dev
      https://golang.org/cl/6248049
      fefae6ee
    • Sameer Ajmani's avatar
      A+C: Peter Kleiweg (individual CLA) · b9918dbf
      Sameer Ajmani authored
      R=golang-dev, bradfitz
      CC=golang-dev
      https://golang.org/cl/6260049
      b9918dbf
    • Andrew Balholm's avatar
      exp/html: implement Noah's Ark clause · 9c14184e
      Andrew Balholm authored
      Implement the (3-per-family) Noah's Ark clause (i.e. don't put
      more than three identical elements on the list of active formatting
      elements.
      
      Also, when running tests, sort attributes by name before dumping
      them.
      
      Pass 4 additional tests with Noah's Ark clause (including one
      that needs attributes to be sorted).
      
      Pass 5 additional, unrelated tests because of sorting attributes.
      
      R=nigeltao, rsc
      CC=golang-dev
      https://golang.org/cl/6247056
      9c14184e
  2. 28 May, 2012 7 commits
  3. 27 May, 2012 1 commit
  4. 26 May, 2012 1 commit
  5. 25 May, 2012 6 commits
  6. 24 May, 2012 13 commits