1. 22 May, 2019 10 commits
  2. 21 May, 2019 10 commits
  3. 20 May, 2019 11 commits
  4. 17 May, 2019 9 commits
    • Keith Randall's avatar
      testing: callerName only needs one PC in the traceback · 1ab063ce
      Keith Randall authored
      callerName requested 2 PCs from Callers, and that causes
      both to be looked up in the file/line mapping.
      We really only need to do the work for one PC.
      (And in fact the caller doesn't need file/line at all, but
      the Callers API can't express that.)
      
      We used to request 2 PCs because in 1.11 and earlier we
      stored an inline skip count in the second entry.
      That's not necessary any more (as of 1.12).
      
      Fixes #32093
      
      Change-Id: I7b272626ef6496e848ee8af388cdaafd2556857b
      Reviewed-on: https://go-review.googlesource.com/c/go/+/177858
      Run-TryBot: Keith Randall <khr@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      Reviewed-by: default avatarCaleb Spare <cespare@gmail.com>
      1ab063ce
    • Josh Bleecher Snyder's avatar
      cmd/compile: optimize postorder · 5c3f3fbd
      Josh Bleecher Snyder authored
      name        old alloc/op      new alloc/op      delta
      Template         37.1MB ± 0%       36.8MB ± 0%  -0.57%  (p=0.008 n=5+5)
      Unicode          28.1MB ± 0%       28.1MB ± 0%  -0.07%  (p=0.008 n=5+5)
      GoTypes           125MB ± 0%        124MB ± 0%  -0.61%  (p=0.008 n=5+5)
      Compiler          571MB ± 0%        568MB ± 0%  -0.60%  (p=0.008 n=5+5)
      SSA              1.88GB ± 0%       1.86GB ± 0%  -0.82%  (p=0.008 n=5+5)
      Flate            22.9MB ± 0%       22.8MB ± 0%  -0.59%  (p=0.008 n=5+5)
      GoParser         27.5MB ± 0%       27.3MB ± 0%  -0.53%  (p=0.008 n=5+5)
      Reflect          79.8MB ± 0%       79.5MB ± 0%  -0.40%  (p=0.008 n=5+5)
      Tar              34.9MB ± 0%       34.7MB ± 0%  -0.44%  (p=0.008 n=5+5)
      XML              45.7MB ± 0%       45.4MB ± 0%  -0.58%  (p=0.008 n=5+5)
      [Geo mean]       80.3MB            79.9MB       -0.52%
      
      name        old allocs/op     new allocs/op     delta
      Template           380k ± 0%         378k ± 0%  -0.57%  (p=0.008 n=5+5)
      Unicode            340k ± 0%         340k ± 0%  -0.08%  (p=0.008 n=5+5)
      GoTypes           1.36M ± 0%        1.36M ± 0%  -0.44%  (p=0.008 n=5+5)
      Compiler          5.52M ± 0%        5.49M ± 0%  -0.45%  (p=0.008 n=5+5)
      SSA               17.6M ± 0%        17.5M ± 0%  -0.42%  (p=0.008 n=5+5)
      Flate              235k ± 0%         234k ± 0%  -0.65%  (p=0.008 n=5+5)
      GoParser           302k ± 0%         300k ± 0%  -0.70%  (p=0.008 n=5+5)
      Reflect            982k ± 0%         978k ± 0%  -0.40%  (p=0.008 n=5+5)
      Tar                353k ± 0%         351k ± 0%  -0.53%  (p=0.008 n=5+5)
      XML                437k ± 0%         435k ± 0%  -0.48%  (p=0.008 n=5+5)
      [Geo mean]         844k              840k       -0.47%
      
      Updates #27739
      
      Change-Id: I5d533013270cbbd7c0bad1b43da96c8499be76f5
      Reviewed-on: https://go-review.googlesource.com/c/go/+/177917
      Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      5c3f3fbd
    • Filippo Valsorda's avatar
      crypto/tls: fix TestVerifyHostnameResumed · e22e2b37
      Filippo Valsorda authored
      In TLS 1.3 session tickets are delivered after the handshake, and it
      looks like now the Google servers wait until the first flight of data to
      send them (or our timeout is too low). Cause some data to be sent so we
      can avoid the guessing game.
      
      Fixes #32090
      
      Change-Id: I54af4acb3a89cc70c9e14a5dfe18a44c29a841a7
      Reviewed-on: https://go-review.googlesource.com/c/go/+/177877Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      e22e2b37
    • Dmitri Shuralyov's avatar
      net/http/httputil: remove os.Stderr claim in ReverseProxy.ErrorLog docs · 3f7c5608
      Dmitri Shuralyov authored
      The motivation for doing so is to avoid making inaccurate claims.
      Logging may not go to os.Stderr if anyone overrides the log package's
      default output via https://godoc.org/log#SetOutput. Saying that
      the standard logger is used should be sufficient to explain the
      behavior, and users can infer that os.Stderr is used by default,
      unless it's changed.
      
      This change is the same as what was applied to http.Server.ErrorLog
      documentation in CL 53950.
      
      Change-Id: I32873fc548ceee573f8616b4d49b8a8b98881803
      Reviewed-on: https://go-review.googlesource.com/c/go/+/176817Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      3f7c5608
    • Jay Conrod's avatar
      cmd/go: don't attempt to downgrade to incompatible versions · 06642d8e
      Jay Conrod authored
      When we downgrade a module (using 'go get m@none' or similar), we
      exclude versions of other modules that depend on it. We'll try
      previous versions (in the "versions" list returned by the proxy or in
      codeRepo.Versions for vcs) until we find a version that doesn't
      require an excluded module version.
      
      If older versions of a module are broken for some reason,
      mvs.Downgrade currently panics. With this change, we ignore versions
      with errors during downgrade.
      
      A frequent cause of this is incompatible v2+ versions. These are
      common if a repository tagged v2.0.0 before migrating to modules, then
      tagged v2.0.1 with a go.mod file later. v2.0.0 is incorrectly
      considered part of the v2 module.
      
      Fixes #31942
      
      Change-Id: Icaa75c5c93f73f18a400c22f18a8cc603aa4011a
      Reviewed-on: https://go-review.googlesource.com/c/go/+/177337
      Run-TryBot: Jay Conrod <jayconrod@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBryan C. Mills <bcmills@google.com>
      06642d8e
    • Jean de Klerk's avatar
      errors: update As example to include else case · 703fb665
      Jean de Klerk authored
      The current example illustrates using As when the error is able to be
      interpreted as an os.PathError, but elides the "else" case. This CL adds the
      small extra else case to make it clear that it's not safe to assume As will
      return true.
      
      This CL also squash the err instantiation and the err nil check into one line
      for brevity.
      
      Change-Id: I3d3ab483ffb38fb2788d0498b3f03229a87dd7c3
      Reviewed-on: https://go-review.googlesource.com/c/go/+/177717Reviewed-by: default avatarJonathan Amsterdam <jba@google.com>
      Reviewed-by: default avatarDamien Neil <dneil@google.com>
      Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      703fb665
    • Filippo Valsorda's avatar
      crypto/tls: add support for Ed25519 certificates in TLS 1.2 and 1.3 · f3533858
      Filippo Valsorda authored
      Support for Ed25519 certificates was added in CL 175478, this wires them
      up into the TLS stack according to RFC 8422 (TLS 1.2) and RFC 8446 (TLS 1.3).
      
      RFC 8422 also specifies support for TLS 1.0 and 1.1, and I initially
      implemented that, but even OpenSSL doesn't take the complexity, so I
      just dropped it. It would have required keeping a buffer of the
      handshake transcript in order to do the direct Ed25519 signatures. We
      effectively need to support TLS 1.2 because it shares ClientHello
      signature algorithms with TLS 1.3.
      
      While at it, reordered the advertised signature algorithms in the rough
      order we would want to use them, also based on what curves have fast
      constant-time implementations.
      
      Client and client auth tests changed because of the change in advertised
      signature algorithms in ClientHello and CertificateRequest.
      
      Fixes #25355
      
      Change-Id: I9fdd839afde4fd6b13fcbc5cc7017fd8c35085ee
      Reviewed-on: https://go-review.googlesource.com/c/go/+/177698
      Run-TryBot: Filippo Valsorda <filippo@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarAdam Langley <agl@golang.org>
      f3533858
    • Joel Sing's avatar
      runtime: correct netbsd/amd64 assembly for timespec handling · ee551846
      Joel Sing authored
      A timespec on netbsd/amd64 is int64/int64, not int64/int32.
      This bug appears to have been introduced in 7777bac6.
      
      Spotted by Cherry Zhang while reviewing https://go-review.googlesource.com/c/go/+/177120.
      
      Change-Id: I163c55d926965defd981bdbfd2511de7d9d4c542
      Reviewed-on: https://go-review.googlesource.com/c/go/+/177637Reviewed-by: default avatarBenny Siegert <bsiegert@gmail.com>
      Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
      Run-TryBot: Benny Siegert <bsiegert@gmail.com>
      ee551846
    • Joel Sing's avatar
      runtime: fix netbsd/arm64 assembly · 37133b5d
      Joel Sing authored
      Fix various bugs in the netbsd/arm64 runtime assembly.
      
      Updates #30824.
      
      Change-Id: I5ca10926ab663a8ff4df9973530e645e2469c1aa
      Reviewed-on: https://go-review.googlesource.com/c/go/+/177120Reviewed-by: default avatarBenny Siegert <bsiegert@gmail.com>
      Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
      Run-TryBot: Benny Siegert <bsiegert@gmail.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      37133b5d