1. 10 Apr, 2016 9 commits
    • Josh Bleecher Snyder's avatar
      runtime: avoid unnecessary map iteration write barrier · 974c201f
      Josh Bleecher Snyder authored
      Update #14921
      
      Change-Id: I5c5816d0193757bf7465b1e09c27ca06897df4bf
      Reviewed-on: https://go-review.googlesource.com/21814
      Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarKeith Randall <khr@golang.org>
      974c201f
    • Brad Fitzpatrick's avatar
      html: fix typo in UnescapeString string docs · a44c4256
      Brad Fitzpatrick authored
      Fixes #15221
      
      Change-Id: I9e927a2f604213338b4572f1a32d0247c58bdc60
      Reviewed-on: https://go-review.googlesource.com/21798Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      a44c4256
    • Klaus Post's avatar
      compress/flate: improve short writer error test · a56f5a03
      Klaus Post authored
      This improves the short version of the writer test.
      
      First of all, it has a much quicker setup. Previously that
      could take up towards 0.5 second.
      
      Secondly, it will test all compression levels in short mode as well.
      
      Execution time is 1.7s/0.03s for normal/short mode.
      
      Change-Id: I275a21f712daff6f7125cc6a493415e86439cb19
      Reviewed-on: https://go-review.googlesource.com/21800Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      a56f5a03
    • Klaus Post's avatar
      compress/flate: eliminate most common bounds checks · f20b1809
      Klaus Post authored
      This uses the SSA compiler to eliminate various unneeded bounds
      checks in loops and various lookups.
      
      This fixes the low hanging fruit, without any major code changes.
      
      name                       old time/op    new time/op    delta
      EncodeDigitsHuffman1e4-8     49.9µs ± 1%    48.1µs ± 1%  -3.74%   (p=0.000 n=10+9)
      EncodeDigitsHuffman1e5-8      476µs ± 1%     458µs ± 1%  -3.58%  (p=0.000 n=10+10)
      EncodeDigitsHuffman1e6-8     4.80ms ± 2%    4.56ms ± 1%  -5.07%   (p=0.000 n=10+9)
      EncodeDigitsSpeed1e4-8        305µs ± 3%     290µs ± 2%  -5.03%   (p=0.000 n=10+9)
      EncodeDigitsSpeed1e5-8       3.67ms ± 2%    3.49ms ± 2%  -4.78%   (p=0.000 n=9+10)
      EncodeDigitsSpeed1e6-8       38.3ms ± 2%    35.8ms ± 1%  -6.58%   (p=0.000 n=9+10)
      EncodeDigitsDefault1e4-8      361µs ± 2%     346µs ± 3%  -4.12%   (p=0.000 n=10+9)
      EncodeDigitsDefault1e5-8     5.24ms ± 2%    4.96ms ± 3%  -5.38%  (p=0.000 n=10+10)
      EncodeDigitsDefault1e6-8     56.5ms ± 3%    52.2ms ± 2%  -7.68%  (p=0.000 n=10+10)
      EncodeDigitsCompress1e4-8     362µs ± 2%     343µs ± 1%  -5.20%   (p=0.000 n=10+9)
      EncodeDigitsCompress1e5-8    5.26ms ± 3%    4.98ms ± 2%  -5.48%  (p=0.000 n=10+10)
      EncodeDigitsCompress1e6-8    56.0ms ± 4%    52.1ms ± 1%  -7.01%  (p=0.000 n=10+10)
      EncodeTwainHuffman1e4-8      70.9µs ± 3%    64.7µs ± 1%  -8.68%   (p=0.000 n=10+9)
      EncodeTwainHuffman1e5-8       556µs ± 2%     524µs ± 2%  -5.84%  (p=0.000 n=10+10)
      EncodeTwainHuffman1e6-8      5.54ms ± 3%    5.22ms ± 2%  -5.70%  (p=0.000 n=10+10)
      EncodeTwainSpeed1e4-8         294µs ± 3%     284µs ± 1%  -3.71%  (p=0.000 n=10+10)
      EncodeTwainSpeed1e5-8        2.59ms ± 2%    2.48ms ± 1%  -4.14%   (p=0.000 n=10+9)
      EncodeTwainSpeed1e6-8        25.6ms ± 1%    24.3ms ± 1%  -5.28%   (p=0.000 n=9+10)
      EncodeTwainDefault1e4-8       419µs ± 2%     396µs ± 1%  -5.59%   (p=0.000 n=10+9)
      EncodeTwainDefault1e5-8      6.23ms ± 4%    5.75ms ± 1%  -7.83%   (p=0.000 n=10+9)
      EncodeTwainDefault1e6-8      66.2ms ± 2%    61.4ms ± 1%  -7.22%  (p=0.000 n=10+10)
      EncodeTwainCompress1e4-8      426µs ± 1%     405µs ± 1%  -4.97%   (p=0.000 n=9+10)
      EncodeTwainCompress1e5-8     6.80ms ± 1%    6.32ms ± 1%  -6.97%   (p=0.000 n=9+10)
      EncodeTwainCompress1e6-8     74.6ms ± 3%    68.7ms ± 1%  -7.90%   (p=0.000 n=10+9)
      
      name                       old speed      new speed      delta
      EncodeDigitsHuffman1e4-8    200MB/s ± 1%   208MB/s ± 1%  +3.88%   (p=0.000 n=10+9)
      EncodeDigitsHuffman1e5-8    210MB/s ± 1%   218MB/s ± 1%  +3.71%  (p=0.000 n=10+10)
      EncodeDigitsHuffman1e6-8    208MB/s ± 2%   219MB/s ± 1%  +5.32%   (p=0.000 n=10+9)
      EncodeDigitsSpeed1e4-8     32.8MB/s ± 3%  34.5MB/s ± 2%  +5.29%   (p=0.000 n=10+9)
      EncodeDigitsSpeed1e5-8     27.2MB/s ± 2%  28.6MB/s ± 2%  +5.29%  (p=0.000 n=10+10)
      EncodeDigitsSpeed1e6-8     26.1MB/s ± 2%  27.9MB/s ± 1%  +7.02%   (p=0.000 n=9+10)
      EncodeDigitsDefault1e4-8   27.7MB/s ± 2%  28.9MB/s ± 3%  +4.30%   (p=0.000 n=10+9)
      EncodeDigitsDefault1e5-8   19.1MB/s ± 2%  20.2MB/s ± 3%  +5.69%  (p=0.000 n=10+10)
      EncodeDigitsDefault1e6-8   17.7MB/s ± 3%  19.2MB/s ± 2%  +8.31%  (p=0.000 n=10+10)
      EncodeDigitsCompress1e4-8  27.6MB/s ± 2%  29.1MB/s ± 1%  +5.47%   (p=0.000 n=10+9)
      EncodeDigitsCompress1e5-8  19.0MB/s ± 3%  20.1MB/s ± 2%  +5.78%  (p=0.000 n=10+10)
      EncodeDigitsCompress1e6-8  17.9MB/s ± 4%  19.2MB/s ± 1%  +7.50%  (p=0.000 n=10+10)
      EncodeTwainHuffman1e4-8     141MB/s ± 3%   154MB/s ± 1%  +9.46%   (p=0.000 n=10+9)
      EncodeTwainHuffman1e5-8     180MB/s ± 2%   191MB/s ± 2%  +6.19%  (p=0.000 n=10+10)
      EncodeTwainHuffman1e6-8     181MB/s ± 3%   192MB/s ± 2%  +6.02%  (p=0.000 n=10+10)
      EncodeTwainSpeed1e4-8      34.0MB/s ± 3%  35.3MB/s ± 1%  +3.84%  (p=0.000 n=10+10)
      EncodeTwainSpeed1e5-8      38.7MB/s ± 2%  40.3MB/s ± 1%  +4.30%   (p=0.000 n=10+9)
      EncodeTwainSpeed1e6-8      39.1MB/s ± 1%  41.2MB/s ± 1%  +5.57%   (p=0.000 n=9+10)
      EncodeTwainDefault1e4-8    23.9MB/s ± 2%  25.3MB/s ± 1%  +5.91%   (p=0.000 n=10+9)
      EncodeTwainDefault1e5-8    16.0MB/s ± 4%  17.4MB/s ± 1%  +8.47%   (p=0.000 n=10+9)
      EncodeTwainDefault1e6-8    15.1MB/s ± 2%  16.3MB/s ± 1%  +7.76%  (p=0.000 n=10+10)
      EncodeTwainCompress1e4-8   23.5MB/s ± 1%  24.7MB/s ± 1%  +5.24%   (p=0.000 n=9+10)
      EncodeTwainCompress1e5-8   14.7MB/s ± 1%  15.8MB/s ± 1%  +7.50%   (p=0.000 n=9+10)
      EncodeTwainCompress1e6-8   13.4MB/s ± 3%  14.6MB/s ± 1%  +8.57%   (p=0.000 n=10+9)
      
      Change-Id: I5c7e84c2f9ea4d38a2115995705eebb93387e22f
      Reviewed-on: https://go-review.googlesource.com/21759Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      f20b1809
    • Martin Möhrmann's avatar
      all: replace magic 0x80 with named constant utf8.RuneSelf · 012557b3
      Martin Möhrmann authored
      Change-Id: Id1c2e8e9d60588de866e8b6ca59cc83dd28f848f
      Reviewed-on: https://go-review.googlesource.com/21756Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      012557b3
    • Dmitry Vyukov's avatar
      internal/trace: fix a typo in error message · 527ffebb
      Dmitry Vyukov authored
      Change-Id: Id79eaa6d49dae80c334c7243b0a5bbcdcb9397d3
      Reviewed-on: https://go-review.googlesource.com/21758Reviewed-by: default avatarMikio Hara <mikioh.mikioh@gmail.com>
      527ffebb
    • Marvin Stenger's avatar
      cmd: remove bio.Bread · de7ee57c
      Marvin Stenger authored
      Replace calls to bio.Bread with calls to io.ReadFull.
      
      Change-Id: I2ee8739d01e04a4da9c20b6ce7d1d5b89914b8ad
      Reviewed-on: https://go-review.googlesource.com/21750Reviewed-by: default avatarDave Cheney <dave@cheney.net>
      de7ee57c
    • Emmanuel Odeke's avatar
      runtime: make execution error panic values implement the Error interface · e4f1d9cf
      Emmanuel Odeke authored
      Make execution panics implement Error as
      mandated by https://golang.org/ref/spec#Run_time_panics,
      instead of panics with strings.
      
      Fixes #14965
      
      Change-Id: I7827f898b9b9c08af541db922cc24fa0800ff18a
      Reviewed-on: https://go-review.googlesource.com/21214Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      e4f1d9cf
    • Wisdom Omuya's avatar
      cmd/go: fix typo in findInternal documentation · 824d8c10
      Wisdom Omuya authored
      Fixes #15217
      
      Change-Id: Ib8f7af714197fd209e743f61f28a5b07c04a7f5c
      Reviewed-on: https://go-review.googlesource.com/21793Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      824d8c10
  2. 09 Apr, 2016 8 commits
  3. 08 Apr, 2016 15 commits
  4. 07 Apr, 2016 8 commits