- 21 Feb, 2013 1 commit
-
-
Brad Fitzpatrick authored
Fixes #4852 R=golang-dev, adg CC=golang-dev https://golang.org/cl/7374045
-
- 20 Feb, 2013 25 commits
-
-
Rob Pike authored
R=nigeltao CC=golang-dev https://golang.org/cl/7399044
-
Brad Fitzpatrick authored
Simplifies the contract for Driver.Stmt.Close in the process of fixing issue 3865. Fixes #3865 Update #4459 (maybe fixes it; uninvestigated) R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7363043
-
Russ Cox authored
Fixes #4435. R=golang-dev, iant, alex.brainman, minux.ma, dvyukov CC=golang-dev https://golang.org/cl/7304104
-
Steven Elliot Harris authored
Mimic the Emacs convention of presenting read-only files meant for browsing using view-mode, rather than Fundamental mode which mistakenly allows editing of the "godoc" content. Fixes #4322. R=golang-dev, bradfitz, sameer CC=golang-dev https://golang.org/cl/7231055
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-dev https://golang.org/cl/7377045
-
Olivier Saingre authored
Fixes #4112. R=remyoudompheng, daniel.morsing, dave, rsc CC=golang-dev https://golang.org/cl/7085053
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-dev https://golang.org/cl/7400045
-
Rob Pike authored
Also close the file when we're done. R=bradfitz CC=golang-dev https://golang.org/cl/7363045
-
Robert Dinu authored
Apply width when using Printf with nil values. Fixes #4772. R=r, adg CC=golang-dev https://golang.org/cl/7314114
-
Rob Pike authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7386045
-
Rob Pike authored
R=rsc CC=golang-dev https://golang.org/cl/7385045
-
Rob Pike authored
R=rsc CC=golang-dev https://golang.org/cl/7381046
-
Robert Griesemer authored
(per r's suggestion) R=r CC=golang-dev https://golang.org/cl/7376045
-
Rob Pike authored
Add a new, simple interface for scanning (probably textual) data, based on a new type called Scanner. It does its own internal buffering, so should be plausibly efficient even without injecting a bufio.Reader. The format of the input is defined by a "split function", by default splitting into lines. Other implemented split functions include single bytes, single runes, and space-separated words. Here's the loop to scan stdin as a file of lines: s := bufio.NewScanner(os.Stdin) for s.Scan() { fmt.Printf("%s\n", s.Bytes()) } if s.Err() != nil { log.Fatal(s.Err()) } While we're dealing with spaces, define what space means to strings.Fields. Fixes #4802. R=adg, rogpeppe, bradfitz, rsc CC=golang-dev https://golang.org/cl/7322088
-
Robert Griesemer authored
(Offsetof is a function of Alignof and Sizeof.) - removed IntSize, PtrSize from Context (set Sizeof instead) - GcImporter needs a Context now (it needs to have access to Sizeof/Alignof) - removed exported Size field from Basic (use Sizeof) - added Offset to Field - added Alignment, Size to Struct R=adonovan CC=golang-dev https://golang.org/cl/7357046
-
Dmitriy Vyukov authored
Can not happen ATM. In preparation for the new scheduler. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7388043
-
Dmitriy Vyukov authored
In preparation for the new scheduler. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7386044
-
Dmitriy Vyukov authored
This is followup to https://golang.org/cl/7319050/ R=golang-dev, dave CC=golang-dev https://golang.org/cl/7379043
-
Dmitriy Vyukov authored
Fixes #4819. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7322086
-
Dmitriy Vyukov authored
The removed code leads to the situation when M executes the same locked G again and again. This is https://golang.org/cl/7310096 but with return instead of break in the nested switch. Fixes #4820. R=golang-dev, alex.brainman, rsc CC=golang-dev https://golang.org/cl/7304102
-
Brad Fitzpatrick authored
The Camlistore code tree rearranged after the go tool came out. (I didn't know this link was here until I saw it in some logs.) R=adg CC=golang-dev https://golang.org/cl/7374043
-
Péter Surányi authored
On Windows, directory names in PATH can be fully or partially quoted in double quotes ('"'), but the path names as used by most APIs must be unquoted. In addition, quoted names can contain the semicolon (';') character, which is otherwise used as ListSeparator. This CL changes SplitList in path/filepath and LookPath in os/exec to only treat unquoted semicolons as separators, and to unquote the separated elements. (In addition, fix harmless test bug I introduced for LookPath on Unix.) Related discussion thread: https://groups.google.com/d/msg/golang-nuts/PXCr10DsRb4/sawZBM7scYgJ R=rsc, minux.ma, mccoyst, alex.brainman, iant CC=golang-dev https://golang.org/cl/7181047
-
Brian Dellisanti authored
Fixes #4844. R=golang-dev, alex.brainman CC=golang-dev https://golang.org/cl/7366043
-
Carl Shapiro authored
R=r, golang-dev CC=golang-dev https://golang.org/cl/7327053
-
Akshat Kumar authored
The data file should be opened when a Conn is first established, rather than waiting for the first Read or Write. Upon Close, we now make sure to try to close both, the ctl as well as data files and set both to nil, even in the face of errors, instead of returning early. The Accept call was not setting the remote address of the connection properly. Now, we read the correct file. Make functions that establish Conn use newTCPConn or newUDPConn. R=rsc, rminnich, ality, dave CC=golang-dev https://golang.org/cl/7228068
-
- 19 Feb, 2013 14 commits
-
-
Mikio Hara authored
This CL changes nothing to existing API behavior, just sets up Zone in IPNet and IPAddr structures if possible. Also does small simplification. Update #4234. R=rsc, dave CC=golang-dev https://golang.org/cl/7300081
-
Mikio Hara authored
On Linux point-to-point interface an IFA_ADDRESS attribute represents a peer address. For a correct interface address we should take an IFA_LOCAL attribute instead. Fixes #4839. R=golang-dev, dave, rsc CC=golang-dev https://golang.org/cl/7352045
-
Alan Donovan authored
This avoids ambiguity and makes the diagnostics closer to those issued by gc, but it is more verbose since it qualifies intra-package references. Without extra context---e.g. a 'from *Package' parameter to Type.String()---we are forced to err on one side or the other. Also, cosmetic changes to exp/ssa: - Remove package-qualification workaround in Function.FullName. - Always set go/types.Package.Path field to the import path, since we know the correct path at this point. - In Function.DumpTo, show variadic '...' and result type info, and delete now-redundant "# Type: " line. R=gri CC=golang-dev https://golang.org/cl/7325051
-
Robert Griesemer authored
R=golang-dev, dsymonds, bradfitz CC=golang-dev https://golang.org/cl/7323073
-
Robert Griesemer authored
Also: - faster code for example extraction - simplify handling of command documentation: all "main" packages are treated as commands - various minor cleanups along the way For commands written in Go, any doc.go file containing documentation must now be part of package main (rather then package documentation), otherwise the documentation won't show up in godoc (it will still build, though). For commands written in C, documentation may still be in doc.go files defining package documentation, but the recommended way is to explicitly ignore those files with a +build ignore constraint to define package main. Fixes #4806. R=adg, rsc, dave, bradfitz CC=golang-dev https://golang.org/cl/7333046
-
Kamil Kisiel authored
R=golang-dev, bradfitz, minux.ma CC=golang-dev https://golang.org/cl/7291043
-
Russ Cox authored
This comment matches the one in path. Fixes #4837. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7305100
-
Andrew Wilkins authored
side expression evaluation in assignment operations. R=golang-dev, gri CC=golang-dev https://golang.org/cl/7349046
-
Robin Eklind authored
ref: http://www.dwarfstd.org/doc/DWARF4.pdf Update #4829 R=minux.ma, iant CC=dave, golang-dev https://golang.org/cl/7354043
-
Donovan Hide authored
Slightly better benchmarks for when string and separator are equivalent and also less branching in inner loops. benchmark old ns/op new ns/op delta BenchmarkGenericNoMatch 3430 3442 +0.35% BenchmarkGenericMatch1 23590 22855 -3.12% BenchmarkGenericMatch2 108031 105025 -2.78% BenchmarkSingleMaxSkipping 2969 2704 -8.93% BenchmarkSingleLongSuffixFail 2826 2572 -8.99% BenchmarkSingleMatch 205268 197832 -3.62% BenchmarkByteByteNoMatch 987 921 -6.69% BenchmarkByteByteMatch 2014 1749 -13.16% BenchmarkByteStringMatch 3083 3050 -1.07% BenchmarkHTMLEscapeNew 922 915 -0.76% BenchmarkHTMLEscapeOld 1654 1570 -5.08% BenchmarkByteByteReplaces 11897 11556 -2.87% BenchmarkByteByteMap 4485 4255 -5.13% BenchmarkIndexRune 174 121 -30.46% BenchmarkIndexRuneFastPath 41 41 -0.24% BenchmarkIndex 45 44 -0.22% BenchmarkMapNoChanges 433 431 -0.46% BenchmarkIndexHard1 4015336 3316490 -17.40% BenchmarkIndexHard2 3976254 3395627 -14.60% BenchmarkIndexHard3 3973158 3378329 -14.97% BenchmarkCountHard1 4403549 3448512 -21.69% BenchmarkCountHard2 4387437 3413059 -22.21% BenchmarkCountHard3 4403891 3382661 -23.19% BenchmarkIndexTorture 28354 25864 -8.78% BenchmarkCountTorture 29625 27463 -7.30% BenchmarkFields 38752040 39169840 +1.08% BenchmarkFieldsFunc 38797765 38888060 +0.23% benchmark old MB/s new MB/s speedup BenchmarkSingleMaxSkipping 3367.07 3697.62 1.10x BenchmarkSingleLongSuffixFail 354.51 389.47 1.10x BenchmarkSingleMatch 73.07 75.82 1.04x BenchmarkFields 27.06 26.77 0.99x BenchmarkFieldsFunc 27.03 26.96 1.00x R=dave, fullung, remyoudompheng, rsc CC=golang-dev https://golang.org/cl/7350045
-
Russ Cox authored
Generated by addca. R=gobot CC=golang-dev https://golang.org/cl/7351046
-
Russ Cox authored
If Python blocks in the SSL handshake it seems to be completely uninterruptible, and I've been seeing it block for at least hours recently. I don't know if the problem is on the client side or the server side or somewhere in the network, but setting the timeout at least means you're guaranteed a new shell prompt (after printing some errors). R=golang-dev, bradfitz, minux.ma CC=golang-dev https://golang.org/cl/7337048
-
Russ Cox authored
R=golang-dev, agl CC=golang-dev https://golang.org/cl/7304106
-
Russ Cox authored
The exact words are taken from the spec. Fixes some confusion on golang-nuts. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7353044
-