Commits · a4e6197b91e2bc16616245a3a704b89ab99db949 · Kirill Smelkov / go

15 Mar, 2012 7 commits
- net/http: couple more triv.go modernizations · a4e6197b
  Brad Fitzpatrick authored Mar 15, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5834049
```
  a4e6197b
- doc/play: use []rune insetead of []int. · aec01c36
  Yasuhiro Matsumoto authored Mar 15, 2012
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/5823058
```
  aec01c36
- cmd/godoc: add toys, tour button to playground · d528f52d
  Andrew Gerrand authored Mar 15, 2012
```
Fixes #3241.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5835043
```
  d528f52d
- os: return some invented data from Stat(DevNull) on windows · 4b872d61
  Alex Brainman authored Mar 15, 2012
```
Fixes #3321.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5831043
```
  4b872d61
- doc: add "Godoc: documenting Go code" article · 235863cb
  Francisco Souza authored Mar 15, 2012
```
Originally published on The Go Programming Language Blog, March 31, 2011.

http://blog.golang.org/2011/03/godoc-documenting-go-code.html

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5830043
```
  235863cb
- net/http: ensure triv.go compiles and runs · 1c224ab9
  Robert Hencke authored Mar 14, 2012
```
R=golang-dev, bradfitz, dsymonds, dave, r
CC=golang-dev
https://golang.org/cl/5795069
```
  1c224ab9
- cmd/godoc: use *goroot as base path in zip file · 181dc14c
  Andrew Gerrand authored Mar 15, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5781069
```
  181dc14c
14 Mar, 2012 21 commits

doc: add reference to FAQ to explain warning about concrete type · f0087252
Stefan Nilsson authored Mar 15, 2012
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5820048
```
f0087252
archive/zip: move r.zip off disk, into reader_test.go · c959ebe4
Brad Fitzpatrick authored Mar 14, 2012
```
Makes certain virus scanners happier.

R=golang-dev, rsc, adg
CC=golang-dev
https://golang.org/cl/5823053
```
c959ebe4
godoc: style example headings like links · 9d08068d
Andrew Gerrand authored Mar 15, 2012
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5819048
```
9d08068d
go/build: clearer argument name for Import (src -> srcDir) · 036731c1
Robert Griesemer authored Mar 14, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/5820052
```
036731c1
cmd/go: fix directory->import path conversion · 95a8bab7
Russ Cox authored Mar 14, 2012
```
Fixes #3306.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5821048
```
95a8bab7
io/ioutil: fix crash when Stat fails · 70e58a2f
Russ Cox authored Mar 14, 2012
```
Fixes #3320.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5824051
```
70e58a2f

runtime: manage stack by ourselves for badcallback on windows/amd64 · b2a9079e

Shenghou Ma authored Mar 15, 2012

This function uses 48-byte of precious non-split stack for every callback
function, and without this CL, it can easily overflow the non-split stack.
I encountered this when trying to enable misc/cgo/test on windows/amd64.

R=rsc
CC=golang-dev
https://golang.org/cl/5784075

b2a9079e

cmd/go: trivial help message fix for go help get · 1ddc9feb

Volker Dobler authored Mar 14, 2012

Direct reference to go help build where the flags are described.

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/5825046

1ddc9feb

os: IsNotExist() should also consider ERROR_PATH_NOT_FOUND on Windows · 24ed667b

Shenghou Ma authored Mar 14, 2012

    Also update documentation about IsExist() and IsNotExist(), they are not
    about files only.

R=rsc
CC=golang-dev
https://golang.org/cl/5794073

24ed667b

misc/dist: don't lose mode bits when setting tar permissions · d6ea81e0
Brad Fitzpatrick authored Mar 14, 2012
```
R=golang-dev, bsiegert, rsc
CC=golang-dev
https://golang.org/cl/5822046
```
d6ea81e0
misc/dist: remove exp and old before building · 5c8e88d6
Andrew Gerrand authored Mar 14, 2012
```
Fixes #3317.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5784074
```
5c8e88d6

misc/vim: restore fileencodings. · 2fc5dd66

Yasuhiro Matsumoto authored Mar 14, 2012

Currently, ftdetect/gofiletype.vim set fileencodings to open the file as
utf-8 encoding event if the file does not contain multibyte characters.
But fileencodings is global option.

$ vim foo.txt
:set fileencodings
utf-8,ucs-bom,cp932

$ vim foo.go
:set fileencodings
utf-8

This change restore fileencodings before opening the file.
Also added specify fileformats=unix.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5718045

2fc5dd66

misc/dist: force modes to 0755 or 0644 in tarballs · b3ca3e95
Andrew Gerrand authored Mar 14, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5823045
```
b3ca3e95
html/template: fix nil pointer bug · 214a1ca3
Rob Pike authored Mar 14, 2012
```
Fixes #3272.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5819046
```
214a1ca3

runtime/cgo: linux signal masking · 9eeb9094

Mikio Hara authored Mar 14, 2012

Fixes #3314.
Fixes #3101 (again).

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5820047

9eeb9094

runtime/cgo: darwin signal masking · 1fc9a17c

Mikio Hara authored Mar 14, 2012

Fixes #3101 (again).

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5825043

1fc9a17c

cmd/godoc: s/ignore/appengine/ in appinit.go +build constraint · ace7d264
Andrew Gerrand authored Mar 14, 2012
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/5784072
```
ace7d264

godoc: fix vet warnings for untagged struct literals · adcb5083

Andrew Gerrand authored Mar 14, 2012

src/cmd/godoc/filesystem.go:337:10: os.PathError struct literal uses untagged fields
src/cmd/godoc/filesystem.go:355:10: os.PathError struct literal uses untagged fields

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5820046

adcb5083

doc: add Go Concurrency Patterns: Timing out, moving on article · 5659826e

Francisco Souza authored Mar 14, 2012

Originally published on The Go Programming Language Blog, September 23, 2010.

http://blog.golang.org/2010/09/go-concurrency-patterns-timing-out-and.html

Update #2547.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5815044

5659826e

all: various typos · d724631a
Robert Griesemer authored Mar 13, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5820045
```
d724631a

doc: add Go image/draw package article and convert code snippets to Go1. · fef92cbb

Johan Euphrosine authored Mar 14, 2012

Originally published on The Go Programming Language Blog, September 29, 2011.

http://blog.golang.org/2011/09/go-imagedraw-package.html

Update #2547.

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/5755057

fef92cbb

13 Mar, 2012 12 commits

html/template: fix panic on Clone · 5f32c8b8
Brad Fitzpatrick authored Mar 13, 2012
```
Fixes #3281

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5819044
```
5f32c8b8
text/template: variables do not take arguments · d6ad6f0e
Rob Pike authored Mar 14, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5821044
```
d6ad6f0e

go/printer, gofmt: fix multi-line logic · b5021f3f

Robert Griesemer authored Mar 13, 2012

A node spans multiple lines if the line difference
between start and end point is > 0 (rather than > 1).
Fixes some odd cases introduced by CL 5706055;
pointed out by dsymonds.

Added corresponding test case. The other change
in the .golden file reverts to the status before
the CL mentioned above and is correct.

gofmt -w src misc changes godoc.go back to where
it was before the CL mentioned above.

Fixes #3304.

R=dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5820044

b5021f3f

fmt: remove dead code · 62bb39e2

Shenghou Ma authored Mar 14, 2012

     Also fix a typo in comment.

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5808043

62bb39e2

text/template: fix a couple of parse bugs around identifiers. · 8170d81f

Rob Pike authored Mar 14, 2012

1) Poor error checking in variable declarations admitted
$x=2 or even $x%2.
2) Need white space or suitable termination character
after identifiers, so $x+2 doesn't parse, in case we want it
to mean something one day.
Number 2 in particular prevents mistakes that we will have
to honor later and so is necessary for Go 1.

Fixes #3270.
Fixes #3271.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5795073

8170d81f

go/build: fix match · 5361712a
Maxim Pimenov authored Mar 13, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5801043
```
5361712a
gc: use quoted string format in import error · cc99d8ad
Russ Cox authored Mar 13, 2012
```
R=ken2
CC=golang-dev
https://golang.org/cl/5794077
```
cc99d8ad
make.bat: properly handle directories with spaces · f26b1f80
Alex Brainman authored Mar 13, 2012
```
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/5797079
```
f26b1f80
os: remove document duplication in error predicate functions · 4ca59a01
Shenghou Ma authored Mar 13, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5783092
```
4ca59a01
tag weekly.2012-03-13 · e24d99d0
Andrew Gerrand authored Mar 13, 2012
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/5795072
```
e24d99d0
weekly.2012-03-13 · 9ef03fdf
Andrew Gerrand authored Mar 13, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5754097
```
9ef03fdf
doc: update weekly notes, untag weekly · f4bf4c3b
Andrew Gerrand authored Mar 13, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5783093
```
f4bf4c3b