Commits · a62722bba4e7ccfe2ebfae4a5702c17e0a64937d · Kirill Smelkov / go

14 Dec, 2011 10 commits

gc: inlining (disabled without -l) · a62722bb

Luuk van Dijk authored Dec 14, 2011

Cross- and intra package inlining of single assignments or return <expression>.
Minus some hairy cases, currently including other calls, expressions with closures and ... arguments.

R=rsc, rogpeppe, adg, gri
CC=golang-dev
https://golang.org/cl/5400043

a62722bb

html: close <button> element before opening a new one · e25a83d0

Andrew Balholm authored Dec 14, 2011

Pass tests6.dat, test 13:
<button><button>

| <html>
|   <head>
|   <body>
|     <button>
|     <button>

Also pass tests through test 25:
<table><colgroup>foo

R=nigeltao
CC=golang-dev
https://golang.org/cl/5487072

e25a83d0

gc: Use %#F in error messages instead of %F. · 3c638f28
Luuk van Dijk authored Dec 14, 2011
```
Fixes #2520

R=rsc
CC=golang-dev
https://golang.org/cl/5482056
```
3c638f28
gc: suppress non-root cause message for bad receivers. · 6a401339
Luuk van Dijk authored Dec 14, 2011
```
Fixed issue 2500

R=rsc
CC=golang-dev
https://golang.org/cl/5485053
```
6a401339

undo CL 5485063 / 21595dc0395a · c8a5f884

Russ Cox authored Dec 14, 2011

breaks 64-bit build

««« original CL description
8c: handle 64-bit switch value
Cases must still be 32-bit values, but one thing at a time.

R=ality, ken2, ken
CC=golang-dev
https://golang.org/cl/5485063
»»»

R=ken2
CC=golang-dev
https://golang.org/cl/5488075

c8a5f884

runtime: bump gc 'extra bytes' check · 1e63a4e4

Christopher Wedgwood authored Dec 13, 2011

(needed for non-zero GOMAXPROCS)

R=iant, rsc
CC=go.peter.90, golang-dev
https://golang.org/cl/5486059

1e63a4e4

8c: handle 64-bit switch value · 6481e37d

Russ Cox authored Dec 14, 2011

Cases must still be 32-bit values, but one thing at a time.

R=ality, ken2, ken
CC=golang-dev
https://golang.org/cl/5485063

6481e37d

encoding/gob: better error messages when types mismatch · ba576b2b

Rob Pike authored Dec 13, 2011

The transmitter must encode an interface value if it is to be decoded
into an interface value, but it's a common and confusing error to
encode a concrete value and attempt to decode it into an interface,
particularly *interface{}. This CL attempts to explain things better.

Fixes #2367.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5485072

ba576b2b

exp/winfsnotify: fix build. · 1c50c32a
Yasuhiro Matsumoto authored Dec 14, 2011
```
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/5483057
```
1c50c32a
spec: values of underlying type uintptr can be converted to unsafe.Pointer · 599c18fa
Robert Griesemer authored Dec 13, 2011
```
Not a language change, just stating the facts.

Fixes #1793.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5488071
```
599c18fa

13 Dec, 2011 30 commits

syscall: regenerate z-files for openbsd · 7b5ae29a
Joel Sing authored Dec 14, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5414053
```
7b5ae29a

runtime: Make gc_test test extra allocated space, not total space. · 26239417

Ian Lance Taylor authored Dec 13, 2011

Testing total space fails for gccgo when not using split
stacks, because then each goroutine has a large stack, and so
the total memory usage is large.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5487068

26239417

bufio: make the minimum read buffer size 16 bytes. · 64776da4
Rob Pike authored Dec 13, 2011
```
R=gri, rsc
CC=golang-dev
https://golang.org/cl/5485067
```
64776da4

test/garbage: move to test/bench/garbage · 5fe96c64

Russ Cox authored Dec 13, 2011

(These are benchmarks for the garbage collector, not tests.)

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5484070

5fe96c64

fix build, sorry · 1161e117
Russ Cox authored Dec 13, 2011
```
TBR=r
CC=golang-dev
https://golang.org/cl/5488066
```
1161e117
strconv: some allocation tests · 39213c1f
Brad Fitzpatrick authored Dec 13, 2011
```
R=rsc, r
CC=golang-dev
https://golang.org/cl/5477084
```
39213c1f
test/bench: move to test/bench/shootout · bcbb2f93
Russ Cox authored Dec 13, 2011
```
R=golang-dev, r, gri, bradfitz
CC=golang-dev
https://golang.org/cl/5487067
```
bcbb2f93

contribute.html: do not fill in the reviewer field · b1175beb

Florian Weimer authored Dec 13, 2011

The golang-dev mailing list is added automatically.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5482060

b1175beb

A+C: Florian Weimer (individual CLA) · f4b430c9
Russ Cox authored Dec 13, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5486056
```
f4b430c9

math: delete non-Sqrt-based Hypot · 25728038

Russ Cox authored Dec 13, 2011

I was confused by the existence of two portable Hypot
routines in the tree when I cleaned things up, and I made
ARM use the wrong (imprecise) one.  Use the right one,
and delete the wrong one.

Fixes arm build.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5485065

25728038

undo CL 5414048 / f6b994f33cf4 · 2c6d3eaf

Russ Cox authored Dec 13, 2011

breaks build

««« original CL description
http: close connection after printing panic stack trace
In a testing situation, it's possible for a local http
server to panic and the test exit without the stack trace
ever being printed.
Fixes #2480.

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5414048

»»»

R=bradfitz
CC=golang-dev
https://golang.org/cl/5482061

2c6d3eaf

go/printer, godoc: print comments in example code · 5fb7e5b4

Robert Griesemer authored Dec 13, 2011

- go/printer: support for printing CommentedNodes
- go/doc: collect comments from examples

Fixes #2429.

R=adg, rsc
CC=golang-dev
https://golang.org/cl/5482052

5fb7e5b4

gofmt: simplify flags · fe746335

Robert Griesemer authored Dec 13, 2011

-tabs replaces -tabindent
-spaces has been removed

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/5487066

fe746335

gofix: add googlecode module for rewriting Google Code imports · 0b0a6ec7
Andrew Gerrand authored Dec 14, 2011
```
goinstall: disallow googlecode.com import paths

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5421049
```
0b0a6ec7

http: close connection after printing panic stack trace · 51616805

Roger Peppe authored Dec 13, 2011

In a testing situation, it's possible for a local http
server to panic and the test exit without the stack trace
ever being printed.
Fixes #2480.

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5414048

51616805

gofix: add fix httputil · 19d064f6
Yasuhiro Matsumoto authored Dec 13, 2011
```
R=r, rsc, adg
CC=golang-dev
https://golang.org/cl/5364056
```
19d064f6
codereview: fix path slash issue. · e62b4034
Yasuhiro Matsumoto authored Dec 13, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5487057
```
e62b4034
archive/tar: (test) structure comparison not reflect.DeepEqual · 0e9ee93c
Christopher Wedgwood authored Dec 14, 2011
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/5487064
```
0e9ee93c

math: regularize build · dd8dc6f0

Russ Cox authored Dec 13, 2011

This will be nicer to the automatic tools.
It requires a few more assembly stubs
but fewer Go files.

There are a few instances where it looks like
there are new blobs of code, but they are just
being copied out of deleted files.

There is no new code here.

Suppose you have a portable implementation for Sin
and a 386-specific assembly one.  The old way to
do this was to write three files

sin_decl.go
   func Sin(x float64) float64  // declaration only
sin_386.s
   assembly implementation

sin_port.go
   func Sin(x float64) float64 { ... }  // pure-Go impl

and then link in either sin_decl.go+sin_386.s or
just sin_port.go.  The Makefile actually did the magic
of linking in only the _port.go files for those without
assembly and only the _decl.go files for those with
assembly, or at least some of that magic.

The biggest problem with this, beyond being hard
to explain to the build system, is that once you do
explain it to the build system, godoc knows which
of sin_port.go or sin_decl.go are involved on a given
architecture, and it (correctly) ignores the other.
That means you have to put identical doc comments
in both files.

The new approach, which is more like what we did
in the later packages math/big and sync/atomic,
is to have

sin.go
   func Sin(x float64) float64  // decl only
   func sin(x float64) float64 {...}  // pure-Go impl

sin_386.s
   // assembly for Sin (ignores sin)
sin_amd64.s
   // assembly for Sin: jmp sin
sin_arm.s
   // assembly for Sin: jmp sin

Once we abandon Makefiles we can put all the assembly
stubs in one source file, so the number of files will
actually go down.

Chris asked whether the branches cost anything.
Given that they are branching to pure-Go implementations
that are not typically known for their speed, the single
direct branch is not going to be noticeable.  That is,
it's on the slow path.

An alternative would have been to preserve the old
"only write assembly files when there's an implementation"
and still have just one copy of the declaration of Sin
(and thus one doc comment) by doing:

sin.go
   func Sin(x float64) float64 { return sin(x) }

sin_decl.go
   func sin(x float64) float64 // declaration only
sin_386.s
   // assembly for sin

sin_port.go
   func sin(x float64) float64 { portable code }

In this version everyone would link in sin.go and
then either sin_decl.go+sin_386.s or sin_port.go.

This has an extra function call on all paths, including
the "fast path" to get to assembly, and it triples the
number of Go files involved compared to what I did
in this CL.  On the other hand you don't have to
write assembly stubs.  After starting down this path
I decided that the assembly stubs were the easier
approach.

As for generating the assembly stubs on the fly, much
of the goal here is to eliminate magic from the build
process, so that zero-configuration tools like goinstall
or the new go tool can handle this package.

R=golang-dev, r, cw, iant, r
CC=golang-dev
https://golang.org/cl/5488057

dd8dc6f0

cypto/ocsp: fix tests · 6f975fbb

Christopher Wedgwood authored Dec 13, 2011

Actually compare the result with expected not itself

R=agl, bradfitz
CC=golang-dev, rsc
https://golang.org/cl/5477079

6f975fbb

go: implement doc, fmt, fix, list, vet · 6e2c3ef4

Russ Cox authored Dec 13, 2011

This CL is concerned with the basic Package structure
and applies it to the (trivial) implementations of the
doc, fmt, fix, list, and vet commands.

The command as a whole is still very much a work in progress.
In particular, work making the error messages look nice
is deferred to a future CL.

R=golang-dev, adg, dsymonds, r
CC=golang-dev
https://golang.org/cl/5482048

6e2c3ef4

build: disable cgo on Windows/amd64 · 969b71d9

Russ Cox authored Dec 13, 2011

Apparently it is broken.  Disable so that dashboard
will let us see other breakages on Windows.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5477081

969b71d9

strconv: make QuoteRune etc. take a rune argument · 38df0459

Rob Pike authored Dec 13, 2011

Just an oversight it didn't already.
Fixes #2515.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5483064

38df0459

5g: fix build · c0951e9f
Russ Cox authored Dec 13, 2011
```
R=ken2
CC=golang-dev
https://golang.org/cl/5482059
```
c0951e9f
strconv: include package and function name in error strings · 02f6719d
Rob Pike authored Dec 13, 2011
```
Fixes #2548.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5484062
```
02f6719d

godoc: text wrapping · 6bf84214

Russ Cox authored Dec 13, 2011

Example:

PACKAGE

package utf8
    import "unicode/utf8"

    Package utf8 implements functions and constants to support text
    encoded in UTF-8.  This package calls a Unicode character a rune for
    brevity.

CONSTANTS

const (
    RuneError = unicode.ReplacementChar // the "error" Rune or "replacement character".
    RuneSelf  = 0x80                    // characters below Runeself are represented as themselves in a single byte.
    UTFMax    = 4                       // maximum number of bytes of a UTF-8 encoded Unicode character.
)
    Numbers fundamental to the encoding.

FUNCTIONS

func DecodeLastRune(p []byte) (r rune, size int)
    DecodeLastRune unpacks the last UTF-8 encoding in p and returns the
    rune and its width in bytes.

func DecodeLastRuneInString(s string) (r rune, size int)
    DecodeLastRuneInString is like DecodeLastRune but its input is a
    string.

func DecodeRune(p []byte) (r rune, size int)
    DecodeRune unpacks the first UTF-8 encoding in p and returns the rune
    and its width in bytes.

func DecodeRuneInString(s string) (r rune, size int)
    DecodeRuneInString is like DecodeRune but its input is a string.

func EncodeRune(p []byte, r rune) int
    EncodeRune writes into p (which must be large enough) the UTF-8
    encoding of the rune.  It returns the number of bytes written.

func FullRune(p []byte) bool
    FullRune reports whether the bytes in p begin with a full UTF-8
    encoding of a rune.  An invalid encoding is considered a full Rune
    since it will convert as a width-1 error rune.

func FullRuneInString(s string) bool
    FullRuneInString is like FullRune but its input is a string.

func RuneCount(p []byte) int
    RuneCount returns the number of runes in p.  Erroneous and short
    encodings are treated as single runes of width 1 byte.

func RuneCountInString(s string) (n int)
    RuneCountInString is like RuneCount but its input is a string.

func RuneLen(r rune) int
    RuneLen returns the number of bytes required to encode the rune.

func RuneStart(b byte) bool
    RuneStart reports whether the byte could be the first byte of an
    encoded rune.  Second and subsequent bytes always have the top two
    bits set to 10.

func Valid(p []byte) bool
    Valid reports whether p consists entirely of valid UTF-8-encoded
    runes.

func ValidString(s string) bool
    ValidString reports whether s consists entirely of valid UTF-8-encoded
    runes.

TYPES

type String struct {
    // contains filtered or unexported fields
}
    String wraps a regular string with a small structure that provides
    more efficient indexing by code point index, as opposed to byte index.
    Scanning incrementally forwards or backwards is O(1) per index
    operation (although not as fast a range clause going forwards).
    Random access is O(N) in the length of the string, but the overhead is
    less than always scanning from the beginning.  If the string is ASCII,
    random access is O(1).  Unlike the built-in string type, String has
    internal mutable state and is not thread-safe.

func NewString(contents string) *String
    NewString returns a new UTF-8 string with the provided contents.

func (s *String) At(i int) rune
    At returns the rune with index i in the String.  The sequence of runes
    is the same as iterating over the contents with a "for range" clause.

func (s *String) Init(contents string) *String
    Init initializes an existing String to hold the provided contents.
    It returns a pointer to the initialized String.

func (s *String) IsASCII() bool
    IsASCII returns a boolean indicating whether the String contains only
    ASCII bytes.

func (s *String) RuneCount() int
    RuneCount returns the number of runes (Unicode code points) in the
    String.

func (s *String) Slice(i, j int) string
    Slice returns the string sliced at rune positions [i:j].

func (s *String) String() string
    String returns the contents of the String.  This method also means the
    String is directly printable by fmt.Print.

Fixes #2479.

R=golang-dev, dsymonds, mattn.jp, r, gri, r
CC=golang-dev
https://golang.org/cl/5472051

6bf84214

gc: delete DUPOK definition · 61655bc5

Russ Cox authored Dec 13, 2011

The relevant header is already included.

R=ken2
CC=golang-dev
https://golang.org/cl/5487062

61655bc5

exp/ssh: improve client channel close behavior · 2b600f77
Dave Cheney authored Dec 13, 2011
```
R=gustav.paul
CC=golang-dev
https://golang.org/cl/5480062
```
2b600f77

gc: small fixes to fmt.c · 7cf48254

Luuk van Dijk authored Dec 13, 2011

don't crash when printing error messages about symbols in a garbled state.
render OCOMPLIT in export mode.

R=rsc
CC=golang-dev
https://golang.org/cl/5466045

7cf48254

gc: fix use of stackallocated AST node in generation of static initialisation code. · e1b1a5fe
Luuk van Dijk authored Dec 13, 2011
```
Fixes #2529

R=rsc, rogpeppe
CC=golang-dev
https://golang.org/cl/5483048
```
e1b1a5fe