- 12 May, 2016 6 commits
-
-
Michael Munday authored
Step 5 was deleted in f3575a95 however the numbering of the other steps wasn't adjusted accordingly. While we're here: clean up the whitespace, add curly braces where appropriate and delete semicolons. Change-Id: I4e77b2d3ee8460abe4bfb993674f83e35be8ff17 Reviewed-on: https://go-review.googlesource.com/23066Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Aliaksandr Valialkin authored
Updates #11041 Change-Id: I32a381854e6a4fd791db380150efab57e6dfc38c Reviewed-on: https://go-review.googlesource.com/23081Reviewed-by:
-
Aliaksandr Valialkin authored
Updates #11041 Change-Id: I7f2583d08f344d6622027c5e8a5de1f5d2f2881c Reviewed-on: https://go-review.googlesource.com/23082Reviewed-by:
-
Aliaksandr Valialkin authored
Updated #11041 Change-Id: I4a110ba8fefb367a1049b4a65dd20c39eb890ea2 Reviewed-on: https://go-review.googlesource.com/23080Reviewed-by:
-
Joel Sing authored
In future releases of OpenBSD, the sigreturn syscall will no longer exist. As such, stop using sigreturn on openbsd/386 and just return from the signal trampoline (as we already do for openbsd/amd64 and openbsd/arm). Change-Id: Ic4de1795bbfbfb062a685832aea0d597988c6985 Reviewed-on: https://go-review.googlesource.com/23024Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Alex Brainman authored
Updates #15167 Change-Id: I826f67e75011ba79325a1294ac0d70d7c6a3e32f Reviewed-on: https://go-review.googlesource.com/23022Reviewed-by:
-
- 11 May, 2016 17 commits
-
-
Robert Griesemer authored
Minor cleanup. Each of these cases appears both during export and import when running all.bash and thus is tested by all.bash. Change-Id: Iaa4a5a5b163cefe33e43d08d396e02a02e5c22a5 Reviewed-on: https://go-review.googlesource.com/23060Reviewed-by:
Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Brad Fitzpatrick authored
Fixes #15647 Change-Id: I588bfa4eb336d1da1fcda8d06e32ed13c0b51c70 Reviewed-on: https://go-review.googlesource.com/23061 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Andrew Gerrand <adg@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Johan Sageryd authored
Change-Id: I4ccfaa16e153aad001d670891b3848264e63cf6f Reviewed-on: https://go-review.googlesource.com/23031Reviewed-by:
-
Robert Griesemer authored
This is addressing feedback given on golang.org/cl/23052; we do it in a separate CL to separate the functional from the rename change. ONAME was not used in the export data, but it's the natural node op where we used OPACK instead. Renamed. Furthermore, OPACK and ONONAME nodes are replaced by the type checker with ONAME nodes, so OPACK nodes cannot occur when exporting type-checked code. Removed a special-case for OPACK nodes since they don't appear. Change-Id: I78b01a1badbf60e9283eaadeca2578a65d28cbd2 Reviewed-on: https://go-review.googlesource.com/23053 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Robert Griesemer authored
Fixes #15646. Change-Id: Ic13d1adc0a358149209195cdb03811eeee506fb8 Reviewed-on: https://go-review.googlesource.com/23052 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Joe Tsai authored
The pprof tools properly cleans up all files it creates, but forgets to clean up the temporary directory itself. This CL fixes that. Fixes #13863 Change-Id: I1151c36cdad5ace7cc97e7e04001cf0149ef0f63 Reviewed-on: https://go-review.googlesource.com/23019Reviewed-by:
-
Marc-Antoine Ruel authored
Include integration test. Confirmed that without the fix, the test case TestDeleteReadOnly fails. This permits to revert "cmd/go: reset read-only flag during TestIssue10952" This reverts commit 3b7841b3. Fixes #9606 Change-Id: Ib55c151a8cf1a1da02ab18c34a9b58f615c34254 Reviewed-on: https://go-review.googlesource.com/18235Reviewed-by:
-
Brad Fitzpatrick authored
Fixes #14981 Change-Id: I39b906d119ca96815801a0fbef2dbe524a3246ff Reviewed-on: https://go-review.googlesource.com/23009Reviewed-by:
-
Ian Lance Taylor authored
The //extern comments are incorrect and cause undefined symbol errorswhen building cgo code with -compiler=gccgo. The code is already designed to use weak references, and that support relies on the cgo check functions being treated as local functions. Change-Id: Ib38a640cc4ce6eba74cfbf41ba7147ec88769ec0 Reviewed-on: https://go-review.googlesource.com/23014 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Summary: Go's HTTP/1.x server closes the request body once writes are flushed. Go's HTTP/2 server supports concurrent read & write. Added a TODO to make the HTTP/1.x server also support concurrent read+write. But for now, document it. Updates #15527 Change-Id: I81f7354923d37bfc1632629679c75c06a62bb584 Reviewed-on: https://go-review.googlesource.com/23011Reviewed-by:
-
Hiroshi Ioka authored
Change-Id: Ia2f61427b1cc09064ac4c0563bccbd9b98767a0e Reviewed-on: https://go-review.googlesource.com/18118Reviewed-by:
-
Mikio Hara authored
Change-Id: I323231f31c4e1e7415661ebd943a90b2f1e9da1c Reviewed-on: https://go-review.googlesource.com/23020Reviewed-by:
-
Mikio Hara authored
This change reorganizes test cases for surveying network interfaces and address prefixes to make sure which part of the functionality is broken. Updates #7849. Change-Id: If6918075802eef69a7f1ee040010b3c46f4f4b97 Reviewed-on: https://go-review.googlesource.com/22990Reviewed-by:
-
David du Colombier authored
This reverts commit a677724e. Change-Id: I6a54ac26a6deca5b2a39ec9f899469a88b543d3d Reviewed-on: https://go-review.googlesource.com/22980Reviewed-by:
-
Alex Brainman authored
Also run "go generate" in internal/syscall/windows and internal/syscall/windows/registry Updates #15167 Change-Id: I0109226962f81857fe11d308b869d561ea8ed9f9 Reviewed-on: https://go-review.googlesource.com/23021Reviewed-by:
-
Robert Griesemer authored
The importer uses a global (shared) package map across multiple imports to determine if a package was imported before. That package map is usually indexed by package (import) path ('id' in this code). However, the binary importer was using the incoming (possibly unclean) path. Fixes #15517. Change-Id: I0c32a708dfccf345e0353fbda20ad882121e437c Reviewed-on: https://go-review.googlesource.com/23012 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: -
Alex Brainman authored
The -systemdll and -xsys flags generate broken code in some situations (see issue for details). Fix all that. This CL only fixes bugs in existing code, but I have more changes comming: golang.org/x/sys/windows is not the only package that uses mksyscall_windows.go. golang.org/x/exp/shiny and github.com/derekparker/delve do too. I also have few personal packages that use mksyscall_windows.go. None of those packages are aware of new -xsys flag. I would like to change mksyscall_windows.go, so external packages do not need to use -xsys flag. I would love to get rid of -xsys flag altogether, but I don't see how it is possible. So I will, probably, replace -xsys with a flag that means opposite to -xsys, and use new flag everywhere in standard libraries. Flag name suggestions are welcome. -systemdll flag makes users code more "secure". I would like to make -systemdll behaviour a default for all mksyscall_windows.go users. We use that already in standard library. If we think "secure" is important, we should encourage it in all users code. If mksyscall_windows.go user insist on using old code, provide -use_old_loaddll (need good name here) flag for that. So -systemdll flag will be replaced with -use_old_loaddll. Fixes #15167 Change-Id: I516369507867358ba1b66aabe00a17a7b477016e Reviewed-on: https://go-review.googlesource.com/21645Reviewed-by:
-
- 10 May, 2016 12 commits
-
-
Brad Fitzpatrick authored
Noticed and fix by Alex Brainman. Tested in https://golang.org/cl/23005 (which makes all compiler warnings fatal during development) Fixes #15623 Change-Id: Ic19999fce8bb8640d963965cc328574efadd7855 Reviewed-on: https://go-review.googlesource.com/23010Reviewed-by:
Alex Brainman <alex.brainman@gmail.com>
-
Ian Lance Taylor authored
Instead of exporting the C function mygetgrouplist as a global symbol to conflict with other symbols of the same name, use trivial Go code and a static C function. Change-Id: I98dd667814d0a0ed8f7b1d4cfc6483d5a6965b26 Reviewed-on: https://go-review.googlesource.com/23008 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Andrew Gerrand authored
Fixes #15598 Change-Id: I4cfb8799dab0e9e34cae2e61839911fd65e4cfa3 Reviewed-on: https://go-review.googlesource.com/23004Reviewed-by:
-
Brad Fitzpatrick authored
Updates x/net/http2 to git rev 96dbb961 for golang.org/cl/23002 Fixes #15366 Updates #15134 (server part remains) Change-Id: I29336e624706f906b754da66381a620ae3293c6c Reviewed-on: https://go-review.googlesource.com/23003Reviewed-by:
-
Brad Fitzpatrick authored
Updates #15617 Change-Id: I2104776f8e789d987b4f2f7f08f2ebe979b747a1 Reviewed-on: https://go-review.googlesource.com/23001 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Dmitry Vyukov <dvyukov@google.com> Reviewed-by:
Minux Ma <minux@golang.org>
-
Keith Randall authored
See #15604. This was a bug in a CL that has since been rolled back. Adding a test to challenge the next attempter. Change-Id: Ic43be254ea6eaab0071018cdc61d9b1c21f19cbf Reviewed-on: https://go-review.googlesource.com/23000Reviewed-by:
-
Scott Bell authored
Although calls to getaddrinfo can't be portably interrupted, we still benefit from more granular resource management by pushing the context downwards. Fixes #15321 Change-Id: I5506195fc6493080410e3d46aaa3fe02018a24fe Reviewed-on: https://go-review.googlesource.com/22961Reviewed-by:
-
Emmanuel Odeke authored
Fixes #15046. Change-Id: Iba7216297735be8e1ec550ce5336d17dcd3fd6b7 Reviewed-on: https://go-review.googlesource.com/22992Reviewed-by:
-
David du Colombier authored
We fixed the implementation of the pread syscall in the Plan 9 kernel, so calling pread doesn't update the channel offset when reading a file. Fixes #11194. Change-Id: Ie4019e445542a73479728af861a50bb54caea3f6 Reviewed-on: https://go-review.googlesource.com/22245Reviewed-by:
-
David du Colombier authored
Fixes #8206. Change-Id: Iec1026ecc586495f5c9562cc84b3240c71d53da5 Reviewed-on: https://go-review.googlesource.com/22164 Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David du Colombier authored
In the Plan 9 kernel, there used to be a bug in the implementation of the pread syscall, where the channel offset was erroneously updated after calling pread on a file. This test verifies that ReadAt is behaving as expected. Fixes #14534. Change-Id: Ifc9fd40a1f94879ee7eb09b2ffc369aa2bec2926 Reviewed-on: https://go-review.googlesource.com/22244 Run-TryBot: David du Colombier <0intro@gmail.com> Reviewed-by:
-
Caleb Spare authored
This change makes encoding and decoding support integer types in map keys, converting to/from JSON string keys. JSON object keys are still sorted lexically, even though the keys may be integer strings. For backwards-compatibility, the existing Text(Un)Marshaler support for map keys (added in CL 20356) does not take precedence over the default encoding for string types. There is no such concern for integer types, so integer map key encoding is only used as a fallback if the map key type is not a Text(Un)Marshaler. Fixes #12529. Change-Id: I7e68c34f9cd19704b1d233a9862da15fabf0908a Reviewed-on: https://go-review.googlesource.com/22060Reviewed-by:
-
- 09 May, 2016 5 commits
-
-
Tilman Dilo authored
The decryption example for AES-GCM was not executed, hiding the fact that the provided ciphertext could not be authenticated. This commit adds the required output comment, replaces the ciphertext with a working example, and removes an unnecessary string conversion along the way. Change-Id: Ie6729ca76cf4a56c48b33fb3b39872105faa604b Reviewed-on: https://go-review.googlesource.com/22953Reviewed-by:
-
Brad Fitzpatrick authored
The time package has never depended on the io package until a recent change during Go 1.7 to use the io.Seek* constants. The go/build dependency check didn't catch this because "time" was allowed to depend on meta package group "L0", which included "io". Adding the "io" package broke one of Dmitry's tools. The tool is fixable, but it's also not necessary for us to depend on "io" at all for some constants. Mirror the constants instead, and change deps_test.go to prevent an io dependency in the future. Change-Id: I74325228565279a74fa4a2f419643f5710e3e09f Reviewed-on: https://go-review.googlesource.com/22960 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Hana Kim authored
After upgrading builder device (android/arm) to android 5.0.2, the test started failing. Running 'ln -s' from shell fails with permission error. Change-Id: I5b9e312806d58532b41ea3560ff079dabbc6424e Reviewed-on: https://go-review.googlesource.com/22962Reviewed-by:
-
Austin Clements authored
Change-Id: I4613aa6d62baba01686bbab10738a7de23daae30 Reviewed-on: https://go-review.googlesource.com/22971Reviewed-by:
Rick Hudson <rlh@golang.org>
-
Joe Tsai authored
Address two documentation issues: 1) Document that the GZIP and ZLIB footer is only verified when the reader has been fully consumed. 2) The zlib reader is guaranteed to not read past the EOF if the input io.Reader is also a io.ByteReader. This functionality was documented in the flate and gzip packages but not on zlib. Fixes #14867 Change-Id: I43d46b93e38f98a04901dc7d4f18ed2f9e09f6fb Reviewed-on: https://go-review.googlesource.com/21218Reviewed-by:
-
