1. 02 Mar, 2016 3 commits
    • Marvin Stenger's avatar
      cmd/vet: polish output of shadow test · a8d4463e
      Marvin Stenger authored
      This commit modifies the style of a error message in case of -shadow.
      
      Previously such a message would look like:
      foo.go:42: declaration of err shadows declaration at shadow.go:13:
      
      Changes of the commit include highlighting the variable name and
      removing the ": "(space intended) at the end of the line:
      foo.go:42: declaration of "err" shadows declaration at shadow.go:13
      
      Fixes #14585.
      
      Change-Id: Ia6a6bf396668dcba9a24f025a08d8826db31f434
      Reviewed-on: https://go-review.googlesource.com/20093Reviewed-by: default avatarRob Pike <r@golang.org>
      a8d4463e
    • Brad Fitzpatrick's avatar
      all: single space after period. · 5fea2ccc
      Brad Fitzpatrick authored
      The tree's pretty inconsistent about single space vs double space
      after a period in documentation. Make it consistently a single space,
      per earlier decisions. This means contributors won't be confused by
      misleading precedence.
      
      This CL doesn't use go/doc to parse. It only addresses // comments.
      It was generated with:
      
      $ perl -i -npe 's,^(\s*// .+[a-z]\.)  +([A-Z]),$1 $2,' $(git grep -l -E '^\s*//(.+\.)  +([A-Z])')
      $ go test go/doc -update
      
      Change-Id: Iccdb99c37c797ef1f804a94b22ba5ee4b500c4f7
      Reviewed-on: https://go-review.googlesource.com/20022Reviewed-by: default avatarRob Pike <r@golang.org>
      Reviewed-by: default avatarDave Day <djd@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      5fea2ccc
    • Ian Lance Taylor's avatar
      cmd/compile: fix OADDSTR buffer size calculation · 8b4deb44
      Ian Lance Taylor authored
      The size calculation has been wrong since this code was first committed
      in https://golang.org/cl/3120.  The effect was that the compiler always
      allocated a temporary buffer on the stack for a non-escaping string
      concatenation.  This turns out to make no practical difference, as the
      compiler always allocates a buffer of the same size (32 bytes) and the
      runtime only uses the temporary buffer if the concatenated strings
      fit (check is in rawstringtmp in runtime/string.go).
      
      The effect of this change is to avoid generating a temporary buffer on
      the stack that will not be used.
      
      Change-Id: Id632bfe3d6c113c9934c018a2dd4bcbf1784a63d
      Reviewed-on: https://go-review.googlesource.com/20112
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      8b4deb44
  2. 01 Mar, 2016 23 commits
  3. 29 Feb, 2016 14 commits