- 24 Nov, 2009 3 commits
-
-
Rob Pike authored
R=rsc CC=golang-dev, reneefrench https://golang.org/cl/157144
-
Sergio Luis O. B. Correia authored
the bash scripts and makefiles for building go didn't take into account the fact $GOROOT / $GOBIN could both be directories containing whitespaces, and was not possible to build it in such a situation. this commit adjusts the various makefiles/scripts to make it aware of that possibility, and now it builds successfully when using a path with whitespaces as well. Fixes #115. R=rsc, dsymonds1 https://golang.org/cl/157067
-
Sergio Luis O. B. Correia authored
getquoted() currently checks for whitespaces and returns nil if it finds one. this prevents us from having go in a path containing whitespaces, as the #pragma dynld directives are processed through the said function. this commit makes getquoted() accept whitespaces, and this is also needed for solving issue #115. R=rsc https://golang.org/cl/157066
-
- 23 Nov, 2009 7 commits
-
-
Russ Cox authored
fix a few paren insertion bugs in the printer too. R=gri, r CC=golang-dev https://golang.org/cl/157119
-
Vish Subramanian authored
I see a crash with the following stack trace: SIGSEGV: segmentation violation Faulting address: 0x44 PC=0x44e510 runtime·mapaccess2+0x18 /home/vish/go/src/pkg/runtime/hashmap.c:790 runtime·mapaccess2(0x0, 0x0) xml·*Parser·text+0x922 /home/vish/go/src/pkg/xml/xml.go:765 xml·*Parser·text(0xe44c9870, 0x7fa3, 0xffffffff, 0x7f00, 0x44b5c4, ...) xml·*Parser·RawToken+0x174 /home/vish/go/src/pkg/xml/xml.go:405 xml·*Parser·RawToken(0xe44c9870, 0x7fa3, 0x0, 0x0) xml·*Parser·Token+0x625 /home/vish/go/src/pkg/xml/xml.go:205 xml·*Parser·Token(0xe44c9870, 0x7fa3, 0x0, 0x0, 0x0, ...) xml·*Parser·Skip+0x27 /home/vish/go/src/pkg/xml/read.go:371 xml·*Parser·Skip(0xe44c9870, 0x7fa3, 0x8, 0x0) xml·*Parser·unmarshal+0xae6 /home/vish/go/src/pkg/xml/read.go:328 xml·*Parser·unmarshal(0xe44c9870, 0x7fa3, 0xe8127120, 0x7fa3, 0xdc94bc40, ...) xml·Unmarshal+0xda /home/vish/go/src/pkg/xml/read.go:121 xml·Unmarshal(0xe65724b0, 0x7fa3, 0xdc94bc00, 0x7fa3, 0x4bcfc0, ...) scraper·DoSearch+0x3d1 /home/vish/my-go-src/google3/experimental/users/vish/go_http/scraper.go:95 scraper·DoSearch(0xe7dc28c0, 0x7fa3, 0x33, 0x3, 0x6d2510, ...) main·scrapeQueries+0x202 /home/vish/my-go-src/google3/experimental/users/vish/go_http/scrape.go:251 main·scrapeQueries(0xe7da2600, 0x7fa3, 0x64, 0x1db0, 0xe7e10000, ...) goexit /home/vish/go/src/pkg/runtime/proc.c:135 goexit() 0x7fa3e7da2600 unknown pc Clearly xml.Parser is accessing an uninitialized map. Add a check for a nil map before accessing it. R=r, rsc https://golang.org/cl/159050
-
Russ Cox authored
R=r https://golang.org/cl/160044
-
Russ Cox authored
R=r CC=eds https://golang.org/cl/160045
-
Rob Pike authored
Fixes #308. R=rsc CC=golang-dev https://golang.org/cl/157142
-
Rob Pike authored
Fixes #315. R=rsc https://golang.org/cl/157140
-
Russ Cox authored
R=ken2 https://golang.org/cl/160043
-
- 21 Nov, 2009 1 commit
-
-
Adam Langley authored
R=rsc, agl CC=golang-dev https://golang.org/cl/157076
-
- 20 Nov, 2009 29 commits
-
-
Rob Pike authored
Fixes #113. R=gri, rsc CC=golang-dev https://golang.org/cl/159049
-
Russ Cox authored
a little slow, but usable (speed unchanged when not using -r) tweak go/printer to handle nodes without line numbers more gracefully in a couple cases. R=gri https://golang.org/cl/156103
-
William Josephson authored
R=rsc, dho https://golang.org/cl/157116
-
Russ Cox authored
except chameneosredux which i know is being edited require gofmt for test/bench R=r https://golang.org/cl/157110
-
Devon H. O'Dell authored
we can't use them interchangably. R=rsc, wjosephson CC=golang-dev https://golang.org/cl/156113
-
Robert Griesemer authored
Meant as illustration of the Go pattern that is using goroutines and channels to handle exceptional situations. Note: There is no need for "Finally" since the "try block" (the function f supplied to Try) cannot do a Smalltalk-style non-local return and terminate the function surrounding Try. Replaces CL 157083. R=r, rsc https://golang.org/cl/157087
-
Russ Cox authored
R=r, gri CC=golang-dev https://golang.org/cl/156115
-
Russ Cox authored
R=ken2 https://golang.org/cl/157114
-
Rob Pike authored
R=rsc https://golang.org/cl/159044
-
Russ Cox authored
what a terrible way to implement strings R=r https://golang.org/cl/156116
-
Rob Pike authored
in order of discovery. R=rsc https://golang.org/cl/157112
-
Rob Pike authored
fix %E: was same as %e. add tests. Fixes #278. R=rsc CC=golang-dev https://golang.org/cl/157111
-
Russ Cox authored
* add runtime sliceslice1 for x[lo:] * remove runtime arraytoslice, rewriting &arr into arr[0:len(arr)]. * port cgen_inline into 8g, 5g. * use native memmove in maps R=ken2 https://golang.org/cl/157106
-
Russ Cox authored
* reverse-complement: port C algorithm to Go saves 30% on my MacBook Pro and makes it a fairer comparison. * test reverse-complement with and without GC (another 15%) * revise timing.sh to work on more systems * avoid two glibcisms in fasta.c R=r https://golang.org/cl/156110
-
Russ Cox authored
R=r https://golang.org/cl/157103
-
Russ Cox authored
R=r https://golang.org/cl/157102
-
Rob Pike authored
simple regexps run 20x faster. the regex-dna benchmark goes 3x faster. R=rsc CC=golang-dev https://golang.org/cl/156108
-
Eden Li authored
fatal error. Fixes #126. R=rsc https://golang.org/cl/157101
-
Russ Cox authored
R=r https://golang.org/cl/156104
-
Russ Cox authored
once more with feeling. TBR=kaib https://golang.org/cl/157100
-
James Meneghello authored
Allows the developer to pass a map either by itself for evaluation, or inside a struct. Access to data inside maps is identical to the current system for structs, ie. -Psuedocode- mp map[string]string = { "header" : "A fantastic header!", "footer" : "A not-so-fantastic footer!", } template.Execute(mp) ...can be accessed using {header} and {footer} in the template. Similarly, for maps inside structs: type s struct { mp map[string]string, } s1 = new s s1.mp["header"] = "A fantastic header!"; template.Execute(s1) ...is accessed using {mp.header}. Multi-maps, ie. map[string](map[string]string) and maps of structs containing more maps are unsupported, but then, I'm not even sure if that's supported by the language. Map elements can be of any type that can be written by the formatters. Keys should really only be strings. Fixes #259. R=r, rsc https://golang.org/cl/157088
-
James Meneghello authored
R=rsc, r https://golang.org/cl/156106
-
Michael Hoisie authored
R=rsc CC=golang-dev https://golang.org/cl/157068
-
Michael Hoisie authored
R=rsc https://golang.org/cl/156081
-
Evan Shaw authored
There's no functional change here. io gives the Read and Write methods byte slice arguments, but tar called them uint8. It's the same thing, but I think this is clearer and it matches what other packages do. R=rsc CC=golang-dev https://golang.org/cl/157099
-
Russ Cox authored
Fixes #269. TBR=kaib https://golang.org/cl/156107
-
Russ Cox authored
Fixes #144. R=ken2 CC=agl1 https://golang.org/cl/156102
-
Rob Pike authored
1) if char class contains a single character, make it a single character. (this is used to quote, e.g. [.] rather than \. 2) if regexp begins with ordinary text substring, use plain string match to start engine R=rsc CC=golang-dev https://golang.org/cl/157095
-
Robert Griesemer authored
R=rsc https://golang.org/cl/157096
-