1. 18 Feb, 2016 1 commit
  2. 17 Feb, 2016 5 commits
  3. 16 Feb, 2016 8 commits
    • Ian Lance Taylor's avatar
      cmd/go: avoid race on test environment · aa22c42d
      Ian Lance Taylor authored
      Fixes #14337.
      
      Change-Id: I58aef7e08d936b0712da577dd1ce5c9ed5d8bfd2
      Reviewed-on: https://go-review.googlesource.com/19513Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      aa22c42d
    • Austin Clements's avatar
      runtime: fix deadlock in TestCrashDumpsAllThreads · 7c22af83
      Austin Clements authored
      TestCrashDumpsAllThreads carefully sets the number of Ps to one
      greater than the number of non-preemptible loops it starts so that the
      main goroutine can continue to run (necessary because of #10958).
      However, if GC starts, it can take over that one spare P and lock up
      the system while waiting for the non-preemptible loops, causing the
      test to eventually time out. This deadlock is easily reproducible if
      you run the runtime test with GOGC=1.
      
      Fix this by forcing GOGC=off when running this test.
      
      Change-Id: Ifb22da5ce33f9a61700a326ea92fcf4b049721d1
      Reviewed-on: https://go-review.googlesource.com/19516
      Run-TryBot: Austin Clements <austin@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      7c22af83
    • Russ Cox's avatar
      cmd/compile: print struct tags in var decl in inlined func body · feb2a5d6
      Russ Cox authored
      This bug was introduced in golang.org/cl/18217,
      while trying to fix #13777.
      
      Originally I wanted to just disable inlining for the case
      being handled incorrectly, but it's fairly difficult to detect
      and much easier just to fix. Since the case being handled
      incorrectly was inlined correctly in Go 1.5, not inlining it
      would also be somewhat of a regression.
      So just fix it.
      
      Test case copied from Ian's CL 19520.
      
      The mistake to worry about in this CL would be relaxing
      the condition too much (we now print the note more often
      than we did yesterday). To confirm that we'd catch this mistake,
      I checked that changing (!fmtbody || !t.Funarg) to (true) does
      cause fixedbugs/issue13777.go to fail. And putting it back
      to what is written in this CL makes that test pass again
      as well as the new fixedbugs/issue14331.go.
      So I believe that the new condition is correct for both constraints.
      
      Fixes #14331.
      
      Change-Id: I91f75a4d5d07c53af5caea1855c780d9874b8df6
      Reviewed-on: https://go-review.googlesource.com/19514
      Run-TryBot: Russ Cox <rsc@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      feb2a5d6
    • Alex Brainman's avatar
      net: make TestInterfaceAddrsWithNetsh more robust · e136cac4
      Alex Brainman authored
      TestInterfaceAddrsWithNetsh invokes Windows netsh command passing
      it a particular interface name. This approach somehow does not work
      on some computers (see issue for details). Change that to call netsh
      without specifying any interface name. This provides output for all
      interfaces available. So we can achieve same goal parsing this output.
      Also makes test faster because we only need to invoke netsh once.
      
      Fixes #14130.
      
      Change-Id: I7911692ca64e372af1e1f9d6acb718c67071de67
      Reviewed-on: https://go-review.googlesource.com/19441Reviewed-by: default avatarVolker Dobler <dr.volker.dobler@gmail.com>
      Run-TryBot: Russ Cox <rsc@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      e136cac4
    • Austin Clements's avatar
      runtime: show panics in traceback · 0c02bc00
      Austin Clements authored
      We used to include panic calls in tracebacks; however, when
      runtime.panic was renamed to runtime.gopanic in the conversion of the
      runtime to Go, we missed the special case in showframe that includes
      panic calls even though they're in package runtime.
      
      Fix the function name check in showframe (and, while we're here, fix
      the other check for "runtime.panic" in runtime/pprof). Since the
      "runtime.gopanic" name doesn't match what users call panic and hence
      isn't very user-friendly, make traceback rewrite it to just "panic".
      
      Updates #5832, #13857. Fixes #14315.
      
      Change-Id: I8059621b41ec043e63d5cfb4cbee479f47f64973
      Reviewed-on: https://go-review.googlesource.com/19492
      Run-TryBot: Austin Clements <austin@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      0c02bc00
    • Russ Cox's avatar
      doc: fix remaining TODOs in Go 1.6 release notes · 095c0e5c
      Russ Cox authored
      Fixes #14300.
      
      Change-Id: Idb6a300fe0e06fb8966cf06b55f9b252752a69a6
      Reviewed-on: https://go-review.googlesource.com/19459Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      Reviewed-by: default avatarMichael Hudson-Doyle <michael.hudson@canonical.com>
      Run-TryBot: Russ Cox <rsc@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      095c0e5c
    • Austin Clements's avatar
      doc: tweak Go 1.6 GC release notes · 62fad436
      Austin Clements authored
      Go 1.6 significantly improves pause times for large heaps, but it
      improves them in many other situations as well, such as when goroutine
      churn is high, allocation rate is high, or when there are many
      finalizers. Hence, make the statement about pause times a bit more
      general.
      
      Change-Id: Ic034b1c904c39dd1d966ee7fa96ca8bbb3614e53
      Reviewed-on: https://go-review.googlesource.com/19504Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      62fad436
    • Austin Clements's avatar
      doc: fix non-possessive "'s" · 18aefe9c
      Austin Clements authored
      Currently we use "Section's" as the plural of the debug/elf Section
      struct. Change this to "Sections" because it's not possessive and
      doesn't seem to fall in to any special cases were the apostrophe is
      acceptable.
      
      Change-Id: Id5d3abbd748502a67ead3f483182ee7729db94a2
      Reviewed-on: https://go-review.googlesource.com/19505Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      18aefe9c
  4. 13 Feb, 2016 2 commits
  5. 12 Feb, 2016 4 commits
  6. 11 Feb, 2016 1 commit
  7. 10 Feb, 2016 3 commits
  8. 09 Feb, 2016 5 commits
  9. 08 Feb, 2016 3 commits
  10. 07 Feb, 2016 1 commit
  11. 06 Feb, 2016 1 commit
    • Ian Lance Taylor's avatar
      net/http: deflake TestCloseNotifierPipelined · 54b4b946
      Ian Lance Taylor authored
      The test sends two HTTP/1.1 pipelined requests.  The first is
      completedly by the second, and as such triggers an immediate call to the
      CloseNotify channel.  The second calls the CloseNotify channel after the
      overall connection is closed.
      
      The test was passing fine on gc because the code would enter the select
      loop before running the handler, so the send on gotReq would always be
      seen first.  On gccgo the code would sometimes enter the select loop
      after the handler had already finished, meaning that the select could
      choose between gotReq and sawClose.  If it picked sawClose, it would
      never close the overall connection, and the httptest server would hang.
      The same hang could be induced with gc by adding a time.Sleep
      immediately before the select loop.
      
      Deflake the test by 1) don't close the overall connection until both
      requests have been seen; 2) don't exit the loop until both closes have
      been seen.
      
      Fixes #14231.
      
      Change-Id: I9d20c309125422ce60ac545f78bcfa337aec1c7d
      Reviewed-on: https://go-review.googlesource.com/19281Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      54b4b946
  12. 05 Feb, 2016 3 commits
  13. 04 Feb, 2016 3 commits