- 03 Nov, 2009 11 commits
-
-
Robert Griesemer authored
(which I uploaded at home and thus can't upload from here). CL 1018027 was reviewed. - added comments to scope.go - commented out some code that is not yet needed (and which showed up prominently in the documentation) R=rsc http://go/go-review/1017017
-
Robert Griesemer authored
- start new sections if a field/method declaration spans multiple lines; this avoids tabs from the previous line affecting the next field/method R=rsc http://go/go-review/1017015
-
Adam Langley authored
R=rsc, r CC=go-dev http://go/go-review/1016001
-
Robert Griesemer authored
(No visual change yet since the comments for exported code snippets - as shown on the pkg page - are not yet formatted using the standard comment intersperse mechanism in the printer. This is a TODO in the printer.) R=rsc http://go/go-review/1016031
-
Rob Pike authored
R=gri http://go/go-review/1017014
-
Robert Griesemer authored
- removed some underbars in section headings for better looks - various minor tweaks R=rsc http://go/go-review/1018026
-
Robert Griesemer authored
- nodes.go implements ast node formatting - printer.go implements the core printing functionality and public interface No code changes except for updating the import clauses and adding a top-level comment to nodes.go. R=rsc http://go/go-review/1016026
-
Rob Pike authored
also fix a error-printing bug in godoc. R=gri http://go/go-review/1016030
-
Russ Cox authored
added ReadFrom/WriteTo for packet protocols like UDP. simplified the net.Conn interface. added new net.PacketConn interface for packet protocols. implemented proper UDP listener. cleaned up LocalAddr/RemoteAddr methods - cache in netFD. threw away various unused methods. an interface change: introduced net.Addr as a network address interface, to avoid conversion of UDP host:port to string and back for every ReadFrom/WriteTo sequence. another interface change: since signature of Listener.Accept was changing anyway, dropped the middle return value, because it is available as c.RemoteAddr(). (the Accept signature predates the existence of that method.) Dial and Listen still accept strings, but the proto-specific versions DialTCP, ListenUDP, etc. take net.Addr instead. because the generic Dial didn't change and because no one calls Accept directly (only indirectly via the http server), very little code will be affected by these interface changes. design comments welcome. R=p CC=go-dev, r http://go/go-review/1018017
-
Adam Langley authored
Rather than drop everything into a single, huge review, I've included some simple bits of code here. R=rsc CC=go-dev http://go/go-review/1016029
-
Russ Cox authored
was 1153 kB now 247 kB R=r http://go/go-review/1018025
-
- 02 Nov, 2009 29 commits
-
-
Rob Pike authored
fix link in spec. R=rsc CC=go-dev http://go/go-review/1017013
-
Russ Cox authored
R=r CC=iant http://go/go-review/1018024
-
Ian Lance Taylor authored
tests are processed, and thus the run.out output. The default LANG on Fedora 10, en_US.utf8, causes the tests to be sorted differently--e.g., arrayindex1.go and arrayindex.go are sorted in the opposite order. R=r, rsc http://go/go-review/1018022
-
Rob Pike authored
fix up one usage to take advantage. R=rsc CC=go-dev http://go/go-review/1018023
-
Ian Lance Taylor authored
R=rsc, agl http://go/go-review/1016028
-
Adam Langley authored
Firstly, with -Werror, GCC switched to printing warnings starting with "error:". Widening the string matches solves this as the messages are otherwise unchanged. Secondly, GCC 4.4 outputs DWARF sections with with NUL bytes in all the offsets and requires the relocation section for .debug_info to be processed in order to result in valid DWARF data. Thus we add minimal handling for relocation sections, which is sufficient for our needs. BUG=1 Fixes #1. R=rsc, iant CC=go-dev http://go/go-review/1017003
-
Ian Lance Taylor authored
type. This is OK in a conversion but not in an assignment. R=rsc http://go/go-review/1016024
-
Rob Pike authored
R=rsc, gri CC=go-dev http://go/go-review/1016025
-
Russ Cox authored
rietveld does not like code reviews with subjects longer than 100 characters, so trim the line pulled out of the description to avoid the limit. R=r http://go/go-review/1016027
-
Rob Pike authored
R=rsc CC=go-dev http://go/go-review/1018021
-
Adam Langley authored
R=rsc CC=go-dev http://go/go-review/1018020
-
Russ Cox authored
R=ken@golang.org CC=r http://go/go-review/1018019
-
Ian Lance Taylor authored
runtime.go:19:10: error: reference to undefined identifier ‘runtime.printbool’ R=rsc http://go/go-review/1018018
-
Rob Pike authored
during initialization. R=rsc CC=go-dev http://go/go-review/1016023
-
Robert Griesemer authored
R=rsc http://go/go-review/1017012
-
Robert Griesemer authored
just a single directory - all pieces present but not well integrated - directory tree served at the moment under /tree R=rsc http://go/go-review/1018016
-
Robert Griesemer authored
(previously not shown in godoc) - simplify parsing of struct types (match code structure for parsing interface types) R=rsc, r http://go/go-review/1016019
-
Russ Cox authored
fix nil pointer check in 6g. was dereferencing after the ADD; dereference before instead. R=ken@golang.org CC=iant http://go/go-review/1016022
-
Rob Pike authored
left, like an assignment, like strcpy, etc. R=rsc CC=go-dev http://go/go-review/1016011
-
Rob Pike authored
R=rsc CC=go-dev http://go/go-review/1016018
-
Rob Pike authored
R=iant, rsc CC=go-dev http://go/go-review/1016015
-
Rob Pike authored
R=rsc CC=go-dev http://go/go-review/1016020
-
Rob Pike authored
R=rsc CC=go-dev http://go/go-review/1017007
-
Rob Pike authored
R=rsc CC=go-dev http://go/go-review/1017008
-
Rob Pike authored
R=rsc http://go/go-review/1018008
-
Rob Pike authored
also add a section about compiling programs because some found it surprising not to have one R=rsc CC=go-dev http://go/go-review/1018011
-
Russ Cox authored
R=r http://go/go-review/1016021
-
Ian Lance Taylor authored
(I should have tested the last change a bit more before submitting). R=rsc http://go/go-review/1017011
-
Ian Lance Taylor authored
to build 6g, 6l, etc. R=rsc CC=go-dev http://go/go-review/1018015
-