1. 05 Apr, 2019 5 commits
  2. 04 Apr, 2019 8 commits
    • Filippo Valsorda's avatar
      math/big: do not panic in Exp when y < 0 and x doesn't have an inverse · ead89568
      Filippo Valsorda authored
      If x does not have an inverse modulo m, and a negative exponent is used,
      return nil just like ModInverse does now.
      
      Change-Id: I8fa72f7a851e8cf77c5fab529ede88408740626f
      Reviewed-on: https://go-review.googlesource.com/c/go/+/170757
      Run-TryBot: Filippo Valsorda <filippo@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarRobert Griesemer <gri@golang.org>
      ead89568
    • Keith Randall's avatar
      syscall: don't use INODE64 for fdopendir on darwin/386 · a8e83d2f
      Keith Randall authored
      The INODE64 variant only exists on 64-bit.
      
      Fixes #31262
      
      Change-Id: I528277c9b3312fdb15463ccbea0d537ff300f4ae
      Reviewed-on: https://go-review.googlesource.com/c/go/+/170837
      Run-TryBot: Keith Randall <khr@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      a8e83d2f
    • Austin Clements's avatar
      runtime: ring buffer for binary debug logging · 3ebb1ad9
      Austin Clements authored
      This adds an internal runtime debug log. It uses per-M time-stamped
      ring buffers of binary log records. On panic, these buffers are
      collected, interleaved, and printed.
      
      The entry-point to the debug log is a new "dlog" function. dlog is
      designed so it can be used even from very constrained corners of the
      runtime such as signal handlers or inside the write barrier.
      
      The facility is only enabled if the debuglog build tag is set.
      Otherwise, it compiles away to a no-op implementation.
      
      The debug log format is also designed so it would be reasonable to
      decode from a core dump, though this hasn't been implemented.
      
      Change-Id: I6e2737c286358e97a0d8091826498070b95b66a3
      Reviewed-on: https://go-review.googlesource.com/c/go/+/157997
      Run-TryBot: Austin Clements <austin@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarMichael Knyszek <mknyszek@google.com>
      3ebb1ad9
    • grant's avatar
      net: use libSystem bindings for DNS resolution on macos if cgo is unavailable · f6b42a53
      grant authored
      This change adds directives to link the res_search function in libSystem.
      The corresponding Go function is then used in `lookup_darwin.go` for
      resolution when cgo is disabled. This makes DNS resolution logic more
      reliable as macOS has some unique quirks such as the `/etc/resolver/`
      directory for specifying nameservers.
      
      Fixes #12524
      
      Change-Id: I367263c4951383965b3ef6491196152f78e614b1
      GitHub-Last-Rev: 3c3ff6bfa7e4811f206f3b119a867c841a016e10
      GitHub-Pull-Request: golang/go#30686
      Reviewed-on: https://go-review.googlesource.com/c/go/+/166297
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarKeith Randall <khr@golang.org>
      f6b42a53
    • Than McIntosh's avatar
      math/bits: add gccgo-friendly code for compiler bootstrap · bead3586
      Than McIntosh authored
      When building as part of the bootstrap process, avoid
      use of "go:linkname" applied to variables, since this
      feature is ill-defined/unsupported for gccgo.
      
      Updates #30771.
      
      Change-Id: Id44d01b5c98d292702e5075674117518cb59e2d0
      Reviewed-on: https://go-review.googlesource.com/c/go/+/170737Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      bead3586
    • Richard Musiol's avatar
      cmd/compile: add saturating conversions on wasm · cf8cc7f6
      Richard Musiol authored
      This change adds the GOWASM option "satconv" to enable the generation
      of experimental saturating (non-trapping) float-to-int conversions.
      It improves the performance of the conversion by 42%.
      
      Previously the conversions had already been augmented with helper
      functions to have saturating behavior. Now Wasm.rules is always using
      the new operation names and wasm/ssa.go is falling back to the helpers
      if the feature is not enabled.
      
      The feature is in phase 4 of the WebAssembly proposal process:
      https://github.com/WebAssembly/meetings/blob/master/process/phases.md
      
      More information on the feature can be found at:
      https://github.com/WebAssembly/nontrapping-float-to-int-conversions/blob/master/proposals/nontrapping-float-to-int-conversion/Overview.md
      
      Change-Id: Ic6c3688017054ede804b02b6b0ffd4a02ef33ad7
      Reviewed-on: https://go-review.googlesource.com/c/go/+/170119Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
      Run-TryBot: Cherry Zhang <cherryyz@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      cf8cc7f6
    • Leo Antunes's avatar
      net: add KeepAlive field to ListenConfig · 1abf3aa5
      Leo Antunes authored
      This commit adds a KeepAlive field to ListenConfig and uses it
      analogously to Dialer.KeepAlive to set TCP KeepAlives per default on
      Accept()
      
      Fixes #23378
      
      Change-Id: I57eaf9508c979e7f0e2b8c5dd8e8901f6eb27fd6
      GitHub-Last-Rev: e9e035d53ee8aa3d899d12db08b293f599daecb6
      GitHub-Pull-Request: golang/go#31242
      Reviewed-on: https://go-review.googlesource.com/c/go/+/170678
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      1abf3aa5
    • Neven Sajko's avatar
      math/big: simplify shlVU_g and shrVU_g · 964fe4b8
      Neven Sajko authored
      Rewrote a few lines to be more idiomatic/less assembly-ish.
      
      Benchmarked with `go test -bench Float -tags math_big_pure_go`:
      
      name                  old time/op    new time/op    delta
      FloatString/100-8        751ns ± 0%     746ns ± 1%  -0.71%  (p=0.000 n=10+10)
      FloatString/1000-8      22.9µs ± 0%    22.9µs ± 0%    ~     (p=0.271 n=10+10)
      FloatString/10000-8     1.89ms ± 0%    1.89ms ± 0%    ~     (p=0.481 n=10+10)
      FloatString/100000-8     184ms ± 0%     184ms ± 0%    ~     (p=0.094 n=9+9)
      FloatAdd/10-8           56.4ns ± 1%    56.5ns ± 0%    ~     (p=0.170 n=9+9)
      FloatAdd/100-8          59.7ns ± 0%    59.3ns ± 0%  -0.70%  (p=0.000 n=8+9)
      FloatAdd/1000-8          101ns ± 0%      99ns ± 0%  -1.89%  (p=0.000 n=8+8)
      FloatAdd/10000-8         553ns ± 0%     536ns ± 0%  -3.00%  (p=0.000 n=9+10)
      FloatAdd/100000-8       4.94µs ± 0%    4.74µs ± 0%  -3.94%  (p=0.000 n=9+10)
      FloatSub/10-8           50.3ns ± 0%    50.5ns ± 0%  +0.52%  (p=0.000 n=8+8)
      FloatSub/100-8          52.0ns ± 0%    52.2ns ± 1%  +0.46%  (p=0.012 n=8+10)
      FloatSub/1000-8         77.9ns ± 0%    77.3ns ± 0%  -0.80%  (p=0.000 n=7+8)
      FloatSub/10000-8         371ns ± 0%     362ns ± 0%  -2.67%  (p=0.000 n=10+10)
      FloatSub/100000-8       3.20µs ± 0%    3.10µs ± 0%  -3.16%  (p=0.000 n=10+10)
      ParseFloatSmallExp-8    7.84µs ± 0%    7.82µs ± 0%  -0.17%  (p=0.037 n=9+9)
      ParseFloatLargeExp-8    29.3µs ± 1%    29.5µs ± 0%    ~     (p=0.059 n=9+8)
      FloatSqrt/64-8           516ns ± 0%     519ns ± 0%  +0.54%  (p=0.000 n=9+9)
      FloatSqrt/128-8         1.07µs ± 0%    1.07µs ± 0%    ~     (p=0.109 n=8+9)
      FloatSqrt/256-8         1.23µs ± 0%    1.23µs ± 0%  +0.50%  (p=0.000 n=9+9)
      FloatSqrt/1000-8        3.43µs ± 0%    3.44µs ± 0%  +0.53%  (p=0.000 n=9+8)
      FloatSqrt/10000-8       40.9µs ± 0%    40.7µs ± 0%  -0.39%  (p=0.000 n=9+8)
      FloatSqrt/100000-8      1.07ms ± 0%    1.07ms ± 0%  -0.10%  (p=0.017 n=10+9)
      FloatSqrt/1000000-8     89.3ms ± 0%    89.2ms ± 0%  -0.07%  (p=0.015 n=9+8)
      
      Change-Id: Ibf07c6142719d11bc7f329246957d87a9f3ba3d2
      GitHub-Last-Rev: 870a041ab7bb9c24be083114f53653a5f4eed611
      GitHub-Pull-Request: golang/go#31220
      Reviewed-on: https://go-review.googlesource.com/c/go/+/170449
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarRobert Griesemer <gri@golang.org>
      964fe4b8
  3. 03 Apr, 2019 17 commits
  4. 02 Apr, 2019 10 commits
    • Agniva De Sarker's avatar
      image/jpeg: reduce bound checks from idct and fdct · 64f22e4b
      Agniva De Sarker authored
      Before -
      $gotip build -gcflags="-d=ssa/check_bce/debug=1" fdct.go idct.go
      ./fdct.go:89:10: Found IsInBounds
      ./fdct.go:90:10: Found IsInBounds
      ./fdct.go:91:10: Found IsInBounds
      ./fdct.go:92:10: Found IsInBounds
      ./fdct.go:93:10: Found IsInBounds
      ./fdct.go:94:10: Found IsInBounds
      ./fdct.go:95:10: Found IsInBounds
      ./fdct.go:96:10: Found IsInBounds
      ./idct.go:77:9: Found IsInBounds
      ./idct.go:77:27: Found IsInBounds
      ./idct.go:77:45: Found IsInBounds
      ./idct.go:78:7: Found IsInBounds
      ./idct.go:78:25: Found IsInBounds
      ./idct.go:78:43: Found IsInBounds
      ./idct.go:78:61: Found IsInBounds
      ./idct.go:79:13: Found IsInBounds
      ./idct.go:92:13: Found IsInBounds
      ./idct.go:93:12: Found IsInBounds
      ./idct.go:94:12: Found IsInBounds
      ./idct.go:95:12: Found IsInBounds
      ./idct.go:97:12: Found IsInBounds
      ./idct.go:98:12: Found IsInBounds
      ./idct.go:99:12: Found IsInBounds
      
      After -
      $gotip build -gcflags="-d=ssa/check_bce/debug=1" fdct.go idct.go
      ./fdct.go:90:9: Found IsSliceInBounds
      ./idct.go:76:11: Found IsSliceInBounds
      ./idct.go:145:11: Found IsSliceInBounds
      
      name                 old time/op    new time/op    delta
      FDCT-4                 1.85µs ± 2%    1.74µs ± 1%  -5.95%  (p=0.000 n=10+10)
      IDCT-4                 1.94µs ± 2%    1.89µs ± 1%  -2.67%  (p=0.000 n=10+9)
      DecodeBaseline-4       1.45ms ± 2%    1.46ms ± 1%    ~     (p=0.156 n=9+10)
      DecodeProgressive-4    2.21ms ± 1%    2.21ms ± 1%    ~     (p=0.796 n=10+10)
      EncodeRGBA-4           24.9ms ± 1%    25.0ms ± 1%    ~     (p=0.075 n=10+10)
      EncodeYCbCr-4          26.1ms ± 1%    26.2ms ± 1%    ~     (p=0.573 n=8+10)
      
      name                 old speed      new speed      delta
      DecodeBaseline-4     42.5MB/s ± 2%  42.4MB/s ± 1%    ~     (p=0.162 n=9+10)
      DecodeProgressive-4  27.9MB/s ± 1%  27.9MB/s ± 1%    ~     (p=0.796 n=10+10)
      EncodeRGBA-4         49.4MB/s ± 1%  49.1MB/s ± 1%    ~     (p=0.066 n=10+10)
      EncodeYCbCr-4        35.3MB/s ± 1%  35.2MB/s ± 1%    ~     (p=0.586 n=8+10)
      
      name                 old alloc/op   new alloc/op   delta
      DecodeBaseline-4       63.0kB ± 0%    63.0kB ± 0%    ~     (all equal)
      DecodeProgressive-4     260kB ± 0%     260kB ± 0%    ~     (all equal)
      EncodeRGBA-4           4.40kB ± 0%    4.40kB ± 0%    ~     (all equal)
      EncodeYCbCr-4          4.40kB ± 0%    4.40kB ± 0%    ~     (all equal)
      
      name                 old allocs/op  new allocs/op  delta
      DecodeBaseline-4         5.00 ± 0%      5.00 ± 0%    ~     (all equal)
      DecodeProgressive-4      13.0 ± 0%      13.0 ± 0%    ~     (all equal)
      EncodeRGBA-4             4.00 ± 0%      4.00 ± 0%    ~     (all equal)
      EncodeYCbCr-4            4.00 ± 0%      4.00 ± 0%    ~     (all equal)
      
      Updates #24499
      
      Change-Id: I6828d077b851817503a7c1a08235763f81bdadf9
      Reviewed-on: https://go-review.googlesource.com/c/go/+/167417
      Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarNigel Tao <nigeltao@golang.org>
      64f22e4b
    • Ian Lance Taylor's avatar
      misc/cgo/testcarchive: skip TestSignalForwardingExternal on darwin/amd64 · 2da96591
      Ian Lance Taylor authored
      On darwin/amd64 the runtime method sigctxt.fixsigcode changes SIGSEGV
      signals so that they are never marked SI_USER. CL 169120 changed the
      signal handler to call fixsigcode even when the signal is delivered to
      a non-Go thread. This breaks TestSignalForwardingExternal, so skip it.
      
      Change-Id: I6740fb5a8f4f854ca69793537a983a696da3b495
      Reviewed-on: https://go-review.googlesource.com/c/go/+/170446
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      2da96591
    • Elias Naur's avatar
      runtime/cgo: look for android_get_device_api_level in libc.so · fc7ac2e8
      Elias Naur authored
      The presence of the android_get_device_api_level symbol is used to
      detect Android Q or later. Use the suggestion by Ryan Prichard and
      look for it in libc.so and not in the entire program where someone
      else might have defined it.
      
      Manually tested on an Android Q amd64 emulator and arm64 Pixel.
      
      Updates #29674
      
      Change-Id: Iaef35d8f8910037b3690aa21f319e216a05a9a73
      Reviewed-on: https://go-review.googlesource.com/c/go/+/170127
      Run-TryBot: Elias Naur <mail@eliasnaur.com>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      fc7ac2e8
    • Matthew Dempsky's avatar
      runtime/internal/atomic: fix wasm's StorepNoWB implementation · 814c97b3
      Matthew Dempsky authored
      Package unsafe's safety rules require that pointers converted to
      uintptr must be converted back to pointer-type before being stored
      into memory. In particular, storing a pointer into a non-pointer-typed
      expression does not guarantee the pointer stays valid, even if the
      expression refers to a pointer-typed variable.
      
      wasm's StorepNoWB implementation violates these rules by storing a
      pointer through a uintptr-typed expression.
      
      This happens to work today because esc.go is lenient in its
      implementation of package unsafe's rules, but my escape analysis
      rewrite follows them more rigorously, which causes val to be treated
      as a non-leaking parameter.
      
      This CL fixes the issue by using a *T-typed expression, where T is
      marked //go:notinheap so that the compiler still omits the write
      barrier as appropriate.
      
      Updates #23109.
      
      Change-Id: I49bc5474dbaa95729e5c93201493afe692591bc8
      Reviewed-on: https://go-review.googlesource.com/c/go/+/170323
      Run-TryBot: Matthew Dempsky <mdempsky@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
      814c97b3
    • Joel Sing's avatar
      crypto/tls: simplify intermediate certificate handling · 20389553
      Joel Sing authored
      The certificates argument to verifyServerCertificate must contain
      at least one certificate. Simplify the intermediate certificate
      handling code accordingly.
      
      Change-Id: I8292cdfb51f418e011d6d97f47d10b4e631aa932
      Reviewed-on: https://go-review.googlesource.com/c/go/+/169657Reviewed-by: default avatarFilippo Valsorda <filippo@golang.org>
      20389553
    • Bryan C. Mills's avatar
      cmd/go/internal/web2: make netrc parsing more robust · 2d683807
      Bryan C. Mills authored
      - Respect the NETRC environment variable if set.
      
      - Ignore lines that contain macro definitions.
      
      - Associate the 'machine' token with only the tokens that follow (not
        precede) it.
      
      Updates #29888
      Updates #26232
      
      Change-Id: I3128b7d6da2d6492df7c864e165eea1a27384f0f
      Reviewed-on: https://go-review.googlesource.com/c/go/+/161698
      Run-TryBot: Bryan C. Mills <bcmills@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarJay Conrod <jayconrod@google.com>
      2d683807
    • Matthew Dempsky's avatar
      cmd/compile: trim more unnecessary escape analysis messages · 131eb8fb
      Matthew Dempsky authored
      "leaking closure reference" is redundant for similar reasons as "&x
      escapes to heap" for OADDR nodes: the reference itself does not
      allocate, and we already report when the referenced variable is moved
      to heap.
      
      "mark escaped content" is redundant with "leaking param content".
      
      Updates #23109.
      
      Change-Id: I1ab599cb1e8434f1918dd80596a70cba7dc8a0cf
      Reviewed-on: https://go-review.googlesource.com/c/go/+/170321
      Run-TryBot: Matthew Dempsky <mdempsky@google.com>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      131eb8fb
    • Alessandro Arzilli's avatar
      compile,link: export package name in debug_info · e29f74ef
      Alessandro Arzilli authored
      Add a new custom attribute to compile units containing the package name
      of the package (i.e. the name after the 'package' keyword), so that
      debuggers can know it when it's different from the last segment
      of the package path.
      
      Change-Id: Ieadaab6f47091aabf2f4dc42c8524452eaa6715b
      Reviewed-on: https://go-review.googlesource.com/c/go/+/163677
      Run-TryBot: Alessandro Arzilli <alessandro.arzilli@gmail.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarHeschi Kreinick <heschi@google.com>
      e29f74ef
    • Matthew Dempsky's avatar
      cmd/compile: skip escape analysis diagnostics for OADDR · abefcac1
      Matthew Dempsky authored
      For most nodes (e.g., OPTRLIT, OMAKESLICE, OCONVIFACE), escape
      analysis prints "escapes to heap" or "does not escape" to indicate
      whether that node's allocation can be heap or stack allocated.
      
      These messages are also emitted for OADDR, even though OADDR does not
      actually allocate anything itself. Moreover, it's redundant because
      escape analysis already prints "moved to heap" diagnostics when an
      OADDR node like "&x" causes x to require heap allocation.
      
      Because OADDR nodes don't allocate memory, my escape analysis rewrite
      doesn't naturally emit the "escapes to heap" / "does not escape"
      diagnostics for them. It's also non-trivial to replicate the exact
      semantics esc.go uses for OADDR.
      
      Since there are so many of these messages, I'm disabling them in this
      CL by themselves. I modified esc.go to suppress the Warnl calls
      without any other behavior changes, and then used a shell script to
      automatically remove any ERROR messages mentioned by run.go in
      "missing error" or "no match for" lines.
      
      Fixes #16300.
      Updates #23109.
      
      Change-Id: I3993e2743c3ff83ccd0893f4e73b366ff8871a57
      Reviewed-on: https://go-review.googlesource.com/c/go/+/170319
      Run-TryBot: Matthew Dempsky <mdempsky@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
      Reviewed-by: default avatarDavid Chase <drchase@google.com>
      abefcac1
    • Mark Ryan's avatar
      cmd/asm: Fix EVEX RIP-relative addressing · 4ebc6514
      Mark Ryan authored
      AVX-512 instructions that use RIP-relative addressing and require the
      R bit of the EVEX prefix to be zero, i.e., instructions that use Z8-Z15 or
      Z24-Z31, are incorrectly encoded by the assembler.  The reason is that
      the location of the offset at which the relative address is to be written
      is incorrectly computed when the R bit is clear.
      
      For example,
      
      VMOVUPS bInitX<>+0(SB), Z0
      
      encodes correctly to
      
      62 f1 7c 48 10 05 66 e9 02 00
      
      whereas
      
      VMOVUPS bInitX<>+0(SB), Z8
      
      encodes incorrectly to
      
      62 71 7c 48 10 05 00 56 e9 02 00
      
      Note the extra zero byte between the ModR/M byte (05) and the relative
      address starting with 56.  This error results in the first byte of the
      following instruction being overwritten and typically, a program crash.
      
      This commit fixes the issue in the same way that is fixed for VEX encoded
      instructions, by simply not incrementing the offset for EVEX instructions.
      Existing test code created for a similar VEX encoding issue (19518) has
      been modified to also test for the issue addressed by this commit.
      
      Fixes #31001
      
      Change-Id: If84719ac22ebb5fb3c42ff96cd32b611ad497414
      Reviewed-on: https://go-review.googlesource.com/c/go/+/168562
      Run-TryBot: Ilya Tocar <ilya.tocar@intel.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIlya Tocar <ilya.tocar@intel.com>
      4ebc6514