Commits · cadbd3ea4986a43eebb1be3cacdce346513d537f · Kirill Smelkov / go

23 Dec, 2011 15 commits

exp/norm: fixed two unrelated bugs in normalization library. · cadbd3ea

Marcel van Lohuizen authored Dec 23, 2011

1) incorrect length given for out buffer in String.
2) patchTail bug that could cause characters to be lost
   when crossing into the out-buffer boundary.

Added tests to expose these bugs.  Also slightly improved
performance of Bytes() and String() by sharing the reorderBuffer
across operations.

Fixes #2567.

R=r
CC=golang-dev
https://golang.org/cl/5502069

cadbd3ea

net/rpc: trivial test cleanup · 335c5db7
Robert Hencke authored Dec 23, 2011
```
R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5498066
```
335c5db7

flag: add Duration flag type. · cf506f6e

David Symonds authored Dec 23, 2011

This works in the expected way: flag.Duration returns a *time.Duration,
and uses time.ParseDuration for parsing the input.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5489113

cf506f6e

time: add ParseDuration. · f298d0ce
David Symonds authored Dec 23, 2011
```
R=rsc, r, r
CC=golang-dev
https://golang.org/cl/5489111
```
f298d0ce
dashboard: fix todo caching nil · e6a322b0
Andrew Gerrand authored Dec 23, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5504082
```
e6a322b0
dashboard: cache packages, introduce caching helpers · 5a65cbac
Andrew Gerrand authored Dec 23, 2011
```
R=rsc, gary.burd, adg
CC=golang-dev
https://golang.org/cl/5498067
```
5a65cbac
tag weekly.2011-12-22 · 9c2e0b75
Andrew Gerrand authored Dec 23, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5504081
```
9c2e0b75

weekly.2011-12-22 · 1a06b513

Andrew Gerrand authored Dec 23, 2011

R=dsymonds, r, r, rsc, adg, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5498074

1a06b513

cmd/go: two testing fixes · eef71840

Russ Cox authored Dec 22, 2011

1. Show passing output for "go test" (no args) and with -v flag.
2. Warn about out-of-date packages being rebuilt.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5504080

eef71840

runtime: delete old asm_*.h if still around · 3800b140

Russ Cox authored Dec 22, 2011

Fixes bug Robert ran into.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5501070

3800b140

cmd/go: update "go help remote" to use correct Google Code urls · e8ae2958
Andrew Gerrand authored Dec 23, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5489114
```
e8ae2958
path/filepath: implement Base and Dir for windows · 5962ef2c
Alex Brainman authored Dec 23, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5501069
```
5962ef2c

dashboard: Don't highlight first heading row. · 0f14ebf9

David Symonds authored Dec 23, 2011

The two heading rows were previously a little hard to pick out,
because they were alternately shaded like the commit rows.

R=adg
CC=golang-dev
https://golang.org/cl/5500074

0f14ebf9

testing: add wrapper methods so the godoc output lists all methods · 416afcb4
Rob Pike authored Dec 22, 2011
```
To be deleted when godoc catches up.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5504079
```
416afcb4

html: Don't ignore whitespace in "after after frameset" mode. · 4a8ea4ae

Andrew Balholm authored Dec 23, 2011

Pass tests6.dat, test 46:
<html><frameset></frameset></html>

| <html>
|   <head>
|   <frameset>
|   " "

R=nigeltao
CC=golang-dev
https://golang.org/cl/5505065

4a8ea4ae

22 Dec, 2011 25 commits

partial build fix: add missing argument to NewPackageDoc · f927d9c1
Robert Griesemer authored Dec 22, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/5489112
```
f927d9c1
fix build: correct build scripts · fcd877ea
Robert Griesemer authored Dec 22, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/5498075
```
fcd877ea
fix build: updated build scripts · dea9f417
Robert Griesemer authored Dec 22, 2011
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/5504078
```
dea9f417

go/doc, godoc: move export filtering into go/doc · 198936f2

Robert Griesemer authored Dec 22, 2011

- exports.go contains a stripped-down (but semantically unchanged)
  version of the code in go/ast/filter.go for export filtering
- filter.go contains the documentation filtering code found before
  at the end of doc.go; this is simply a code move w/o any semantic
  changes
- godoc now relies on go/doc for export filtering when creating
  documentation. It still has a separate form of export filtering
  for showing the source code version. This needs to be consolidated
  (perhaps the source form view should just be removed?).
- Stripping of function bodies (stripFunctionBodies function of
  godoc.go) is now happening in doc.go (line 176).
- doc.NewPackageDoc has an extra parameter "exportsOnly. If set
  to false, the behavior is as before. This function is only called
  once in our source code; a gofix module is probably not warranted.
- Deleted doc.NewFileDoc - was never called.

This change is mostly a code move w/ some minimal tweaks. It should
not cause any changes to the behavior of godoc. It's a prerequisite
for extracting anonymous embedded fields.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5502072

198936f2

fmt: make the malloc test check its counts · 07db2522

Rob Pike authored Dec 22, 2011

Discover than %g is now down to 1 malloc from 2 from 4.
Have fun with funcs.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5504077

07db2522

go/build: (*Tree).BinDir should not return path with / in it on windows · 102c1a7c
Alex Brainman authored Dec 23, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5502064
```
102c1a7c

strconv: fix bug in extended-float based conversion. · 2afebbdf

Rémy Oudompheng authored Dec 22, 2011

A test intended for denormals erroneously returned true also for
infinities, leading to bad overflows and wrong error estimates.

R=rsc
CC=golang-dev, remy
https://golang.org/cl/5489091

2afebbdf

math/big: Rand shouldn't hang if argument is also receiver. · fc78c5aa
Robert Griesemer authored Dec 22, 2011
```
Fixes #2607.

R=rsc
CC=golang-dev
https://golang.org/cl/5489109
```
fc78c5aa

path: Dir · b6122b0a

Rob Pike authored Dec 22, 2011

There was Base but not Dir, so fill in the gap.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5504076

b6122b0a

go/doc: s/typeDoc/typeInfo/ · c0589a21

Robert Griesemer authored Dec 22, 2011

To avoid confusion between typeDoc and TypeDoc.
No semantic change.

R=r
CC=golang-dev
https://golang.org/cl/5502071

c0589a21

path/filepath: Dir · dd1a34bd

Rob Pike authored Dec 22, 2011

There was Base but not Dir, so fill in the gap.

R=n13m3y3r, r, rsc, gustavo
CC=golang-dev
https://golang.org/cl/5503067

dd1a34bd

doc: fix misspelt CSS properties. · ddf67af0
David Symonds authored Dec 23, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5498071
```
ddf67af0

go/doc, godoc: show methods of anonymous fields · 7ea92ddd

Robert Griesemer authored Dec 22, 2011

Missing: Handling of embedded interfaces.

Also, for reasons outlined in the previous CL (5500055), embedded
types have to be exported for its "inherited" methods to be visible.
This will be addressed w/ a subsequent CL.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5502059

7ea92ddd

testing: fix the fix to the wording about the bug · b1a287e3
Rob Pike authored Dec 22, 2011
```
TBR=rsc

R=rsc
CC=golang-dev
https://golang.org/cl/5498070
```
b1a287e3
testing: fix wording in explanation of potential bug · 34139ee1
Rob Pike authored Dec 22, 2011
```
TBR=rsc

R=rsc
CC=golang-dev
https://golang.org/cl/5504075
```
34139ee1

testing: make signalling safer for parallel tests · 66155134

Rob Pike authored Dec 22, 2011

Each test gets a private signal channel.
Also fix a bug that prevented parallel tests from running.

R=r, r
CC=golang-dev
https://golang.org/cl/5505061

66155134

testing: compare Log to Println · b5216e2e

Robert Hencke authored Dec 22, 2011

Log always adds spaces between operands, like Println but unlike Print

R=golang-dev
CC=golang-dev
https://golang.org/cl/5504069

b5216e2e

gc: better linenumbers for inlined functions · 86deacc0
Luuk van Dijk authored Dec 22, 2011
```
Fixes #2580 up to a point.

R=rsc
CC=golang-dev
https://golang.org/cl/5498068
```
86deacc0

exp/terminal: several cleanups · 7350c771

Adam Langley authored Dec 22, 2011

1) Add EscapeCodes to the terminal so that applications don't wire
   them in.
2) Add a callback for auto-complete
3) Fix an issue with input lines longer than the width of the
   terminal.
4) Have Write() not stomp the current line. It now erases the current
   input, writes the output and reprints the prompt and partial input.
5) Support prompting without local echo in Terminal.
6) Add GetSize to report the size of terminal.

R=bradfitz
CC=golang-dev
https://golang.org/cl/5479043

7350c771

syscall: make pipe work on netbsd · f1ebbf80
Joel Sing authored Dec 23, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5504070
```
f1ebbf80
os: update package location of exec to os/exec in comments · a626adce
Brad Fitzpatrick authored Dec 22, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5503065
```
a626adce

dashboard: horizontal crunch · 0b702937

Russ Cox authored Dec 22, 2011

* group builders in to columns by OS
* drop builder suffix (moved to hover title)
* cut all domain names from email (full name+email in hover title)
* make ok smaller

This should easily give us room for netbsd and plan9,
even on small laptop screens.

Running at http://build-rsc.golang.org/.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5501064

0b702937

dashboard: do not require key in source code · 550856c5

Russ Cox authored Dec 22, 2011

Or else eventually someone will check it in.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5504071

550856c5

cmd/go: fix windows build · 98fe44bd

Mikio Hara authored Dec 23, 2011

R=golang-dev, alex.brainman, rsc
CC=golang-dev
https://golang.org/cl/5502066

98fe44bd

cmd/gc: make sure use of pthread for gcc-4.5 and beyond · e636f6f5
Mikio Hara authored Dec 22, 2011
```
R=golang-dev, rsc, n13m3y3r, rogpeppe
CC=golang-dev
https://golang.org/cl/5501060
```
e636f6f5