Commits · cbbc6a102d5e7e5e2bb685a0c661d1f731c88344 · Kirill Smelkov / go

06 Jan, 2013 2 commits

cmd/5l, cmd/6l, cmd/8l, cmd/cc, cmd/gc: new flag parsing · cbbc6a10

Russ Cox authored Jan 06, 2013

This CL adds a flag parser that matches the semantics of Go's
package flag. It also changes the linkers and compilers to use
the new flag parser.

Command lines that used to work, like
        8c -FVw
        6c -Dfoo
        5g -I/foo/bar
now need to be split into separate arguments:
        8c -F -V -w
        6c -D foo
        5g -I /foo/bar
The new spacing will work with both old and new tools.

The new parser also allows = for arguments, as in
        6c -D=foo
        5g -I=/foo/bar
but that syntax will not work with the old tools.

In addition to matching standard Go binary flag parsing,
the new flag parser generates more detailed usage messages
and opens the door to long flag names.

The recently added gc flag -= has been renamed -complete.

R=remyoudompheng, daniel.morsing, minux.ma, iant
CC=golang-dev
https://golang.org/cl/7035043

cbbc6a10

cmd/ld: move symtab, ELF generation to portable code · d37c572a

Russ Cox authored Jan 06, 2013

More cleanup in preparation for fixing issue 4069.

This CL replaces the three nearly identical copies of the
asmb ELF code with a single asmbelf function in elf.c.

In addition to the ELF code movement, remove the elfstr
array in favor of a simpler lookup, and identify sections by
name throughout instead of computing fragile indices.

The CL also replaces the three nearly identical copies of the
genasmsym code with a single genasmsym function in lib.c.

The ARM linker still compiles and generates binaries,
but I haven't tested the binaries. They may not work.

R=ken2
CC=golang-dev
https://golang.org/cl/7062047

d37c572a

05 Jan, 2013 1 commit
- cmd/go: avoid leaking timer if test process failed to start · b006cd9b
  Dave Cheney authored Jan 05, 2013
```
R=rsc
CC=golang-dev
https://golang.org/cl/7034047
```
  b006cd9b
04 Jan, 2013 7 commits

cmd/ld: use native-endian symbol values in symbol table · 4e2aa9bf

Russ Cox authored Jan 04, 2013

The Plan 9 symbol table format defines big-endian symbol values
for portability, but we want to be able to generate an ELF object file
and let the host linker link it, as part of the solution to issue 4069.
The symbol table itself, since it is loaded into memory at run time,
must be filled in by the final host linker, using relocation directives
to set the symbol values. On a little-endian machine, the linker will
only fill in little-endian values during relocation, so we are forced
to use little-endian symbol values.

To preserve most of the original portability of the symbol table
format, we make the table itself say whether it uses big- or
little-endian values. If the table begins with the magic sequence
        fe ff ff ff 00 00
then the actual table begins after those six bytes and contains
little-endian symbol values. Otherwise, the table is in the original
format and contains big-endian symbol values. The magic sequence
looks like an "end of table" entry (the fifth byte is zero), so legacy
readers will see a little-endian table as an empty table.

All the gc architectures are little-endian today, so the practical
effect of this CL is to make all the generated tables little-endian,
but if a big-endian system comes along, ld will not generate
the magic sequence, and the various readers will fall back to the
original big-endian interpretation.

R=ken2
CC=golang-dev
https://golang.org/cl/7066043

4e2aa9bf

cmd/5g, cmd/6g, cmd/8g: flush return parameters in case of panic. · f1e4ee3f
Daniel Morsing authored Jan 04, 2013
```
Fixes #4066.

R=rsc, minux.ma
CC=golang-dev
https://golang.org/cl/7040044
```
f1e4ee3f

cmd/5g, cmd/5l, cmd/ld: Small adjustments for the Plan 9 native tools · 62dfa9c4

Lucio De Re authored Jan 04, 2013

A few USED(xxx) additions and a couple of deletions of variable
initialisations that go unused.  One questionable correction,
mirrored in 8l/asm.c, where the result of invocation of a function
shouldn't be used.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6736054

62dfa9c4

cmd/dist: sse auto-detect · a4e08183

Russ Cox authored Jan 04, 2013

R=golang-dev, dsymonds, minux.ma, iant, alex.brainman
CC=golang-dev
https://golang.org/cl/7035055

a4e08183

runtime: always incorporate hash seed at start of hash computation · 63bee953

Ian Lance Taylor authored Jan 04, 2013

Otherwise we can get predictable collisions.

R=golang-dev, dave, patrick, rsc
CC=golang-dev
https://golang.org/cl/7051043

63bee953

log/syslog: remove RFC5424 version number for greater compatibility · c0964989

John Graham-Cumming authored Jan 04, 2013

RFC5424 specifies a version number (currently 1) after the facility and
severity in a syslog message (e.g. <7>1 TIMESTAMP ...).  This causes
rsyslog to fail to parse syslog message because the rest of the message
is not fully compliant with RFC5424.

For the widest compatibility, drop the version (messages are in the
RFC3164 BSD syslog format (e.g. <7>TIMESTAMP ...). Have tested this with
syslog-ng, rsyslog and syslogd.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7036050

c0964989

runtime: introduce typedefs and delete struct keywords in mgc0.c · 89ec208e
Jan Ziak authored Jan 04, 2013
```
R=rsc
CC=golang-dev
https://golang.org/cl/7029055
```
89ec208e

03 Jan, 2013 5 commits

net/http: Sync TimeoutHandler godoc with code. · 98edf09e

Matthew Dempsky authored Jan 03, 2013

TimeoutHandler was changed from "ns int64" to "dt time.Duration" on
Nov 30, 2011, but the godoc still refers to "ns".

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7031050

98edf09e

CONTRIBUTORS: add Matthew Dempsky (Google CLA) · 17eafcd0
Ian Lance Taylor authored Jan 03, 2013
```
R=golang-dev, agl
CC=golang-dev
https://golang.org/cl/7049043
```
17eafcd0

go/types: add more logging to gc import test · 14b65436

Dave Cheney authored Jan 03, 2013

* Extended deadline to 30 seconds
* Added logging of the duration of each package import
* Fail the test immediately if directories cannot be read

R=gri, minux.ma
CC=golang-dev
https://golang.org/cl/7030055

14b65436

net: fix docs for type IP: s/array/slice/. · 699b99fa
Nigel Tao authored Jan 03, 2013
```
R=rsc
CC=golang-dev
https://golang.org/cl/6930047
```
699b99fa

spec: clarify language about unary operator & · 614b02d2

Robert Griesemer authored Jan 02, 2013

A composite literal may be parenthesized when
used as operand for the unary operator &.

R=rsc, iant, r, ken
CC=golang-dev
https://golang.org/cl/6996053

614b02d2

02 Jan, 2013 18 commits

cmd/8g: extend elimination of temporaries to SSE2 code. · cf77dd37

Rémy Oudompheng authored Jan 03, 2013

Before:
(erf.go:188)    TEXT     Erf+0(SB),$220
(erf.go:265)    TEXT     Erfc+0(SB),$204
(lgamma.go:174) TEXT     Lgamma+0(SB),$948

After:
(erf.go:188)    TEXT     Erf+0(SB),$84
(erf.go:265)    TEXT     Erfc+0(SB),$84
(lgamma.go:174) TEXT     Lgamma+0(SB),$44

SSE before vs. SSE after:

benchmark             old ns/op    new ns/op    delta
BenchmarkAcosh               81           49  -39.14%
BenchmarkAsinh              109          109   +0.00%
BenchmarkAtanh               73           74   +0.68%
BenchmarkLgamma             138           42  -69.20%
BenchmarkModf                24           15  -36.95%
BenchmarkSqrtGo             565          556   -1.59%

R=rsc
CC=golang-dev
https://golang.org/cl/7028048

cf77dd37

cmd/dist: use separate args for separate compiler flags · 5e46d540

Russ Cox authored Jan 02, 2013

This makes dist safe for CL 7035043 (but keeps working now too).

R=golang-dev, remyoudompheng
CC=golang-dev
https://golang.org/cl/7029047

5e46d540

net/http: make NewRequest pick a ContentLength from a *bytes.Reader too · 5e8ca201

Brad Fitzpatrick authored Jan 02, 2013

It already did so for its sibling, *strings.Reader, as well as *bytes.Buffer.

R=edsrzf, dave, adg, kevlar, remyoudompheng, adg, rsc
CC=golang-dev
https://golang.org/cl/7031045

5e8ca201

encoding/json: don't panic marshaling anonymous non-struct field · cdec0850

Thomas Kappler authored Jan 02, 2013

Add a check for this case and don't try to follow the anonymous
type's non-existent fields.

Fixes #4474.

R=rsc
CC=golang-dev
https://golang.org/cl/6945065

cdec0850

A+C: Thomas Kappler (individual CLA) · a29702f0
Russ Cox authored Jan 02, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/7038049
```
a29702f0

net/http: document Request.URL · 948f0b7a

Rick Arnold authored Jan 02, 2013

Request.URL had no documentation before and some people were expecting all fields to be populated.

Fixes #3805.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7008046

948f0b7a

cmd/8g: fix possibly uninitialized variable in foptoas. · 15f2c01f
Rémy Oudompheng authored Jan 02, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7045043
```
15f2c01f

cmd/dist, cmd/8g: implement GO386=387/sse to choose FPU flavour. · 9afb34b4

Rémy Oudompheng authored Jan 02, 2013

A new environment variable GO386 is introduced to choose between
code generation targeting 387 or SSE2. No auto-detection is
performed and the setting defaults to 387 to preserve previous
behaviour.

The patch is a reorganization of CL6549052 by rsc.

Fixes #3912.

R=minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6962043

9afb34b4

sync/atomic: document that users must deal with 64-bit alignment · 64a0017d
Russ Cox authored Jan 02, 2013
```
Update #599.

R=dvyukov, iant, minux.ma
CC=golang-dev
https://golang.org/cl/7001056
```
64a0017d

cmd/gc: mark wrapper methods for unnamed types as DUPOK. · 20c76f7f

Rémy Oudompheng authored Jan 02, 2013

Unnamed types like structs with embedded fields can have methods.
These methods are generated on-the-fly by the compiler and
it may happen for identical types in different packages.
The linker must accept these multiple definitions.

Fixes #4590.

R=golang-dev, rsc
CC=golang-dev, remy
https://golang.org/cl/7030051

20c76f7f

cmd/gc: make redeclaration between import and func less confusing · ae2131ab
Russ Cox authored Jan 02, 2013
```
Fixes #4510.

R=ken2
CC=golang-dev
https://golang.org/cl/7001054
```
ae2131ab

test/run: handle compiledir and errorcheckdir with multi-file packages · 8850d14f

Russ Cox authored Jan 02, 2013

Multiple files with the same package all get compiled together.

R=golang-dev, iant, dave
CC=golang-dev
https://golang.org/cl/7005053

8850d14f

api: add go/types to next.txt · 7ced3f12
Russ Cox authored Jan 02, 2013
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/7035045
```
7ced3f12

go/types: remove most remaining uses of ast.Object from exported API · a846d479

Robert Griesemer authored Jan 02, 2013

Also: Return first error whether an error handler is set in the
      context or not (bug fix).

R=adonovan
CC=golang-dev
https://golang.org/cl/7024043

a846d479

doc: add race detector manual · b2e9ca7f

Dmitriy Vyukov authored Jan 02, 2013

R=minux.ma, franciscossouza, rsc, adg, adg
CC=golang-dev
https://golang.org/cl/6948043

b2e9ca7f

doc: update standard copyright header · d5d046e3
Andrew Gerrand authored Jan 02, 2013
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/7034044
```
d5d046e3
A+C: Kamil Kisiel (individual CLA) · 53d3bbcb
Andrew Gerrand authored Jan 02, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/7038046
```
53d3bbcb
cmd/godoc: ignore misnamed examples and print a warning · 267a5539
Kamil Kisiel authored Jan 02, 2013
```
Fixes #4211.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6970051
```
267a5539

01 Jan, 2013 2 commits

runtime: fix freebsd/arm instruction cache flush · c2d2bfcc

Dave Cheney authored Jan 01, 2013

sysarch requires arguments to be passed on the stack, not in registers.

Credit to Shenghou Ma (minux) for the fix.

R=minux.ma, devon.odell
CC=golang-dev
https://golang.org/cl/7037043

c2d2bfcc

go/build: disable cgo on freebsd/arm · 52dc13b5

Dave Cheney authored Jan 01, 2013

Under FreeBSD-CURRENT on arm, cgo enabled binaries segfault. Disable cgo support for the moment so we can have a freebsd/arm builder on the dashboard.

R=minux.ma, rsc, iant
CC=golang-dev
https://golang.org/cl/7031044

52dc13b5

30 Dec, 2012 3 commits
- cmd/gc: do not generate code for var _ = ... unless necessary · 6592456f
  Russ Cox authored Dec 30, 2012
```
Fixes #2443.

R=ken2
CC=golang-dev
https://golang.org/cl/6997048
```
  6592456f
- encoding/json: encode map key is of string kind, decode only of string type · a4600126
  Ryan Slade authored Dec 30, 2012
```
Allows encoding and decoding of maps with key of string kind, not just string type.
Fixes #3519.

R=rsc, dave
CC=golang-dev
https://golang.org/cl/6943047
```
  a4600126
- runtime: say 'fatal error' instead of 'throw' · a22389ec
  Russ Cox authored Dec 29, 2012
```
Fixes #4597.

R=ken2
CC=golang-dev
https://golang.org/cl/7032043
```
  a22389ec
29 Dec, 2012 2 commits

cmd/dist: use -pipe during bootstrap · 0c6beb00
Dave Cheney authored Dec 30, 2012
```
R=golang-dev, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/7025044
```
0c6beb00

runtime: handle locked mmap failure on Linux · e786829e

Sébastien Paolacci authored Dec 29, 2012

Used to then die on a nil pointer situation. Most Linux standard setups are rather
restrictive regarding the default amount of lockable memory.

R=minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6997049

e786829e