- 20 Jun, 2014 2 commits
-
-
Dmitriy Vyukov authored
Afterprologue check was required when did not know about return arguments of functions and/or they were not zeroed. Now 100% precision is required for stacks due to stack copying, so it must work w/o afterprologue one way or another. I can limit this change for 1.3 to merely adding a TODO, but this check is super confusing so I don't want this knowledge to get lost. LGTM=rsc R=golang-codereviews, gobot, rsc, khr CC=golang-codereviews, khr, rsc https://golang.org/cl/96580045
-
Rui Ueyama authored
LGTM=dave R=golang-codereviews, bradfitz, dave CC=golang-codereviews https://golang.org/cl/109090048
-
- 19 Jun, 2014 8 commits
-
-
Rui Ueyama authored
Avoid unnecessary bitwise-OR operations. benchmark old MB/s new MB/s speedup BenchmarkEncodeToStringBase64 179.02 205.74 1.15x BenchmarkEncodeToStringBase32 155.86 167.82 1.08x LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/109090043
-
Rui Ueyama authored
Use WriteString instead of allocating a byte slice as a buffer. This was a TODO. benchmark old ns/op new ns/op delta BenchmarkWriteString 40139 19991 -50.20% LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/107190044
-
Bill Thiede authored
Fixes #8201. LGTM=nigeltao R=nigeltao CC=golang-codereviews https://golang.org/cl/105990046
-
Caleb Spare authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/102830043
-
Nigel Tao authored
requires a decoder to do its own byte buffering instead of using bufio.Reader, due to byte stuffing. benchmark old MB/s new MB/s speedup BenchmarkDecodeBaseline 33.40 50.65 1.52x BenchmarkDecodeProgressive 24.34 31.92 1.31x On 6g, unsafe.Sizeof(huffman{}) falls from 4872 to 964 bytes, and the decoder struct contains 8 of those. LGTM=r R=r, nightlyone CC=bradfitz, couchmoney, golang-codereviews, raph https://golang.org/cl/109050045
-
Andrew Gerrand authored
LGTM=minux R=golang-codereviews, minux CC=golang-codereviews https://golang.org/cl/107200043
-
Andrew Gerrand authored
This is a clone of 101370043, which I accidentally applied to the release branch first. No big deal, it needed to be applied there anyway. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/108090043
-
ChaiShushan authored
Fixes #7694. LGTM=nigeltao, rsc, r R=golang-codereviews, nigeltao, rsc, r CC=golang-codereviews https://golang.org/cl/109000049
-
- 18 Jun, 2014 6 commits
-
-
Rui Ueyama authored
Storing temporary values to a slice is slower than storing them to local variables of type byte. benchmark old MB/s new MB/s speedup BenchmarkEncodeToStringBase32 102.21 156.66 1.53x BenchmarkEncodeToStringBase64 124.25 177.91 1.43x LGTM=crawshaw R=golang-codereviews, crawshaw, bradfitz, dave CC=golang-codereviews https://golang.org/cl/109820045
-
Robert Dinu authored
Fixes #8175. LGTM=r R=golang-codereviews, r, gobot CC=golang-codereviews https://golang.org/cl/103320043
-
Rob Pike authored
Just to be more thorough. No need to push this to 1.3; it's just a test change that worked without any changes to the code being tested. LGTM=crawshaw R=golang-codereviews, crawshaw CC=golang-codereviews https://golang.org/cl/109080045
-
David Symonds authored
LGTM=bradfitz R=adg, rsc, bradfitz CC=golang-codereviews https://golang.org/cl/102470045
-
Rui Ueyama authored
genericReplacer.lookup is called for each byte of an input string. In many (most?) cases, lookup will fail for the first byte, and it will return immediately. Adding a fast path for that case seems worth it. Benchmark on my Xeon 3.5GHz Linux box: benchmark old ns/op new ns/op delta BenchmarkGenericNoMatch 2691 774 -71.24% BenchmarkGenericMatch1 7920 8151 +2.92% BenchmarkGenericMatch2 52336 39927 -23.71% BenchmarkSingleMaxSkipping 1575 1575 +0.00% BenchmarkSingleLongSuffixFail 1429 1429 +0.00% BenchmarkSingleMatch 56228 55444 -1.39% BenchmarkByteByteNoMatch 568 568 +0.00% BenchmarkByteByteMatch 977 972 -0.51% BenchmarkByteStringMatch 1669 1687 +1.08% BenchmarkHTMLEscapeNew 422 422 +0.00% BenchmarkHTMLEscapeOld 692 670 -3.18% BenchmarkByteByteReplaces 8492 8474 -0.21% BenchmarkByteByteMap 2817 2808 -0.32% LGTM=rsc R=golang-codereviews, bradfitz, dave, rsc CC=golang-codereviews https://golang.org/cl/79200044
-
Keith Randall authored
Make assembly govet-clean. Clean up fixes for CL 93380044. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/107160047
-
- 17 Jun, 2014 15 commits
-
-
Rob Pike authored
Bug was introduced recently. Add more tests, fix the bugs. Suppress + sign when not required in zero padding. Do not zero pad infinities. All old tests still pass. This time for sure! Fixes #8217. LGTM=rsc R=golang-codereviews, dan.kortschak, rsc CC=golang-codereviews https://golang.org/cl/103480043
-
Dominik Honnef authored
LGTM=adonovan R=adonovan, ruiu CC=golang-codereviews https://golang.org/cl/107160048
-
Dominik Honnef authored
Using flet to replace kill-region with delete-region was a hack, flet is now (GNU Emacs 24.3) deprecated and at least two people have reported an issue where using go--delete-whole-line would permanently break their kill ring. While that issue is probably caused by faulty third party code (possibly prelude), it's easier to write a clean implementation than to tweak the hack. LGTM=ruiu, adonovan R=adonovan, ruiu CC=adg, golang-codereviews https://golang.org/cl/106010043
-
Robert Griesemer authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/105300044
-
Keith Randall authored
Null terminate string. Make it endian-agnostic. TBR=bradfitz R=golang-codereviews CC=golang-codereviews https://golang.org/cl/106060044
-
Josh Bleecher Snyder authored
No functional changes. Generating shorter functions improves compilation time. On my laptop, this test's running time goes from 5.5s to 1.5s; the wall clock time to run all tests goes down 1s. On Raspberry Pi, this CL cuts 50s off the wall clock time to run all tests. Fixes #7503. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/72590045
-
Robert Griesemer authored
Fixes #8207. LGTM=gordon.klaus, bradfitz R=golang-codereviews, wandakkelly, gordon.klaus, bradfitz CC=golang-codereviews https://golang.org/cl/106010046
-
Keith Randall authored
The go:nosplit change wasn't the problem, reinstating. ««« original CL description undo CL 93380044 / 7f0999348917 Partial undo, just of go:nosplit annotation. Somehow it is breaking the windows builders. TBR=bradfitz ««« original CL description runtime: implement string ops in Go Also implement go:nosplit annotation. Not really needed for now, but we'll definitely need it for other conversions. benchmark old ns/op new ns/op delta BenchmarkRuneIterate 534 474 -11.24% BenchmarkRuneIterate2 535 470 -12.15% LGTM=bradfitz R=golang-codereviews, dave, bradfitz, minux CC=golang-codereviews https://golang.org/cl/93380044 »»» TBR=bradfitz CC=golang-codereviews https://golang.org/cl/105260044 »»» TBR=bradfitz R=bradfitz, golang-codereviews CC=golang-codereviews https://golang.org/cl/103490043
-
Keith Randall authored
TBR=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/105280045
-
Keith Randall authored
Fixes windows builds (hopefully). LGTM=bradfitz R=golang-codereviews, bradfitz, alex.brainman CC=golang-codereviews https://golang.org/cl/103470045
-
Keith Randall authored
Partial undo, just of go:nosplit annotation. Somehow it is breaking the windows builders. TBR=bradfitz ««« original CL description runtime: implement string ops in Go Also implement go:nosplit annotation. Not really needed for now, but we'll definitely need it for other conversions. benchmark old ns/op new ns/op delta BenchmarkRuneIterate 534 474 -11.24% BenchmarkRuneIterate2 535 470 -12.15% LGTM=bradfitz R=golang-codereviews, dave, bradfitz, minux CC=golang-codereviews https://golang.org/cl/93380044 »»» TBR=bradfitz CC=golang-codereviews https://golang.org/cl/105260044
-
Shenghou Ma authored
LGTM=bradfitz R=rsc, iant CC=golang-codereviews https://golang.org/cl/107160046
-
Keith Randall authored
Also implement go:nosplit annotation. Not really needed for now, but we'll definitely need it for other conversions. benchmark old ns/op new ns/op delta BenchmarkRuneIterate 534 474 -11.24% BenchmarkRuneIterate2 535 470 -12.15% LGTM=bradfitz R=golang-codereviews, dave, bradfitz, minux CC=golang-codereviews https://golang.org/cl/93380044
-
Keith Randall authored
BenchmarkCompareStringEqual 10.4 7.33 -29.52% BenchmarkCompareStringIdentical 3.99 3.67 -8.02% BenchmarkCompareStringSameLength 9.80 6.84 -30.20% BenchmarkCompareStringDifferentLength 1.09 0.95 -12.84% BenchmarkCompareStringBigUnaligned 75220 76071 +1.13% BenchmarkCompareStringBig 69843 74746 +7.02% LGTM=bradfitz, josharian R=golang-codereviews, bradfitz, josharian, dave, khr CC=golang-codereviews https://golang.org/cl/105280044
-
Rui Ueyama authored
We don't need to shift array elements to shuffle them. We just have to swap a selected element with 0th element. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/91750044
-
- 16 Jun, 2014 3 commits
-
-
Robert Griesemer authored
LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/108030044
-
Matthew Dempsky authored
LGTM=r R=golang-codereviews, bradfitz, r CC=golang-codereviews https://golang.org/cl/109020043
-
Rob Pike authored
Printf("%x", "abc") was "0x610x620x63"; is now "0x616263", which is surely better. Printf("% #x", "abc") is still "0x61 0x62 0x63". Fixes #8080. LGTM=bradfitz, gri R=golang-codereviews, bradfitz, gri CC=golang-codereviews https://golang.org/cl/106990043
-
- 14 Jun, 2014 3 commits
-
-
Alex Brainman authored
Fixes build. LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/105140047
-
Alan Shreve authored
Also added a test to verify os.Getppid() works across all platforms LGTM=alex.brainman R=golang-codereviews, alex.brainman, shreveal, iant CC=golang-codereviews https://golang.org/cl/102320044
-
Ian Lance Taylor authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/102410044
-
- 13 Jun, 2014 3 commits
-
-
Ian Lance Taylor authored
Reportedly in the Linux 3.16 kernel the VDSO will not have section headers or a normal symbol table. Too late for 1.3 but perhaps for 1.3.1, if there is one. Fixes #8197. LGTM=rsc R=golang-codereviews, mattn.jp, rsc CC=golang-codereviews https://golang.org/cl/101260044
-
Nigel Tao authored
algorithm. See https://golang.org/cl/105750045/ for an implementation of TIFF's LZW. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/102940043
-
Nigel Tao authored
bufio.Scanner.Scan returns whether the scan succeeded, not whether it is done, so the test was mistakenly breaking early. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/93670045
-