1. 17 Jul, 2014 4 commits
    • Michael Fraenkel's avatar
      os: Implement symlink support for Windows · cf521ce6
      Michael Fraenkel authored
      Fixes #5750.
      
      https://code.google.com/p/go/issues/detail?id=5750
      
      os: Separate windows from posix. Implement windows support.
      path/filepath: Use the same implementation as other platforms
      syscall: Add/rework new APIs for Windows
      
      LGTM=alex.brainman
      R=golang-codereviews, alex.brainman, gobot, rsc, minux
      CC=golang-codereviews
      https://golang.org/cl/86160044
      cf521ce6
    • Shenghou Ma's avatar
      A+C: snyh (individual CLA) · 47fd6bd9
      Shenghou Ma authored
      Generated by a+c.
      
      R=gobot
      CC=golang-codereviews
      https://golang.org/cl/114890043
      47fd6bd9
    • Keith Randall's avatar
      runtime: align gomemeq return value correctly · 5035750f
      Keith Randall authored
      Fixes #8378
      
      LGTM=bradfitz
      R=golang-codereviews, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/114880043
      5035750f
    • Cristian Staretu's avatar
      archive/tar: fix writing of pax headers · 7a9e7c0a
      Cristian Staretu authored
      "archive/tar: reuse temporary buffer in writeHeader" introduced a
      change which was supposed to help lower the number of allocations from
      512 bytes for every call to writeHeader. This change broke the writing
      of PAX headers.
      
      writeHeader calls writePAXHeader and writePAXHeader calls writeHeader
      again. writeHeader will end up writing the PAX header twice.
      
      example broken header:
      PaxHeaders.4007/NetLock_Arany_=Class_Gold=_Ftanstvny.crt0000000000000000000000000000007112301216634021512 xustar0000000000000000
      PaxHeaders.4007/NetLock_Arany_=Class_Gold=_Ftanstvny.crt0000000000000000000000000000007112301216634021512 xustar0000000000000000
      
      example correct header:
      PaxHeaders.4290/NetLock_Arany_=Class_Gold=_Ftanstvny.crt0000000000000000000000000000007112301216634021516 xustar0000000000000000
      0100644000000000000000000000270412301216634007250 0ustar0000000000000000
      
      This commit adds a dedicated buffer for pax headers to the Writer
      struct. This change increases the size of the struct by 512 bytes, but
      allows tar/writer to avoid allocating 512 bytes for all written
      headers and it avoids allocating 512 more bytes for pax headers.
      
      LGTM=dsymonds
      R=dsymonds, dave, iant
      CC=golang-codereviews
      https://golang.org/cl/110480043
      7a9e7c0a
  2. 16 Jul, 2014 11 commits
  3. 15 Jul, 2014 13 commits
  4. 14 Jul, 2014 4 commits
  5. 12 Jul, 2014 2 commits
  6. 11 Jul, 2014 3 commits
    • David du Colombier's avatar
      liblink: fix warnings on Plan 9 · 90c146f3
      David du Colombier authored
      warning: /usr/go/src/liblink/asm5.c:720 set and not used: m
      warning: /usr/go/src/liblink/asm5.c:807 set and not used: c
      
      LGTM=minux
      R=minux
      CC=golang-codereviews
      https://golang.org/cl/108570043
      90c146f3
    • Rob Pike's avatar
      ld: change DWARF output for structs · 125d1e92
      Rob Pike authored
      The debug/dwarf package cannot parse the format generated here,
      but the format can be changed so it does.
      After this edit, tweaking the expression defining the offset
      of a struct field, the dwarf package can parse the tables (again?).
      
      LGTM=rsc
      R=rsc
      CC=golang-codereviews
      https://golang.org/cl/105710043
      125d1e92
    • Dustin Long's avatar
      image/png: interlacing support for png. · 5c2f01f3
      Dustin Long authored
      Fixes #6293.
      
      Image "testdata/benchRGB-interlace.png" was generated by opening "testdata/benchRGB.png" in the editor Gimp and saving it with interlacing enabled.
      
      Benchmark:
      BenchmarkDecodeRGB        	     500	   7014194 ns/op	  37.37 MB/s
      ok  	pkg/image/png	4.657s
      
      BenchmarkDecodeInterlacing	     100	  10623241 ns/op	  24.68 MB/s
      ok  	pkg/image/png	1.339s
      
      LGTM=nigeltao
      R=nigeltao, andybons, matrixik
      CC=golang-codereviews
      https://golang.org/cl/102130044
      5c2f01f3
  7. 10 Jul, 2014 3 commits
    • Benny Siegert's avatar
      cmd/go: do not fail if libgcc does not exist · 0e694298
      Benny Siegert authored
      (This is a patch from the pkgsrc Go package.)
      
      LGTM=iant
      R=golang-codereviews, iant, joerg.sonnenberger, dave
      CC=golang-codereviews, joerg
      https://golang.org/cl/108340043
      0e694298
    • Pietro Gagliardi's avatar
      debug/elf: add (*File).DynamicSymbols, ErrNoSymbols, and tests for... · f5b600f7
      Pietro Gagliardi authored
      debug/elf: add (*File).DynamicSymbols, ErrNoSymbols, and tests for (*File).Symbols and (*File).DynamicSymbols, and formalize symbol order.
      
      Added a complement to (*File).Symbols for the dynamic symbol table.
      Would be useful, for instance, if seraching for certain shared objects
      compatible with certain libraries (for instance, LADSPA requires an
      exported symbol "ladspa_descriptor").
      
      Added a variable ErrNoSymbols that canonicalizes a return from
      (*File).Symbols and (*File).DyanmicSymbols if the file has no symbols.
      
      Added tests for both (*File).Symbols and (*File).DynamicSymbols;
      there was never a test for (*File).Symbols at all. A small C program using
      libelf, included in the test data, was used to produce the golden
      symbols to compare against.
      
      As part of the requirements for testing, (*File).Symbols and (*File).DynamicSymbols now document the order in which the symbol tables are returned (in the order the symbols appear in the file).
      
      All tests currently pass.
      
      LGTM=iant
      R=golang-codereviews, iant
      CC=golang-codereviews
      https://golang.org/cl/107530043
      f5b600f7
    • Shenghou Ma's avatar
      nacltest.bash: set GOROOT before invoking cmd/go · 54d0b5ab
      Shenghou Ma authored
      The builder builds with GOROOT_FINAL=/usr/local/go set.
      
      TBR=rsc
      R=golang-codereviews
      CC=golang-codereviews
      https://golang.org/cl/112100043
      54d0b5ab