- 20 Aug, 2011 4 commits
-
-
Rob Pike authored
Also update the big example to the new template system. There are a number of other examples that should be extracted; this CL serves as an introduction to the approach. R=golang-dev, adg CC=golang-dev https://golang.org/cl/4923043
-
Rob Pike authored
Trivial change: just fix the import. R=golang-dev, adg CC=golang-dev https://golang.org/cl/4937043
-
Robert Griesemer authored
- templates should be read before any handlers are started - for app engine use, must use underlying file system to read templates R=r CC=golang-dev https://golang.org/cl/4928042
-
Robert Griesemer authored
In the process, rewrite index.go to use slices instead of vectors, rewrite for-loops into range loops, and generally simplify code (this code was written before the launch of go and showed its age). Also, fix a wrong import in appinit.go. No significant performance changes (improvements); most of time is spent elsewhere (measured on an stand- alone MacBook Pro with SSD disk, running standard godoc settings: godoc -v -http=:7777 -index). R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4875056
-
- 19 Aug, 2011 3 commits
-
-
Robert Griesemer authored
R=rsc, r CC=golang-dev https://golang.org/cl/4894057
-
Rob Pike authored
R=golang-dev, dsymonds, r CC=golang-dev, mikesamuel https://golang.org/cl/4918041
-
Alex Brainman authored
R=golang-dev CC=golang-dev https://golang.org/cl/4873058
-
- 18 Aug, 2011 15 commits
-
-
Brad Fitzpatrick authored
ParseMediaType previously documented that it always returned a non-nil map, but also documented that it returned a nil map to signal an error. That is confusing, contradictory and not Go-like. Now it returns (mediatype string, params map, os.Error). R=golang-dev, r CC=golang-dev https://golang.org/cl/4867054
-
Robert Griesemer authored
The subtle AST changes introduced with CL 4896053 broke type checking of type switches in gofix. Coming up with a correct fix will take some time. Undoing this change for now. ««« original CL description go/parser: fix type switch scoping The variable declared by a TypeSwitchGuard must be visible in each TypeCaseClause and must not conflict with other variables declared by the initial SimpleStmt of a type switch. Also: - explicitly detect type switches (as opposed to detecting regular (expression switches) and then do extra testing for type switches - fix all outstanding TODOs in parser.go R=rsc CC=golang-dev https://golang.org/cl/4896053 »»» R=rsc CC=golang-dev https://golang.org/cl/4902052
-
Robert Griesemer authored
The variable declared by a TypeSwitchGuard must be visible in each TypeCaseClause and must not conflict with other variables declared by the initial SimpleStmt of a type switch. Also: - explicitly detect type switches (as opposed to detecting regular (expression switches) and then do extra testing for type switches - fix all outstanding TODOs in parser.go R=rsc CC=golang-dev https://golang.org/cl/4896053
-
Wei Guangjing authored
R=rsc CC=golang-dev https://golang.org/cl/4825047
-
Mikio Hara authored
This CL changes both JoinGroup and LeaveGroup methods to take an interface as an argument for enabling IPv6 group address join/leave, join a group address on a specific interface. R=rsc, dave CC=golang-dev https://golang.org/cl/4815074
-
Alex Brainman authored
Allocate Defer on stack during cgo calls, as suggested by dvyukov. Also includes some comment corrections. benchmark old,ns/op new,ns/op BenchmarkCgoCall 669 330 (Intel Xeon CPU 1.80GHz * 4, Linux 386) R=dvyukov, rsc CC=golang-dev https://golang.org/cl/4910041
-
Rob Pike authored
They are used internally and do not appear in the final parse tree. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4905052
-
Andrew Gerrand authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/4867060
-
Andrew Gerrand authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/4914042
-
Rob Pike authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4887048
-
Rob Pike authored
I converted this program yesterday and the output is the same as it used to be, ignoring space, but the result is not the best expression of the algorithm. The old {.section Maybe} pieces are now {{with .Maybe}}, as a direct translation, but I they should be {{if .Maybe}} as the output is just a bool and there is no cascading. I have verified that the output of the program is unaffected. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4889053
-
Yasuhiro Matsumoto authored
R=golang-dev, dsymonds, jnwhiteh, n13m3y3r, gustavo CC=golang-dev https://golang.org/cl/4837051
-
Rob Pike authored
R=golang-dev, dsymonds, adg CC=golang-dev https://golang.org/cl/4907049
-
Mike Samuel authored
This defines just enough context to distinguish HTML URI attributes from parsed character data. It does not affect any public module API as I thought I would get early comment on style for defining enumerations and tables. R=rsc, r, nigeltao, r CC=golang-dev https://golang.org/cl/4906043
-
Andrew Gerrand authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/4897048
-
- 17 Aug, 2011 18 commits
-
-
Robert Griesemer authored
Use naming convention for template variables to indicate "escaped-ness" for easier reviewing. (per suggestion from bradfitz) R=bradfitz CC=golang-dev https://golang.org/cl/4914041
-
Russ Cox authored
R=gri CC=golang-dev https://golang.org/cl/4644052
-
Russ Cox authored
The spec has defined nil chans this way for months. I'm behind. R=ken2 CC=golang-dev https://golang.org/cl/4897050
-
Russ Cox authored
The spec has defined nil maps this way for months. I'm behind. R=ken2 CC=golang-dev https://golang.org/cl/4901052
-
Russ Cox authored
Broken by Plan 9 changes. R=ken2 CC=golang-dev https://golang.org/cl/4896050
-
Robert Griesemer authored
R=rsc CC=golang-dev https://golang.org/cl/4908047
-
Fazlul Shahriar authored
All tests enabled by default passes except those in timeout_test.go. For TestLookupPort, add an entry for "bootps" in /lib/ndb/common (Plan 9 calls it "bootp"). I've sent out a patch to fix this. R=paulzhol, rsc, mikioh.mikioh CC=ality, golang-dev https://golang.org/cl/4779041
-
Robert Griesemer authored
- Resolves a long-standing TODO. - Replacement for CL 4908042 by befelemepeseveze@gmail.com Fixes #2155. R=rsc CC=golang-dev https://golang.org/cl/4904048
-
Kyle Lemons authored
Fixes #2150. R=golang-dev, nigeltao, rsc CC=golang-dev https://golang.org/cl/4890042
-
Dave Cheney authored
Also improve error message for unsupported integer types R=agl, rsc CC=golang-dev https://golang.org/cl/4873049
-
Marcel van Lohuizen authored
forminfo.go: - Wrappers for table data. - Per Form dispatch table. composition.go: - reorderBuffer type. Implements decomposition, reordering, and composition. - Note: decompose and decomposeString fields in formInfo could be replaced by a pointer to the trie for the respective form. The proposed design makes testing easier, though. normalization.go: - Temporarily added panic("not implemented") methods to make the tests run. These will be removed again with the next CL, which will introduce the implementation. R=r, rogpeppe, mpvl, rsc CC=golang-dev https://golang.org/cl/4875043
-
Rob Pike authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4911041
-
Mike Samuel authored
Replaces the toy func Reverse(*Template) with one that implements naive autoescaping. Now Escape(*Template) walks a template parse tree to find all template actions and adds the |html command to them if it is not already present. R=golang-dev, r CC=golang-dev https://golang.org/cl/4867049
-
Andrew Gerrand authored
R=gri, r, rsc CC=golang-dev https://golang.org/cl/4891041
-
Rob Pike authored
(Leave exp/template/html where it is for now.) R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4899048
-
Rob Pike authored
It's already in old/template; make that build. Update a couple of references to point to the old template. They can be updated later. Update goplay to use exp/template. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4902046
-
Rob Pike authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4876057
-
Rob Pike authored
This is just moving the URL code from package http into its own package, which has been planned for a while. Besides clarity, this also breaks a nascent dependency cycle the new template package was about to introduce. Add a gofix module, url, and use it to generate changes outside http and url. Sadness about the churn, gladness about some of the naming improvements. R=dsymonds, bradfitz, rsc, gustavo, r CC=golang-dev https://golang.org/cl/4893043
-