- 11 Nov, 2017 2 commits
-
-
Edan B authored
Fixes #22658 Change-Id: I00e2b007d77b6f54798f7755d0b08e4fea824392 Reviewed-on: https://go-review.googlesource.com/77170Reviewed-by:
Emmanuel Odeke <emm.odeke@gmail.com> Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
David du Colombier authored
CL 76873 added TestGoTestJSON. However, this test is only succeeding on SMP machines. This change skips TestGoTestJSON on uniprocessor machines. Fixes #22665. Change-Id: I3989d3331fb71193a25a3f0bbb84ff3e1b730890 Reviewed-on: https://go-review.googlesource.com/77130Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 10 Nov, 2017 21 commits
-
-
Alex Brainman authored
Sometimes getmac lists many interfaces for the same MAC address, while Interfaces returns only single name for that address. Adjust the test to ignore the names that are not returned by the Interfaces. Fixes #21027 Change-Id: I08d98746a7c669f2d730dba2da36e07451a6f405 Reviewed-on: https://go-review.googlesource.com/59411Reviewed-by:
Mikio Hara <mikioh.mikioh@gmail.com>
-
Hiroshi Ioka authored
Fixes #22093 Fixes #19988 Change-Id: Ibd8ec89e091fd527f363999e484676931d7aa6e2 Reviewed-on: https://go-review.googlesource.com/67450Reviewed-by:
Keith Randall <khr@golang.org> Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Russ Cox authored
Added in CL 76873 but forgot to add the flag docs. Change-Id: I448f85cc8cf51399c0d799691226b94f88f327da Reviewed-on: https://go-review.googlesource.com/77030 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
Caleb Spare <cespare@gmail.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Russ Cox authored
If you run go test -coverpkg=all fmt one possible interpretation is that you want coverage for all the packages involved in the fmt test, not all the packages in the world. Because coverpkg was previously defined as a list of packages to be loaded, however, it meant all packages in the world. Now that the go command has a concept of package notation being used as a matching filter instead of a direct enumeration, apply that to -coverpkg, so that -coverpkg=all now has the more useful filter interpretation. Fixes #10271. Fixes #21283. Change-Id: Iddb77b21ba286d3dd65b62507af27e244865072d Reviewed-on: https://go-review.googlesource.com/76876 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
Russ Cox authored
It's easy to merge the coverage profiles from the multiple executed tests, so do that. Also ensures that at least an empty coverage profile is always written. Fixes #6909. Fixes #18909. Change-Id: I28b88e1fb0fb773c8f57e956b18904dc388cdd82 Reviewed-on: https://go-review.googlesource.com/76875 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
-
Russ Cox authored
This is already documented in the time.Time package but people might not look there. Followup to CL 76872, which I submitted accidentally (Gerrit has placed the Submit button next to Reply again.) Change-Id: Ibfd6a4da241982d591a8698282a0c15fe9f2e775 Reviewed-on: https://go-review.googlesource.com/77010 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
-
Aman Gupta authored
Fixes unintended consequence of CL 76393 Change-Id: I7e4644a0bc6a8b37eb41196687d9661f902ba183 Reviewed-on: https://go-review.googlesource.com/76890 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Alex Brainman <alex.brainman@gmail.com>
-
Russ Cox authored
This CL finally adds one of our longest-requested cmd/go features: a way for test-running harnesses to access test output in structured form. In fact the structured json output is more informative than the text output, because the output from multiple parallel tests can be interleaved as it becomes available, instead of needing to wait for the previous test to finish before showing any output from the next test. See CL 76872 for the conversion details. Fixes #2981. Change-Id: I749c4fc260190af9fe633437a781ec0cf56b7260 Reviewed-on: https://go-review.googlesource.com/76873 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Russ Cox authored
Also add cmd/internal/test2json, the actual implementation, which will be called directly from cmd/go in addition to being a standalone command (like cmd/buildid and cmd/internal/buildid). For #2981. Change-Id: I244ce36d665f424bbf13f5ae00ece10b705d367d Reviewed-on: https://go-review.googlesource.com/76872 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Russ Cox authored
In past releases, whether test output appears on stdout or stderr has varied depending on exactly how go test was invoked and also (indefensibly) on the number of CPUs available. Standardize on standard output for all test output. This is easy to explain and makes go test | go tool test2json work nicely. Change-Id: I605641213fbc6c7ff49e1fd38a0f732045a8383d Reviewed-on: https://go-review.googlesource.com/76871 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Daniel Martí authored
Now possible, since stringer just got the -trimprefix flag added. While at it, simplify a few Op stringifications since we can now use %v, and no longer have to worry about o<len(opnames). Passes toolstash -cmp on std cmd. Fixes #15462. Change-Id: Icdcde0b0a5eb165d18488918175024da274f782b Reviewed-on: https://go-review.googlesource.com/76790 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> Reviewed-by:
Matthew Dempsky <mdempsky@google.com> Reviewed-by:
Dave Cheney <dave@cheney.net>
-
Daniel Martí authored
The old code only worked for double-quoted strings, and only checked that the end of the literal value was \n". This worked most of the time, except for some strings like "foo\\n", which doesn't actually translate into a trailing newline when unquoted. To fix this, unquote the string first and look for a real newline at the end of it. Ignore errors, as we don't have anything to do with string literals using back quotes. Fixes #22613. Change-Id: I7cf96916dd578b7068216c2051ec2622cce0b740 Reviewed-on: https://go-review.googlesource.com/76194 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Sina Siadat authored
See CL 40291. ctx.Err() is defined to only return non-nil exactly when ctx.Done() returns a closed channel. Change-Id: I12f51d8c42228f759273319b3ccc28012cb9fc73 Reviewed-on: https://go-review.googlesource.com/71310 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Aman Gupta authored
This means {Read,Write}Msg{UDP,IP} now work on windows. Fixes #9252 Change-Id: Ifb105f9ad18d61289b22d7358a95faabe73d2d02 Reviewed-on: https://go-review.googlesource.com/76393 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: -
Wèi Cōngruì authored
A header line with leading whitespaces is not valid in HTTP as per RFC7230. This change ignores these invalid lines in ReadMIMEHeader. Updates #22464 Change-Id: Iff9f00380d28a9617a55ff7888a76fba82001402 Reviewed-on: https://go-review.googlesource.com/75350Reviewed-by:
-
Ian Kent authored
Change-Id: Id7f0d978ce5b0471a404d6e6673b789e7db04650 Reviewed-on: https://go-review.googlesource.com/65653Reviewed-by:
-
Ariel Mashraki authored
this change removes the state field from the lexer, because it's only used by the run method and can be replaced with a local variable Change-Id: Ib7a90ab6e9a894716cba2c7d9ed71bf2ad1240c0 Reviewed-on: https://go-review.googlesource.com/47338Reviewed-by:
-
Bryan A Ford authored
This changes improves the ConstantTimeByteEq and ConstantTimeEq primitives to both simplify them and improve their performance. Also, since there were no benchmarks for this package before, this change adds benchmarks for ConstantTimeByteEq, ConstantTimeEq, and ConstantTimeLessOrEq. benchmarks on darwin/amd64, 10 runs on old vs new code: name old time/op new time/op delta ConstantTimeByteEq-4 2.28ns ±16% 1.53ns ± 2% -33.09% (p=0.000 n=10+9) ConstantTimeEq-4 2.77ns ±10% 1.51ns ± 2% -45.59% (p=0.000 n=10+9) ConstantTimeLessOrEq-4 1.52ns ± 8% 1.50ns ± 2% ~ (p=0.866 n=9+9) Change-Id: I29b8cbcf158e1f30411720db82d38b4ecd166b15 Reviewed-on: https://go-review.googlesource.com/45310Reviewed-by:
Adam Langley <agl@golang.org> Reviewed-by:
-
Russ Cox authored
Obviously not OK. For #22651. Change-Id: I4238045bec6e50788daaa27a7fbc1d547e72cde9 Reviewed-on: https://go-review.googlesource.com/76870 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
-
Alex Brainman authored
cmd/go/internal/work.Builder.updateBuildID left a file opened. But opened files cannot be deleted on Windows, so cmd/go just leaves these files in %TMP% directory. Close the file so deletion can succeed. Fixes #22650 Change-Id: Ia3ea62f6ec7208d73972eae2e17fb4a766407914 Reviewed-on: https://go-review.googlesource.com/76810Reviewed-by:
-
Joe Tsai authored
The former is more succinct and readable. Change-Id: Ic249d1261a705ad715aeb611c70c7fa91db98254 Reviewed-on: https://go-review.googlesource.com/76830 Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com> Reviewed-by:
-
- 09 Nov, 2017 9 commits
-
-
Than McIntosh authored
Fix a buglet in the go command support for 'go test -n': check for nil output buffer in action routine. Fixes #22644 Change-Id: I2566e3bb3d53d0324c4ddd6fec5d30224bf290df Reviewed-on: https://go-review.googlesource.com/76710 Run-TryBot: Than McIntosh <thanm@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Ariel Mashraki authored
The lastPos field used in the past to track the line number of a token. it's irrelevant anymore, and we can remove it. Change-Id: I42c0bf55e884b79574a7da4926489f2d77618cd0 Reviewed-on: https://go-review.googlesource.com/49591Reviewed-by:
-
Cherry Zhang authored
I added this in CL 76024 in order to do compile+link+run. This is no longer necessary after CL 76551, which changed it back to "go run". Remove it. Change-Id: Ifa744d4b2f73f33cad056b24051821e43638cc7f Reviewed-on: https://go-review.googlesource.com/76690 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Jeff R. Allen authored
The linker will refuse to work on objects larger than 2e9 bytes (see issue #9862 for why). With this change, the compiler gives a useful error message explaining this, instead of leaving it to the linker to give a cryptic message later. Fixes #1700. Change-Id: I3933ce08ef846721ece7405bdba81dff644cb004 Reviewed-on: https://go-review.googlesource.com/74330Reviewed-by:
Robert Griesemer <gri@golang.org> Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Alberto Donizetti authored
The recent vendored pprof update broke the iOS builders. The issue was reported and patched upstream. Re-vendor the internal pprof copy. Updates vendored pprof to commit 9e20b5b106e946f4cd1df94c1f6fe3f88456628d from github.com/google/pprof (2017-11-08). Fixes #22612 Change-Id: I74c46c75e92ce401e605c55e27d8545c0d66082c Reviewed-on: https://go-review.googlesource.com/76651Reviewed-by:
Elias Naur <elias.naur@gmail.com>
-
Russ Cox authored
Even if the go command can see that the target is up-to-date an mtime-based build system invoking the go command may not be able to tell. Update the mtime to make clear that the target is up-to-date, and also to hide exactly how smart the go command is or is not. This keeps users (and programs) from depending on the exact details of the go command's staleness determination. Without this I believe we will get a stream of (completely reasonable) bug reports that "go install (or go test -c) did not update the binary after I trivially changed the source code or touched a source file". Change-Id: I920e4aaed2a57319e3c0c37717f872bc059e484e Reviewed-on: https://go-review.googlesource.com/76590 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
-
Russ Cox authored
We want test caching to work even for people with scripts that set a non-default test timeout. But then that raises the question of what to do about runs with different timeouts: is a cached success with one timeout available for use when asked to run the test with a different timeout? This CL answers that question by saying that the timeout applies to the overall execution of either running the test or displaying the cached result, and displaying a cached result takes no time. So it's always OK to record a cached result, regardless of timeout, and it's always OK to display a cached result, again regardless of timeout. Fixes #22633. Change-Id: Iaef3602710e3be107602267bbc6dba9a2250796c Reviewed-on: https://go-review.googlesource.com/76552 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
roger peppe <rogpeppe@gmail.com> Reviewed-by:
-
Russ Cox authored
It has always been problematic that there was no way to specify tool flags that applied only to the build of certain packages; it was only to specify flags for all packages being built. The usual workaround was to install all dependencies of something, then build just that one thing with different flags. Since the dependencies appeared to be up-to-date, they were not rebuilt with the different flags. The new content-based staleness (up-to-date) checks see through this trick, because they detect changes in flags. This forces us to address the underlying problem of providing a way to specify per-package flags. The solution is to allow -gcflags=pattern=flags, which means that flags apply to packages matching pattern, in addition to the usual -gcflags=flags, which is now redefined to apply only to the packages named on the command line. See #22527 for discussion and rationale. Fixes #22527. Change-Id: I6716bed69edc324767f707b5bbf3aaa90e8e7302 Reviewed-on: https://go-review.googlesource.com/76551 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
-
Russ Cox authored
It needs to refer to packages, so it can no longer be in cfg. No semantic changes here. Can now be unexported, so that was a net win anyway. Change-Id: I58bf6cdcd435e6e019291bb8dcd5d5b7f1ac03a3 Reviewed-on: https://go-review.googlesource.com/76550 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
-
- 08 Nov, 2017 8 commits
-
-
filewalkwithme authored
In the current implementation, it is possible for a client to continuously send warning alerts, which are just dropped on the floor inside readRecord. This can enable scenarios in where someone can try to continuously send warning alerts to the server just to keep it busy. This CL implements a simple counter that triggers an error if we hit the warning alert limit. Fixes #22543 Change-Id: Ief0ca10308cf5a4dea21a5a67d3e8f6501912da6 Reviewed-on: https://go-review.googlesource.com/75750Reviewed-by:
Filippo Valsorda <hi@filippo.io> Run-TryBot: Adam Langley <agl@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
David Chase authored
Plain blocks that contain only uninteresting instructions (that do not have reliable Pos information themselves) need to have their Pos left unset so that they can inherit it from their successors. The "uninteresting" test was not properly applied and not properly defined. OpFwdRef does not appear in the ssa.html debugging output, but at the time of the test these instructions did appear, and it needs to be part of the test. Fixes #22365. Change-Id: I99e5b271acd8f6bcfe0f72395f905c7744ea9a02 Reviewed-on: https://go-review.googlesource.com/74252 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Filippo Valsorda authored
This is the equivalent change to 1c105980 but for SHA-512. SHA-512 certificates are already supported by default since b53bb2ca, but some servers will refuse connections if the algorithm is not advertised in the overloaded signatureAndHash extension (see 09b238f1). This required adding support for SHA-512 signatures on CertificateVerify and ServerKeyExchange messages, because of said overloading. Some testdata/Client-TLSv1{0,1} files changed because they send a 1.2 ClientHello even if the server picks a lower version. Closes #22422 Change-Id: I16282d03a3040260d203711ec21e6b20a0e1e105 Reviewed-on: https://go-review.googlesource.com/74950 Run-TryBot: Filippo Valsorda <hi@filippo.io> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Agniva De Sarker authored
Handling the ASCII case inline and call unicode.ToLower only for non-ASCII cases. Gives good improvements for the ASCII case and minor perf degrade for non-ASCII case name old time/op new time/op delta ToLower/#00 10.8ns ± 1% 9.0ns ± 1% -16.83% (p=0.008 n=5+5) ToLower/abc 23.3ns ± 4% 12.6ns ± 1% -46.01% (p=0.008 n=5+5) ToLower/AbC123 91.0ns ± 2% 70.4ns ± 0% -22.59% (p=0.008 n=5+5) ToLower/azAZ09_ 104ns ± 3% 75ns ± 1% -28.35% (p=0.008 n=5+5) ToLower/longStrinGwitHmixofsmaLLandcAps 254ns ± 4% 157ns ± 0% -38.19% (p=0.016 n=5+4) ToLower/LONGⱯSTRINGⱯWITHⱯNONASCIIⱯCHARS 446ns ± 1% 451ns ± 1% ~ (p=0.056 n=5+5) ToLower/ⱭⱭⱭⱭⱭ 345ns ± 1% 348ns ± 0% +0.93% (p=0.016 n=5+5) name old alloc/op new alloc/op delta ToLower/#00 0.00B 0.00B ~ (all equal) ToLower/abc 0.00B 0.00B ~ (all equal) ToLower/AbC123 16.0B ± 0% 16.0B ± 0% ~ (all equal) ToLower/azAZ09_ 24.0B ± 0% 16.0B ± 0% -33.33% (p=0.008 n=5+5) ToLower/longStrinGwitHmixofsmaLLandcAps 80.0B ± 0% 64.0B ± 0% -20.00% (p=0.008 n=5+5) ToLower/LONGⱯSTRINGⱯWITHⱯNONASCIIⱯCHARS 96.0B ± 0% 96.0B ± 0% ~ (all equal) ToLower/ⱭⱭⱭⱭⱭ 48.0B ± 0% 48.0B ± 0% ~ (all equal) Ran on a machine with Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz Fixes #17859 Change-Id: Iacc1e6b77e1aedba9447a6e94352606f131ea597 Reviewed-on: https://go-review.googlesource.com/76470Reviewed-by:
Marvin Stenger <marvin.stenger94@gmail.com> Reviewed-by:
Joe Tsai <thebrokentoaster@gmail.com>
-
Matthew Dempsky authored
Fixes #16394. Change-Id: I7108c9e8e67d86678bdb6015f0862e5c92bcf911 Reviewed-on: https://go-review.googlesource.com/76450Reviewed-by:
-
Ian Lance Taylor authored
Fixes #22629 Change-Id: I31e85f9faa125ee0dfd6d3c5fa89334b00d61e6e Reviewed-on: https://go-review.googlesource.com/76530 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Joe Tsai <joetsai@google.com>
-
Leigh McCulloch authored
The docs for xml.Marshal state that the XML elements name is derived from one of five locations in a specific order of precedence, but does not mention that if the field is a struct type and has its name defined in a tag and in the types XMLName field that an error will occur. This is documented in the structFieldInfo function but not in the function documentation, and the existing docs in Marshal are misleading without this behavior being discussed. Fixes #18564 Change-Id: I29042f124a534bd1bc993f1baeddaa0af2e72fed Reviewed-on: https://go-review.googlesource.com/76321Reviewed-by:
-
Adam Langley authored
This change adds the cryptobyte package from x/crypto at git revision faadfbdc035307d901e69eea569f5dda451a3ee3. Updates #22616, #15196 Change-Id: Iffd0b022ca129d340ef429697e05b581f04e5c4f Reviewed-on: https://go-review.googlesource.com/74270Reviewed-by:
-
