Commits · da8e6eec9a69b6de4b75a92797a92fa0c6c8be3e · Kirill Smelkov / go

23 Feb, 2011 13 commits

Adam Langley authored Feb 23, 2011

(Once again, proving that a fuzz tester is the first thing that I
should try.)

R=bradfitzgo
CC=golang-dev
https://golang.org/cl/4227042

da8e6eec

codereview: fix clpatch with empty diffs · 73aacbda

Gustavo Niemeyer authored Feb 23, 2011

Avoid passing the placeholder diff to hgpatch, so that
clpatch-ing an empty diff grabs the metadata and warns
about it being empty, rather than failing with a
hard-to-debug problem ("mkdir: no such file or dir",
no metadata, etc).

R=rsc
CC=golang-dev
https://golang.org/cl/4172060

73aacbda

json: use base64 to encode []byte · 83da7d15
Roger Peppe authored Feb 23, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4160058
```
83da7d15

compress/bzip2: add package. · bf693982

Adam Langley authored Feb 23, 2011

This code implements bzip2 decompression only.

R=bradfitzgo, r2, nigeltao, rsc
CC=golang-dev
https://golang.org/cl/4176051

bf693982

compress/lzw: implement a decoder. · 658447ab
Nigel Tao authored Feb 23, 2011
```
R=rsc
CC=bsiegert, golang-dev, mpl
https://golang.org/cl/4182081
```
658447ab

http: introduce Header type, implement with net/textproto · b8fa6188

Petar Maymounkov authored Feb 23, 2011

textproto: introduce Header type
websocket: use new interface to access Header

R=rsc, mattn
CC=golang-dev
https://golang.org/cl/4185053

b8fa6188

Make.pkg, doc: Replace references to "-benchmarks" and "-match" with "-test.bench" and "-test.run". · 07cc8b9a
Kyle Consalus authored Feb 22, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4197041
```
07cc8b9a
go/parser: if and switch statements still can have empty init statements · 8e4e1150
Robert Griesemer authored Feb 22, 2011
```
This is a fix for the overly aggressive CL 4173075.
Ran all tests.

R=r, rsc
CC=golang-dev
https://golang.org/cl/4203041
```
8e4e1150
net: refactor windows code · 0e7995c0
Alex Brainman authored Feb 23, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4185054
```
0e7995c0
5l/6l/8l: use enums for header type and symbolic strings for -H option values · 0cf6f8c0
Alex Brainman authored Feb 23, 2011
```
Thanks to rsc for the suggestion.

R=r
CC=golang-dev
https://golang.org/cl/4174060
```
0cf6f8c0

exp/eval, go/printer: fix build · cd0f799e

Robert Griesemer authored Feb 22, 2011

There are some minor irregularities in the printer
output (some paren's are present that should be
removed), but these are unrelated issues.
Will review in a 2nd step.

R=rsc
CC=golang-dev
https://golang.org/cl/4188068

cd0f799e

arm: fix build · bdbea6e4

Russ Cox authored Feb 22, 2011

Changes on laptop were not sync'ed to machine
where I ran hg submit.

R=r
CC=golang-dev
https://golang.org/cl/4195048

bdbea6e4

go/ast, parser: condition in if statement is mandatory · 23c16cf2

Robert Griesemer authored Feb 22, 2011

As a result, parsing a "control clause" is now sufficiently
different for if, switch, and for statements that the code
is not factored out anymore. The code is a bit longer but
clearer in each individual case.

Reflect the changes in AST.

R=r, r2
CC=golang-dev
https://golang.org/cl/4173075

23c16cf2

22 Feb, 2011 10 commits

go spec: make condition mandatory in if statements · a1368a6a

Robert Griesemer authored Feb 22, 2011

Plus a few minor HTML fixes.

Fixes #1535.

R=r, rsc, ken2, iant, r2
CC=golang-dev
https://golang.org/cl/4185065

a1368a6a

gc: require if condition · 52943bfe
Russ Cox authored Feb 22, 2011
```
R=ken2, r2
CC=golang-dev
https://golang.org/cl/4195045
```
52943bfe

test: do not depend on implicit if condition · 814075df

Russ Cox authored Feb 22, 2011

Deleted test/ken/robif.go because test/if.go is
the same program modulo formatting.

R=golang-dev, gri, r2
CC=golang-dev
https://golang.org/cl/4186068

814075df

ld: detect stack overflow due to NOSPLIT · d9fd1144

Russ Cox authored Feb 22, 2011

Fix problems found.

On amd64, various library routines had bigger
stack frames than expected, because large function
calls had been added.

runtime.assertI2T: nosplit stack overflow
        120	assumed on entry to runtime.assertI2T
        8	after runtime.assertI2T uses 112
        0	on entry to runtime.newTypeAssertionError
        -8	on entry to runtime.morestack01

runtime.assertE2E: nosplit stack overflow
        120	assumed on entry to runtime.assertE2E
        16	after runtime.assertE2E uses 104
        8	on entry to runtime.panic
        0	on entry to runtime.morestack16
        -8	after runtime.morestack16 uses 8

runtime.assertE2T: nosplit stack overflow
        120	assumed on entry to runtime.assertE2T
        16	after runtime.assertE2T uses 104
        8	on entry to runtime.panic
        0	on entry to runtime.morestack16
        -8	after runtime.morestack16 uses 8

runtime.newselect: nosplit stack overflow
        120	assumed on entry to runtime.newselect
        56	after runtime.newselect uses 64
        48	on entry to runtime.printf
        8	after runtime.printf uses 40
        0	on entry to vprintf
        -8	on entry to runtime.morestack16

runtime.selectdefault: nosplit stack overflow
        120	assumed on entry to runtime.selectdefault
        56	after runtime.selectdefault uses 64
        48	on entry to runtime.printf
        8	after runtime.printf uses 40
        0	on entry to vprintf
        -8	on entry to runtime.morestack16

runtime.selectgo: nosplit stack overflow
        120	assumed on entry to runtime.selectgo
        0	after runtime.selectgo uses 120
        -8	on entry to runtime.gosched

On arm, 5c was tagging functions NOSPLIT that should
not have been, like the recursive function printpanics:

printpanics: nosplit stack overflow
        124	assumed on entry to printpanics
        112	after printpanics uses 12
        108	on entry to printpanics
        96	after printpanics uses 12
        92	on entry to printpanics
        80	after printpanics uses 12
        76	on entry to printpanics
        64	after printpanics uses 12
        60	on entry to printpanics
        48	after printpanics uses 12
        44	on entry to printpanics
        32	after printpanics uses 12
        28	on entry to printpanics
        16	after printpanics uses 12
        12	on entry to printpanics
        0	after printpanics uses 12
        -4	on entry to printpanics

R=r, r2
CC=golang-dev
https://golang.org/cl/4188061

d9fd1144

misc/dashboard/builder: talk to hg with utf-8 encoding always. · 7f5acfb2
Andrew Gerrand authored Feb 23, 2011
```
Fixes #1465.

R=rsc
CC=golang-dev
https://golang.org/cl/4172063
```
7f5acfb2
.hgignore: add *.cgo*.{c,go} · bd44684f
Gustavo Niemeyer authored Feb 22, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4168059
```
bd44684f

gob: compute information about a user's type once. · 14b6a477

Rob Pike authored Feb 22, 2011

Other than maybe cleaning the code up a bit, this has
little practical effect for now, but lays the foundation
for remembering the method set of a type, which can
be expensive.

R=rsc
CC=golang-dev
https://golang.org/cl/4193041

14b6a477

go spec: fix local link · 556506e8
Robert Griesemer authored Feb 22, 2011
```
Fixes #1543.

R=rsc, r2
CC=golang-dev
https://golang.org/cl/4169068
```
556506e8

reflect: add a secret method to ArrayOrSliceType. · 795ff00d

Rob Pike authored Feb 22, 2011

It was observed that the interface was generic enough
that several other types implemented it too.

Fixes #1530.

R=rsc
CC=golang-dev
https://golang.org/cl/4169063

795ff00d

http: add pointer from Handle[Func] to ServeMux docs · 1e73fed8
Andrew Gerrand authored Feb 22, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4169065
```
1e73fed8

21 Feb, 2011 5 commits

http: cleaned up HEAD request method. · 1f39ed8a

Padraig Kitterick authored Feb 22, 2011

Removed a redefinition of the request URL which is never used and
redundant checking of the return value from send().

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4184061

1f39ed8a

A+C: Padraig Kitterick · c010b0e8
Andrew Gerrand authored Feb 22, 2011
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/4186065
```
c010b0e8
testing: Fix typo on Logf doc comment. · 1634390f
David Symonds authored Feb 22, 2011
```
R=rsc, r2
CC=golang-dev
https://golang.org/cl/4167064
```
1634390f

image/png: support for more formats · ca0d4830

Mikael Tillenius authored Feb 22, 2011

Added support for reading images with grayscale + alpha and
for images with depth 1, 2 or 4.

R=nigeltao
CC=golang-dev
https://golang.org/cl/4174053

ca0d4830

A+C: Mikael Tillenius (individual CLA) · c015dd21
Nigel Tao authored Feb 21, 2011
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/4179063
```
c015dd21

20 Feb, 2011 1 commit
- runtime-gdb.py: gdb pretty printer for go strings properly handles length. · db22e236
  Luuk van Dijk authored Feb 20, 2011
```
R=rsc, r2
CC=golang-dev
https://golang.org/cl/4183060
```
  db22e236
19 Feb, 2011 2 commits
- spec: delete incorrect obsolete mention of selector working on · e041b998
  Rob Pike authored Feb 19, 2011
```
pointer to interface type.

R=golang-dev, niemeyer, gri
CC=golang-dev
https://golang.org/cl/4173067
```
  e041b998
- crypto/openpgp/packet: comment typo fix. · 7b166cd7
  Adam Langley authored Feb 19, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4178065
```
  7b166cd7
18 Feb, 2011 9 commits

build: reduce the use of subshells in recursive make · 8a8ecda5

Dave Cheney authored Feb 19, 2011

Using make -C $* rather than (cd $* ; make) results in a small,
but measurable improvement in build times where compilation is
not the major component. eg.

before - ~/go/src/pkg$ time make
        real	0m1.176s
        user	0m0.639s
        sys	0m0.399s
after - ~/go/src/pkg$ time make
        real	0m0.916s
        user	0m0.571s
        sys	0m0.243s

There are other places in the distribution src/make.common for example
that could also benefit from this change.

R=adg
CC=golang-dev, rsc
https://golang.org/cl/4174055

8a8ecda5

misc/dashboard: tweak build fail notification email · 79ba1ce0
Andrew Gerrand authored Feb 19, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4170063
```
79ba1ce0
net: fix multicast tests · 90847a85
Dave Cheney authored Feb 18, 2011
```
R=rsc, mikioh, rsc1, dho
CC=golang-dev
https://golang.org/cl/4174056
```
90847a85
crypto/openpgp/packet: fix testing print (missing arg) · 7e6488f9
Rob Pike authored Feb 18, 2011
```
R=agl
CC=golang-dev
https://golang.org/cl/4173062
```
7e6488f9
godoc: serve robots.txt raw · 06a923ad
Andrew Gerrand authored Feb 19, 2011
```
R=gri, niemeyer, rsc, r2, r
CC=golang-dev
https://golang.org/cl/4188063
```
06a923ad
.hgignore: add doc/codelab/wiki/*.bin · 3173821a
Gustavo Niemeyer authored Feb 19, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4173063
```
3173821a
runtime: handle non-standard call sequences in arm traceback · 7081e675
Russ Cox authored Feb 18, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4191048
```
7081e675

fix build · f07a45f2

Russ Cox authored Feb 18, 2011

pieces of an upcoming CL leaked into CL 4168056

TBR=r
CC=golang-dev
https://golang.org/cl/4180057

f07a45f2

runtime: record $GOROOT_FINAL for runtime.GOROOT · d3ac545f
Russ Cox authored Feb 18, 2011
```
Update #1527.

R=adg, oerdnj
CC=golang-dev
https://golang.org/cl/4171060
```
d3ac545f