- 04 Mar, 2014 18 commits
-
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/71160044
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/71150043
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/69110045
-
Russ Cox authored
The flakiness appears to be just in tests, not in the actual code. Specifically, the many tests call runtime.GC once and expect that the finalizers will be running in the background when GC returns. Now that the sweep phase is concurrent with execution, however, the finalizers will not be run until sweep finishes, which might be quite a bit later. To force sweep to finish, implement runtime.GC by calling the actual collection twice. The second will complete the sweep from the first. This was reliably broken after a few runs before the CL and now passes tens of runs: while GOMAXPROCS=2 ./runtime.test -test.run=Finalizer -test.short \ -test.timeout=300s -test.cpu=$(perl -e 'print ("1,2,4," x 100) . "1"') do true; done Fixes #7328. LGTM=dvyukov R=dvyukov, dave CC=golang-codereviews https://golang.org/cl/71080043
-
Dmitriy Vyukov authored
Fixes #7438. LGTM=rsc R=golang-codereviews CC=bradfitz, golang-codereviews, iant, rsc https://golang.org/cl/70420044
-
Rémy Oudompheng authored
Fixes #7346. LGTM=rsc R=rsc, iant, khr CC=golang-codereviews https://golang.org/cl/69050044
-
Russ Cox authored
The exception handler runs on the ordinary g stack, and the stack copier is now trying to do a traceback across it. That's never been needed before, so it was unimplemented. Implement it, in all its ugliness. Fixes windows/amd64 build. TBR=khr CC=golang-codereviews https://golang.org/cl/71030043
-
Robert Griesemer authored
gccgo considers built-in function calls returning a constant not as function call (issue 7386) go/types considers any call (regular or built-in) as a function call The wording and examples clarify that only "function calls" that are issued at run-time (and thus do not result in a constant result) are considered function calls in this case. gc is inconsistent (issue 7385) gccgo already interprets the spec accordingly and issue 7386 is moot. go/types considers all calls (constant or not) as function calls (issue 7457). Fixes #7387. Fixes #7386. LGTM=r, rsc, iant R=r, rsc, iant, ken CC=golang-codereviews https://golang.org/cl/66860046
-
Brad Fitzpatrick authored
1) Move StateHijacked callback earlier, to make it panic-proof. A Hijack followed by a panic didn't previously result in ConnState getting fired for StateHijacked. Move it earlier, to the time of hijack. 2) Don't fire StateActive unless any bytes were read off the wire while waiting for a request. This means we don't transition from New or Idle to Active if the client disconnects or times out. This was documented before, but not implemented properly. This CL is required for an pending fix for Issue 7264 LGTM=josharian R=josharian CC=golang-codereviews https://golang.org/cl/69860049
-
Mikio Hara authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/71000043
-
Russ Cox authored
Actually, speed up Int31n and Int63n by avoiding retry loop. benchmark old ns/op new ns/op delta BenchmarkFloat32 32 26 -19.45% BenchmarkFloat64 46 23 -49.47% Fixes #7267. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/69980047
-
Russ Cox authored
TBR=ken2 CC=golang-codereviews https://golang.org/cl/70200053
-
Mikio Hara authored
Also makes variable names explicit. Fixes #7186. LGTM=iant R=golang-codereviews, gobot, iant, bradfitz CC=golang-codereviews https://golang.org/cl/69100043
-
Mikio Hara authored
Update #7186 Update #7428 LGTM=r, bradfitz R=golang-codereviews, rsc, minux.ma, r, bradfitz CC=golang-codereviews https://golang.org/cl/68880043
-
Mikio Hara authored
Fixes #7187. Update #7193 LGTM=bradfitz R=golang-codereviews, dave, rsc, minux.ma, bradfitz CC=golang-codereviews https://golang.org/cl/64510043
-
Mikio Hara authored
This CL tweaks syscall.InterfaceMessage to support FreeBSD 10 and prior to 10. See http://svnweb.freebsd.org/base?view=revision&revision=254804. Fixes #7193. LGTM=iant R=golang-codereviews, rsc, minux.ma, gobot, iant CC=golang-codereviews https://golang.org/cl/56980043
-
Mikio Hara authored
Update #7193 LGTM=minux.ma R=golang-codereviews, rsc, minux.ma, iant CC=golang-codereviews https://golang.org/cl/57210043
-
Mikio Hara authored
Unfortunately FreeBSD 10 has changed its syscall arguments for some reasons but as per request at golang-dev this CL does not generate some structures, syscall numbers and constants as compatible to FreeBSD 10 as follows: Structure: Stat_t, IfData, IfMsghdr are based on 8-STABLE Syscall number: Capsicum API is based on 9-STABLE Constant: IFT_CARP, SIOCAIFADDR, SIOCSIFPHYADDR are based on 9-STABLE Update #7193 FreeBSD 10 breaking changes: r205792: Rename st_*timespec fields to st_*tim for POSIX 2008 compliance. http://svnweb.freebsd.org/base?view=revision&revision=205792 r254804: Restructure the mbuf pkthdr to make it fit for upcoming capabilities and features. http://svnweb.freebsd.org/base?view=revision&revision=254804 r255219: Change the cap_rights_t type from uint64_t to a structure that we can extend in the future in a backward compatible (API and ABI) way. http://svnweb.freebsd.org/base?view=revision&revision=255219 LGTM=iant R=golang-codereviews, rsc, minux.ma, gobot, iant CC=golang-codereviews https://golang.org/cl/56770044
-
- 03 Mar, 2014 10 commits
-
-
Dave Cheney authored
CBARGS is unused on amd64p32 so make this explicit. LGTM=bradfitz R=rsc, bradfitz CC=golang-codereviews https://golang.org/cl/70940043
-
Brad Fitzpatrick authored
In Go 1.2, closing a request body without reading to EOF causes the underlying TCP connection to not be reused. This client code following redirects was never updated when that happened. This was part of a previous CL but moved to its own CL at Josh's request. Now with test too. LGTM=josharian R=josharian CC=golang-codereviews https://golang.org/cl/70800043
-
Graham King authored
DWARF 2 has 9 standard opcodes, so dwarfdump expects us to use an opcode base of at least 10. Previously we used 5. Discussion: https://groups.google.com/forum/#!topic/golang-dev/d-BqpPgalzc LGTM=josharian, rsc R=golang-codereviews, gobot, rsc, josharian, iant, bradfitz CC=golang-codereviews https://golang.org/cl/69320043
-
Adam Langley authored
Currently a write error will cause future reads to return that same error. However, there may have been extra information from a peer pending on the read direction that is now unavailable. This change splits the single connErr into errors for the read, write and handshake. (Splitting off the handshake error is needed because both read and write paths check the handshake error.) Fixes #7414. LGTM=bradfitz, r R=golang-codereviews, r, bradfitz CC=golang-codereviews https://golang.org/cl/69090044
-
Shenghou Ma authored
perl is installed by pkgsrc to /usr/pkg/bin. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/70630043
-
David du Colombier authored
warning: src/cmd/ld/pcln.c:184 more arguments than format INT LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/69870047
-
Brad Fitzpatrick authored
Fixes #3362 LGTM=josharian R=golang-codereviews, josharian CC=adg, dsymonds, golang-codereviews, n13m3y3r https://golang.org/cl/70120045
-
Andrew Gerrand authored
LGTM=r R=minux.ma, r CC=golang-codereviews https://golang.org/cl/70660043
-
Andrew Gerrand authored
This broke when we renamed the tool, and I missed this fix when I fixed darwin last week. LGTM=minux.ma, bradfitz R=golang-codereviews, minux.ma, bradfitz CC=golang-codereviews https://golang.org/cl/70670043
-
Andrew Gerrand authored
LGTM=minux.ma R=golang-codereviews, minux.ma CC=golang-codereviews https://golang.org/cl/69970047
-
- 02 Mar, 2014 4 commits
-
-
Mikio Hara authored
Also enables netgo test on solaris. LGTM=aram, jsing R=golang-codereviews, dave, aram, jsing CC=golang-codereviews https://golang.org/cl/70300043
-
Mikio Hara authored
Update #7186 LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/70490043
-
Richard Crowley authored
The addition of Server.ConnState provides all the necessary hooks to stop a Server gracefully, but StateNew previously could fire concurrently with Serve exiting (as it does when its net.Listener is closed). This previously meant one couldn't use a WaitGroup incremented in the StateNew hook along with calling Wait after Serve. Now you can. Update #4674 LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/70410044
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/70470043
-
- 01 Mar, 2014 3 commits
-
-
Shenghou Ma authored
See also CL 4259056 for FreeBSD. Test program: // exec.go package main import ( "log" "os" "os/exec" "runtime" ) func main() { path := runtime.GOROOT() + "/src/pkg/net/http/cgi/testdata" cmd := &exec.Cmd{ Path: "test.cgi", Args: []string{path + "/test.cgi"}, Dir: path Stdout: os.Stdout} if err := cmd.Start(); err != nil { log.Fatal(err) } if err := cmd.Wait(); err != nil { log.Fatal(err) } } $ go run exec.go 2014/03/01 15:52:41 fork/exec test.cgi: argument list too long LGTM=iant R=rsc, iant CC=golang-codereviews https://golang.org/cl/69970044
-
Dave Cheney authored
Update #7338 The nil deref tests are currently failing on the *bsd/arm platforms. In an effort to avoid the build deteriorating further I would like to skip these tests on freebsd/arm and netbsd/arm. LGTM=bradfitz, minux.ma R=golang-codereviews, bradfitz, minux.ma CC=golang-codereviews https://golang.org/cl/69870045
-
Dave Cheney authored
cgocall.c: define the CBARGS macro for GOARCH_amd64p32. I don't think the value of this macro will ever be used under nacl/amd64p32 but it is required to compile even if cgo is not used. hashmap.goc: amd64p32 uses 32bit words. LGTM=iant R=rsc, iant CC=golang-codereviews https://golang.org/cl/69960044
-
- 28 Feb, 2014 5 commits
-
-
Brad Fitzpatrick authored
LGTM=r R=r CC=golang-codereviews https://golang.org/cl/70120044
-
Brad Fitzpatrick authored
LGTM=josharian R=golang-codereviews, josharian CC=golang-codereviews https://golang.org/cl/70270043
-
Brad Fitzpatrick authored
Fixes #7291 LGTM=agl R=golang-codereviews, agl CC=agl, golang-codereviews https://golang.org/cl/70250044
-
Josh Bleecher Snyder authored
The pcln file number was being encoded incorrectly. The recorded delta was always against -1, not against the previous value. Update #7369 This CL fixes the bad DWARF file numbers. It does not, however, fix the gdb continue-to-end bug. LGTM=iant R=rsc, minux.ma, iant CC=golang-codereviews, graham https://golang.org/cl/68960046
-
Brad Fitzpatrick authored
This is a user error, but killing -1 kills everything, which is a pretty bad failure mode. Fixes #7434 LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/70140043
-