1. 04 Sep, 2014 6 commits
    • Russ Cox's avatar
      runtime: correct various Go -> C function calls · e3edfea0
      Russ Cox authored
      Some things get converted.
      Other things (too complex or too many C deps) get onM calls.
      Other things (too simple) get #pragma textflag NOSPLIT.
      
      After this CL, the offending function list is basically:
              - panic.c
              - netpoll.goc
              - mem*.c
              - race stuff
              - readgstatus
              - entersyscall/exitsyscall
      
      LGTM=r, iant
      R=golang-codereviews, r, iant
      CC=dvyukov, golang-codereviews, khr
      https://golang.org/cl/140930043
      e3edfea0
    • Russ Cox's avatar
      runtime: reject onM calls from gsignal stack · 32ecf57d
      Russ Cox authored
      The implementation and use patterns of onM assume
      that they run on either the m->curg or m->g0 stack.
      
      Calling onM from m->gsignal has two problems:
      
      (1) When not on g0, onM switches to g0 and then "back" to curg.
      If we didn't start at curg, bad things happen.
      
      (2) The use of scalararg/ptrarg to pass C arguments and results
      assumes that there is only one onM call at a time.
      If a gsignal starts running, it may have interrupted the
      setup/teardown of the args for an onM on the curg or g0 stack.
      Using scalararg/ptrarg itself would smash those.
      
      We can fix (1) by remembering what g was running before the switch.
      
      We can fix (2) by requiring that uses of onM that might happen
      on a signal handling stack must save the old scalararg/ptrarg
      and restore them after the call, instead of zeroing them.
      The only sane way to do this is to introduce a separate
      onM_signalsafe that omits the signal check, and then if you
      see a call to onM_signalsafe you know the surrounding code
      must preserve the old scalararg/ptrarg values.
      (The implementation would be that onM_signalsafe just calls
      fn if on the signal stack or else jumps to onM. It's not necessary
      to have two whole copies of the function.)
      
      (2) is not a problem if the caller and callee are both Go and
      a closure is used instead of the scalararg/ptrarg slots.
      
      For now, I think we can avoid calling onM from code executing
      on gsignal stacks, so just reject it.
      
      In the long term, (2) goes away (as do the scalararg/ptrarg slots)
      once everything is in Go, and at that point fixing (1) would be
      trivial and maybe worth doing just for regularity.
      
      LGTM=iant
      R=golang-codereviews, iant
      CC=dvyukov, golang-codereviews, khr, r
      https://golang.org/cl/135400043
      32ecf57d
    • Russ Cox's avatar
      runtime: refactor/fix asmcgocall/asmcgocall_errno · cb767247
      Russ Cox authored
      Instead of making asmcgocall call asmcgocall_errno,
      make both load args into registers and call a shared
      assembly function.
      
      On amd64, this costs 1 word in the asmcgocall_errno path
      but saves 3 words in the asmcgocall path, and the latter
      is what happens on critical nosplit paths on Windows.
      
      On arm, this fixes build failures: asmcgocall was writing
      the arguments for asmcgocall_errno into the wrong
      place on the stack. Passing them in registers avoids the
      decision entirely.
      
      On 386, this isn't really needed, since the nosplit paths
      have twice as many words to work with, but do it for consistency.
      
      Update #8635
      Fixes arm build (except GOARM=5).
      
      TBR=iant
      CC=golang-codereviews
      https://golang.org/cl/134390043
      cb767247
    • Mikio Hara's avatar
      net: fix parsing literal IPv6 address with zone identifier in builtin dns stub resolver · f4034164
      Mikio Hara authored
      Fixes #8619.
      
      LGTM=iant
      R=golang-codereviews, iant
      CC=golang-codereviews
      https://golang.org/cl/132560043
      f4034164
    • Russ Cox's avatar
      runtime: give 2 words back in notetsleep_internal · 93805d71
      Russ Cox authored
      I really hoped we could avoid this nonsense, but it appears not.
      
      Should fix windows/amd64 build breakage.
      
      TBR=iant
      CC=golang-codereviews
      https://golang.org/cl/137120043
      93805d71
    • Mikio Hara's avatar
      net: fix parsing literal IP address in builtin dns stub resolver · ced0ba56
      Mikio Hara authored
      This CL fixes a bug introduced by CL 128820043 which is that
      builtin dns stub resolver doesn't work well with literal IPv6
      address namesever entries in /etc/resolv.conf.
      
      Also simplifies resolv.conf parser and adds more test cases.
      
      LGTM=iant
      R=golang-codereviews, bradfitz, iant
      CC=golang-codereviews
      https://golang.org/cl/140040043
      ced0ba56
  2. 03 Sep, 2014 14 commits
  3. 02 Sep, 2014 17 commits
  4. 01 Sep, 2014 3 commits