- 20 Feb, 2013 8 commits
-
-
Dmitriy Vyukov authored
This is followup to https://golang.org/cl/7319050/ R=golang-dev, dave CC=golang-dev https://golang.org/cl/7379043
-
Dmitriy Vyukov authored
Fixes #4819. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7322086
-
Dmitriy Vyukov authored
The removed code leads to the situation when M executes the same locked G again and again. This is https://golang.org/cl/7310096 but with return instead of break in the nested switch. Fixes #4820. R=golang-dev, alex.brainman, rsc CC=golang-dev https://golang.org/cl/7304102
-
Brad Fitzpatrick authored
The Camlistore code tree rearranged after the go tool came out. (I didn't know this link was here until I saw it in some logs.) R=adg CC=golang-dev https://golang.org/cl/7374043
-
Péter Surányi authored
On Windows, directory names in PATH can be fully or partially quoted in double quotes ('"'), but the path names as used by most APIs must be unquoted. In addition, quoted names can contain the semicolon (';') character, which is otherwise used as ListSeparator. This CL changes SplitList in path/filepath and LookPath in os/exec to only treat unquoted semicolons as separators, and to unquote the separated elements. (In addition, fix harmless test bug I introduced for LookPath on Unix.) Related discussion thread: https://groups.google.com/d/msg/golang-nuts/PXCr10DsRb4/sawZBM7scYgJ R=rsc, minux.ma, mccoyst, alex.brainman, iant CC=golang-dev https://golang.org/cl/7181047
-
Brian Dellisanti authored
Fixes #4844. R=golang-dev, alex.brainman CC=golang-dev https://golang.org/cl/7366043
-
Carl Shapiro authored
R=r, golang-dev CC=golang-dev https://golang.org/cl/7327053
-
Akshat Kumar authored
The data file should be opened when a Conn is first established, rather than waiting for the first Read or Write. Upon Close, we now make sure to try to close both, the ctl as well as data files and set both to nil, even in the face of errors, instead of returning early. The Accept call was not setting the remote address of the connection properly. Now, we read the correct file. Make functions that establish Conn use newTCPConn or newUDPConn. R=rsc, rminnich, ality, dave CC=golang-dev https://golang.org/cl/7228068
-
- 19 Feb, 2013 19 commits
-
-
Mikio Hara authored
This CL changes nothing to existing API behavior, just sets up Zone in IPNet and IPAddr structures if possible. Also does small simplification. Update #4234. R=rsc, dave CC=golang-dev https://golang.org/cl/7300081
-
Mikio Hara authored
On Linux point-to-point interface an IFA_ADDRESS attribute represents a peer address. For a correct interface address we should take an IFA_LOCAL attribute instead. Fixes #4839. R=golang-dev, dave, rsc CC=golang-dev https://golang.org/cl/7352045
-
Alan Donovan authored
This avoids ambiguity and makes the diagnostics closer to those issued by gc, but it is more verbose since it qualifies intra-package references. Without extra context---e.g. a 'from *Package' parameter to Type.String()---we are forced to err on one side or the other. Also, cosmetic changes to exp/ssa: - Remove package-qualification workaround in Function.FullName. - Always set go/types.Package.Path field to the import path, since we know the correct path at this point. - In Function.DumpTo, show variadic '...' and result type info, and delete now-redundant "# Type: " line. R=gri CC=golang-dev https://golang.org/cl/7325051
-
Robert Griesemer authored
R=golang-dev, dsymonds, bradfitz CC=golang-dev https://golang.org/cl/7323073
-
Robert Griesemer authored
Also: - faster code for example extraction - simplify handling of command documentation: all "main" packages are treated as commands - various minor cleanups along the way For commands written in Go, any doc.go file containing documentation must now be part of package main (rather then package documentation), otherwise the documentation won't show up in godoc (it will still build, though). For commands written in C, documentation may still be in doc.go files defining package documentation, but the recommended way is to explicitly ignore those files with a +build ignore constraint to define package main. Fixes #4806. R=adg, rsc, dave, bradfitz CC=golang-dev https://golang.org/cl/7333046
-
Kamil Kisiel authored
R=golang-dev, bradfitz, minux.ma CC=golang-dev https://golang.org/cl/7291043
-
Russ Cox authored
This comment matches the one in path. Fixes #4837. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7305100
-
Andrew Wilkins authored
side expression evaluation in assignment operations. R=golang-dev, gri CC=golang-dev https://golang.org/cl/7349046
-
Robin Eklind authored
ref: http://www.dwarfstd.org/doc/DWARF4.pdf Update #4829 R=minux.ma, iant CC=dave, golang-dev https://golang.org/cl/7354043
-
Donovan Hide authored
Slightly better benchmarks for when string and separator are equivalent and also less branching in inner loops. benchmark old ns/op new ns/op delta BenchmarkGenericNoMatch 3430 3442 +0.35% BenchmarkGenericMatch1 23590 22855 -3.12% BenchmarkGenericMatch2 108031 105025 -2.78% BenchmarkSingleMaxSkipping 2969 2704 -8.93% BenchmarkSingleLongSuffixFail 2826 2572 -8.99% BenchmarkSingleMatch 205268 197832 -3.62% BenchmarkByteByteNoMatch 987 921 -6.69% BenchmarkByteByteMatch 2014 1749 -13.16% BenchmarkByteStringMatch 3083 3050 -1.07% BenchmarkHTMLEscapeNew 922 915 -0.76% BenchmarkHTMLEscapeOld 1654 1570 -5.08% BenchmarkByteByteReplaces 11897 11556 -2.87% BenchmarkByteByteMap 4485 4255 -5.13% BenchmarkIndexRune 174 121 -30.46% BenchmarkIndexRuneFastPath 41 41 -0.24% BenchmarkIndex 45 44 -0.22% BenchmarkMapNoChanges 433 431 -0.46% BenchmarkIndexHard1 4015336 3316490 -17.40% BenchmarkIndexHard2 3976254 3395627 -14.60% BenchmarkIndexHard3 3973158 3378329 -14.97% BenchmarkCountHard1 4403549 3448512 -21.69% BenchmarkCountHard2 4387437 3413059 -22.21% BenchmarkCountHard3 4403891 3382661 -23.19% BenchmarkIndexTorture 28354 25864 -8.78% BenchmarkCountTorture 29625 27463 -7.30% BenchmarkFields 38752040 39169840 +1.08% BenchmarkFieldsFunc 38797765 38888060 +0.23% benchmark old MB/s new MB/s speedup BenchmarkSingleMaxSkipping 3367.07 3697.62 1.10x BenchmarkSingleLongSuffixFail 354.51 389.47 1.10x BenchmarkSingleMatch 73.07 75.82 1.04x BenchmarkFields 27.06 26.77 0.99x BenchmarkFieldsFunc 27.03 26.96 1.00x R=dave, fullung, remyoudompheng, rsc CC=golang-dev https://golang.org/cl/7350045
-
Russ Cox authored
Generated by addca. R=gobot CC=golang-dev https://golang.org/cl/7351046
-
Russ Cox authored
If Python blocks in the SSL handshake it seems to be completely uninterruptible, and I've been seeing it block for at least hours recently. I don't know if the problem is on the client side or the server side or somewhere in the network, but setting the timeout at least means you're guaranteed a new shell prompt (after printing some errors). R=golang-dev, bradfitz, minux.ma CC=golang-dev https://golang.org/cl/7337048
-
Russ Cox authored
R=golang-dev, agl CC=golang-dev https://golang.org/cl/7304106
-
Russ Cox authored
The exact words are taken from the spec. Fixes some confusion on golang-nuts. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7353044
-
Robin Eklind authored
If a test can be placed in the same package ("internal"), it is placed there. This facilitates testing of package-private details. Because of dependency cycles some packages cannot be tested by internal tests. R=golang-dev, rsc, mikioh.mikioh CC=golang-dev, r https://golang.org/cl/7323044
-
Shenghou Ma authored
R=iant CC=golang-dev https://golang.org/cl/7323064
-
Lucio De Re authored
R=minux.ma, bradfitz CC=golang-dev https://golang.org/cl/7307120
-
Volker Dobler authored
The current implementation would store all cookies received from any .com domain under "com" in the entries map if a nil public suffix list is used in constructing the Jar. This is inefficient. This CL uses the TLD+1 of the domain if the public suffix list is nil which has two advantages: - It uses the entries map efficiently. - It prevents a host foo.com to set cookies for bar.com. (It may set the cookie, but it won't be returned to bar.com.) A domain like www.british-library.uk may still set a domain cookie for .british-library.uk in this case. The behavior for a non-nil public suffix list is unchanged, cookies are stored under eTLD+1 in this case. R=nigeltao CC=golang-dev https://golang.org/cl/7312105
-
Andrew Wilkins authored
R=golang-dev, gri CC=golang-dev https://golang.org/cl/7358044
-
- 18 Feb, 2013 7 commits
-
-
Robert Griesemer authored
The field is nil for predeclared (universe) objects and parameter/result variables. R=adonovan CC=golang-dev https://golang.org/cl/7312093
-
Russ Cox authored
* Handle p==nil in signalstack by setting SS_DISABLE flag. * Make minit only allocate a signal g if there's not one already. R=golang-dev, r CC=golang-dev https://golang.org/cl/7323072
-
Russ Cox authored
copy+paste error while cleaning up CL 7303099 before submit R=ken2 CC=golang-dev https://golang.org/cl/7308104
-
Russ Cox authored
The routine that adds an automatic to the stack was adding ptrsize-1 to the size before rounding up. That addition would only make sense to turn a round down into a round up. Before a round up, it just wastes a word. The effect was that a 6c function with one local and one two-word function call used (8+8)+(16+8) = 40 bytes instead of 8+16 = 24 bytes. The wasted space mostly didn't matter, but one place where it does matter is when trying to stay within the 128-byte total frame constraint for #pragma textflag 7 functions. This only affects the C compilers, not the Go compilers. 5c already had correct code, which is now copied to 6c and 8c. R=ken2 CC=golang-dev https://golang.org/cl/7303099
-
Dmitriy Vyukov authored
Fixes #4835. R=golang-dev, fullung CC=golang-dev https://golang.org/cl/7319050
-
David Symonds authored
Fixes #3308. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/7301086
-
Volker Dobler authored
Re-enable TestUpdateAndDelete, TestExpiration, TestChromiumDomain and TestChromiumDeletion on Windows. Sorting of cookies with same path length and same creation time is done by an additional seqNum field. This makes the order in which cookies are returned in Cookies deterministic, even if the system clock is manipulated or on systems with a low-resolution clock. The tests now use a synthetic time: This makes cookie testing reliable in case of bogus system clocks and speeds up the expiration tests. R=nigeltao, alex.brainman, dave CC=golang-dev https://golang.org/cl/7323063
-
- 17 Feb, 2013 2 commits
-
-
Joel Sing authored
Fix the sa_mask member of the sigaction struct - on FreeBSD this is declared as a sigset_t, which is an array of four unsigned ints. Replace the current int64 with Sigset from defs_freebsd_GOARCH, which has the correct definition. Unbreaks the FreeBSD builds. R=golang-dev, dave, minux.ma CC=golang-dev https://golang.org/cl/7333047
-
Rémy Oudompheng authored
The O(n+m) complexity is obtained probabilistically by using Rabin-Karp algorithm, which provides the needed complexity unless exceptional collisions occur, without memory allocation. benchmark old ns/op new ns/op delta BenchmarkIndexHard1 6532331 4045886 -38.06% BenchmarkIndexHard2 8178173 4038975 -50.61% BenchmarkIndexHard3 6973687 4042591 -42.03% BenchmarkCountHard1 6270864 4071090 -35.08% BenchmarkCountHard2 7838039 4072853 -48.04% BenchmarkCountHard3 6697828 4071964 -39.20% BenchmarkIndexTorture 2730546 28934 -98.94% BenchmarkCountTorture 2729622 29064 -98.94% Fixes #4600. R=rsc, donovanhide, remyoudompheng CC=golang-dev https://golang.org/cl/7314095
-
- 16 Feb, 2013 3 commits
-
-
Georg Reinke authored
R=golang-dev, jsing CC=golang-dev https://golang.org/cl/7312104
-
Mikio Hara authored
Also refactors mock ICMP stuff. R=dave, rsc CC=golang-dev https://golang.org/cl/7325043
-
Dave Cheney authored
R=rsc, dvyukov CC=golang-dev https://golang.org/cl/7312103
-
- 15 Feb, 2013 1 commit
-
-
Russ Cox authored
broke windows build ««« original CL description runtime: ensure forward progress of runtime.Gosched() for locked goroutines The removed code leads to the situation when M executes the same locked G again and again. Fixes #4820. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7310096 »»» TBR=dvyukov CC=golang-dev https://golang.org/cl/7343050
-