Commits · e919275825d65806986035715d705387e72048b8 · Kirill Smelkov / go

02 Dec, 2009 1 commit

Integrated feedback by Ken. · e9192758

Robert Griesemer authored Dec 01, 2009

Easy stuff in this round, more to come.

R=iant, rsc, r, ken2
https://golang.org/cl/163058

e9192758

01 Dec, 2009 12 commits

Explicitly return values where it's shadowing the parameter. · 4f6dbc69

Christopher Wedgwood authored Dec 01, 2009

Bad returns noticed by "Devon H. O'Dell" <devon.odell@gmail.com>.

Resolves Issue 360.

R=rsc, dho, agl, agl1
CC=ukai
https://golang.org/cl/163055

4f6dbc69

8g: fix 386 floating point stack bug · e1c347ca
Charles L. Dorian authored Dec 01, 2009
```
Also fixes issue 310 comment 5 error.
Fixes #310.

R=rsc
https://golang.org/cl/163042
```
e1c347ca

more gob bugs · a0f742d3

Rob Pike authored Dec 01, 2009

1) need to send slice and array types (was only sending element types)
2) compatibleType needs to use decoder's type map

R=rsc
CC=golang-dev
https://golang.org/cl/164062

a0f742d3

make test.sh work again · 749da968
Robert Griesemer authored Dec 01, 2009
```
R=rsc
https://golang.org/cl/164059
```
749da968
A/C: add Charles L. Dorian · 20cacd64
Russ Cox authored Dec 01, 2009
```
R=r
https://golang.org/cl/164060
```
20cacd64
Added Sven Almgren to AUTHORS and CONTRIBUTORS · 5dd66f01
Sven Almgren authored Dec 01, 2009
```
R=rsc
https://golang.org/cl/163053
```
5dd66f01
a couple of usage fixups in prof · 67dc2ae3
Rob Pike authored Dec 01, 2009
```
R=rsc
https://golang.org/cl/161050
```
67dc2ae3

gofmt: use os.Stdin instead of opening /dev/stdin · db18ce2f

Fazlul Shahriar authored Dec 01, 2009

Opening /dev/stdin can sometimes fail. For example, in the acme editor,
executing "Edit ,|gofmt" fails with:

	open /dev/stdin: no such device or address

Executing "Edit ,|ls -l /dev/stdin /proc/self/fd/0" gives:

	lrwxrwxrwx 1 root root  15 2009-09-07 02:17 /dev/stdin -> /proc/self/fd/0
	lrwx------ 1 fhs  users 64 2009-11-26 22:05 /proc/self/fd/0 -> socket:[5528230]

(This is my first change, and I've signed the individual contributor license agreement.)

R=rsc, gri
CC=golang-dev
https://golang.org/cl/162041

db18ce2f

some godoc cleanup: · 9e450880

Robert Griesemer authored Dec 01, 2009

- simplified dealing with parse errors: no need to intersperse them in the source
- improve visibility of highlighted identifiers by showing them in bold

R=rsc
https://golang.org/cl/163051

9e450880

Fix typo in spec · 330139e3
Fazlul Shahriar authored Nov 30, 2009
```
R=golang-dev, rsc
https://golang.org/cl/164052
```
330139e3
Syntax coloring and function navigation for BBEdit/TextWrangler · 593ea313
Anthony Starks authored Nov 30, 2009
```
R=rsc
CC=agl1
https://golang.org/cl/154123
```
593ea313
Adding to AUTHORS and CONTRIBUTORS as per http://golang.org/doc/contribute.html#copyright · 1cf5d0d4
Anthony Starks authored Nov 30, 2009
```
R=rsc
https://golang.org/cl/163050
```
1cf5d0d4

30 Nov, 2009 21 commits
- change command-line argument to be · 99d0c3d8
  Roger Peppe authored Nov 30, 2009
```
unnamed, not require -n, in line with other
entries.

R=rsc
CC=r
https://golang.org/cl/162061
```
  99d0c3d8
- Make tests run on systems missing time utility · 842d69b0
  Sergey 'SnakE' Gromov authored Nov 30, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/164047
```
  842d69b0
- Added my name to the AUTHORS and CONTRIBUTORS files. · 5fcb0087
  Adrian O'Grady authored Nov 30, 2009
```
R=rsc
https://golang.org/cl/157153
```
  5fcb0087
- A first stab at porting the XCB X11 protocol bindings to go. · 598f3e28
  Tor Andersson authored Nov 30, 2009
```
The python script needs a checkout of xcb/proto to generate
an xproto.go file, which together with xgb.go provide functions
to access all of the core X11 protocol requests. I have included the
generated file.

Extensions and authentication methods are not implemented.

R=r, rsc, nigeltao_golang
https://golang.org/cl/162053
```
  598f3e28
- json: Decode into native Go data structures · 9d50b468
  Sergey 'SnakE' Gromov authored Nov 30, 2009
```
This patch adds an ability to convert JSON-encoded data into
a hierarchy of Go's native data types.

R=rsc
CC=golang-dev
https://golang.org/cl/161060
```
  9d50b468
- Typo in comment. · c1767dbd
  Robert Griesemer authored Nov 30, 2009
```
Fixes #358.

R=rsc
CC=r
https://golang.org/cl/164043
```
  c1767dbd
- sync.RWMutex: rewritten to add support for concurrent readers. · 12206f64
  Péter Szabó authored Nov 30, 2009
```
Also made sync.xadd public to help testing sync.RWMutex.

Also added unit tests for sync.RWMutex.

R=rsc
https://golang.org/cl/162044
```
  12206f64
- Added a method on UDPConn so they can actually send broadcast packets. · 229807c8
  Jonathan Wills authored Nov 30, 2009
```
R=rsc
https://golang.org/cl/162046
```
  229807c8
- a[b:len(a)] -> a[b:] · a85c258e
  Christopher Wedgwood authored Nov 30, 2009
```
R=r, rsc
CC=agl1
https://golang.org/cl/161070
```
  a85c258e
- Handle \r as a whitespace when parsing JSON string. · 68d3b6e5
  Andrew Skiba authored Nov 30, 2009
```
Fixes #272.

R=rsc
https://golang.org/cl/161061
```
  68d3b6e5
- Add trivial whitespace to CorruptInputError strings. · c78710f5
  Christopher Wedgwood authored Nov 30, 2009
```
R=r, rsc
https://golang.org/cl/161058
```
  c78710f5
- Minimise bitrot: bytes.Copy -> copy · f0c97195
  Christopher Wedgwood authored Nov 30, 2009
```
(compile tested only)

R=r, rsc
https://golang.org/cl/161069
```
  f0c97195
- Ports of lib9, libbio and libmach to Windows. · cd9d72ba
  Hector Chu authored Nov 30, 2009
```
R=rsc
https://golang.org/cl/157159
```
  cd9d72ba
- AUTHORS+CONTRIBUTORS: more names; CLA verified · 49c859a5
  Russ Cox authored Nov 30, 2009
```
R=gri
CC=r
https://golang.org/cl/163044
```
  49c859a5
- template: two bug fixes / nits · ed62d27a
  Russ Cox authored Nov 30, 2009
```
  * diagnose template not created with New
    (current code just crashes)
  * write []byte uninterpreted
    (current code writes fmt format: "[65 65 65 65]")

R=r
CC=golang-dev
https://golang.org/cl/161075
```
  ed62d27a
- codereview: allow editing of local CL description · be32c6aa
  Russ Cox authored Nov 30, 2009
```
between hg clpatch and hg submit.

R=r
https://golang.org/cl/162059
```
  be32c6aa
- AUTHORS/CONTRIBUTORS: two more names · 1dc65e3a
  Russ Cox authored Nov 30, 2009
```
R=r, SnakE
CC=fhs, pts
https://golang.org/cl/162054
```
  1dc65e3a
- Fix example Makefile to avoid $GOROOT in case it has spaces. · 65112628
  Fumitoshi Ukai authored Nov 29, 2009
```
R=rsc, sergio
https://golang.org/cl/162058
```
  65112628
- websocket: avoid $GOROOT in case it has spaces · be98bc48
  Russ Cox authored Nov 29, 2009
```
Fixes #115.

R=r, ukai, sergio
https://golang.org/cl/162057
```
  be98bc48
- crypto/md4, exp/draw/x11: fix makefile to build when GOROOT has whitespaces · 46892656
  Sergio Luis O. B. Correia authored Nov 29, 2009
```
this is the exact same thing issue #115 is about. fix makefiles to use relative
path to work in the case we have whitespaces as part of GOROOT.

R=rsc
https://golang.org/cl/162055
```
  46892656
- cgo: use C type void for opaque types if dwarf.Common().Type returns nothing · 354b1005
  Eden Li authored Nov 29, 2009
```
Ideally, the C name would come from the typedef or pointer that
references the Size<0 type, but we can't easily generate this without
performing a look-ahead to see if any referencing type will become opaque.

Fixes #334.
Fixes #281.

R=rsc
https://golang.org/cl/161056
```
  354b1005
29 Nov, 2009 4 commits
- Add WebSocket server framework hooked into http. · f9f0184e
  Fumitoshi Ukai authored Nov 29, 2009
```
R=r, rsc
https://golang.org/cl/156071
```
  f9f0184e
- Make comment-start/-end changes buffer-local instead of global. · 6e6125ff
  Austin Clements authored Nov 29, 2009
```
Fixes #290.

R=rsc
https://golang.org/cl/160070
```
  6e6125ff
- Add myself to CONTRIBUTORS · 770f3538
  Fumitoshi Ukai authored Nov 29, 2009
```
R=r, rsc
https://golang.org/cl/156070
```
  770f3538
- Correct expression level for argument lists. · f3e0f214
  Robert Griesemer authored Nov 29, 2009
```
Fixes #352.

R=rsc
https://golang.org/cl/161073
```
  f3e0f214
25 Nov, 2009 2 commits

a few utf8 benchmarks. on my mac: · b5358e06

Rob Pike authored Nov 25, 2009

utf8_test.BenchmarkRuneCountTenASCIIChars	20000000	       108 ns/op
utf8_test.BenchmarkRuneCountTenJapaneseChars	10000000	       199 ns/op
utf8_test.BenchmarkEncodeASCIIRune	500000000	         6 ns/op
utf8_test.BenchmarkEncodeJapaneseRune	100000000	        10 ns/op
utf8_test.BenchmarkDecodeASCIIRune	100000000	        13 ns/op
utf8_test.BenchmarkDecodeJapaneseRune	100000000	        21 ns/op

R=gri
CC=golang-dev
https://golang.org/cl/161049

b5358e06

rewrite RuneCountInString to use range. · 773e7798
Rob Pike authored Nov 25, 2009
```
R=gri
CC=golang-dev
https://golang.org/cl/160069
```
773e7798