1. 24 Sep, 2012 2 commits
  2. 23 Sep, 2012 7 commits
  3. 22 Sep, 2012 6 commits
  4. 21 Sep, 2012 10 commits
  5. 20 Sep, 2012 9 commits
  6. 19 Sep, 2012 6 commits
    • David Symonds's avatar
      vet: fix rangeloop. · 5a93fea0
      David Symonds authored
      In a range loop, the presence of a value implies the presence of a key.
      However, the presence of a value as an *ast.Ident does not imply that
      the key is also an *ast.Ident, thus leading to a panic any time the
      two argument form is used where the key is not an identifier.
      
      R=golang-dev, adg, r
      CC=golang-dev
      https://golang.org/cl/6540045
      5a93fea0
    • David Symonds's avatar
      misc/vim: fix Drop for imports after the first group. · adcf0a2a
      David Symonds authored
      Previously, an import block such as
      	import (
              	"net"
      
                      "stack"
              )
      would not permit ":Drop stack" to work because we were aborting
      the scan early, which is only correct when Import is in operation.
      
      R=golang-dev, franciscossouza
      CC=golang-dev
      https://golang.org/cl/6532053
      adcf0a2a
    • Robert Griesemer's avatar
      gofmt: added testcase for files containing \r\n line endings · 83601807
      Robert Griesemer authored
      (see also issue 3961).
      
      hexdump -c testdata/crlf.input
      0000000   /   *  \r  \n  \t   S   o   u   r   c   e       c   o   n   t
      0000010   a   i   n   i   n   g       C   R   /   L   F       l   i   n
      0000020   e       e   n   d   i   n   g   s   .  \r  \n  \t   T   h   e
      0000030       g   o   f   m   t   '   e   d       o   u   t   p   u   t
      0000040       m   u   s   t       o   n   l   y       h   a   v   e
      0000050   L   F  \r  \n  \t   l   i   n   e       e   n   d   i   n   g
      0000060   s   .  \r  \n   *   /  \r  \n   p   a   c   k   a   g   e
      0000070   m   a   i   n  \r  \n  \r  \n   f   u   n   c       m   a   i
      0000080   n   (   )       {  \r  \n  \t   /   /       l   i   n   e
      0000090   c   o   m   m   e   n   t  \r  \n  \t   p   r   i   n   t   l
      00000a0   n   (   "   h   e   l   l   o   ,       w   o   r   l   d   !
      00000b0   "   )       /   /       a   n   o   t   h   e   r       l   i
      00000c0   n   e       c   o   m   m   e   n   t  \r  \n  \t   p   r   i
      00000d0   n   t   l   n   (   )  \r  \n   }  \r  \n
      00000db
      
      hexdump -c testdata/crlf.golden
      0000000   /   *  \n  \t   S   o   u   r   c   e       c   o   n   t   a
      0000010   i   n   i   n   g       C   R   /   L   F       l   i   n   e
      0000020       e   n   d   i   n   g   s   .  \n  \t   T   h   e       g
      0000030   o   f   m   t   '   e   d       o   u   t   p   u   t       m
      0000040   u   s   t       o   n   l   y       h   a   v   e       L   F
      0000050  \n  \t   l   i   n   e       e   n   d   i   n   g   s   .  \n
      0000060   *   /  \n   p   a   c   k   a   g   e       m   a   i   n  \n
      0000070  \n   f   u   n   c       m   a   i   n   (   )       {  \n  \t
      0000080   /   /       l   i   n   e       c   o   m   m   e   n   t  \n
      0000090  \t   p   r   i   n   t   l   n   (   "   h   e   l   l   o   ,
      00000a0       w   o   r   l   d   !   "   )       /   /       a   n   o
      00000b0   t   h   e   r       l   i   n   e       c   o   m   m   e   n
      00000c0   t  \n  \t   p   r   i   n   t   l   n   (   )  \n   }  \n
      00000cf
      
      R=rsc
      CC=golang-dev
      https://golang.org/cl/6526052
      83601807
    • Robert Griesemer's avatar
      encoding/gob: fix comment · 93195e1f
      Robert Griesemer authored
      Fixes #4100.
      
      R=adg, r, dave
      CC=golang-dev
      https://golang.org/cl/6535055
      93195e1f
    • Shenghou Ma's avatar
      src/all.bat: fix banner · 2e7aaedd
      Shenghou Ma authored
      we need to restore %PATH% before calling "dist banner", so that
      it could suggest the user to add %GOROOT%/bin to %PATH% if necessary.
      
      R=golang-dev, bradfitz
      CC=golang-dev
      https://golang.org/cl/6525049
      2e7aaedd
    • Shenghou Ma's avatar
      misc/cgo/stdio: make it work on Windows and also test it · 674bbafc
      Shenghou Ma authored
      use a function to get stdout and stderr, instead of depending
      on a specific libc implementation.
      also make test/run.go replace \r\n by \n before comparing
      output.
      
              Fixes #2121.
              Part of issue 1741.
      
      R=alex.brainman, rsc, r, remyoudompheng
      CC=golang-dev
      https://golang.org/cl/5847068
      674bbafc