1. 15 May, 2015 22 commits
    • Alex A Skinner's avatar
      net: redo resolv.conf recheck implementation · ef7e1085
      Alex A Skinner authored
      The previous implementation spawned an extra goroutine to handle
      rechecking resolv.conf for changes.
      
      This change eliminates the extra goroutine, and has rechecking
      done as part of a lookup.  A side effect of this change is that the
      first lookup after a resolv.conf change will now succeed, whereas
      previously it would have failed.  It also fixes rechecking logic to
      ignore resolv.conf parsing errors as it should.
      
      Fixes #8652
      Fixes #10576
      Fixes #10649
      Fixes #10650
      Fixes #10845
      
      Change-Id: I502b587c445fa8eca5207ca4f2c8ec8c339fec7f
      Reviewed-on: https://go-review.googlesource.com/9991
      Run-TryBot: Matthew Dempsky <mdempsky@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarJosh Bleecher Snyder <josharian@gmail.com>
      Reviewed-by: default avatarMikio Hara <mikioh.mikioh@gmail.com>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      ef7e1085
    • Robert Griesemer's avatar
      go/parser: better error message for missing ',' in lists · 40fad6c2
      Robert Griesemer authored
      Fixes #8940.
      
      Change-Id: Ie9e5149983518ba8d56ddd82ac8f4cde6b644167
      Reviewed-on: https://go-review.googlesource.com/10089Reviewed-by: default avatarAlan Donovan <adonovan@google.com>
      40fad6c2
    • Matthew Dempsky's avatar
      cmd/internal/obj: update callers to Linkline{fmt,hist} and remove · 1467776b
      Matthew Dempsky authored
      Does the TODOs added by https://golang.org/cl/7623.
      
      Passes rsc.io/toolstash/buildall.
      
      Change-Id: I23913a8f03834640e9795d48318febb3f88c10f9
      Reviewed-on: https://go-review.googlesource.com/9160Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      1467776b
    • Matthew Dempsky's avatar
      cmd/internal/gc, cmd/yacc: merge yaccerrors.go into cmd/yacc · 82e1651a
      Matthew Dempsky authored
      This extends cmd/yacc with support for
      
      	%error { tokens } : message
      
      syntax to specify custom error messages to use instead of the default
      generic ones.  This allows merging go.errors into go.y and removing
      the yaccerrors.go tool.
      
      Updates #9968.
      
      Change-Id: I781219c568b86472755f877f48401eaeab00ead5
      Reviewed-on: https://go-review.googlesource.com/8563Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      82e1651a
    • Brad Fitzpatrick's avatar
      syscall: don't run fcntl child process test on iOS · d4ed3061
      Brad Fitzpatrick authored
      Fixes darwin-arm{,64} builds.
      Child processes aren't allowed on iOS.
      
      Change-Id: I9258ed4df757ec394ef6327dbda96f5b9705bcdd
      Reviewed-on: https://go-review.googlesource.com/10142Reviewed-by: default avatarHyang-Ah Hana Kim <hyangah@gmail.com>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      d4ed3061
    • Brad Fitzpatrick's avatar
      Revert "cmd/internal/gc: ignore declarations of types for goto validation" · 97494a45
      Brad Fitzpatrick authored
      This reverts commit 5726af54.
      
      It broke all the builds.
      
      Change-Id: I4b1dde86f9433717d303c1dabd6aa1a2bf97fab2
      Reviewed-on: https://go-review.googlesource.com/10143Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      97494a45
    • Håvard Haugen's avatar
      encoding/json: fix decoding of types with '[]byte' as underlying type · 4302fd04
      Håvard Haugen authored
      All slice types which have elements of kind reflect.Uint8 are marshalled
      into base64 for compactness. When decoding such data into a custom type
      based on []byte the decoder checked the slice kind instead of the slice
      element kind, so no appropriate decoder was found.
      
      Fixed by letting the decoder check slice element kind like the encoder.
      This guarantees that already encoded data can still be successfully
      decoded.
      
      Fixes #8962.
      
      Change-Id: Ia320d4dc2c6e9e5fe6d8dc15788c81da23d20c4f
      Reviewed-on: https://go-review.googlesource.com/9371Reviewed-by: default avatarPeter Waldschmidt <peter@waldschmidt.com>
      Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      4302fd04
    • Daniel Morsing's avatar
      cmd/internal/gc: ignore declarations of types for goto validation · 5726af54
      Daniel Morsing authored
      Fixes #8042.
      
      Change-Id: I75080f24104256065fd73b07a13c5b8e7d6da94c
      Reviewed-on: https://go-review.googlesource.com/9442Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      5726af54
    • Josh Bleecher Snyder's avatar
      cmd/internal/gc: separate Name-only Node fields · 76ec0ee5
      Josh Bleecher Snyder authored
      Name will be converted from an anonymous to a
      named field in a subsequent, automated CL.
      
      No functional changes. Passes toolstash -cmp.
      
      This reduces the size of gc.Node from 424 to 400 bytes.
      This in turn reduces the permanent (pprof -inuse_space)
      memory usage while compiling the test/rotate?.go tests:
      
      test	old(MB)	new(MB)	change
      rotate0	379.49	367.30	-3.21%
      rotate1	373.42	361.59	-3.16%
      rotate2	381.17	368.77	-3.25%
      rotate3	374.30	362.48	-3.15%
      
      Updates #9933.
      
      Change-Id: I21479527c136add4f1efb9342774e3be3e276e83
      Reviewed-on: https://go-review.googlesource.com/10120Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      76ec0ee5
    • Josh Bleecher Snyder's avatar
      cmd/internal/gc: convert Val.U to interface{} · 13485be9
      Josh Bleecher Snyder authored
      This CL was generated by updating Val in go.go
      and then running:
      
      sed -i "" 's/\.U\.[SBXFC]val = /.U = /' *.go
      sed -i "" 's/\.U\.Sval/.U.\(string\)/g' *.go *.y
      sed -i "" 's/\.U\.Bval/.U.\(bool\)/g' *.go *.y
      sed -i "" 's/\.U\.Xval/.U.\(\*Mpint\)/g' *.go *.y
      sed -i "" 's/\.U\.Fval/.U.\(\*Mpflt\)/g' *.go *.y
      sed -i "" 's/\.U\.Cval/.U.\(\*Mpcplx\)/g' *.go *.y
      
      No functional changes. Passes toolstash -cmp.
      
      This reduces the size of gc.Node from 424 to 392 bytes.
      This in turn reduces the permanent (pprof -inuse_space)
      memory usage while compiling the test/rotate?.go tests:
      
      test	old(MB)	new(MB)	change
      rotate0	379.49	364.78	-3.87%
      rotate1	373.42	359.07	-3.84%
      rotate2	381.17	366.24	-3.91%
      rotate3	374.30	359.95	-3.83%
      
      CL 8445 was similar to this; gri asked that Val's implementation
      be hidden first. CLs 8912, 9263, and 9267 have at least
      isolated the changes to the cmd/internal/gc package.
      
      Updates #9933.
      
      Change-Id: I83ddfe003d48e0a73c92e819edd3b5e620023084
      Reviewed-on: https://go-review.googlesource.com/10059Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      13485be9
    • Josh Bleecher Snyder's avatar
      cmd/internal/gc: explicitly set zero bool Val · 3c06cff7
      Josh Bleecher Snyder authored
      This trivial change is a prerequisite to
      converting Val.U to an interface{}.
      
      No functional changes. Passes toolstash -cmp.
      
      Change-Id: I17ff036f68d29a9ed0097a8b23ae1c91e6ce8c21
      Reviewed-on: https://go-review.googlesource.com/10058Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      3c06cff7
    • Josh Bleecher Snyder's avatar
      cmd/5g, etc: prepare Node.Val to be unexported · ba577811
      Josh Bleecher Snyder authored
      Remove all uses of Node.Val outside of the gc package.
      
      A subsequent, automated commit in the Go 1.6 cycle
      will unexport Node.Val.
      
      No functional changes. Passes toolstash -cmp.
      
      Change-Id: Ia92ae6a7766c83ab3e45c69edab24a9581c824f9
      Reviewed-on: https://go-review.googlesource.com/9267Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      ba577811
    • Josh Bleecher Snyder's avatar
      cmd/5g, etc: prepare to unexport gc.Mp* · 0112f6f6
      Josh Bleecher Snyder authored
      Remove all uses of Mp* outside of the gc package.
      
      A subsequent, automated commit in the Go 1.6
      cycle will unexport all Mp* functions and types.
      
      No functional changes. Passes toolstash -cmp.
      
      Change-Id: Ie1604cb5b84ffb30b47f4777d4235570f2c62709
      Reviewed-on: https://go-review.googlesource.com/9263Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      0112f6f6
    • Russ Cox's avatar
      runtime: allocate map element zero values for reflect-created types on demand · 7e26a2d9
      Russ Cox authored
      Preallocating them in reflect means that
      (1) if you say _ = PtrTo(ArrayOf(1000000000, reflect.TypeOf(byte(0)))), you just allocated 1GB of data
      (2) if you say it again, that's *another* GB of data.
      
      The only use of t.zero in the runtime is for map elements.
      Delay the allocation until the creation of a map with that element type,
      and share the zeros.
      
      The one downside of the shared zero is that it's not garbage collected,
      but it's also never written, so the OS should be able to handle it fairly
      efficiently.
      
      Change-Id: I56b098a091abf3ac0945de28ebef9a6c08e76614
      Reviewed-on: https://go-review.googlesource.com/10111Reviewed-by: default avatarKeith Randall <khr@golang.org>
      7e26a2d9
    • Russ Cox's avatar
      runtime: optimize heapBitsBulkBarrier a tiny amount · 65c4d7be
      Russ Cox authored
      This may be mostly noise but:
      
      name                   old mean              new mean              delta
      BinaryTree17            6.03s × (0.98,1.02)   5.98s × (0.97,1.03)    ~    (p=0.306)
      Fannkuch11              4.42s × (0.99,1.01)   4.34s × (0.99,1.02)  -1.83% (p=0.000)
      FmtFprintfEmpty        84.7ns × (0.99,1.01)  84.4ns × (1.00,1.00)    ~    (p=0.138)
      FmtFprintfString        289ns × (0.98,1.02)   289ns × (1.00,1.01)    ~    (p=0.509)
      FmtFprintfInt           280ns × (0.97,1.03)   272ns × (0.98,1.03)  -2.64% (p=0.003)
      FmtFprintfIntInt        484ns × (0.98,1.02)   482ns × (0.98,1.03)    ~    (p=0.606)
      FmtFprintfPrefixedInt   397ns × (0.98,1.03)   393ns × (0.99,1.02)    ~    (p=0.064)
      FmtFprintfFloat         573ns × (0.99,1.01)   569ns × (0.99,1.01)  -0.69% (p=0.023)
      FmtManyArgs            1.89µs × (0.99,1.02)  1.91µs × (0.98,1.02)    ~    (p=0.219)
      GobDecode              15.4ms × (0.99,1.02)  15.1ms × (0.99,1.01)  -2.05% (p=0.000)
      GobEncode              12.0ms × (0.97,1.04)  11.9ms × (0.97,1.03)    ~    (p=0.458)
      Gzip                    652ms × (0.99,1.01)   653ms × (0.99,1.01)    ~    (p=0.743)
      Gunzip                  144ms × (0.99,1.01)   143ms × (0.99,1.01)    ~    (p=0.134)
      HTTPClientServer       91.6µs × (0.99,1.01)  91.8µs × (0.99,1.03)    ~    (p=0.678)
      JSONEncode             31.9ms × (1.00,1.00)  32.0ms × (0.99,1.01)    ~    (p=0.334)
      JSONDecode              110ms × (0.99,1.01)   110ms × (0.99,1.01)    ~    (p=0.315)
      Mandelbrot200          6.04ms × (0.99,1.01)  6.04ms × (1.00,1.01)    ~    (p=0.596)
      GoParse                6.72ms × (0.98,1.03)  6.74ms × (0.99,1.03)    ~    (p=0.577)
      RegexpMatchEasy0_32     161ns × (0.99,1.01)   160ns × (1.00,1.00)  -0.83% (p=0.002)
      RegexpMatchEasy0_1K     542ns × (0.99,1.02)   541ns × (0.99,1.01)    ~    (p=0.396)
      RegexpMatchEasy1_32     140ns × (0.98,1.01)   137ns × (1.00,1.00)  -2.12% (p=0.000)
      RegexpMatchEasy1_1K     892ns × (0.99,1.01)   891ns × (1.00,1.01)    ~    (p=0.631)
      RegexpMatchMedium_32    255ns × (0.99,1.01)   253ns × (0.99,1.01)  -0.76% (p=0.008)
      RegexpMatchMedium_1K   73.1µs × (1.00,1.01)  72.9µs × (1.00,1.00)    ~    (p=0.229)
      RegexpMatchHard_32     3.86µs × (1.00,1.01)  3.85µs × (1.00,1.00)    ~    (p=0.341)
      RegexpMatchHard_1K      117µs × (1.00,1.01)   117µs × (0.99,1.00)    ~    (p=0.955)
      Revcomp                 954ms × (0.97,1.03)   955ms × (0.98,1.02)    ~    (p=0.894)
      Template                133ms × (0.97,1.05)   129ms × (0.99,1.02)  -2.50% (p=0.014)
      TimeParse               629ns × (0.99,1.01)   626ns × (0.99,1.01)    ~    (p=0.106)
      TimeFormat              663ns × (0.99,1.01)   660ns × (0.99,1.02)    ~    (p=0.231)
      
      Change-Id: I580e03ed01b0629cb5eae4c4637618f20127f924
      Reviewed-on: https://go-review.googlesource.com/9994Reviewed-by: default avatarAustin Clements <austin@google.com>
      65c4d7be
    • Russ Cox's avatar
      runtime: use memmove during slice append · 497970f4
      Russ Cox authored
      The effect of this CL:
      
      name                   old mean              new mean              delta
      BinaryTree17            5.97s × (0.96,1.04)   5.95s × (0.98,1.02)    ~    (p=0.697)
      Fannkuch11              4.39s × (1.00,1.01)   4.41s × (1.00,1.01)  +0.52% (p=0.015)
      FmtFprintfEmpty        90.8ns × (0.97,1.05)  89.4ns × (0.94,1.13)    ~    (p=0.571)
      FmtFprintfString        305ns × (0.99,1.01)   292ns × (0.98,1.05)  -4.35% (p=0.000)
      FmtFprintfInt           278ns × (0.96,1.03)   279ns × (0.98,1.04)    ~    (p=0.741)
      FmtFprintfIntInt        489ns × (0.99,1.02)   482ns × (0.98,1.03)  -1.43% (p=0.024)
      FmtFprintfPrefixedInt   402ns × (0.98,1.02)   395ns × (0.98,1.03)  -1.67% (p=0.014)
      FmtFprintfFloat         578ns × (1.00,1.00)   569ns × (0.99,1.01)  -1.48% (p=0.000)
      FmtManyArgs            1.88µs × (0.99,1.01)  1.88µs × (1.00,1.01)    ~    (p=0.055)
      GobDecode              15.3ms × (0.99,1.01)  15.2ms × (1.00,1.01)  -0.61% (p=0.007)
      GobEncode              11.8ms × (0.98,1.05)  11.6ms × (0.99,1.01)    ~    (p=0.075)
      Gzip                    647ms × (0.99,1.01)   647ms × (1.00,1.00)    ~    (p=0.790)
      Gunzip                  143ms × (1.00,1.00)   142ms × (1.00,1.00)    ~    (p=0.370)
      HTTPClientServer       91.2µs × (0.99,1.01)  91.7µs × (0.99,1.02)    ~    (p=0.233)
      JSONEncode             31.5ms × (0.98,1.01)  31.8ms × (0.99,1.02)  +1.09% (p=0.015)
      JSONDecode              110ms × (0.99,1.01)   110ms × (0.99,1.02)    ~    (p=0.577)
      Mandelbrot200          6.00ms × (1.00,1.00)  6.02ms × (1.00,1.00)  +0.24% (p=0.001)
      GoParse                6.68ms × (0.98,1.02)  6.61ms × (0.99,1.01)  -1.10% (p=0.027)
      RegexpMatchEasy0_32     162ns × (1.00,1.00)   161ns × (1.00,1.01)  -0.66% (p=0.001)
      RegexpMatchEasy0_1K     539ns × (1.00,1.00)   539ns × (0.99,1.01)    ~    (p=0.509)
      RegexpMatchEasy1_32     140ns × (0.99,1.02)   139ns × (0.99,1.02)    ~    (p=0.163)
      RegexpMatchEasy1_1K     886ns × (1.00,1.00)   887ns × (1.00,1.00)    ~    (p=0.408)
      RegexpMatchMedium_32    252ns × (1.00,1.00)   255ns × (0.99,1.01)  +1.01% (p=0.000)
      RegexpMatchMedium_1K   72.6µs × (1.00,1.00)  72.6µs × (1.00,1.00)    ~    (p=0.176)
      RegexpMatchHard_32     3.84µs × (1.00,1.00)  3.84µs × (1.00,1.00)    ~    (p=0.403)
      RegexpMatchHard_1K      117µs × (1.00,1.00)   117µs × (1.00,1.00)    ~    (p=0.351)
      Revcomp                 926ms × (0.99,1.01)   925ms × (0.99,1.01)    ~    (p=0.541)
      Template                126ms × (0.99,1.02)   130ms × (0.99,1.01)  +3.42% (p=0.000)
      TimeParse               632ns × (0.99,1.01)   626ns × (1.00,1.00)  -0.88% (p=0.000)
      TimeFormat              658ns × (0.99,1.01)   662ns × (0.99,1.02)    ~    (p=0.111)
      
      The effect of this CL combined with CL 9886:
      
      name                   old mean              new mean              delta
      BinaryTree17            5.90s × (0.98,1.03)   5.95s × (0.98,1.02)    ~    (p=0.175)
      Fannkuch11              4.34s × (1.00,1.00)   4.41s × (1.00,1.01)  +1.69% (p=0.000)
      FmtFprintfEmpty        87.3ns × (0.97,1.17)  89.4ns × (0.94,1.13)    ~    (p=0.499)
      FmtFprintfString        288ns × (0.98,1.04)   292ns × (0.98,1.05)    ~    (p=0.292)
      FmtFprintfInt           290ns × (0.98,1.05)   279ns × (0.98,1.04)  -3.76% (p=0.001)
      FmtFprintfIntInt        493ns × (0.98,1.04)   482ns × (0.98,1.03)  -2.27% (p=0.017)
      FmtFprintfPrefixedInt   399ns × (0.98,1.02)   395ns × (0.98,1.03)    ~    (p=0.159)
      FmtFprintfFloat         569ns × (1.00,1.00)   569ns × (0.99,1.01)    ~    (p=0.847)
      FmtManyArgs            1.90µs × (0.99,1.03)  1.88µs × (1.00,1.01)  -1.14% (p=0.009)
      GobDecode              15.2ms × (1.00,1.01)  15.2ms × (1.00,1.01)    ~    (p=0.170)
      GobEncode              11.8ms × (0.99,1.02)  11.6ms × (0.99,1.01)  -1.47% (p=0.003)
      Gzip                    649ms × (0.99,1.00)   647ms × (1.00,1.00)    ~    (p=0.200)
      Gunzip                  144ms × (0.99,1.01)   142ms × (1.00,1.00)  -1.04% (p=0.000)
      HTTPClientServer       91.1µs × (0.98,1.03)  91.7µs × (0.99,1.02)    ~    (p=0.345)
      JSONEncode             31.5ms × (0.99,1.01)  31.8ms × (0.99,1.02)  +0.98% (p=0.021)
      JSONDecode              110ms × (1.00,1.01)   110ms × (0.99,1.02)    ~    (p=0.259)
      Mandelbrot200          6.02ms × (1.00,1.01)  6.02ms × (1.00,1.00)    ~    (p=0.500)
      GoParse                6.68ms × (1.00,1.01)  6.61ms × (0.99,1.01)  -1.17% (p=0.001)
      RegexpMatchEasy0_32     161ns × (1.00,1.00)   161ns × (1.00,1.01)  -0.39% (p=0.033)
      RegexpMatchEasy0_1K     539ns × (1.00,1.00)   539ns × (0.99,1.01)    ~    (p=0.445)
      RegexpMatchEasy1_32     138ns × (1.00,1.01)   139ns × (0.99,1.02)    ~    (p=0.281)
      RegexpMatchEasy1_1K     887ns × (1.00,1.01)   887ns × (1.00,1.00)    ~    (p=0.610)
      RegexpMatchMedium_32    251ns × (1.00,1.02)   255ns × (0.99,1.01)  +1.42% (p=0.000)
      RegexpMatchMedium_1K   72.7µs × (1.00,1.00)  72.6µs × (1.00,1.00)    ~    (p=0.097)
      RegexpMatchHard_32     3.85µs × (1.00,1.00)  3.84µs × (1.00,1.00)  -0.31% (p=0.000)
      RegexpMatchHard_1K      117µs × (1.00,1.00)   117µs × (1.00,1.00)    ~    (p=0.704)
      Revcomp                 923ms × (0.98,1.02)   925ms × (0.99,1.01)    ~    (p=0.574)
      Template                126ms × (0.98,1.03)   130ms × (0.99,1.01)  +3.28% (p=0.000)
      TimeParse               631ns × (0.99,1.02)   626ns × (1.00,1.00)    ~    (p=0.053)
      TimeFormat              660ns × (0.99,1.01)   662ns × (0.99,1.02)    ~    (p=0.398)
      
      Change-Id: I59c03d329fe7bc178a31477c6f1f01062b881041
      Reviewed-on: https://go-review.googlesource.com/9993Reviewed-by: default avatarAustin Clements <austin@google.com>
      497970f4
    • David Symonds's avatar
      cmd/go: fix count of number of reserved names (doc change). · 3b214175
      David Symonds authored
      Change-Id: I2784f831453d929df64c66febb4982cdf1f08e06
      Reviewed-on: https://go-review.googlesource.com/10133Reviewed-by: default avatarMinux Ma <minux@golang.org>
      3b214175
    • Patrick Mezard's avatar
      internal/syscall/windows/registry: fix read overrun in GetStringsValue · 335e44d2
      Patrick Mezard authored
      According to MSDN RegQueryValueEx page:
      
        If the data has the REG_SZ, REG_MULTI_SZ or REG_EXPAND_SZ type, the
        string may not have been stored with the proper terminating null
        characters. Therefore, even if the function returns ERROR_SUCCESS, the
        application should ensure that the string is properly terminated before
        using it; otherwise, it may overwrite a buffer. (Note that REG_MULTI_SZ
        strings should have two terminating null characters.)
      
      Test written by Alex Brainman <alex.brainman@gmail.com>
      
      Change-Id: I8c0852e0527e27ceed949134ed5e6de944189986
      Reviewed-on: https://go-review.googlesource.com/9806Reviewed-by: default avatarAlex Brainman <alex.brainman@gmail.com>
      Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
      335e44d2
    • Shenghou Ma's avatar
      syscall: add test for Flock_t roundtrip · ed8ae792
      Shenghou Ma authored
      See CL 9962 for the rationale.
      
      Change-Id: I73c714fce258430eea1e61d3835f5c8e9014ca1f
      Signed-off-by: default avatarShenghou Ma <minux@golang.org>
      Reviewed-on: https://go-review.googlesource.com/9925Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      ed8ae792
    • Shenghou Ma's avatar
      syscall: add explicit build tags · 38631846
      Shenghou Ma authored
      Auto-generated using the following bash script:
      for i in z*_*_*.go; do
              goosgoarch=`basename ${i/${i/_*/}_/} .go`
              goos=${goosgoarch/_*/}
              goarch=${goosgoarch/*_/}
              echo $i $goos $goarch
              [ "$goos" = "windows" ] && continue
              sed -i -e "/^package /i\/\/ +build $goarch,$goos\n" "$i"
      done
      
      Change-Id: I756fee551d1698080e4591fed8f058ae0450aaa5
      Signed-off-by: default avatarShenghou Ma <minux@golang.org>
      Reviewed-on: https://go-review.googlesource.com/10113Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      38631846
    • Mikio Hara's avatar
      cmd/doc: fix build · 37eb1d19
      Mikio Hara authored
      Change-Id: Ic8437a1d2aeb424d6d5ce9e608c1293bba4c7bbc
      Reviewed-on: https://go-review.googlesource.com/10093
      Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
      Reviewed-by: default avatarJosh Bleecher Snyder <josharian@gmail.com>
      37eb1d19
    • Shenghou Ma's avatar
      syscall: fix F_SETLK{,W} on linux/ppc64 · 5069452d
      Shenghou Ma authored
      Change-Id: Ia81675b0f01ceafada32bdd2bc59088016a7421e
      Reviewed-on: https://go-review.googlesource.com/10043Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      5069452d
  2. 14 May, 2015 18 commits