1. 16 Jul, 2019 1 commit
  2. 15 Jul, 2019 1 commit
  3. 08 Jul, 2019 6 commits
  4. 01 Jul, 2019 1 commit
  5. 26 Jun, 2019 1 commit
    • Ian Lance Taylor's avatar
      [release-branch.go1.12] cmd/cgo: fix inappropriate array copy · 77c14d29
      Ian Lance Taylor authored
      Ensure that during rewriting of expressions that take the address of
      an array, that we properly recognize *ast.IndexExpr as an operation
      to create a pointer variable and thus assign the proper addressOf
      and deference operators as "&" and "*" respectively.
      
      This fixes a regression from CL 142884.
      
      This is a backport of CLs 183458 and 183778 to the 1.12 release branch.
      It is not a cherry pick because the code in misc/cgo/test has changed.
      
      Updates #32579
      Fixes #32756
      
      Change-Id: I0daa75ec62cccbe82ab658cb2947f51423e0c235
      Reviewed-on: https://go-review.googlesource.com/c/go/+/183627
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarEmmanuel Odeke <emm.odeke@gmail.com>
      77c14d29
  6. 11 Jun, 2019 3 commits
  7. 10 Jun, 2019 2 commits
  8. 07 Jun, 2019 3 commits
  9. 17 May, 2019 1 commit
    • Jason A. Donenfeld's avatar
      [release-branch.go1.12] os: pass correct environment when creating Windows processes · afcfe0d3
      Jason A. Donenfeld authored
      This is CVE-2019-11888.
      
      Previously, passing a nil environment but a non-nil token would result
      in the new potentially unprivileged process inheriting the parent
      potentially privileged environment, or would result in the new
      potentially privileged process inheriting the parent potentially
      unprivileged environment. Either way, it's bad. In the former case, it's
      an infoleak. In the latter case, it's a possible EoP, since things like
      PATH could be overwritten.
      
      Not specifying an environment currently means, "use the existing
      environment". This commit amends the behavior to be, "use the existing
      environment of the token the process is being created for." The behavior
      therefore stays the same when creating processes without specifying a
      token. And it does the correct thing when creating processes when
      specifying a token.
      
      Updates #32000
      Fixes #32081
      
      Change-Id: Ib4a90cfffb6ba866c855f66f1313372fdd34ce41
      Reviewed-on: https://go-review.googlesource.com/c/go/+/177538
      Run-TryBot: Jason Donenfeld <Jason@zx2c4.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      afcfe0d3
  10. 14 May, 2019 1 commit
  11. 08 May, 2019 1 commit
  12. 06 May, 2019 6 commits
  13. 01 May, 2019 2 commits
    • Russ Cox's avatar
      [release-branch.go1.12] cmd/vet: add tests for point-release issues · dc6db5f4
      Russ Cox authored
      Add explicit tests for:
      
       #30465	cmd/vet: Consider reverting tag conflict for embedded fields
       #30399	cmd/vet: possible to get a printf false positive with big.Int
      
      because we have managed not to fix them in the last
      couple point releases, and it will be too embarrassing
      to do that yet again.
      
      Change-Id: Ib1da5df870348b6eb9bfc8a87c507ecc6d44b8dd
      Reviewed-on: https://go-review.googlesource.com/c/go/+/174520
      Run-TryBot: Russ Cox <rsc@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      dc6db5f4
    • Russ Cox's avatar
      [release-branch.go1.12] cmd/vendor/golang.org/x/tools/go/analysis: update from... · 9ac70939
      Russ Cox authored
      [release-branch.go1.12] cmd/vendor/golang.org/x/tools/go/analysis: update from release-branch.go1.12
      
      $ ./update-xtools.sh
      Copied /Users/rsc/src/golang.org/x/tools@aa829657 to .
      $ cd ~/src/golang.org/x/tools
      $ git log -n1 aa829657
      commit aa82965741a9fecd12b026fbb3d3c6ed3231b8f8 (HEAD -> release-branch.go1.12, origin/release-branch.go1.12)
      Author:     Daniel Martí <mvdan@mvdan.cc>
      AuthorDate: Fri Mar 1 11:00:19 2019 +0000
      Commit:     Brad Fitzpatrick <bradfitz@golang.org>
      CommitDate: Wed Mar 13 21:06:03 2019 +0000
      ...
      $
      
      Picks up cmd/vet fixes that have been inadvertently missed in point releases so far.
      
      Fixes #30399.
      Fixes #30465.
      
      Change-Id: Ibcfaac51d134205b986b32f857d54006b19c896a
      Reviewed-on: https://go-review.googlesource.com/c/go/+/174519
      Run-TryBot: Russ Cox <rsc@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      9ac70939
  14. 29 Apr, 2019 1 commit
  15. 26 Apr, 2019 2 commits
  16. 23 Apr, 2019 1 commit
  17. 22 Apr, 2019 1 commit
  18. 18 Apr, 2019 1 commit
  19. 16 Apr, 2019 1 commit
  20. 15 Apr, 2019 1 commit
  21. 11 Apr, 2019 2 commits
  22. 08 Apr, 2019 1 commit