1. 02 Mar, 2014 4 commits
  2. 01 Mar, 2014 3 commits
    • Shenghou Ma's avatar
      syscall: workaround Dragonfly BSD kernel exec bug · 5fbd6044
      Shenghou Ma authored
      See also CL 4259056 for FreeBSD.
      
      Test program:
      // exec.go
      package main
      import (
              "log"
              "os"
              "os/exec"
              "runtime"
      )
      func main() {
              path := runtime.GOROOT() + "/src/pkg/net/http/cgi/testdata"
              cmd := &exec.Cmd{
                      Path:   "test.cgi",
                      Args:   []string{path + "/test.cgi"},
                      Dir:    path
                      Stdout: os.Stdout}
              if err := cmd.Start(); err != nil {
                      log.Fatal(err)
              }
              if err := cmd.Wait(); err != nil {
                      log.Fatal(err)
              }
      }
      
      $ go run exec.go
      2014/03/01 15:52:41 fork/exec test.cgi: argument list too long
      
      LGTM=iant
      R=rsc, iant
      CC=golang-codereviews
      https://golang.org/cl/69970044
      5fbd6044
    • Dave Cheney's avatar
      sync/atomic: skip broken tests on freebsd/arm and netbsd/arm · 5b456c74
      Dave Cheney authored
      Update #7338
      
      The nil deref tests are currently failing on the *bsd/arm platforms. In an effort to avoid the build deteriorating further I would like to skip these tests on freebsd/arm and netbsd/arm.
      
      LGTM=bradfitz, minux.ma
      R=golang-codereviews, bradfitz, minux.ma
      CC=golang-codereviews
      https://golang.org/cl/69870045
      5b456c74
    • Dave Cheney's avatar
      runtime: small Native Client fixes · 0c6e4b96
      Dave Cheney authored
      cgocall.c: define the CBARGS macro for GOARCH_amd64p32. I don't think the value of this macro will ever be used under nacl/amd64p32 but it is required to compile even if cgo is not used.
      
      hashmap.goc: amd64p32 uses 32bit words.
      
      LGTM=iant
      R=rsc, iant
      CC=golang-codereviews
      https://golang.org/cl/69960044
      0c6e4b96
  3. 28 Feb, 2014 13 commits
  4. 27 Feb, 2014 18 commits
  5. 26 Feb, 2014 2 commits
    • Keith Randall's avatar
      runtime: get rid of the settype buffer and lock. · 3b5278fc
      Keith Randall authored
      MCaches	now hold a MSpan for each sizeclass which they have
      exclusive access to allocate from, so no lock is needed.
      
      Modifying the heap bitmaps also no longer requires a cas.
      
      runtime.free gets more expensive.  But we don't use it
      much any more.
      
      It's not much faster on 1 processor, but it's a lot
      faster on multiple processors.
      
      benchmark                 old ns/op    new ns/op    delta
      BenchmarkSetTypeNoPtr1           24           23   -0.42%
      BenchmarkSetTypeNoPtr2           33           34   +0.89%
      BenchmarkSetTypePtr1             51           49   -3.72%
      BenchmarkSetTypePtr2             55           54   -1.98%
      
      benchmark                old ns/op    new ns/op    delta
      BenchmarkAllocation          52739        50770   -3.73%
      BenchmarkAllocation-2        33957        34141   +0.54%
      BenchmarkAllocation-3        33326        29015  -12.94%
      BenchmarkAllocation-4        38105        25795  -32.31%
      BenchmarkAllocation-5        68055        24409  -64.13%
      BenchmarkAllocation-6        71544        23488  -67.17%
      BenchmarkAllocation-7        68374        23041  -66.30%
      BenchmarkAllocation-8        70117        20758  -70.40%
      
      LGTM=rsc, dvyukov
      R=dvyukov, bradfitz, khr, rsc
      CC=golang-codereviews
      https://golang.org/cl/46810043
      3b5278fc
    • Robert Griesemer's avatar
      go/printer: refine handling of one-line functions · 3d4c12d9
      Robert Griesemer authored
      Functions that "fit" on one line and were on one
      line in the original source are not broken up into
      two lines anymore simply because they contain a comment.
      
      - Fine-tuned use of separating blanks after /*-style comments, so:
      
      ( /* extra blank after this comment */ )
      (a int /* no extra blank after this comment*/)
      
      - Factored out comment state (from printer state) into commentInfo.
      - No impact on $GOROOT/src, misc formatting.
      
      Fixes #5543.
      
      LGTM=r
      R=golang-codereviews, r
      CC=golang-codereviews
      https://golang.org/cl/68630043
      3d4c12d9