- 18 Oct, 2011 3 commits
-
-
David Symonds authored
There's a problem that is manifesting on the 386 builders, but this test bug is masking it. R=adg CC=golang-dev https://golang.org/cl/5295042
-
David Symonds authored
This fixes the 386 builds. R=golang-dev, adg, r CC=golang-dev https://golang.org/cl/5293043
-
Andrew Gerrand authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5298041
-
- 17 Oct, 2011 17 commits
-
-
Anthony Martin authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/5273045
-
Andrew Gerrand authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5267049
-
Robert Griesemer authored
scanner.Position is the position of the most recently scanned token. Make sure it is invalid if there is no token scanned and update corresponding comment. This is particularly important when reporting errors. Fixes #2371. R=r CC=golang-dev https://golang.org/cl/5294041
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/5285042
-
Russ Cox authored
Had been allowing it for use by fmt, but it is too hard to lock down. Fix other packages not to depend on it. R=r, r CC=golang-dev https://golang.org/cl/5266054
-
Nigel Tao authored
Previously, Next would call either nextText or nextTag, but nextTag could also call nextText. Both nextText and nextTag were responsible for detecting "</a" end tags and "<!" comments. This change simplifies the call chain and puts that responsibility in a single place. R=andybalholm CC=golang-dev https://golang.org/cl/5263050
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/5286049
-
Anthony Martin authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/5266046
-
Robert Griesemer authored
Fixes #2377. R=r, rsc CC=golang-dev https://golang.org/cl/5267048
-
Robert Griesemer authored
R=golang-dev, r, rsc CC=golang-dev https://golang.org/cl/5272045
-
Dmitriy Vyukov authored
Fixes #2376 R=golang-dev, lvd, rsc CC=golang-dev https://golang.org/cl/5278048
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/5284050
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/5268048
-
Paul Borman authored
Address the issue coalescing two records together when TrimLeadingSpace is set to true. The input a,b, c,d,e Would result with a singled a,b,c,d,e record. With TrailingComma set to true it should give two records. With TrailingComma set to false it should be an error. Fixes #2366. R=golang-dev, go.peter.90, r CC=golang-dev https://golang.org/cl/5284046
-
Andrew Gerrand authored
Fixes #2375. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5279049
-
Esko Luontola authored
Uses a generic solution of renaming the tested package, instead of using cryptic names for all other imports, variables and methods in the generated _testmain.go file. Fixes #2346. R=golang-dev, r, adg CC=golang-dev, rsc https://golang.org/cl/5254061
-
Andrew Gerrand authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5275050
-
- 16 Oct, 2011 2 commits
-
-
Nigel Tao authored
R=andybalholm CC=golang-dev https://golang.org/cl/5284042
-
Dmitriy Vyukov authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/5284044
-
- 15 Oct, 2011 5 commits
-
-
Anthony Martin authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/5286047
-
Alex Brainman authored
New DLL and Proc types to manage and call dll functions. These were used to simplify syscall tests in runtime package. They were also used to implement LazyDLL and LazyProc. LazyProc, like Proc, now have Call function, that just a wrapper for SyscallN. It is not as efficient as Syscall, but easier to use. NewLazyDLL now supports non-ascii filenames. LazyDLL and LazyProc now have Load and Find methods. These can be used during runtime to discover if some dll functions are not present. All dll functions now return errors that fit os.Error interface. They also contain Windows error number. Some of these changes are suggested by jp. R=golang-dev, jp, rsc CC=golang-dev https://golang.org/cl/5272042
-
Andrew Balholm authored
R=nigeltao CC=golang-dev https://golang.org/cl/5279044
-
Brad Fitzpatrick authored
Previously, if an http.Handler didn't fully consume a Request.Body before returning and the request and the response from the handler indicated no reason to close the connection, the server would read an unbounded amount of the request's unread body to advance past the request message to find the next request's header. That was a potential DoS. With this CL there's a threshold under which we read (currently 256KB) in order to keep the connection in keep-alive mode, but once we hit that, we instead switch into a "Connection: close" response and don't read the request body. Fixes #2093 (along with number of earlier CLs) R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5268043
-
Anthony Martin authored
The current code will panic if an invalid request (one with a nil URL) is passed to the doFollowingRedirects function. Also, remove a redundant nil Header check. R=bradfitz CC=golang-dev https://golang.org/cl/5270046
-
- 14 Oct, 2011 13 commits
-
-
Robert Griesemer authored
R=adg CC=golang-dev https://golang.org/cl/5273044
-
Andrew Gerrand authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5273043
-
Dave Cheney authored
Also, add golden output data for linux/arm. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5256041
-
Chris Farmiloe authored
When xml.Marshal is called on a struct it will happily reflect the information in the "tag" of an XMLName member regardless of the type to give the struct a tag-name in it's XML form. This is backed up by the documentation which says: However xml.Unmarshal *does* care about the XMLName field being of type xml.Name, and currently returns the error "field XMLName does not have type xml.Name" if you have it set to something else. This is firstly inconsistant with xml.Marshal but it also makes it impossible to use xml.Marshal alongside other Marshallers (like json/bson) without poluting the state's namespace with XMLName fields. Inorder to exclude fields from other Marshallers the convention has been started to tag fields as "omitempty"; which will cause the field not to display if it is at it's "zero" state, XMLName cannot have such as zero-state since it is a struct, so it is nicer to use a pointer/bool value for XMLName so it can be easily excluded when I want to Marshal my struct by some other wire format. Attached is the proposed minor change, that simply stops erring if it can't set the name on the XMLName field, which is just optional metadata anyway. Fixes #2265. R=rsc CC=golang-dev https://golang.org/cl/5067044
-
Brad Fitzpatrick authored
Fixes #2146 R=rsc CC=golang-dev https://golang.org/cl/5284041
-
Russ Cox authored
Fixes #2369. R=gri CC=golang-dev https://golang.org/cl/5275048
-
Russ Cox authored
Apparently some versions of bash do the ||exit implicitly when in set -e mode, but others do not. ??? R=gri CC=golang-dev https://golang.org/cl/5285043
-
Jaroslavas Počepko authored
http://code.google.com/p/go/issues/detail?id=1899 R=rsc, alex.brainman, bsiegert, hectorchu, bradfitz CC=golang-dev https://golang.org/cl/4978047
-
Adam Langley authored
We also have functions for dealing with PKCS#1 private keys. This change adds functions for PKIX /public/ keys. Most of the time one won't be parsing them because they usually come in certificates, but marshaling them happens and I've previously copied the code from x509.go for this. R=bradfitz, rsc CC=golang-dev https://golang.org/cl/5286042
-
Adam Langley authored
X509 names, like everything else X509, are ludicrously general. This change keeps the raw version of the subject and issuer around for matching. Since certificates use a distinguished encoding, comparing the encoding is the same as comparing the values directly. This came up recently when parsing the NSS built-in certificates which use the raw subject and issuer for matching trust records to certificates. R=bradfitz CC=golang-dev https://golang.org/cl/5275047
-
Adam Langley authored
R=bradfitz CC=golang-dev https://golang.org/cl/5172042
-
Brad Fitzpatrick authored
Fixes #2057 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5269044
-
Luca Greco authored
Firefox Websocket implementation send a "Connection: keep-alive, upgrade" header during the handshake (and as descripted on the last hybi draft the "Connection" header must include, but doesn't need to be equal to, "upgrade": '4. A "Connection" header field that includes the token "Upgrade", treated as an ASCII case-insensitive value.' From: http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-17#page-23 R=golang-dev, ukai, cw, rsc CC=golang-dev https://golang.org/cl/5233059
-