1. 21 May, 2014 1 commit
    • Robert Griesemer's avatar
      spec: specify order of init() calls · c00043b5
      Robert Griesemer authored
      The spec did not specify the order in which
      init() functions are called. Specify that
      they are called in source order since we have
      now also specified the initialization order
      of independent variables.
      
      While technically a language change, no
      existing code could have relied on this,
      so this should not break anything.
      
      Per suggestion from rsc.
      
      LGTM=r, iant
      R=rsc, iant, r, ken
      CC=golang-codereviews
      https://golang.org/cl/98420046
      c00043b5
  2. 20 May, 2014 22 commits
    • Keith Randall's avatar
      reflect: don't panic on delete from nil map. · cb6cb42e
      Keith Randall authored
      Fixes #8051
      
      LGTM=bradfitz
      R=golang-codereviews, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/95560046
      cb6cb42e
    • Robert Griesemer's avatar
      spec: clarify section on package initialization · a4366984
      Robert Griesemer authored
      - split description of package initialization and
        program execution
      - better grouping of concerns in section on package
        initialization
      - more explicit definition of what constitues a
        dependency
      - removed language about constant dependencies -
        they are computed at compile-time and not
        initialized at run-time
      - clarified that independent variables are initialized
        in declaration order (rather than reference order)
      
      Note that the last clarification is what distinguishes
      gc and gccgo at the moment: gc uses reference order
      (i.e., order in which variables are referenced in
      initialization expressions), while gccgo uses declaration
      order for independent variables.
      
      Not a language change. But adopting this CL will
      clarify what constitutes a dependency.
      
      Fixes #6703.
      
      LGTM=adonovan, r, iant, rsc
      R=r, rsc, iant, ken, adonovan
      CC=golang-codereviews
      https://golang.org/cl/99020043
      a4366984
    • Rob Pike's avatar
      doc/go_spec.html: fix broken anchor tag · 4d36ad77
      Rob Pike authored
      LGTM=gri
      R=gri
      CC=golang-codereviews
      https://golang.org/cl/99420045
      4d36ad77
    • Rob Pike's avatar
      doc/install.html: fix duplicate id= tag · 87ef6e91
      Rob Pike authored
      LGTM=minux.ma
      R=adg, minux.ma
      CC=golang-codereviews
      https://golang.org/cl/95540045
      87ef6e91
    • Shenghou Ma's avatar
      all: fix "the the" typos. · ca6be91c
      Shenghou Ma authored
      LGTM=bradfitz
      R=golang-codereviews, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/93470043
      ca6be91c
    • Shenghou Ma's avatar
      runtime: revise the document of Version() · 8aa8348b
      Shenghou Ma authored
      Fixes #7701. (again, differently)
      
      LGTM=rsc
      R=iant, rsc
      CC=golang-codereviews
      https://golang.org/cl/94560043
      8aa8348b
    • Brad Fitzpatrick's avatar
      src: make nacltest.bash executable · 2fed8c76
      Brad Fitzpatrick authored
      TBR=rsc
      R=rsc
      CC=golang-codereviews
      https://golang.org/cl/98480043
      2fed8c76
    • Shenghou Ma's avatar
      undo CL 84040045 / 5302b4c58aa0 · dfbb2a95
      Shenghou Ma authored
      This idea was rejected in CL 5731059. We should fix the
      runtime docs instead.
      
      ««« original CL description
      cmd/dist: reflect local changes to tree in goversion
      
      runtime.Version() requires a trailing "+" when
      tree had local modifications at time of build.
      
      Fixes #7701
      
      LGTM=iant
      R=golang-codereviews, iant
      CC=golang-codereviews
      https://golang.org/cl/84040045
      
      »»»
      
      LGTM=rsc, mra
      R=iant, rsc, mra
      CC=golang-codereviews
      https://golang.org/cl/100520043
      dfbb2a95
    • David du Colombier's avatar
      debug/plan9obj: cleanup api · b28aa1f1
      David du Colombier authored
      - Don't export Prog structure.
      - Remove ProgHeader and ExecTable structures.
      - Add Magic, Bss and Entry fields in FileHeader.
      - Replace ?_MAGIC variables with constants.
      - Ignore final EOF from ReadAt.
      - Improve documentation.
      
      Fixes #7989.
      
      LGTM=rsc
      R=rsc, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/91400044
      b28aa1f1
    • Rob Pike's avatar
      cmd/go: document file types · 294f9b88
      Rob Pike authored
      Explain which files the go command looks at, and what they represent.
      Fixes #6348.
      
      LGTM=rsc
      R=rsc, minux.ma
      CC=golang-codereviews
      https://golang.org/cl/96480043
      294f9b88
    • Russ Cox's avatar
      doc/go1.3.html: mention cgo [0]byte bug fix fallout · 7ef0eb1c
      Russ Cox authored
      Fixes #7958.
      
      LGTM=r
      R=r
      CC=golang-codereviews
      https://golang.org/cl/91590044
      7ef0eb1c
    • Russ Cox's avatar
      build: make nacl pass · 0c2a7274
      Russ Cox authored
      Add nacl.bash, the NaCl version of all.bash.
      It's a separate script because it builds a variant of package syscall
      with a large zip file embedded in it, containing all the input files
      needed for tests.
      
      Disable various tests new since the last round, mostly the ones using os/exec.
      
      Fixes #7945.
      
      LGTM=dave
      R=golang-codereviews, remyoudompheng, dave, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/100590044
      0c2a7274
    • Russ Cox's avatar
      test: test issue 7884 (already fixed) · f374dd30
      Russ Cox authored
      I don't know when the bug was fixed, but empirically it was.
      Make sure it stays fixed by adding a test.
      
      Fixes #7884.
      
      LGTM=adg
      R=golang-codereviews, adg
      CC=golang-codereviews
      https://golang.org/cl/93500043
      f374dd30
    • Russ Cox's avatar
      syscall: fix Write(nil) on NaCl · 82854d7b
      Russ Cox authored
      Fixes #7050.
      
      LGTM=crawshaw, r
      R=golang-codereviews, crawshaw, r
      CC=golang-codereviews
      https://golang.org/cl/91590043
      82854d7b
    • Russ Cox's avatar
      cmd/ld: make lldb happy with Mach-O 6.out files · a4a1fadf
      Russ Cox authored
      Apparently all the __DWARF sections need addresses
      even though they are marked as "do not load from disk".
      Continue the address numbering from the data segment.
      
      With this change:
      
      g% lldb helloworld
      Current executable set to 'helloworld' (x86_64).
      (lldb) b main.main
      Breakpoint 1: where = helloworld`main.main + 25 at helloworld.go:12, address = 0x0000000000002019
      (lldb) r
      Process 68509 launched: '/Users/rsc/g/go/src/cmd/6l/helloworld' (x86_64)
      1 location added to breakpoint 1
      (lldb)
      [KProcess 68509 stopped
      * thread #1: tid = 0x8b7a27, 0x0000000000002019 helloworld`main.main + 25 at helloworld.go:12, stop reason = breakpoint 1.2
          frame #0: 0x0000000000002019 helloworld`main.main + 25 at helloworld.go:12
         9   	package main
         10
         11  	func main() {
      -> 12  		print("hello, world\n")
         13  	}
      (lldb) bt
      * thread #1: tid = 0x8b7a27, 0x0000000000002019 helloworld`main.main + 25 at helloworld.go:12, stop reason = breakpoint 1.2
        * frame #0: 0x0000000000002019 helloworld`main.main + 25 at helloworld.go:12
      (lldb) disas
      helloworld`main.main at helloworld.go:11:
         0x2000:  movq   %gs:0x8a0, %rcx
         0x2009:  cmpq   (%rcx), %rsp
         0x200c:  ja     0x2015                    ; main.main + 21 at helloworld.go:11
         0x200e:  callq  0x20da0                   ; runtime.morestack00_noctxt at atomic_amd64x.c:28
         0x2013:  jmp    0x2000                    ; main.main at helloworld.go:11
         0x2015:  subq   $0x10, %rsp
      -> 0x2019:  leaq   0x2c2e0, %rbx
         0x2021:  leaq   (%rsp), %rbp
         0x2025:  movq   %rbp, %rdi
         0x2028:  movq   %rbx, %rsi
         0x202b:  movsq
         0x202d:  movsq
         0x202f:  callq  0x10300                   ; runtime.printstring at compiler.go:1
         0x2034:  addq   $0x10, %rsp
         0x2038:  ret
         0x2039:  addb   %al, (%rax)
         0x203b:  addb   %al, (%rax)
         0x203d:  addb   %al, (%rax)
      (lldb) quit
      Quitting LLDB will kill one or more processes. Do you really want to proceed: [Y/n] y
      g%
      
      Fixes #7070.
      
      LGTM=iant
      R=golang-codereviews, iant
      CC=golang-codereviews
      https://golang.org/cl/93510043
      a4a1fadf
    • Andrew Gerrand's avatar
      misc/makerelease: handle update tour file layout · 9cd759ae
      Andrew Gerrand authored
      Fixes #7835.
      
      LGTM=bradfitz
      R=golang-codereviews, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/94670044
      9cd759ae
    • Mikio Hara's avatar
      doc/go1.3.html: switch default stack size back to 8kB · 66f72f8a
      Mikio Hara authored
      Update #8030
      
      LGTM=bradfitz
      R=golang-codereviews, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/94680043
      66f72f8a
    • Elias Naur's avatar
      cmd/cgo: document CC_FOR_TARGET and CXX_FOR_TARGET · 88d07b2c
      Elias Naur authored
      Update #4714
      
      LGTM=iant, minux.ma, rsc
      R=rsc, iant, r, minux.ma
      CC=golang-codereviews
      https://golang.org/cl/100390043
      88d07b2c
    • Russ Cox's avatar
      liblink: fix field tracking · d9c9665f
      Russ Cox authored
      The USEFIELD instructions no longer make it to the linker,
      so we have to do something else to pin the references
      they were pinning. Emit a 0-length relocation of type R_USEFIELD.
      
      Fixes #7486.
      
      LGTM=iant
      R=golang-codereviews, iant
      CC=golang-codereviews, r
      https://golang.org/cl/95530043
      d9c9665f
    • Russ Cox's avatar
      runtime: switch default stack size back to 8kB · 6aee2964
      Russ Cox authored
      The move from 4kB to 8kB in Go 1.2 was to eliminate many stack split hot spots.
      
      The move back to 4kB was predicated on copying stacks eliminating
      the potential for hot spots.
      
      Unfortunately, the fact that stacks do not copy 100% of the time means
      that hot spots can still happen under the right conditions, and the slowdown
      is worse now than it was in Go 1.2. There is a real program in issue 8030 that
      sees about a 30x slowdown: it has a reflect call near the top of the stack
      which inhibits any stack copying on that segment.
      
      Go back to 8kB until stack copying can be used 100% of the time.
      
      Fixes #8030.
      
      LGTM=khr, dave, iant
      R=iant, khr, r, bradfitz, dave
      CC=golang-codereviews
      https://golang.org/cl/92540043
      6aee2964
    • Russ Cox's avatar
      cmd/gc: fix float32 const conversion and printing of big float consts · 60be4a24
      Russ Cox authored
      The float32 const conversion used to round to float64
      and then use the hardware to round to float32.
      Even though there was a range check before this
      conversion, the double rounding introduced inaccuracy:
      the round to float64 might round the value further away
      from the float32 range, reaching a float64 value that
      could not actually be rounded to float32. The hardware
      appears to give us 0 in that case, but it is probably undefined.
      Double rounding also meant that the wrong value might
      be used for certain border cases.
      
      Do the rounding the float32 ourselves, just as we already
      did the rounding to float64. This makes the conversion
      precise and also makes the conversion match the range check.
      
      Finally, add some code to print very large (bigger than float64)
      floating point constants in decimal floating point notation instead
      of falling back to the precise but human-unreadable binary floating
      point notation.
      
      Fixes #8015.
      
      LGTM=iant
      R=golang-codereviews, iant
      CC=golang-codereviews, r
      https://golang.org/cl/100580044
      60be4a24
    • Shenghou Ma's avatar
      cmd/ld: abort if (32-bit) address relocation is negative on amd64. · 66129835
      Shenghou Ma authored
      Update #7980
      This CL make the linker abort for the example program. For Go 1.4,
      we need to find a general way to handle large memory model programs.
      
      LGTM=dave, josharian, iant
      R=iant, dave, josharian
      CC=golang-codereviews
      https://golang.org/cl/91500046
      66129835
  3. 19 May, 2014 10 commits
  4. 17 May, 2014 2 commits
  5. 16 May, 2014 5 commits