Commits · weekly.2011-06-23 · Kirill Smelkov / go

24 Jun, 2011 5 commits

weekly.2011-06-23 · 30d08b40

Andrew Gerrand authored Jun 24, 2011

R=golang-dev, robert.hencke, r
CC=golang-dev
https://golang.org/cl/4625062

30d08b40

os: fixed PathListSeparator to ';' for windows. · 8ab2c989
Yasuhiro Matsumoto authored Jun 24, 2011
```
Fixed issue 1992

R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/4661047
```
8ab2c989
http: buffer Request.Write · 89873e60
Brad Fitzpatrick authored Jun 23, 2011
```
Fixes #1996

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4639068
```
89873e60

runtime: don't use twice the memory with grsec-like kernels · 65b036c3

Gustavo Niemeyer authored Jun 24, 2011

grsec needs the FIXED flag to be provided to mmap, which
works now.  That said, when the allocation fails to be made
in the specific address, we're still given back a writable
page.  This change will unmap that page to avoid using
twice the amount of memory needed.

It'd also be pretty easy to avoid the extra system calls
once we detected that the flag is needed, but I'm not sure
if that edge case is worth the effort.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4634086

65b036c3

goinstall: build with make by default, add -make flag · b4bab6f8

Andrew Gerrand authored Jun 24, 2011

This is a temporary measure until go/build can build cgo packages.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4627056

b4bab6f8

23 Jun, 2011 7 commits

mime/multipart: remove newline at top of the multipart. · 73d741fd
Yasuhiro Matsumoto authored Jun 23, 2011
```
R=golang-dev, bradfitz, arctanofyourface
CC=golang-dev
https://golang.org/cl/4635063
```
73d741fd

libmach: fix disassembly of FCMOVcc and FCOMI · d8474670

Anthony Martin authored Jun 23, 2011

The optable for 0xDB is handled specially.

This was the cause of a really weird bug
when using cov (386!) on the math package.

A real head-scratcher.

R=rsc
CC=golang-dev
https://golang.org/cl/4639066

d8474670

libmach: fix tracing on linux (for cov) · 8f72a87b
Anthony Martin authored Jun 22, 2011
```
R=rsc, dave
CC=golang-dev
https://golang.org/cl/4629064
```
8f72a87b

5c: do not use R9 and R10 · c475c307

Russ Cox authored Jun 22, 2011

This program used to use R9 and R10.
Now it fails to compile (out of registers).
I used to know a simpler test but can't remember it.

Learned something new: Rietveld refuses change
list descriptions bigger than 10 kB.

int sum(int x, int y, int z, int w) {
        return
        (((((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))%
        (((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))))*
        ((((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))%
        (((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))))*
        (((((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))%
        (((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))))*
        ((((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))%
        (((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))))
        ;
}

R=ken2
CC=golang-dev
https://golang.org/cl/4650053

c475c307

exec: LookPath should not search %PATH% for files like c:cmd.exe · 5d53aab4
Alex Brainman authored Jun 23, 2011
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/4632055
```
5d53aab4

exp/template: make -0 be an unsigned int. · 96731619

Rob Pike authored Jun 23, 2011

Fix (inconsequential) type error in list initializer.

R=rsc
CC=golang-dev
https://golang.org/cl/4638058

96731619

go/build: include Import objects in Script Inputs · d7df79a7

Andrew Gerrand authored Jun 23, 2011

This has the effect of making goinstall rebuild a package's
dependencies when they are newer than the current package object.

R=rsc
CC=golang-dev
https://golang.org/cl/4627051

d7df79a7

22 Jun, 2011 14 commits

net, syscall: interface for windows · 88442358

Yasuhiro Matsumoto authored Jun 23, 2011

R=mikioh.mikioh, alex.brainman, rsc, vincent.vanackere
CC=golang-dev
https://golang.org/cl/4590050

88442358

io: clarify Read, ReadAt, Copy, Copyn EOF behavior · 36b5e1d6
Russ Cox authored Jun 22, 2011
```
R=golang-dev, bradfitz, iant, dsymonds, nigeltao, r
CC=golang-dev
https://golang.org/cl/4629062
```
36b5e1d6

First cut at the parser for the new template package. · cd7826e5

Rob Pike authored Jun 23, 2011

This is not a full grammar, but the pieces are there to implement whatever we converge on.

R=rsc
CC=golang-dev
https://golang.org/cl/4629053

cd7826e5

exec: better error message for windows LookPath · 123549ac
Alex Brainman authored Jun 23, 2011
```
Fixes #1991.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4648049
```
123549ac
image: basic test for the 16-bits-per-color-channel types. · 6b4fb9f8
Nigel Tao authored Jun 23, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4635059
```
6b4fb9f8

syscall: add tty support to StartProcess · c8443d72

Ken Rockot authored Jun 22, 2011

These changes add a Ctty int field to the Unix syscall.ProcAttr which,
if set >= 0 in conjuction with Setsid=true, will be used by
forkAndExecInChild as the file descriptor for the new child's
controlling terminal.

Necessary changes have been made to mkerrors.sh to generate defs for
TIOC*, though changes to its output files are not included here.
The changes made should support Linux, FreeBSD and Darwin, at least.

R=iant, bradfitz, r, rsc, borman
CC=golang-dev
https://golang.org/cl/4532075

c8443d72

A+C: Ken Rockot (individual CLA) · 8a4acd53
Russ Cox authored Jun 22, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4648053
```
8a4acd53
build: explain $PWD use · 2e41120a
Russ Cox authored Jun 22, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4639064
```
2e41120a
sync: restore GOMAXPROCS during benchmarks · 8cab7f57
Dmitriy Vyukov authored Jun 22, 2011
```
R=golang-dev
CC=dvyukov, golang-dev
https://golang.org/cl/4631060
```
8cab7f57

ld: don't attempt to build dynamic sections unnecessarily · 89d334ff

Gustavo Niemeyer authored Jun 22, 2011

This prevents ld from generating zeroed symtab entries for
sections that aren't going to be generated because dynamic
linkage has been disabled (-d was used or no dynamic libs
were seen).  Even though they were not explicitly added by
doelf, the section creation process was making them
reachable again.

The windows head is being disconsidered for this because
apparently it's not taking into account debug['d'].

This makes elflint 0.1% happier.

R=golang-dev, rsc, gustavo
CC=golang-dev
https://golang.org/cl/4638050

89d334ff

Fix Windows build; ErrorString->NewError · 5dfdccf2
Brad Fitzpatrick authored Jun 22, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4634080
```
5dfdccf2

os.Error API: don't export os.ErrorString, use os.NewError consistently · 712fb6dc

Robert Griesemer authored Jun 22, 2011

This is a core API change.

1) gofix misc src
2) Manual adjustments to the following files under src/pkg:
   gob/decode.go
   rpc/client.go
   os/error.go
   io/io.go
   bufio/bufio.go
   http/request.go
   websocket/client.go
as well as:
   src/cmd/gofix/testdata/*.go.in (reverted)
   test/fixedbugs/bug243.go
3) Implemented gofix patch (oserrorstring.go) and test case (oserrorstring_test.go)

Compiles and runs all tests.

R=r, rsc, gri
CC=golang-dev
https://golang.org/cl/4607052

712fb6dc

godefs: remove test from build · 55b06624

Russ Cox authored Jun 21, 2011

The test is only defined on darwin/amd64, and it fails
with recent versions of Xcode, which do not support
-gstabs+ debugging output.  At some point godefs will
have to be replaced, perhaps merged with cgo.
Godefs is not needed during builds anyway (its output files
are checked into the repository in src/pkg/runtime),
so its failure on the newer Xcode is a distraction from an
otherwise usable build.  Disable the test.

Fixes #1985.

R=golang-dev, gri, robert.hencke, r
CC=golang-dev
https://golang.org/cl/4638053

55b06624

crypto/openpgp: add ElGamal support. · f2e94de6
Adam Langley authored Jun 21, 2011
```
R=bradfitz, r
CC=golang-dev
https://golang.org/cl/4639049
```
f2e94de6

21 Jun, 2011 7 commits

8l: more fixes for Plan 9 · 10b5519d

Lucio De Re authored Jun 21, 2011

Once these changes are effected, it is possible to construct
"8l" native on a (386?) Plan 9 system, albeit with assistance
from modules such as mkfiles that are not (yet) included in any
public patches.

8l/asm.c:
. Corrected some format qualifiers.

8l/list.c:
. Cast a print() argument to (int) to match the given format.
  It may be possible to change the format (%R), but I have not
  looked into it.

8l/obj.c:
. Removed some unused code.

8l/span.c:
. Removed unnecessary incrementation on "bp".
. Corrected some format qualifiers.

ld/data.c:
. Corrected some format qualifiers.
. Cast print argument to (int): used as field size.
. Use braces to suppress warning about empty if() statements.

ld/dwarf.c:
. Trivial spelling mistake in comment.

ld/ldelf.c:
. Added USED() statements to silence warnings.
. Dropped redundant address (&) operators.
. corrected some format qualifiers.
. Cast to (int) for switch selection variable.

ld/macho.c:
. Added USED() statements to silence warnings.

ld/ldpe.c:
. Added USED() statements to silence warnings.
. More careful use of "sect" variable.
. Corrected some format qualifiers.
. Removed redundant assignments.
. Minor fix dropped as it was submitted separately.

ld/pe.c:
. Dropped <time.h> which is now in <u.h>.
. Dropped redundant address (&) operators.
. Added a missing variable initialisation.

ld/symtab.c:
. Added USED() statements to silence warnings.
. Removed redundant incrementation.
. Corrected some format qualifiers.

All the above have been tested against a (very) recent release
and do not seem to trigger any regressions.

All review suggestions have been incorporated.

R=rsc
CC=golang-dev
https://golang.org/cl/4633043

10b5519d

nacl, tiny: remove vestiges · b88e669a
Robert Hencke authored Jun 21, 2011
```
R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/4635053
```
b88e669a

gopprof: update list of memory allocators · d6be71c7

Russ Cox authored Jun 21, 2011

Also import new weblist command from Google version.

R=r, bradfitz
CC=golang-dev
https://golang.org/cl/4650048

d6be71c7

goinstall: undo 1ad616fb313d (always rebuild...) · f338d9f7

Andrew Gerrand authored Jun 21, 2011

CL 4627051 is a better way of doing the same thing.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4654045

f338d9f7

builder: run make single-threaded on windows · 524d02cb

Alex Brainman authored Jun 21, 2011

Will still honor MAKEFLAGS environment variable if set.

R=golang-dev
CC=bradfitz, golang-dev
https://golang.org/cl/4644049

524d02cb

goinstall: undo repo peeking code · ceae2c93

Andrew Gerrand authored Jun 21, 2011

Keeping the Julian's good refactoring work.

R=rsc
CC=golang-dev
https://golang.org/cl/4638049

ceae2c93

Effective Go: supplied missing type in variadic function example. · 6be0bdf7
Ben Lynn authored Jun 21, 2011
```
R=golang-dev, nigeltao
CC=golang-dev
https://golang.org/cl/4595055
```
6be0bdf7

20 Jun, 2011 7 commits

syscall: add socket control message support for darwin, freebsd, linux · 5d6f118f
Mikio Hara authored Jun 20, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4528113
```
5d6f118f

fmt: catch panics from calls to String etc. · 97a929aa

Rob Pike authored Jun 21, 2011

This change causes Print et al. to catch panics generated by
calls to String, GoString, and Format.  The panic is formatted
into the output stream as an error, but the program continues.
As a special case, if the argument was a nil pointer, the
result is just "<nil>", because that's almost certainly enough
information and handles the very common case of String
methods that don't guard against nil.

Scan does not want this change. Input must work; output can
be for debugging and it's nice to get output even when you
make a mistake.

R=dsymonds, r, adg, gri, rsc, gri
CC=golang-dev
https://golang.org/cl/4640043

97a929aa

all-qemu.bash: cannot test go/build · 4bbe9d87
Russ Cox authored Jun 20, 2011
```
R=adg, r
CC=golang-dev
https://golang.org/cl/4633054
```
4bbe9d87
http: write Header keys with empty values · 9ee83f54
Brad Fitzpatrick authored Jun 20, 2011
```
R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/4630052
```
9ee83f54

http: permit handlers to explicitly remove the Date header · 922ceadd

Brad Fitzpatrick authored Jun 20, 2011

We'll do the right thing by default, but people wanting minimal
response sizes can explicitly remove the Date header.
(empty fields aren't written out)

R=rsc
CC=golang-dev
https://golang.org/cl/4634048

922ceadd

os: change Waitmsg String method to use pointer receiver · cf201ed6
Graham Miller authored Jun 20, 2011
```
Fixes #1851.

R=rsc
CC=golang-dev
https://golang.org/cl/4628045
```
cf201ed6
http: add Server.ListenAndServeTLS · c2784340
Brad Fitzpatrick authored Jun 20, 2011
```
Fixes #1964

R=rsc
CC=golang-dev
https://golang.org/cl/4630045
```
c2784340