Commits · weekly.2011-11-01 · Kirill Smelkov / go

02 Nov, 2011 2 commits

weekly.2011-11-01 · 08757f72
Andrew Gerrand authored Nov 02, 2011
```
R=rsc, r
CC=golang-dev
https://golang.org/cl/5336044
```
08757f72

html: stop at scope marker node when generating implied </a> tags · 22ee5ae2

Andrew Balholm authored Nov 02, 2011

A <a> tag generates implied end tags for any open <a> elements.
But it shouldn't do that when it is inside a table cell the the open <a>
is outside the table.
So stop the search for an open <a> when we reach a scope marker node.

Pass tests1.dat, test 78:
<a href="blah">aba<table><tr><td><a href="foo">br</td></tr>x</table>aoe

| <html>
|   <head>
|   <body>
|     <a>
|       href="blah"
|       "abax"
|       <table>
|         <tbody>
|           <tr>
|             <td>
|               <a>
|                 href="foo"
|                 "br"
|       "aoe"

Also pass test 79:
<table><a href="blah">aba<tr><td><a href="foo">br</td></tr>x</table>aoe

R=nigeltao
CC=golang-dev
https://golang.org/cl/5320063

22ee5ae2

01 Nov, 2011 11 commits

html: refactor the blacklist for the "render and re-parse" test. · 90b76c0f
Nigel Tao authored Nov 02, 2011
```
R=andybalholm
CC=golang-dev, mikesamuel
https://golang.org/cl/5331056
```
90b76c0f

textproto: prevent long lines in HTTP headers from causing HTTP 400 responses. · f753e3fa

Mike Solomon authored Nov 01, 2011

This fixes the issue without an extra copy in the average case.

R=golang-dev, ality, bradfitz
CC=golang-dev
https://golang.org/cl/5272049

f753e3fa

doc/Makefile: add 'all' rule to build all docs · cf7281e7
Rob Pike authored Nov 01, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5334044
```
cf7281e7
gc: test + fix escape analysis bug · b4df33a6
Russ Cox authored Nov 01, 2011
```
R=lvd
CC=golang-dev
https://golang.org/cl/5333049
```
b4df33a6
doc: refer to tour.golang.org instead of go-tour.appspot.com · 1fe22d2d
Andrew Gerrand authored Nov 01, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5331055
```
1fe22d2d
doc: fix typo in spec example code comment · 44262d15
Charles L. Dorian authored Nov 01, 2011
```
R=r, golang-dev, adg
CC=golang-dev
https://golang.org/cl/5308071
```
44262d15
go spec: introduce rune type · b910a273
Robert Griesemer authored Nov 01, 2011
```
R=r, iant, rsc, r
CC=golang-dev
https://golang.org/cl/5293048
```
b910a273

rpc: avoid infinite loop on input error · 2e79e8e5

Russ Cox authored Nov 01, 2011

Fixes #1828.
Fixes #2179.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5305084

2e79e8e5

gopack: change archive file name length back to 16 · 7b04471d

Russ Cox authored Nov 01, 2011

This CL grew the archive file name length from 16 to 64:

        changeset:   909:58574851d792
        user:        Russ Cox <rsc@golang.org>
        date:        Mon Oct 20 13:53:56 2008 -0700

Back then, every x.go file in a package became an x.6 file
in the archive.  It was important to be able to allow the
use of long Go source file names, hence the increase in size.

Today, all Go source files compile into a single _go_.6 file
regardless of their names, so the archive file name length
no longer needs to be long.  The longer name causes some
problems on Plan 9, where the native archive format is the
same but with 16-byte names, so revert back to 16.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5333050

7b04471d

os: do not interpret 0-length read as EOF · 4853c517
Russ Cox authored Nov 01, 2011
```
Fixes #2402.

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/5298081
```
4853c517

html: process </td> tags; foster parent at most one node per token · 9db3f78c

Andrew Balholm authored Nov 01, 2011

Correctly close table cell when </td> is read.

Because of reconstructing the active formatting elements, more than one
node may be created when reading a single token.
If both nodes are foster parented, they will be siblings, but the first
node should be the parent of the second.

Pass tests1.dat, test 77:
<a href="blah">aba<table><a href="foo">br<tr><td></td></tr>x</table>aoe

| <html>
|   <head>
|   <body>
|     <a>
|       href="blah"
|       "aba"
|       <a>
|         href="foo"
|         "br"
|       <a>
|         href="foo"
|         "x"
|       <table>
|         <tbody>
|           <tr>
|             <td>
|     <a>
|       href="foo"
|       "aoe"

R=nigeltao
CC=golang-dev
https://golang.org/cl/5305074

9db3f78c

31 Oct, 2011 13 commits

template: fix error checking on execute without parse · cae23f03

Scott Lawrence authored Oct 31, 2011

Fixed error checking in exec.go to give a sensible error message when
execution is attempted before a successful parse (rather than an
outright panic).

R=r
CC=golang-dev
https://golang.org/cl/5306065

cae23f03

pkg: minor cleanup · 92926f54

Russ Cox authored Oct 31, 2011

remove some redundant .String()
change variable name to make it os.Error-proof

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5302075

92926f54

test: make bug107 os.Error-proof · a07841e2
Russ Cox authored Oct 31, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5306087
```
a07841e2
runtime/pprof: document OS X being broken · d0eaa58b
Russ Cox authored Oct 31, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5307078
```
d0eaa58b
time: add RFC1123 with numeric timezone format · a7e473be
Scott Lawrence authored Oct 31, 2011
```
Fixes #841.

R=rsc, r
CC=golang-dev
https://golang.org/cl/5322058
```
a7e473be
math: Improved accuracy for Sin and Cos. · 739c442e
Charles L. Dorian authored Oct 31, 2011
```
Fixes #1564.

R=rsc, dchest
CC=golang-dev
https://golang.org/cl/5320056
```
739c442e

json: Properly handle nil slices. · 48c75c5f

Alexander Reece authored Oct 31, 2011

Marshal nil slices as null and parse null value as a nil slice.
Fixes #2278.

R=rsc
CC=golang-dev
https://golang.org/cl/5257053

48c75c5f

A+C: Alexander Reece (individual CLA) · 288dacd0
Russ Cox authored Oct 31, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5297072
```
288dacd0

syscall: fix Await msg on Plan 9 · d1f48db1

Andrey Mirtchovski authored Oct 31, 2011

Plan 9's await() returns '' for nil exit status but programs, most notably gotest,
see this as an error return.

R=rsc
CC=golang-dev
https://golang.org/cl/5305079

d1f48db1

gc: clean up printing. · 50110c9f

Luuk van Dijk authored Oct 31, 2011

Got rid of all the magic mystery globals. Now
for %N, %T, and %S, the flags +,- and # set a sticky
debug, sym and export mode, only visible in the new fmt.c.
Default is error mode. Handle h and l flags consistently with
the least side effects, so we can now change
things without worrying about unrelated things
breaking.

fixes #2361

R=rsc
CC=golang-dev
https://golang.org/cl/5316043

50110c9f

net: Plan 9 fixes · 58423360

Fazlul Shahriar authored Oct 31, 2011

Makes all tests pass.

R=rsc
CC=golang-dev
https://golang.org/cl/5320041

58423360

misc/emacs/go-lang.el: Fix restoration of multiple windows in a frame after gofmt · 350a5ce6

Jan Newmarch authored Oct 31, 2011

If a frame has multiple windows then the windows must all be restored
after gofmt has finished and the old windows must be restored.
Before this fix, only the Go code edit window would be left.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5280050

350a5ce6

exp/norm: fixed bug that creeped in with moving to the new · eef78091

Marcel van Lohuizen authored Oct 31, 2011

regexp, which caused the last line of a test block to be ignored.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5177052

eef78091

29 Oct, 2011 1 commit

exp/ssh: fix length header leaking into channel data streams. · 0f6b80c6

Dave Cheney authored Oct 29, 2011

The payload of a data message is defined as an SSH string type,
which uses the first four bytes to encode its length. When channelData
and channelExtendedData were added I defined Payload as []byte to
be able to use it directly without a string to []byte conversion. This
resulted in the length data leaking into the payload data.

This CL fixes the bug, and restores agl's original fast path code.

Additionally, a bug whereby s.lock was not released if a packet arrived
for an invalid channel has been fixed.

Finally, as they were no longer used, I have removed
the channelData and channelExtedendData structs.

R=agl, rsc
CC=golang-dev
https://golang.org/cl/5330053

0f6b80c6

28 Oct, 2011 13 commits

html: adjust bookmark in "adoption agency" algorithm · 604e10c3

Andrew Balholm authored Oct 29, 2011

In the adoption agency algorithm, the formatting element is sometimes
removed from the list of active formatting elements and reinserted at a later index.
In that case, the bookmark showing where it is to be reinserted needs to be moved,
so that its position relative to its neighbors remains the same
(and also so that it doesn't become out of bounds).

Pass tests1.dat, test 70:
<DIV> abc <B> def <I> ghi <P> jkl </B>

| <html>
|   <head>
|   <body>
|     <div>
|       " abc "
|       <b>
|         " def "
|         <i>
|           " ghi "
|       <i>
|         <p>
|           <b>
|             " jkl "

Also pass tests through test 76:
<test attribute---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------->

R=nigeltao
CC=golang-dev
https://golang.org/cl/5322052

604e10c3

html: don't run "adoption agency" on elements that aren't in scope. · 03f163c7

Andrew Balholm authored Oct 28, 2011

Pass tests1.dat, test 55:
<!DOCTYPE html><font><table></font></table></font>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <font>
|       <table>

Also pass tests through test 69:
<DIV> abc <B> def <I> ghi <P> jkl

R=nigeltao
CC=golang-dev
https://golang.org/cl/5309074

03f163c7

fmt: handle os.Error values · 0e81e508