1. 20 Feb, 2018 1 commit
    • Kirill Smelkov's avatar
      open: Fix error message · 0d47edb6
      Kirill Smelkov authored
      By accident I was trying to open a non-existing database file and got
      the following message:
      
      	unable to open database file (unable to open database file)
      
      which was not helpful.
      
      By convention the error returned by a function should contain the
      context passed to that function - the filename in Open case, the
      operation performed and the error description. So
      
      - teach OpenError to print filename of the opened database and the
        operation.
      - don't duplicate the code in braces if we have the error message
        with the same text because they are often redundant.
      - if we have only error code but not a message, still we have to include
        the filename and operation in the printed context.
      - in the Open itself: always return OpenError on handling errors from
        sqlite3_open_v2 even if db == nil - instead of returning only Errno
        without any context.
      
      Now the error in my case is:
      
      	notfound.db: unable to open database file
      
      ( @gwenn requested to omit the ": open" (operation) probable because it
        duplicates error detail a bit )
      
      /helped-by @gwenn
      0d47edb6
  2. 18 Feb, 2018 2 commits
  3. 09 Feb, 2018 2 commits
  4. 31 Dec, 2017 2 commits
  5. 18 Sep, 2017 1 commit
  6. 02 Sep, 2017 2 commits
  7. 08 Jul, 2017 1 commit
  8. 15 Jun, 2017 2 commits
  9. 12 Jun, 2017 2 commits
  10. 15 Mar, 2017 2 commits
  11. 05 Mar, 2017 7 commits
  12. 23 Feb, 2017 2 commits
  13. 21 Feb, 2017 2 commits
  14. 13 Jan, 2017 1 commit
  15. 05 Jan, 2017 1 commit
  16. 02 Dec, 2016 1 commit
  17. 05 Nov, 2016 1 commit
  18. 12 Oct, 2016 2 commits
  19. 27 Aug, 2016 1 commit
    • gwenn's avatar
      Go 1.7 · b836af76
      gwenn authored
      b836af76
  20. 30 Mar, 2016 1 commit
  21. 03 Mar, 2016 1 commit
  22. 21 Feb, 2016 3 commits