1. 16 Mar, 2018 1 commit
    • Kirill Smelkov's avatar
      fixup! open: Fix error message · d90dd8b9
      Kirill Smelkov authored
      This commit fixes 0d47edb6. Recently I hit the following: I was trying
      to open the database via
      
      	sqlite3.Open(dburl, sqlite3.OpenNoMutex)
      
      i.e. by passing flags, but erroneously no OpenReadWrite or something
      similar, and got
      
      	"testdata/1.sqlite: bad parameter or other API misuse"
      
      as the error.
      
      The message was confusing because there is no "open" action in it, so
      add the action to OpenError and the mesage becomes:
      
      	"testdata/1.sqlite: open: bad parameter or other API misuse"
      
      See full discussion for structure of error messages here:
      
      https://github.com/gwenn/gosqlite/pull/14
      d90dd8b9
  2. 20 Feb, 2018 2 commits
    • gwenn's avatar
      Merge pull request #14 from navytux/y/open-error · 900751f4
      gwenn authored
      open: Fix error message
      900751f4
    • Kirill Smelkov's avatar
      open: Fix error message · 0d47edb6
      Kirill Smelkov authored
      By accident I was trying to open a non-existing database file and got
      the following message:
      
      	unable to open database file (unable to open database file)
      
      which was not helpful.
      
      By convention the error returned by a function should contain the
      context passed to that function - the filename in Open case, the
      operation performed and the error description. So
      
      - teach OpenError to print filename of the opened database and the
        operation.
      - don't duplicate the code in braces if we have the error message
        with the same text because they are often redundant.
      - if we have only error code but not a message, still we have to include
        the filename and operation in the printed context.
      - in the Open itself: always return OpenError on handling errors from
        sqlite3_open_v2 even if db == nil - instead of returning only Errno
        without any context.
      
      Now the error in my case is:
      
      	notfound.db: unable to open database file
      
      ( @gwenn requested to omit the ": open" (operation) probable because it
        duplicates error detail a bit )
      
      /helped-by @gwenn
      0d47edb6
  3. 18 Feb, 2018 2 commits
  4. 09 Feb, 2018 2 commits
  5. 31 Dec, 2017 2 commits
  6. 18 Sep, 2017 1 commit
  7. 02 Sep, 2017 2 commits
  8. 08 Jul, 2017 1 commit
  9. 15 Jun, 2017 2 commits
  10. 12 Jun, 2017 2 commits
  11. 15 Mar, 2017 2 commits
  12. 05 Mar, 2017 7 commits
  13. 23 Feb, 2017 2 commits
  14. 21 Feb, 2017 2 commits
  15. 13 Jan, 2017 1 commit
  16. 05 Jan, 2017 1 commit
  17. 02 Dec, 2016 1 commit
  18. 05 Nov, 2016 1 commit
  19. 12 Oct, 2016 2 commits
  20. 27 Aug, 2016 1 commit
    • gwenn's avatar
      Go 1.7 · b836af76
      gwenn authored
      b836af76
  21. 30 Mar, 2016 1 commit
  22. 03 Mar, 2016 1 commit
  23. 21 Feb, 2016 1 commit