http://koct9i.livejournal.com/53773.html

Signed-off-by: Kir Kolyshkin <kir@openvz.org>

Make it depend on DISTFILES
Signed-off-by: Kir Kolyshkin <kir@openvz.org>

Makefile:
* append CFLAGS, do not set
* use CFLAGS when linking (for -m32 etc)
ioping.spec:
* pass RPM_OPT_FLAGS to make in environment

While at it, also:
* Makefile: move compiler/linker options before file names
* Makefile: move -lm to where it belongs (LDFLAGS)
Signed-off-by: Kir Kolyshkin <kir@openvz.org>

Signed-off-by: Kir Kolyshkin <kir@openvz.org>

-h is a valid option, so...
Signed-off-by: Kir Kolyshkin <kir@openvz.org>

Signed-off-by: Kir Kolyshkin <kir@openvz.org>

0: success
1: argument error
2: preparation error
3: runtime error

Try to use info from /proc/self/mounts if there is no mountinfo.

From: Konstantin Vaskovtsov <derkonstantin@cloudlinux.com>
Reworked-by: Konstantin Khlebnikov <koct9i@gmail.com>

This message is shown if fcntl() fails (for any reason)

	ioping: fcntl failed, please retry without -D: Invalid argument

First, it tells that -D is invalid argument, which is misleading.

Second it tells to retry with -D even if -D was not used.

Fix it, now the message is:

	ioping: fcntl failed: Invalid argument
	Please retry without -D
Signed-off-by: Kir Kolyshkin <kir@openvz.org>

This is done in a proper way, ie all the files that need to be included
in a dist tarball are explicitly listed.

In the meantime, generalize Makefile a bit.

For the sake of a better place, I take a version field from the .spec file,
feel free to change that.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Hacked-by: Konstantin Khlebnikov <koct9i@gmail.com>

Note that RPM reqires version so I set it to be 0.1.

Simple way to build (until we have 'make dist' target):

	cd ..
	ln -s ioping ioping-0.1
	tar chjf ioping-0.1.tar.bz2 ioping-0.1
	rpmbuild -ta ioping-0.1.tar.bz2
Signed-off-by: Kir Kolyshkin <kir@openvz.org>

Signed-off-by: Kir Kolyshkin <kir@openvz.org>

(1) mkostemp with O_DIRECT in flags can fail, leaving a temporary file:

Apparently, O_DIRECT is not working on top of LVM. The problem is
in this case mkostemp() creates the temporary file but still returns
an error, and the temp file is not removed:

 $ ls
 ioping  ioping.1  ioping.c  ioping.o  ioping.spec  Makefile
 $ strace ./ioping -D .
 ....
 open("./ioping.UFuMHz", O_RDWR|O_CREAT|O_EXCL|O_DIRECT, 0600) = -1 EINVAL (Invalid argument)
 ....
 $ ls
 ioping  ioping.1  ioping.c  ioping.o  ioping.UFuMHz  ioping.spec  Makefile

Solution -- do not use flags, apply those later using fcntl()

(2) While trying to rebuild on centos5:

 cc -c -o ioping.o ioping.c -std=c99 -g -Wall -Wextra -pedantic -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
 ioping.c: In function 'main':
 ioping.c:369: warning: implicit declaration of function 'mkostemp'
Signed-off-by: Kir Kolyshkin <kir@openvz.org>

'ioping -w 7 -i 2' was taking 8 seconds to run, not 7 or less.
Fix it by moving the check to before usleep(), and taking
the interval (ie usleep argument) into account.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>

This commit addresses two similar (but distinct) bugs.

(1) 'ioping -c' was needlessly sleeping after the last iteration
(and before showing final stats). Fix it by moving the check
to before the usleep(), not after.

(2) 'ioping -w' was going over the time limit specified. For example,
'ioping -w 7 -i 2' was taking 8 seconds to run, not 7 or less.
Fix it by moving the check to before usleep(), and taking
the interval (ie usleep argument) into account.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>

err(1, NULL) prints program name and errno string, which is
just what we need in this case.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>

* free temp path string

getopt() already emits warning about unknown option, so if we do that, too,
the result will look like this:

	$ ./ioping -z
	./ioping: invalid option -- 'z'
	ioping: unknown option: -z

Don't warn about unknown option, instead show usage().
Signed-off-by: Kir Kolyshkin <kir@openvz.org>

Needed mostly for distro vendors (.spec writers etc.)

* Makefile: do not strip when installing
Otherwise distros could not produce debuginfo packages

* Makefile: add BINDIR
Signed-off-by: Kir Kolyshkin <kir@openvz.org>

Signed-off-by: Kir Kolyshkin <kir@openvz.org>