qfq: fix parse_opt dead code

Fix Coverity warning from dead code.

qfq: fix parse_opt dead code
Fix Coverity warning from dead code.
037660b3 · Stephen Hemminger · 8fe98398 · 037660b3
Commit 037660b3 authored Oct 27, 2015 by Stephen Hemminger
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 9 deletions

tc/q_qfq.c tc/q_qfq.c +4 -9

No files found.
--- a/tc/q_qfq.c
+++ b/tc/q_qfq.c
@@ -38,16 +38,11 @@ static void explain_class(void)
 static int qfq_parse_opt(struct qdisc_util *qu, int argc, char **argv,
 			 struct nlmsghdr *n)
 {
-	while (argc > 0) {
+	if (argc > 0) {
-		if (matches(*argv, "help") == 0) {
+		if (matches(*argv, "help") != 0)
-			explain();
-			return -1;
-		} else {
 			fprintf(stderr, "What is \"%s\"?\n", *argv);
-			explain();
+		explain();
-			return -1;
+		return -1;
-		}
-		argc--; argv++;
 	}
 	return 0;