Commit cdb2227e authored by Eric Dumazet's avatar Eric Dumazet Committed by Stephen Hemminger

nstat: 64bit support on 32bit arches

SNMP counters can be provided as 64bit numbers.
nstat needs to cope with this even if running in 32bit mode.
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarStephen Hemminger <stephen@networkplumber.org>
parent 19106180
...@@ -77,7 +77,6 @@ struct nstat_ent ...@@ -77,7 +77,6 @@ struct nstat_ent
struct nstat_ent *next; struct nstat_ent *next;
char *id; char *id;
unsigned long long val; unsigned long long val;
unsigned long ival;
double rate; double rate;
}; };
...@@ -143,7 +142,6 @@ static void load_good_table(FILE *fp) ...@@ -143,7 +142,6 @@ static void load_good_table(FILE *fp)
if ((n = malloc(sizeof(*n))) == NULL) if ((n = malloc(sizeof(*n))) == NULL)
abort(); abort();
n->id = strdup(idbuf); n->id = strdup(idbuf);
n->ival = (unsigned long)val;
n->val = val; n->val = val;
n->rate = rate; n->rate = rate;
n->next = db; n->next = db;
...@@ -206,9 +204,8 @@ static void load_ugly_table(FILE *fp) ...@@ -206,9 +204,8 @@ static void load_ugly_table(FILE *fp)
if (!p) if (!p)
abort(); abort();
*p = 0; *p = 0;
if (sscanf(p+1, "%lu", &n->ival) != 1) if (sscanf(p+1, "%llu", &n->val) != 1)
abort(); abort();
n->val = n->ival;
/* Trick to skip "dummy" trailing ICMP MIB in 2.4 */ /* Trick to skip "dummy" trailing ICMP MIB in 2.4 */
if (strcmp(idbuf, "IcmpOutAddrMaskReps") == 0) if (strcmp(idbuf, "IcmpOutAddrMaskReps") == 0)
idbuf[5] = 0; idbuf[5] = 0;
...@@ -365,10 +362,10 @@ static void update_db(int interval) ...@@ -365,10 +362,10 @@ static void update_db(int interval)
for (h1 = h; h1; h1 = h1->next) { for (h1 = h; h1; h1 = h1->next) {
if (strcmp(h1->id, n->id) == 0) { if (strcmp(h1->id, n->id) == 0) {
double sample; double sample;
unsigned long incr = h1->ival - n->ival; unsigned long long incr = h1->val - n->val;
n->val += incr;
n->ival = h1->ival; n->val = h1->val;
sample = (double)(incr*1000)/interval; sample = (double)incr * 1000.0 / interval;
if (interval >= scan_interval) { if (interval >= scan_interval) {
n->rate += W*(sample-n->rate); n->rate += W*(sample-n->rate);
} else if (interval >= 1000) { } else if (interval >= 1000) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment