Skip to content

I
iproute2
Switch branch/tag
  1. 20 Jun, 2013 1 commit
  3. 07 Jun, 2013 3 commits
    • Eric Dumazet's avatar
      get_rate: detect 32bit overflows · a303853e
      Eric Dumazet authored 
      On Mon, 2013-06-03 at 16:36 +0100, Ben Hutchings wrote:

> Oops, I read this as being strtol() currently, not strtod().  Currently
> '1.5gbit' will work, but this change will break that.  So I think you
> need to keep bps as a double.

Arg

> Then here I think the check should be *rate != floor(bps), i.e. accept
> rounding down of a non-integer number of bytes but any other change is
> assumed to be overflow.

Thanks Ben, here is v4 then ;)

[PATCH v4] get_rate: detect 32bit overflows

Current rate limit is 34.359.738.360 bit per second, and
unfortunately 40Gbps links are above it.

overflows in get_rate() are currently not detected, and some
users are confused. Let's detect this and complain.

Note that some qdisc are ready to get extended range, but this will
need additional attributes and new iproute2

With help from Ben Hutchings
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarBen Hutchings <bhutchings@solarflare.com>
      a303853e
    • Stephen Hemminger's avatar
      htb: fix indentation · 22fa92e3
      Stephen Hemminger authored 
      iproute2 uses kernel style indenting
      22fa92e3
    • Eric Dumazet's avatar
      htb: report overhead attribute · 44f1ff0a
      Eric Dumazet authored 
      "tc class show dev ..." omits the overhead attribute for HTB.

After patch I have :

tc class add dev $DEV parent 1: classid 1:1 est 1sec 4sec htb \
    rate 12Mbit mtu 1500 quantum 1514 overhead 20

tc class show dev $DEV
class htb 1:1 root prio 0 rate 12000Kbit overhead 20 ceil 12000Kbit
burst 1500b cburst 1500b
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      44f1ff0a
  5. 05 Jun, 2013 4 commits
  7. 04 Jun, 2013 3 commits
    • Andrey Vagin's avatar
      ip: set the close-on-exec flag for descriptors · bcb9d403
      Andrey Vagin authored 
      Otherwise a program executed by "ip netns exec" has two extra
descriptors.

$ ip netns exec test /bin/bash
$ lsof -p $$
...
bash    817 root    0u   CHR  136,0       0t0          3 /dev/pts/0
bash    817 root    1u   CHR  136,0       0t0          3 /dev/pts/0
bash    817 root    2u   CHR  136,0       0t0          3 /dev/pts/0
bash    817 root    3u  sock    0,6       0t0      13386 protocol: NETLINK
bash    817 root    4r   REG    0,3         0 4026532155 net
bash    817 root  255u   CHR  136,0       0t0          3 /dev/pts/0

Cc: Stephen Hemminger <stephen@networkplumber.org>
Reported-by: default avatarDilip Daya <dilip.daya@hp.com>
Acked-by: default avatarCyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: default avatarAndrey Vagin <avagin@openvz.org>
      bcb9d403
    • Andreas Henriksson's avatar
      iproute2: fix build failure on sparc due to -Wformat and tv_usec · c083d99d
      Andreas Henriksson authored 
      tv_usec is "suseconds_t" which is apparently usually
a signed long, but sometimes not....
Change the printf modifier to use signed and
cast the tv_usec to long in case it's not already long.

gcc -Wall -Wstrict-prototypes -Werror -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -O2 -I../include -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib\" -DCONFDIR=\"/etc/iproute2\" -D_GNU_SOURCE -fPIC   -c -o utils.o utils.c
utils.c: In function 'print_timestamp':
utils.c:802:2: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type '__suseconds_t' [-Werror=format]
cc1: all warnings being treated as errors
Signed-off-by: default avatarAndreas Henriksson <andreas@fatal.se>
      c083d99d
    • John Fastabend's avatar
      iproute2: bridge: fix 'bridge link' setlink/getlink parsing · a40d0827
      John Fastabend authored 
      Use IFLA_AF_SPEC nested attributes to lookup bridge mode and when
doing strcmp() check for equality.

These appear to be typos from the original commit,

commit 64108901
Author: Vlad Yasevich <vyasevic@redhat.com>
Date:   Fri Mar 15 10:01:28 2013 -0700

    bridge: Add support for setting bridge port attributes

Also set flags to BRIDGE_FLAGS_SELF instead of using OR operation.
This allows setting the bridge mode when not being used with a
master device.

To allow setting both master and self devices simultaneously we
will need to add a {self|master} field similar to fdb commands.
For now the command sets are mutually exclusive as noted in the
original commit.

With this patch 'bridge link set' works now,

# ./bridge/bridge link set dev veth1 cost 3
# ./bridge/bridge link show
10: veth1 state UP : <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 master bridge0 state forwarding priority 3 cost 3

CC: Vlad Yasevich <vyasevic@redhat.com>
Signed-off-by: default avatarJohn Fastabend <john.r.fastabend@intel.com>
      a40d0827
  9. 28 May, 2013 1 commit
  11. 24 May, 2013 3 commits
  13. 23 May, 2013 1 commit
  15. 17 May, 2013 5 commits
  17. 15 May, 2013 1 commit
    • Stephen Hemminger's avatar
      vxlan: nag user to set port value · 2a126a85
      Stephen Hemminger authored 
      This change shifts burden onto the users to choose the UDP port value.
Kernel default value is incorrect UDP port 5287 but now there is
an official assigned port for VXLAN.

The kernel can't change because of legacy compatibility
but new deployments should not use the legacy port value.
      2a126a85
  19. 06 May, 2013 1 commit
  21. 04 May, 2013 1 commit
  23. 03 May, 2013 6 commits
  25. 01 May, 2013 1 commit
    • Alexander Duyck's avatar
      iproute2: act_ipt fix xtables breakage on older versions. · cfa292de
      Alexander Duyck authored 
      In trying to build on a RHEL6.3 I ran into several build issues that are
addressed in this patch.

The first is that xtables_merge_options only has 3 parameters.  It appears
this is how this code was originally.  As such for the case where the version
is less than 6 I am assuming it would be correct to maintain the original
setup that only had 3 parameters being passed instead of 4.

I also ran into an issue with the define for __ALIGN_KERNEL not being present.
I believe this may be due to the fact that __ALIGN_KERNEL was moved into a
separate header from ALIGN after the UAPI changes.  In order to just cover all
of the bases I have moved the main definition for the macros into
__ALIGN_KERNEL_MASK and __ALIGN_KERNEL and if ALIGN is also needed then it is
just a direct redefine to __ALIGN_KERNEL.

Cc: Hasan Chowdhury <shemonc@gmail.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
      cfa292de
  27. 30 Apr, 2013 1 commit
  29. 26 Apr, 2013 1 commit
  31. 17 Apr, 2013 3 commits
  33. 12 Apr, 2013 2 commits
  35. 05 Apr, 2013 1 commit
  37. 01 Apr, 2013 1 commit
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7