1. 04 Aug, 2013 4 commits
    • Stefan Tomanek's avatar
      ip rule: add route suppression options · b1d0525f
      Stefan Tomanek authored
      When configuring a system with multiple network uplinks and default routes, it
      is often convenient to reference a routing table multiple times - but reject
      its routing decision if certain constraints are not met by it.
      
      Consider this setup:
      
      $ ip route add table secuplink default via 10.42.23.1
      
      $ ip rule add pref 100            table main suppress_prefixlength 0
      $ ip rule add pref 150 fwmark 0xA table secuplink
      
      With this setup, packets marked 0xA will be processed by the additional routing
      table "secuplink", but only if no suitable route in the main routing table can
      be found. By suppressing entries with a prefixlength of 0 (or less), the
      default route (/0) of the table "main" is hidden to packets processed by rule
      100; packets traveling to destinations via more specific routes are processed
      as usual.
      
      It is also possible to suppress a routing entry if a device belonging to
      a specific interface group is to be used:
      
      $ ip rule add pref 150 table main suppress_group 1
      Signed-off-by: default avatarStefan Tomanek <stefan.tomanek@wertarbyte.de>
      b1d0525f
    • Stephen Hemminger's avatar
      7bfc49cf
    • Stefan Tomanek's avatar
      ip link: fix display of interface groups · c4fdf75d
      Stefan Tomanek authored
      This change adds the interface group to the output of "ip link show".
      
      It also makes "ip link" print _all_ devices if no group filter is specified;
      previously, only interfaces of the default group (0) were shown.
      Signed-off-by: default avatarStefan Tomanek <stefan.tomanek@wertarbyte.de>
      c4fdf75d
    • Stephen Hemminger's avatar
      5318b2c6
  2. 01 Aug, 2013 1 commit
    • Stephen Hemminger's avatar
      Remove -Werror · 3140e9a3
      Stephen Hemminger authored
      -Werror just doesn't work because it changes too much
      between compiler versions.
      3140e9a3
  3. 26 Jul, 2013 3 commits
  4. 16 Jul, 2013 4 commits
  5. 13 Jul, 2013 1 commit
  6. 12 Jul, 2013 3 commits
  7. 09 Jul, 2013 5 commits
    • Thomas Richter's avatar
      iproute2 vxlan documentation update for ip command · 2816a568
      Thomas Richter authored
      The ip link command line help and the ip-link.8.in
      man page are outdated in regards to the vxlan support.
      The patch updates both the command line help for the
      ip command and its man page.
      Signed-off-by: default avatarThomas Richter <tmricht@linux.vnet.ibm.com>
      2816a568
    • Thomas Richter's avatar
      iproute2 vxlan documentation update for bridge command · 7578ae88
      Thomas Richter authored
      The bridge fdb command line help and the bridge.8
      man page are outdated in regards to the vxlan support.
      The patch updates both the command line help for the
      bridge command and its man page.
      Signed-off-by: default avatarThomas Richter <tmricht@linux.vnet.ibm.com>
      7578ae88
    • JunweiZhang's avatar
      ipbatch: fix use of 'ip netns exec' · 95592b47
      JunweiZhang authored
      execvp() does not return when the command succeed, hence all commands in the
      batch file after the line 'ip netns exec' are not executed.
      
      Let's fork before calling execvp() if batch mode is used..
      
      Example:
      $ cat test.batch
      netns add netns1
      netns exec netns1 ip l
      netns
      $ ip -b test.batch
      1: lo: <LOOPBACK> mtu 65536 qdisc noop state DOWN mode DEFAULT
          link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
      2: sit0: <NOARP> mtu 1480 qdisc noop state DOWN mode DEFAULT
          link/sit 0.0.0.0 brd 0.0.0.0
      
      All command after 'netns exec' are never executed.
      
      With the patch:
      $ ip -b test.batch
      1: lo: <LOOPBACK> mtu 65536 qdisc noop state DOWN mode DEFAULT
          link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
      2: sit0: <NOARP> mtu 1480 qdisc noop state DOWN mode DEFAULT
          link/sit 0.0.0.0 brd 0.0.0.0
      netns1
      
      Now, existing netns are displayed.
      Signed-off-by: default avatarJunweiZhang <junwei.zhang@6wind.com>
      Signed-off-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
      95592b47
    • Amerigo Wang's avatar
      iptunnel: check SIT_ISATAP flag only for SIT tunnel · 86c00faa
      Amerigo Wang authored
      Without patch, I got:
      
      	# ./ip/ip tunnel show
      	ip_vti0: ioctl 89f4 failed: Invalid argument
      	ip_vti0: ip/ip  remote any  local any  ttl inherit  nopmtudisc key 0
      
      this is due to VTI_ISVTI has the same numeric value with SIT_ISATAP,
      but only sit tunnel has SIOCGETPRL, therefore it should check for SIT
      tunnel first.
      
      Cc: Stephen Hemminger <stephen@networkplumber.org>
      Signed-off-by: default avatarCong Wang <amwang@redhat.com>
      86c00faa
    • esr@thyrsus.com's avatar
      tc-stab.8: Fix synopsis errors, an invalid escape, and incorrect English usge. · 11eb9396
      esr@thyrsus.com authored
      The command synopsis is regularized and part of it split off into an
      OPTIONS section.  This allows the page to lift to XML-DocBook.
      
      An invalid \p escape was removed.
      
      This page was written by someone who didn't understand the use of
      definite and indefinite articles in English, nor its punctuation rules.
      I've fixed these mistakes, and some glitches in punctuation and
      capitalization.
      11eb9396
  8. 25 Jun, 2013 3 commits
    • Adam Borowski's avatar
      ip: fix build failure if time_t is not long int · 5d8a7529
      Adam Borowski authored
      This includes x32, and, per Linus' decree, any future arch with longs
      shorter than 64 bits.
      Signed-off-by: default avatarAdam Borowski <kilobyte@angband.pl>
      5d8a7529
    • Eric Dumazet's avatar
      ss: add more TCP_INFO components · 260804f4
      Eric Dumazet authored
      Allow ss -i to display more TCP informations :
      
      unacked:N   Number of un-acked packets
      retrans:X/Y   X: number of outstanding retransmit packets
                    Y: total number of retransmits for the session
      lost:N       Number of lost packets (tcpi_lost)
      sacked:N     Number of sacked packets (tcpi_sacked)
      facked:N     Number of facked packets (tcpi_facked)
      reordering:N Reordering level (if different of 3)
      
      Example :
      
      $ ss -emoi dst 10.7.7.83
      tcp   ESTAB      0      1154056   10.7.7.84:54127    10.7.7.83:34342
      timer:(on,200ms,0) ino:57003 sk:ffff88063c51d0c0 <->
      	 skmem:(r0,rb89280,t0,tb2097152,f726504,w1436184,o0,bl0) ts sack cubic
      wscale:7,6 rto:310 rtt:107.375/1 mss:1448 cwnd:568 ssthresh:108 send
      61.3Mbps unacked:568 retrans:0/21 reordering:127 rcv_space:29200
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Cc: Yuchung Cheng <ycheng@google.com>
      Cc: Neal Cardwell <ncardwell@google.com>
      260804f4
    • esr@thyrsus.com's avatar
      First set of manpage markup fixes · 61f541fe
      esr@thyrsus.com authored
      Enclosed patch fixes inappropriate uses of the .SS macro.  Fuller explanation
      in the change comment.
      
      There are other problems in these pages that block lifting to
      XML-DocBook, most notably in the command synopses.  They will take
      some creativity to fix.  I'm working on it
      
      >From 75745adba4b45b87577b61a2daa886dd444f44da Mon Sep 17 00:00:00 2001
      From: "Eric S. Raymond" <esr@thyrsus.com>
      Date: Fri, 21 Jun 2013 15:27:38 -0400
      Subject: [PATCH] Abolish presentation-level misuse of the .SS macro.
      
      This change fixes most (but not all) fatal errors in attempts to lift
      the iproute2 manual pages to XML-DocBook.  Where .SS is still used it
      is a real subsection header, not just a way to outdent and bold text.
      Presentation-level instances are turned into .TP calls and tables.
      61f541fe
  9. 21 Jun, 2013 1 commit
  10. 20 Jun, 2013 3 commits
  11. 07 Jun, 2013 3 commits
    • Eric Dumazet's avatar
      get_rate: detect 32bit overflows · a303853e
      Eric Dumazet authored
      On Mon, 2013-06-03 at 16:36 +0100, Ben Hutchings wrote:
      
      > Oops, I read this as being strtol() currently, not strtod().  Currently
      > '1.5gbit' will work, but this change will break that.  So I think you
      > need to keep bps as a double.
      
      Arg
      
      > Then here I think the check should be *rate != floor(bps), i.e. accept
      > rounding down of a non-integer number of bytes but any other change is
      > assumed to be overflow.
      
      Thanks Ben, here is v4 then ;)
      
      [PATCH v4] get_rate: detect 32bit overflows
      
      Current rate limit is 34.359.738.360 bit per second, and
      unfortunately 40Gbps links are above it.
      
      overflows in get_rate() are currently not detected, and some
      users are confused. Let's detect this and complain.
      
      Note that some qdisc are ready to get extended range, but this will
      need additional attributes and new iproute2
      
      With help from Ben Hutchings
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Reviewed-by: default avatarBen Hutchings <bhutchings@solarflare.com>
      a303853e
    • Stephen Hemminger's avatar
      htb: fix indentation · 22fa92e3
      Stephen Hemminger authored
      iproute2 uses kernel style indenting
      22fa92e3
    • Eric Dumazet's avatar
      htb: report overhead attribute · 44f1ff0a
      Eric Dumazet authored
      "tc class show dev ..." omits the overhead attribute for HTB.
      
      After patch I have :
      
      tc class add dev $DEV parent 1: classid 1:1 est 1sec 4sec htb \
          rate 12Mbit mtu 1500 quantum 1514 overhead 20
      
      tc class show dev $DEV
      class htb 1:1 root prio 0 rate 12000Kbit overhead 20 ceil 12000Kbit
      burst 1500b cburst 1500b
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      44f1ff0a
  12. 05 Jun, 2013 4 commits
  13. 04 Jun, 2013 3 commits
    • Andrey Vagin's avatar
      ip: set the close-on-exec flag for descriptors · bcb9d403
      Andrey Vagin authored
      Otherwise a program executed by "ip netns exec" has two extra
      descriptors.
      
      $ ip netns exec test /bin/bash
      $ lsof -p $$
      ...
      bash    817 root    0u   CHR  136,0       0t0          3 /dev/pts/0
      bash    817 root    1u   CHR  136,0       0t0          3 /dev/pts/0
      bash    817 root    2u   CHR  136,0       0t0          3 /dev/pts/0
      bash    817 root    3u  sock    0,6       0t0      13386 protocol: NETLINK
      bash    817 root    4r   REG    0,3         0 4026532155 net
      bash    817 root  255u   CHR  136,0       0t0          3 /dev/pts/0
      
      Cc: Stephen Hemminger <stephen@networkplumber.org>
      Reported-by: default avatarDilip Daya <dilip.daya@hp.com>
      Acked-by: default avatarCyrill Gorcunov <gorcunov@openvz.org>
      Signed-off-by: default avatarAndrey Vagin <avagin@openvz.org>
      bcb9d403
    • Andreas Henriksson's avatar
      iproute2: fix build failure on sparc due to -Wformat and tv_usec · c083d99d
      Andreas Henriksson authored
      tv_usec is "suseconds_t" which is apparently usually
      a signed long, but sometimes not....
      Change the printf modifier to use signed and
      cast the tv_usec to long in case it's not already long.
      
      gcc -Wall -Wstrict-prototypes -Werror -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -O2 -I../include -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib\" -DCONFDIR=\"/etc/iproute2\" -D_GNU_SOURCE -fPIC   -c -o utils.o utils.c
      utils.c: In function 'print_timestamp':
      utils.c:802:2: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type '__suseconds_t' [-Werror=format]
      cc1: all warnings being treated as errors
      Signed-off-by: default avatarAndreas Henriksson <andreas@fatal.se>
      c083d99d
    • John Fastabend's avatar
      iproute2: bridge: fix 'bridge link' setlink/getlink parsing · a40d0827
      John Fastabend authored
      Use IFLA_AF_SPEC nested attributes to lookup bridge mode and when
      doing strcmp() check for equality.
      
      These appear to be typos from the original commit,
      
      commit 64108901
      Author: Vlad Yasevich <vyasevic@redhat.com>
      Date:   Fri Mar 15 10:01:28 2013 -0700
      
          bridge: Add support for setting bridge port attributes
      
      Also set flags to BRIDGE_FLAGS_SELF instead of using OR operation.
      This allows setting the bridge mode when not being used with a
      master device.
      
      To allow setting both master and self devices simultaneously we
      will need to add a {self|master} field similar to fdb commands.
      For now the command sets are mutually exclusive as noted in the
      original commit.
      
      With this patch 'bridge link set' works now,
      
      # ./bridge/bridge link set dev veth1 cost 3
      # ./bridge/bridge link show
      10: veth1 state UP : <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 master bridge0 state forwarding priority 3 cost 3
      
      CC: Vlad Yasevich <vyasevic@redhat.com>
      Signed-off-by: default avatarJohn Fastabend <john.r.fastabend@intel.com>
      a40d0827
  14. 28 May, 2013 1 commit
  15. 24 May, 2013 1 commit