1. 05 Jun, 2013 4 commits
  2. 04 Jun, 2013 3 commits
    • Andrey Vagin's avatar
      ip: set the close-on-exec flag for descriptors · bcb9d403
      Andrey Vagin authored
      Otherwise a program executed by "ip netns exec" has two extra
      descriptors.
      
      $ ip netns exec test /bin/bash
      $ lsof -p $$
      ...
      bash    817 root    0u   CHR  136,0       0t0          3 /dev/pts/0
      bash    817 root    1u   CHR  136,0       0t0          3 /dev/pts/0
      bash    817 root    2u   CHR  136,0       0t0          3 /dev/pts/0
      bash    817 root    3u  sock    0,6       0t0      13386 protocol: NETLINK
      bash    817 root    4r   REG    0,3         0 4026532155 net
      bash    817 root  255u   CHR  136,0       0t0          3 /dev/pts/0
      
      Cc: Stephen Hemminger <stephen@networkplumber.org>
      Reported-by: default avatarDilip Daya <dilip.daya@hp.com>
      Acked-by: default avatarCyrill Gorcunov <gorcunov@openvz.org>
      Signed-off-by: default avatarAndrey Vagin <avagin@openvz.org>
      bcb9d403
    • Andreas Henriksson's avatar
      iproute2: fix build failure on sparc due to -Wformat and tv_usec · c083d99d
      Andreas Henriksson authored
      tv_usec is "suseconds_t" which is apparently usually
      a signed long, but sometimes not....
      Change the printf modifier to use signed and
      cast the tv_usec to long in case it's not already long.
      
      gcc -Wall -Wstrict-prototypes -Werror -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -O2 -I../include -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib\" -DCONFDIR=\"/etc/iproute2\" -D_GNU_SOURCE -fPIC   -c -o utils.o utils.c
      utils.c: In function 'print_timestamp':
      utils.c:802:2: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type '__suseconds_t' [-Werror=format]
      cc1: all warnings being treated as errors
      Signed-off-by: default avatarAndreas Henriksson <andreas@fatal.se>
      c083d99d
    • John Fastabend's avatar
      iproute2: bridge: fix 'bridge link' setlink/getlink parsing · a40d0827
      John Fastabend authored
      Use IFLA_AF_SPEC nested attributes to lookup bridge mode and when
      doing strcmp() check for equality.
      
      These appear to be typos from the original commit,
      
      commit 64108901
      Author: Vlad Yasevich <vyasevic@redhat.com>
      Date:   Fri Mar 15 10:01:28 2013 -0700
      
          bridge: Add support for setting bridge port attributes
      
      Also set flags to BRIDGE_FLAGS_SELF instead of using OR operation.
      This allows setting the bridge mode when not being used with a
      master device.
      
      To allow setting both master and self devices simultaneously we
      will need to add a {self|master} field similar to fdb commands.
      For now the command sets are mutually exclusive as noted in the
      original commit.
      
      With this patch 'bridge link set' works now,
      
      # ./bridge/bridge link set dev veth1 cost 3
      # ./bridge/bridge link show
      10: veth1 state UP : <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 master bridge0 state forwarding priority 3 cost 3
      
      CC: Vlad Yasevich <vyasevic@redhat.com>
      Signed-off-by: default avatarJohn Fastabend <john.r.fastabend@intel.com>
      a40d0827
  3. 28 May, 2013 1 commit
  4. 24 May, 2013 3 commits
  5. 23 May, 2013 1 commit
  6. 17 May, 2013 5 commits
  7. 15 May, 2013 1 commit
    • Stephen Hemminger's avatar
      vxlan: nag user to set port value · 2a126a85
      Stephen Hemminger authored
      This change shifts burden onto the users to choose the UDP port value.
      Kernel default value is incorrect UDP port 5287 but now there is
      an official assigned port for VXLAN.
      
      The kernel can't change because of legacy compatibility
      but new deployments should not use the legacy port value.
      2a126a85
  8. 06 May, 2013 1 commit
  9. 04 May, 2013 1 commit
  10. 03 May, 2013 6 commits
  11. 01 May, 2013 1 commit
    • Alexander Duyck's avatar
      iproute2: act_ipt fix xtables breakage on older versions. · cfa292de
      Alexander Duyck authored
      In trying to build on a RHEL6.3 I ran into several build issues that are
      addressed in this patch.
      
      The first is that xtables_merge_options only has 3 parameters.  It appears
      this is how this code was originally.  As such for the case where the version
      is less than 6 I am assuming it would be correct to maintain the original
      setup that only had 3 parameters being passed instead of 4.
      
      I also ran into an issue with the define for __ALIGN_KERNEL not being present.
      I believe this may be due to the fact that __ALIGN_KERNEL was moved into a
      separate header from ALIGN after the UAPI changes.  In order to just cover all
      of the bases I have moved the main definition for the macros into
      __ALIGN_KERNEL_MASK and __ALIGN_KERNEL and if ALIGN is also needed then it is
      just a direct redefine to __ALIGN_KERNEL.
      
      Cc: Hasan Chowdhury <shemonc@gmail.com>
      Cc: Jamal Hadi Salim <jhs@mojatatu.com>
      Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
      Signed-off-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
      cfa292de
  12. 30 Apr, 2013 1 commit
  13. 26 Apr, 2013 1 commit
  14. 17 Apr, 2013 3 commits
  15. 12 Apr, 2013 2 commits
  16. 05 Apr, 2013 1 commit
  17. 01 Apr, 2013 1 commit
  18. 28 Mar, 2013 4 commits