• Pu Wen's avatar
    x86/sev: Check SME/SEV support in CPUID first · 009767db
    Pu Wen authored
    The first two bits of the CPUID leaf 0x8000001F EAX indicate whether SEV
    or SME is supported, respectively. It's better to check whether SEV or
    SME is actually supported before accessing the MSR_AMD64_SEV to check
    whether SEV or SME is enabled.
    
    This is both a bare-metal issue and a guest/VM issue. Since the first
    generation Hygon Dhyana CPU doesn't support the MSR_AMD64_SEV, reading that
    MSR results in a #GP - either directly from hardware in the bare-metal
    case or via the hypervisor (because the RDMSR is actually intercepted)
    in the guest/VM case, resulting in a failed boot. And since this is very
    early in the boot phase, rdmsrl_safe()/native_read_msr_safe() can't be
    used.
    
    So check the CPUID bits first, before accessing the MSR.
    
     [ tlendacky: Expand and improve commit message. ]
     [ bp: Massage commit message. ]
    
    Fixes: eab696d8 ("x86/sev: Do not require Hypervisor CPUID bit for SEV guests")
    Signed-off-by: default avatarPu Wen <puwen@hygon.cn>
    Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
    Acked-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
    Cc: <stable@vger.kernel.org> # v5.10+
    Link: https://lkml.kernel.org/r/20210602070207.2480-1-puwen@hygon.cn
    009767db
mem_encrypt_identity.c 17.2 KB