• Milo Kim's avatar
    ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio' · 05b01dd9
    Milo Kim authored
    This patch enables getting a HPD GPIO descriptor quicker.
    The exynos-hdmi driver uses "hpd" for HDMI hot plug detection.
    
    	static int hdmi_resources_init(struct hdmi_context *hdata)
    	{
    		...
    		hdata->hpd_gpio = devm_gpiod_get(dev, "hpd", GPIOD_IN);
    		...
    	}
    
    This calls 'of_find_gpio()' and it generates the GPIO consumer ID by referring
    GPIO suffix. So 'hpd-gpios' is preferred on getting a GPIO descriptor.
    
    However, if the device tree uses 'hpd-gpio', then the exynos-hdmi driver
    always retries to get a GPIO descriptor because the first GPIO suffix is not
    'gpio' but 'gpios'. So you always see the debug message below.
    
    	of_get_named_gpiod_flags: can't parse 'hpd-gpios' property of node '/soc/hdmi@14530000[0]'
    
    Use the preferred property, 'hpd-gpios' instead of 'hpd-gpio'.
    Acked-by: default avatarRob Herring <robh@kernel.org>
    Reviewed-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
    Cc: devicetree@vger.kernel.org
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: linux-samsung-soc@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: default avatarMilo Kim <woogyom.kim@gmail.com>
    Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
    05b01dd9
exynos_hdmi.txt 2.49 KB