• Darrick J. Wong's avatar
    xfs: redesign the reflink remap loop to fix blkres depletion crash · 00fd1d56
    Darrick J. Wong authored
    The existing reflink remapping loop has some structural problems that
    need addressing:
    
    The biggest problem is that we create one transaction for each extent in
    the source file without accounting for the number of mappings there are
    for the same range in the destination file.  In other words, we don't
    know the number of remap operations that will be necessary and we
    therefore cannot guess the block reservation required.  On highly
    fragmented filesystems (e.g. ones with active dedupe) we guess wrong,
    run out of block reservation, and fail.
    
    The second problem is that we don't actually use the bmap intents to
    their full potential -- instead of calling bunmapi directly and having
    to deal with its backwards operation, we could call the deferred ops
    xfs_bmap_unmap_extent and xfs_refcount_decrease_extent instead.  This
    makes the frontend loop much simpler.
    
    Solve all of these problems by refactoring the remapping loops so that
    we only perform one remapping operation per transaction, and each
    operation only tries to remap a single extent from source to dest.
    Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
    Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
    Reported-by: default avatarEdwin Török <edwin@etorok.net>
    Tested-by: default avatarEdwin Török <edwin@etorok.net>
    00fd1d56
xfs_bmap.h 9.85 KB